From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D901AA04BC; Tue, 6 Oct 2020 10:47:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7EEA2952; Tue, 6 Oct 2020 10:47:17 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8480D11A4; Tue, 6 Oct 2020 10:47:15 +0200 (CEST) IronPort-SDR: O8CbkV3jKsv+lb2++8D0Yra8l473bL4hrgI8IoHxizpRKAMzQoGYJ+zMDhgisqsakTGZEGHGjp iZKHb4NQJLJg== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="164484311" X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="164484311" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 01:47:12 -0700 IronPort-SDR: a13blX3nvVw5O/xiPOiwhjiPWPwcCGYWrgOx5alfllt1PdXN7SUs9A6Tu2C4/TO7YvR1VW6iXx DzJ4uVFyOS1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="311130379" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 06 Oct 2020 01:47:12 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 01:47:11 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 6 Oct 2020 01:47:11 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.58) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 6 Oct 2020 01:47:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JM6at20nRzjlle/B8jUa8vkjnGub4c4jn4iTxRDpngz4fUkd03FklA42EgCuK1pPngGXUeumiC93pcn0BaHiAyWFDJmJDJRo+jqHQhyWwmLKmsUcN3b7UAHspQrbhUNQsN1wRsTysEZOKhtMwrItg1rmADgiP8RvMSaO2oVaNjretQBlMgM0jm1RibU2WbJQ7dzcfB0HPGlRoF/XHZMRYjbcO2xjhVRYmXDZlorz6oy02pcPB0BBVL/nPnxX0p0dt76SvN0ICEo/F1UR4hlN9L1zx9Rlk+JMt7geaZEWTaxlIQEri2xggYUFdmBD/8+UTR+ATgX3qYecsRFpAshOuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1LLf4D5POkaaywZZCzS0LLJRvC0SYmXYEWKt1+5oR2M=; b=VGBT/osgtcA8Y+To3wY6iJ4BvBOf0eAuI0Z8gs1caKX9ZJ6TWawDbgNgmqz4Wxl7ji4FSEWKiXLreBTu2jEXIPTRUiG2Vs0chIU8mp+Jrv8n2DOXu148O9cxX+PmU5C3x96CLEDsWGjcWYyJlozZ9ZYg7GkIQ/Komu2QLIOG01DeRLOdKEGl7wXrenVbWETSs3ftvzVf7A6sU0qGWoMkPNSCwo9iKOt+sQASzTcKK4lMcpOSmuAeGlzONkJ6+VGDuEJ/nJX4ASUO1Rgb2YsfwVPVclfBeu+s0ryiD5KkgX5Me9KpsM6s9f6xm7ixNl3T/5uM9bapOqxgjdUWKvSErw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1LLf4D5POkaaywZZCzS0LLJRvC0SYmXYEWKt1+5oR2M=; b=XJcA0PE3ISX9ocRb/+y1NMVKr6DnGhzR1yLyUZg1xH+5p2lVYGoRzouI008nnFrGZugvgD8WhVLLdSJQiEG2AkDWUAKu61Z5bZJpoH+7mU0bqZHe62aOZiwZmWLALgOsYkcmpxHCwwuWwkoIK2b9rEF+7XnkTRL7wI1ejv42fgs= Received: from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19) by MN2PR11MB4519.namprd11.prod.outlook.com (2603:10b6:208:26c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.35; Tue, 6 Oct 2020 08:47:10 +0000 Received: from BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::11fa:a7fe:329d:9239]) by BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::11fa:a7fe:329d:9239%5]) with mapi id 15.20.3433.045; Tue, 6 Oct 2020 08:47:10 +0000 From: "Zhang, Roy Fan" To: Olivier Matz , "dev@dpdk.org" CC: "Kovacevic, Marko" , Akhil Goyal , "Kusztal, ArkadiuszX" , "stable@dpdk.org" , Anoob Joseph Thread-Topic: [PATCH 2/3] examples/fips_validation: ignore \r in input files Thread-Index: AQHWm7Q4Kcw8UFQAJkyqV8ey/1yPmamKQQZw Date: Tue, 6 Oct 2020 08:47:10 +0000 Message-ID: References: <20201006074143.31691-1-olivier.matz@6wind.com> <20201006074143.31691-3-olivier.matz@6wind.com> In-Reply-To: <20201006074143.31691-3-olivier.matz@6wind.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [95.44.220.85] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7661587c-4a72-4bf6-c551-08d869d46a24 x-ms-traffictypediagnostic: MN2PR11MB4519: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: boUcr9t6vOYhkIcOljWibrNyqu2pPLrf9tuJx1u0j1YbXGMmAEw4OxKYOH1cSXCX5+eI28QxwGc1TYfQEqTL4CGihO7hOigKCP/lsbc3PA8fhK4fQjmcPtMUtbrfInkqbG9sKNub6XTWctOymVV8vr12nqpQWG/KWh3azJhVK454q1zRYogH3uB5auSPTcFeiuAytqC+aBPSI1B+tm6p7Lkupsw4vfm28CZTKSuGAJHQ1E//GVyKW2fVsmKUtezUbhrTY/D1lcMftGup3widl/L8IHQ49ITLs58tOSZqfhDjOzVjIS0XvdX0POwFXJ4+LHug10bxMJ/v2N7BEPi2/jsft7VL233UZA8Xnz8qH7XreR/u+OYX9T64dfTdIeiS/DSLxyebhB96dF4ugy/vbw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(376002)(39860400002)(366004)(64756008)(2906002)(66446008)(66476007)(66556008)(26005)(83080400001)(53546011)(6506007)(7696005)(33656002)(66946007)(5660300002)(186003)(52536014)(55016002)(76116006)(71200400001)(8936002)(966005)(478600001)(9686003)(83380400001)(86362001)(316002)(110136005)(54906003)(4326008)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: SlRJ579bTrfKxFM9t7c1l7fY0KyV6sUqbmlbIsTPugsJV9w6VvG1Lj0tPzJj1pJ+xIBxSiQRgJILQcztzXM/YUmATt2bX7b7Kpzf+t95YNSsO7AFt+j9pQNKsU56HHwCPkvULV0r5PXXAm8cjajWepXUlae0UDsuGzWewLmoDBl0QHgF+ZCzyT681eIDAqW7H3AAHRdF8gJwi+B7KZIU8H0SoIg/mCi/RvPLG4KgAhuX0L0K9+n6GSvRs0ocv/hTiJ+KYsdRO7480ttKjuOMCSHwgAd8c6sN/joOdp780pT88pLAhW0Wo+IbA30vU/Y2XjTKoR3MNxS7TCmK4ic1id1i0pbKLF65wU7Ldwxyr9ebSBwSBorH2YdUUoJmoXVd5XevRWo1e/0ztMWsenZj1KC7+lY9CskjOjkq6KAiHiNuomRMEitAw72lCXopi1b+Z9jXoSxsNfXo9W73u+E+HAhETCgOOECgKCsygYngVwqleiXiVMQlzKVPQx5uqXfvAaIAfL3TwWL/5vPB7pxxIryjuE/lc/Lo3Xckcraknu6bXX82TCZZSqA++UnV+2PgxCa3o0tPqUGjbvgi0UpBTndOCECaInFUjoY0t6SwsxF84egGPhNl6t9Q1UJgdqOYk3mf6utJZsAIsHRLrt817g== Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3043.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7661587c-4a72-4bf6-c551-08d869d46a24 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 08:47:10.6593 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yt43h7RAyhdjD/YJuP2iShkW/8mh722wLZWaeyDLO60LWi/6tOtIXj5u9sKW1kHJ6KJuCyhgVmcsMktj3LGOvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4519 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/3] examples/fips_validation: ignore \r in input files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Olivier, The patch looks ok but the test file link you provided in the patch is CAVS= 5.3.=20 As mentioned in https://doc.dpdk.org/guides/sample_app_ug/fips_validation.h= tml, the supported CAVS supported version is 21.0 (not latest one by newer = than 5.3). In CAVS 21.0 test files there is no '\r' before '\n' (I suppose = this is for Windows right). Regards, Fan > -----Original Message----- > From: Olivier Matz > Sent: Tuesday, October 6, 2020 8:42 AM > To: dev@dpdk.org > Cc: Kovacevic, Marko ; Akhil Goyal > ; Zhang, Roy Fan ; Kusztal, > ArkadiuszX ; stable@dpdk.org > Subject: [PATCH 2/3] examples/fips_validation: ignore \r in input files >=20 > Some test vectors contain '\r' before '\n' (see link). Ignore them. >=20 > Link: https://www.openssl.org/docs/fips/testvectors-linux-2007-10-10.tar.= gz > Fixes: 3d0fad56b74a ("examples/fips_validation: add crypto FIPS applicati= on") > Cc: stable@dpdk.org >=20 > Signed-off-by: Olivier Matz > --- > examples/fips_validation/fips_validation.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/examples/fips_validation/fips_validation.c > b/examples/fips_validation/fips_validation.c > index 13f763c9aa..858f581ba3 100644 > --- a/examples/fips_validation/fips_validation.c > +++ b/examples/fips_validation/fips_validation.c > @@ -33,6 +33,8 @@ get_file_line(void) >=20 > if (loc >=3D MAX_LINE_CHAR - 1) > return -ENOMEM; > + if (c =3D=3D '\r') > + continue; > if (c =3D=3D '\n') > break; > line[loc++] =3D c; > -- > 2.25.1