From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DF74A0C46; Tue, 31 Aug 2021 10:38:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B37BB40141; Tue, 31 Aug 2021 10:38:58 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D27FD40041 for ; Tue, 31 Aug 2021 10:38:56 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10092"; a="205649019" X-IronPort-AV: E=Sophos;i="5.84,365,1620716400"; d="scan'208";a="205649019" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2021 01:38:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,365,1620716400"; d="scan'208";a="600844453" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 31 Aug 2021 01:38:50 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 31 Aug 2021 01:38:50 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 31 Aug 2021 01:38:50 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 31 Aug 2021 01:38:50 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 31 Aug 2021 01:38:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FQH+MNjJYl4QZSWzu7SZKvyjLGJguY5nzOrU3Uo+Eovh3eDw/60XY79F7ADEHRMMEF3jEnitTquQs6Nn5EsGVJWmwGwuPl21+20drPmsUfOYbIGUuVHz9qKlVtu2pwZY45RD3v+s/ZLexJNrQ9prj9pXvKteoeSJgCksUdAMxpwSX/Gss0caKG9mRy/Bx0ITJ6y+M0TDMtXcVk7xTuqza1wmNuv/3OUqxJNE7CNNtWRYN5YyGCQBIJWXFvMS6z2MD/mM/i2pK8KEUemI9CMUqRo2nXy4FhPF47tTRqFg11TH5A3qBrV5ZY1cZ9kpKNa2ZKqEJbvM4NjgzvgBimlWgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7EpgbaqiMD3vdlFQ5PO8m6qqdI27zSDr5v1aPI2P9CM=; b=UNHvh6RwJnss8jHIUEdnfMWb2ykJWgbpTXD7yIQQhgwWbmQE8tDfLSigTmFh0xUDn0sDzlX+aE1D5HRgEyZagXxSWXWE1XZRNi+Ahonps4Jju+d5Ub7ikaFZQjB7fb27T3uhHTSAGax/fAmp33AWPiPqKQ0NGBg+NzW0OYvxh0FWdzMarA3XDR/goW+tdQTrn+LVlGGEdrmhNS4pZaF7q30fvSdg/Vungv+p17XyIJPHod++ptQrBErxJr4j1BNEbkF1SAHKh+ELZHN63tNM6u50Pu3Cc1vJFxJNrc+hS4/WNCES57pU9hjgKh7EnvUj3ja1CHIB9sfU9a3w7Mg92g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7EpgbaqiMD3vdlFQ5PO8m6qqdI27zSDr5v1aPI2P9CM=; b=pV3zGb3bc+6gBEoYjkk+eBDPiUaarV+/mUHGrrfLsPbnoWkGsvia5lUC8kpnQ9KkyHknM/iu5+jxBEgjviZOx5hWGgEpXTFrXzeWZkbuUmlt2ebE4auT6LSF7sI+AWHvCuAq/W8J7U94xdvshUXprX273073RAe2Mjpj248wIRc= Received: from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19) by MN2PR11MB4582.namprd11.prod.outlook.com (2603:10b6:208:265::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Tue, 31 Aug 2021 08:38:48 +0000 Received: from BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::3ca9:5da5:8b6e:ad0e]) by BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::3ca9:5da5:8b6e:ad0e%5]) with mapi id 15.20.4457.024; Tue, 31 Aug 2021 08:38:48 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , Matan Azrad , "dev@dpdk.org" CC: Anoob Joseph , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "Ananyev, Konstantin" , NBU-Contact-Thomas Monjalon , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , Ankur Dwivedi , Michael Shamis , Nagadheeraj Rottela , "jianjay.zhou@huawei.com" Thread-Topic: [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs Thread-Index: AQHXjiEbpiQKuDW4dUmU1gDJKZwiRatt3+AAgAAXFwCAHqTZUIAAtJ+AgAAaYEA= Date: Tue, 31 Aug 2021 08:38:48 +0000 Message-ID: References: <20210805200236.1180289-1-gakhil@marvell.com> <20210810195020.1423013-1-gakhil@marvell.com> <20210810195020.1423013-4-gakhil@marvell.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.0.76 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aa89e733-bb7a-4749-6c3f-08d96c5ac0bf x-ms-traffictypediagnostic: MN2PR11MB4582: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lanSe5UsSBFo7ntXCkvkVmd9cvyVd/Bq3j5UCyVDjiRno5esTwIkfB+qxCNewE9AU6GCze4G8PNnLrUwCLKtQByr5IH5UKVk0neifgrHYDqGgijH3tjUPkSWNWsk+gsC10siAVFbLVrMlElibyKt5bnxet6h+hmq2vSf1nMPwteXtWPxoSk7VL3A0K83MaK0W42O14aeKEm/NljhfMbR4Jb4HaYaVGPNjrNICQtL7ixZeB8YjyOYF9AtxVu0bdTzqqlAZmTGO5XdVNLEmDrnFq10/3Wl63khnV9yKSQK8K9tyPjUSaWp+M3W59sceG2o4ac9a4pE2D+3w0y3fXRv4M9VC4dDnft0NBfowrZ0IGLYOUxph184me9Dc6fsfbFyawZvLmpjgNc/G1V2NrRyUL3vMDcpYWjXUA7NMaZM4TZkBQHhgSQ8i2B/2TcAr/dlWXf1uNtz9NewZsul4aVq1Do6T6wcBvcsdbzcSuPzguzb90rsFe+4kXPlbektXdk90Vri0PgFiuF+FHe8JnCToyLRkFyDyM1zVNCJvNSG8vVM0qmE8Og6LPRCTwa0sqJ4Rw2YFkC7JMRes4IAhdlZGLnVvFL8aWHC3AJK8uPftqk5+SXI5zhbdrYxOIwLVB04ZZj1BUDr9sByOFNm1S+XStqgp+Ru5AbgnaoQGRKraXhT5n7DvuTiy75f9I/Kf7dxMQVoXgTj3GPixex3ciZLYw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(396003)(376002)(39860400002)(346002)(71200400001)(316002)(33656002)(38100700002)(9686003)(83380400001)(6506007)(2906002)(8936002)(26005)(52536014)(5660300002)(4326008)(54906003)(110136005)(122000001)(478600001)(76116006)(86362001)(8676002)(64756008)(66946007)(66556008)(66476007)(38070700005)(53546011)(7696005)(7416002)(55016002)(66446008)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?HCkJKSVo4d5nBT+1fFjAueFnTNCzZBZ6J6dkgVwucJ1CB20Z/BVCivlF?= =?Windows-1252?Q?coYQZZA2fyP14u+lyz0rm6nIittCwbvoyCRomap4oq7y6U1mjc4w4qMx?= =?Windows-1252?Q?ot7ThxQsH8uMiePIv//QarKUTiMuOmibmNJ2SIAyianzHetQDXDuA5EG?= =?Windows-1252?Q?mgFK3Aqt7Rivx5KwXZopTZjv1MgFFnJLbATWemGQFddlDnGeLIDARD9l?= =?Windows-1252?Q?rpnU7qhNQ7o8/IgntvHq8DKfNOgUOZH2WgOJqzNijCWfqsK4cVqi6I1p?= =?Windows-1252?Q?IVydPZ6S7aFMj/O/cmbyVlD+Go5hUnKxYc3fjRbUFTg1ILFF6jqT+1K6?= =?Windows-1252?Q?IUwi+hisAlqH7VV5sKcivORTC85pm1M76G0TJVLlE7eLYIwvDJgWeu+r?= =?Windows-1252?Q?CxDSGzWUFRXMVSC9YR9Z0e8AQAuYdK4DbFAym+oTwqr4yCb+x+K0Oj73?= =?Windows-1252?Q?/vbntKjPELTZwNV+V5pF7dHoW7THYXCIpOnc5dnnBM+id6tensusB1Ku?= =?Windows-1252?Q?JCFN1qlZlzLQsAsQZD8AEMgBb300ggGEcCi1ULbDZMaMCDdg2ADRC2+w?= =?Windows-1252?Q?vzWiimzx/JFOwLm3GEjgcKRPAYkuzMsxEvD56dLe5AVSTqFFyrXgUT0S?= =?Windows-1252?Q?V5rXSsgx9bTM8zAb5Lb35AXiFbL9Ah2inAs2a2y1sZlUPa9Ij4Ne0C0L?= =?Windows-1252?Q?hLEew99oB2Gf1J2wJiiGch3XnisQPcRBrUZ34CecUIWC1iM57oJAHTVx?= =?Windows-1252?Q?YZfNAIojFzkMboewoCLPnAZUQr2WCZM1d0487/bWfiRdqJzTrR8fNWAl?= =?Windows-1252?Q?FTSIVccNKcoyrUkADRNw/E5t1ZsaGFpUpd/Asii4PnLyfT1sVVJB6Ys9?= =?Windows-1252?Q?5rhmSZatrbJauYrPHwHQkI44rFb+1Teae5ukUiQ04n4Ub0ccLhSnLTOg?= =?Windows-1252?Q?20kgQX6txXzmUxnFTIMWMgfJt4FPGxd1G6zuGwi0HGVkhcZjxr/nfkOC?= =?Windows-1252?Q?4F8f/qB9h0ytM3hiN2k56I9Ubi9ckwB7rlOq/YVJlxqvArZR1r9b0MMn?= =?Windows-1252?Q?bTVReET+h7RiF1rXV3TlCD6CcFkh+/YHo8AgA/gW+R4YGrRHR4al/ZOq?= =?Windows-1252?Q?pCSXB67nYXrET3zl5bWubszkR2M9XhQBUvPZzBmW7nOol44LHZMK9y2u?= =?Windows-1252?Q?7jwZPA49Zc4MKWeVQYfAUzP8ktlJBqakhFB7PfAvJicQIE2wbsVNeUNk?= =?Windows-1252?Q?N/X8ymoiZxXUb571y+vgShH7yqkMZd0uSv7pGKIDpU9uxqXXJG2gbCcg?= =?Windows-1252?Q?1orT8DSu7qCZKRHi2yyxpE0XTF2DsqPTg/GsDR32plKYDzZYiXk8GTRT?= =?Windows-1252?Q?knWy83pQG7bX5mFlAA39lqmRJ2eXFYbrGdjTJDx9K+9F5Z4sJq5/jTRb?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3043.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa89e733-bb7a-4749-6c3f-08d96c5ac0bf X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2021 08:38:48.4193 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rx0KUR/OIYHepzHagAPpmEbDVc+us5jHOi5AusEQvNc9ryZhNjAYSxdShC06m7H7LuU+TOeQ3yodHP62uPps/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4582 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, August 31, 2021 8:04 AM > To: Zhang, Roy Fan ; Matan Azrad > ; dev@dpdk.org > Cc: Anoob Joseph ; Nicolau, Radu > ; Doherty, Declan ; > hemant.agrawal@nxp.com; Ananyev, Konstantin > ; NBU-Contact-Thomas Monjalon > ; asomalap@amd.com; ruifeng.wang@arm.com; > ajit.khaparde@broadcom.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Ankur Dwivedi ; Michael Shamis > ; Nagadheeraj Rottela > ; jianjay.zhou@huawei.com > Subject: RE: [PATCH v2 3/4] examples/fips_validation: remove illegal usag= e of > APIs >=20 > Hi Fan, > > > > > Some of the cryptodev APIs are not allowed to be used by applicat= ion > > > > > directly. Hence removing the usage of 1. queue_pair_release: it i= s not > > > > > required, as configure > > > > > of queue pair release the previous queue pairs and the > > > > > dev is not directly exposed to application, hence cannot > > > > > use its ops from app. > > > > > 2. rte_cryptodev_stop: it can be used directly without > > > > > checking if the device is started or not. > > > > > 3. rte_cryptodev_pmd_destroy: application should use > > > > > rte_cryptodev_close instead. > > > > > > > > > > Signed-off-by: Akhil Goyal > > > > > > > > Look's like it should be backported to stable releases with a Fixes > > reference. > > > > What do you think? > > > > > > > > Besides, > > > > Acked-by: Matan Azrad > > > > > > > Yes, Agreed. > > > I wanted to get opinion from the Maintainer of fips app first if the > changes > > > are > > > Correct or not. > > > > Hi Akhil, > > > > FIPS requirement is upon failure of running self-test the device memory > > shall be destroyed completely and not visible by the application at all= - > > rte_cryptodev_close does not provide this functionality. > > > > In this case we may need new API rte_cryptodev_destroy() to replace > > rte_cryptodev_pmd_destroy(). > > > _create and _destroy are called from device probe and remove. > If the requirement is to use pmd_destroy, how is the driver created again= ? > I do not see the use of rte_cryptodev_pmd_create() function. >=20 > The use of pmd APIs is not allowed from the application and it looks > something > Is not correct here for the use of destroy API. > Please check and fix as required. >=20 > Regards, > Akhil Will fix for Intel PMDs.=20 Regards, Fan