From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86C97A0C40; Thu, 5 Aug 2021 16:53:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4657F41281; Thu, 5 Aug 2021 16:53:09 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 914CC40040 for ; Thu, 5 Aug 2021 16:53:07 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="299757922" X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="299757922" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 07:53:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="512717240" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 05 Aug 2021 07:53:06 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 07:53:06 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 07:53:05 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Thu, 5 Aug 2021 07:53:05 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 5 Aug 2021 07:53:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=entr3bIWQiOZ6jQ/dT9Zz9tG08x5a88Zp4Umzu2Iq/Xe0jtHQu5XXuKxAinrkqnnqnu2eXf8dBfopOj9IDUEJxfwV+dxexRORFDYsoWG01ElCEXWipJCEfmLdjjd+tPp29jcYpg9ktatj7qgHgZCr/GU4n1Q49uIJ9870CNmzD7Bk+k56QV7XU+ksCEA72FOg3YFOrdt61kgcN9fgZunfNdxiyNIpboQ67GRBOYirLQHymooDq8VT3IFAnhNk3RnIFiv7aB8FsXI3U79OGjLH00cyf/K6mEyGt4/FGzCj5OwJEuGO5Mg2EvUFxAqwKhazKG+5bCOzab8MNMtw4uKmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BOgLZW51es98bRQ1EekzN0gpj9QJTLNR8oxxRI7PnB8=; b=Ilk0v84VEUfUi9D0Q6Hn8SeHrGiKMQU1hMLirJ7YwR5qWnxQyg7jnyjme6W6nl4rVcbnAWPJx2SOnDFf505utQgGIG5B81/XGd5RnhY14D9Hi2KWG8CGXHsEovZTQCpN+i5d8S8SxwLRb/XwUfk4pGBKC61y2Y/QF7wVl70egwLtFgmrpH7hRI5SP2jHG+oQoUJjn6Vbv1jlISy+T++r9L8LMR1NSr5Vo6HeyB7AxF8zkiyLJ3nRXuhE7Pp5UATGST4aTig02PJruFMRjhznN8jg8FcR1xc0xD+7kQUBoKF6FFvHP37zAh6F5nO51cLz/YjeuwE46mxMnTm5N3gzyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BOgLZW51es98bRQ1EekzN0gpj9QJTLNR8oxxRI7PnB8=; b=Q3HZFa2I21LjOMhxO4p40uhvKtHZSkcLBgtOmqpjfdExiF76Tg16tg1FIDPFLwvj0H80tTYdw4nGJZfjlWBoLJZPHhRxyUWl+4D8gH+3OEWiY5cfh493qwOeA+qBVSeftjVR54WuGhCiN4FwDNRNCX24ON7bSrhvnXGThw7qTvA= Received: from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19) by MN2PR11MB4176.namprd11.prod.outlook.com (2603:10b6:208:13b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.16; Thu, 5 Aug 2021 14:53:02 +0000 Received: from BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::3048:2055:b488:129f]) by BL0PR11MB3043.namprd11.prod.outlook.com ([fe80::3048:2055:b488:129f%5]) with mapi id 15.20.4373.027; Thu, 5 Aug 2021 14:53:02 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "dev@dpdk.org" CC: Anoob Joseph , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "matan@nvidia.com" , "Ananyev, Konstantin" , "thomas@monjalon.net" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , Ankur Dwivedi , Michael Shamis , Nagadheeraj Rottela , "jianjay.zhou@huawei.com" Thread-Topic: [PATCH v2] doc: announce restructuring of crypto session structs Thread-Index: AQHXiF97YIW/OpvIP0qm7wF9Hsp9AKtk8YZggAAE1ACAAAvfgA== Date: Thu, 5 Aug 2021 14:53:02 +0000 Message-ID: References: <20210803115512.694546-1-gakhil@marvell.com> <20210803120112.694697-1-gakhil@marvell.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.0.76 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3d7cbefa-b94d-4de4-6dbf-08d95820b981 x-ms-traffictypediagnostic: MN2PR11MB4176: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y1ZV0JwZXJtpmiRYyjoliybf+a1/sWE3JuUnwa+S2/TUVh31NNuTJqA/250bn+bKk0/jtJ0dp2S3LydH53oNpZlP2Q7kUbCeqHhVWRDaeBosQwJ7k3YPWLEAUaru12euKjkZCRhoXyyX3Br2FE9G/YiB+pv18kGIV+p6P5ZAmfSjuHFgysNiDybvaBYdYf5IEhgywA1f37Zj7HNE78IVj67RJlMYFwQ7TxBYsk9xAk/EXKy+xWMtBkLdz3FsT/jM0seiRa4XU5F9Bq9OPZnSVJQm233idFzIajHR6bwCHuqYma2qFhX9/vI/NkPHrgXJ/ZqAMSSTb+yJOojGbWWuYGr+8wcOd+v/tYDXuAHU5v4Hh+LHKl1RnRLIc84Kck9Kouh2UgKKbZREBxCLnFPACMgVxHxl3oDPUswTgzTPsR17PjvsR/JVWcc6Ci2f7H4/MPVsicUpgQQlw5G5XFoUWyh3AouprQTlwhUr0h1EnqV1w3Z7ZVFk5LU1HHpKLUy97DsTHldQQXnODXI66luzWs6dBRyhxR+5HOMXHiuKwKJNz+E/VPf39e4XujM5Icvz6DFM1MyTyCYYKvEpdnqQDrgKItL9unJTArJzurIA6OKLl5/9mxQTzOqz+ZOPE0F2t3f/lI0kGq6ktoFZrXhvpZRGXSvQ1aK2cgUCgaIwp/SF3K5iLDafpc9rDh+dnHhnxfjO20O+YZyvYWDhhzR2Ew== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(39860400002)(396003)(376002)(346002)(84040400005)(4326008)(110136005)(55016002)(122000001)(478600001)(38100700002)(8676002)(9686003)(54906003)(316002)(5660300002)(71200400001)(38070700005)(52536014)(2906002)(7696005)(86362001)(7416002)(83380400001)(6506007)(53546011)(8936002)(64756008)(76116006)(66476007)(66556008)(66446008)(186003)(33656002)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?jtrvNHtDDdXzN14GXWwoxroytY92sT1tQPdadHIOFG+diKandDXIyE+K?= =?Windows-1252?Q?XEZ5SLy33fpZOxLBrtw3kc7G6uZ8MuPCVXrPo/oavvhEd3qGePSHy+NY?= =?Windows-1252?Q?IG3g1pnU1GkCdW3oyx5SwfFj7HTXpBc0D2jkTWLYsi6pONy/dAELQs8M?= =?Windows-1252?Q?UCgfxplHQyI7mk8dS3zWvsCNdcEb1xE3gTvCwHUFEsBHKiz/tXgsT9c9?= =?Windows-1252?Q?sJSrZFBGRk3vQE0mPC7E0FPdINdWJf8T5O4IXpUOHzRwwe8lV3Q7IFph?= =?Windows-1252?Q?h3r2yVoYbZaHUAAqgWMa82/qkuMTUEb3wcHe66c5hlT4ADJoG7OQ8pzB?= =?Windows-1252?Q?wHIWdfzhM8jqJLnuufA0z1LJqzx9Zt3zlMCdBHFEqr1ZP38CSPYxZlxX?= =?Windows-1252?Q?Y53zdzZkqUFehp/0F9D+wz6BLnI8A6kUfDBbiqFAel5iz6BdNE/l0xf5?= =?Windows-1252?Q?fp79jPEMjt7cfBQlZe826dZFSMa7T4bpcl2cz0voUvX9OgEg/8kz7Mcl?= =?Windows-1252?Q?jI2OxMU8ihB6J868ZdgXdhrWuPoj0WQWbJxNBSdc90+BvalfiN1RHvA7?= =?Windows-1252?Q?OvLrS3SDadNS+eUzn8msZATFuU7jOLGJq2QnL2zL82pcI7hreUwRb84P?= =?Windows-1252?Q?LGeIUII8gFXW9Y6cnSHlKvX2KloQbKUjYySp6/bKazl81uSHEqVK9v3s?= =?Windows-1252?Q?Aa1r/n55jq1b/V9X4KYMMqli9l3uIJZroQ/Fk4zG/V+/+C/W/ALBHhtE?= =?Windows-1252?Q?LJrc3fUOXrkkCRHv/d+/QTVGGU0nf1MKHMTzUj49EhXZ9FlggVmln7TK?= =?Windows-1252?Q?z3VUrqZUDfjvUamPykbxFiBBcIwjm58saw2h7J9ElA8Wmn9udwiwmW11?= =?Windows-1252?Q?ztLl7bqearil/ylrvJHKWZqJxElz+QI7yVucRBySEhx8tuRztf+euTzw?= =?Windows-1252?Q?jxPNY9iOlHx4Y1WlJMCWD0CgCSA2GhP8TeaqQ/jAJS6iZPquVz4plO0c?= =?Windows-1252?Q?Ghv8NRwGinkBOyjgE6jRmjLTYHUkrvLdLo3/CyXG6zxbB+7TlKKzvxrK?= =?Windows-1252?Q?Vg1dGIyIiReYAVFQFPwC9QseM9aP3VAoU2TxI5w5bDG+woKX+WGntvNo?= =?Windows-1252?Q?tOqLMz+Vf9COL7zA7Q4fU7Wn+0UvN+ykyxi87KtwxXXmNenSLR1SHMi5?= =?Windows-1252?Q?eExxH06/Tk4off+e4hZP3dxIn6y/3wnhoaOGDOCK5VqI6XBtsnCANoYV?= =?Windows-1252?Q?GDaJB3ZxP92JOtiXcy5PfXnfbZ0Q3tiTBQWtL2ngFzZh5GLsLO5F9RkU?= =?Windows-1252?Q?UKp5+Yd92zkwusPkt5wSXV0CYtHbqc0AQIHpedZAffTGukeDIHNunAGj?= =?Windows-1252?Q?mlXrFImDYHtt9lgkows0dsVf7CLvHdSTXR5vK/6KlCp14W9QEFC3ugfh?= =?Windows-1252?Q?Ybc6/7HlWmyrm7EULrd+7jWff3L/N9lLRVsEUfrIiIqdmI8thkPOG9Dj?= =?Windows-1252?Q?c8m39gqO?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3043.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d7cbefa-b94d-4de4-6dbf-08d95820b981 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2021 14:53:02.2471 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q6ESoicK/FgDkVSoBHVQkf1J58b3rU9YX9pVC2YugUT6yHNMUfymHdBc9KdtSEpiaStteFgGo7T9Ujede0GWkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4176 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] doc: announce restructuring of crypto session structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, No problem. Glad to help. If you have code ready to share please let me kno= w. Regards, Fan > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, August 5, 2021 3:10 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: Anoob Joseph ; Nicolau, Radu > ; Doherty, Declan ; > hemant.agrawal@nxp.com; matan@nvidia.com; Ananyev, Konstantin > ; thomas@monjalon.net; > asomalap@amd.com; ruifeng.wang@arm.com; > ajit.khaparde@broadcom.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Ankur Dwivedi ; Michael Shamis > ; Nagadheeraj Rottela > ; jianjay.zhou@huawei.com > Subject: RE: [PATCH v2] doc: announce restructuring of crypto session str= ucts >=20 > Hi Fan, > > Hi Akhil, > > > > > The structures rte_cryptodev_sym_session and > > > rte_cryptodev_asym_session are not used by the > > > application directly. The application just need > > > an opaque pointer which it can attach to rte_crypto_op > > > while enqueue. > > > Hence, these structures can be internal to library > > > hidden from the user. > > > > > > Signed-off-by: Akhil Goyal > > > --- > > > v2: fixed trailing whitespace. > > > > > > doc/guides/rel_notes/deprecation.rst | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > > b/doc/guides/rel_notes/deprecation.rst > > > index f81bd87f10..c540c90f8e 100644 > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > @@ -151,6 +151,11 @@ Deprecation Notices > > > * cryptodev: The APIs for interfacing between library and PMD will b= e > > > marked > > > as internal APIs in DPDK 21.11. > > > > > > +* cryptodev: Hide structures ``rte_cryptodev_sym_session`` and > > > + ``rte_cryptodev_asym_session`` to remove unnecessary indirection > > > between > > > + session and the private data of session. An opaque pointer can be > > exposed > > > + directly to application which can be attached to the ``rte_crypto_= op``. > > > + > > > * security: The functions ``rte_security_set_pkt_metadata`` and > > > ``rte_security_get_userdata`` will be made inline functions and > additional > > > flags will be added in structure ``rte_security_ctx`` in DPDK 21.1= 1. > > > -- > > > 2.25.1 > > > > Have you considered how crypto scheduler PMD can support multiple > crypto > > devices' opaque data pointers after the change? Of course it is doable = by > > adding dedicated APIs to the scheduler PMD - shall I assume you will wo= rk > on > > it? >=20 > I haven't considered about the scheduler PMD yet. Would need your help in > aligning that. > The deprecation notice is to allow us change in 21.11 timeframe. >=20 > Thanks, > Akhil