* [dpdk-dev] [PATCH v3] test/crypto: check if RAW API is supported
@ 2021-07-19 12:37 Adam Dybkowski
2021-07-19 15:25 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-20 13:11 ` [dpdk-dev] [PATCH v4] " Adam Dybkowski
0 siblings, 2 replies; 5+ messages in thread
From: Adam Dybkowski @ 2021-07-19 12:37 UTC (permalink / raw)
To: dev, roy.fan.zhang, gakhil; +Cc: Adam Dybkowski
This patch adds checking if RAW API is supported at the start
of the test command "cryptodev_qat_raw_api_autotest".
Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
---
app/test/test_cryptodev.c | 34 +++++++++++++++++++++++++++++++++-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 31201d93e1..43c05ed3d8 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -14766,7 +14766,39 @@ test_cryptodev_bcmfs(void)
static int
test_cryptodev_qat_raw_api(void)
{
- int ret;
+ static const char *pmd_name = RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD);
+ struct rte_cryptodev_info dev_info;
+ uint8_t i, nb_devs, found = 0;
+ int driver_id, ret;
+
+ driver_id = rte_cryptodev_driver_id_get(pmd_name);
+ if (driver_id == -1) {
+ RTE_LOG(WARNING, USER1, "%s PMD must be loaded.\n", pmd_name);
+ return TEST_SKIPPED;
+ }
+
+ nb_devs = rte_cryptodev_count();
+ if (nb_devs < 1) {
+ RTE_LOG(WARNING, USER1, "No crypto devices found?\n");
+ return TEST_SKIPPED;
+ }
+
+ for (i = 0; i < nb_devs; i++) {
+ rte_cryptodev_info_get(i, &dev_info);
+ if (dev_info.driver_id == driver_id) {
+ if (!(dev_info.feature_flags &
+ RTE_CRYPTODEV_FF_SYM_RAW_DP)) {
+ RTE_LOG(INFO, USER1, "RAW API not supported\n");
+ return TEST_SKIPPED;
+ }
+ found = 1;
+ break;
+ }
+ }
+ if (!found) {
+ RTE_LOG(INFO, USER1, "RAW API not supported\n");
+ return TEST_SKIPPED;
+ }
global_api_test_type = CRYPTODEV_RAW_API_TEST;
ret = run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [EXT] [PATCH v3] test/crypto: check if RAW API is supported
2021-07-19 12:37 [dpdk-dev] [PATCH v3] test/crypto: check if RAW API is supported Adam Dybkowski
@ 2021-07-19 15:25 ` Akhil Goyal
2021-07-20 13:11 ` [dpdk-dev] [PATCH v4] " Adam Dybkowski
1 sibling, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2021-07-19 15:25 UTC (permalink / raw)
To: Adam Dybkowski, dev, roy.fan.zhang
> This patch adds checking if RAW API is supported at the start
> of the test command "cryptodev_qat_raw_api_autotest".
>
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> app/test/test_cryptodev.c | 34 +++++++++++++++++++++++++++++++++-
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index 31201d93e1..43c05ed3d8 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -14766,7 +14766,39 @@ test_cryptodev_bcmfs(void)
> static int
> test_cryptodev_qat_raw_api(void)
> {
> - int ret;
> + static const char *pmd_name =
> RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD);
> + struct rte_cryptodev_info dev_info;
> + uint8_t i, nb_devs, found = 0;
> + int driver_id, ret;
> +
> + driver_id = rte_cryptodev_driver_id_get(pmd_name);
> + if (driver_id == -1) {
> + RTE_LOG(WARNING, USER1, "%s PMD must be loaded.\n",
> pmd_name);
> + return TEST_SKIPPED;
> + }
> +
> + nb_devs = rte_cryptodev_count();
> + if (nb_devs < 1) {
> + RTE_LOG(WARNING, USER1, "No crypto devices found?\n");
> + return TEST_SKIPPED;
> + }
> +
> + for (i = 0; i < nb_devs; i++) {
> + rte_cryptodev_info_get(i, &dev_info);
> + if (dev_info.driver_id == driver_id) {
> + if (!(dev_info.feature_flags &
> + RTE_CRYPTODEV_FF_SYM_RAW_DP))
> {
> + RTE_LOG(INFO, USER1, "RAW API not
> supported\n");
> + return TEST_SKIPPED;
> + }
> + found = 1;
> + break;
> + }
> + }
> + if (!found) {
> + RTE_LOG(INFO, USER1, "RAW API not supported\n");
> + return TEST_SKIPPED;
> + }
>
Can we make it a generic function which may be used by other PMDs as well
to check if feature flag is set or not. You can call the function from
test_cryptodev_qat_raw_api(). The function can take pmd_name as input
similar to run_cryptodev_testsuite.
> global_api_test_type = CRYPTODEV_RAW_API_TEST;
> ret =
> run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v4] test/crypto: check if RAW API is supported
2021-07-19 12:37 [dpdk-dev] [PATCH v3] test/crypto: check if RAW API is supported Adam Dybkowski
2021-07-19 15:25 ` [dpdk-dev] [EXT] " Akhil Goyal
@ 2021-07-20 13:11 ` Adam Dybkowski
2021-07-20 13:14 ` Zhang, Roy Fan
1 sibling, 1 reply; 5+ messages in thread
From: Adam Dybkowski @ 2021-07-20 13:11 UTC (permalink / raw)
To: dev, roy.fan.zhang, gakhil; +Cc: Adam Dybkowski
This patch adds checking if RAW API is supported at the start
of the test command "cryptodev_qat_raw_api_autotest".
Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
app/test/test_cryptodev.c | 43 ++++++++++++++++++++++++++++++++++++++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 31201d93e1..25778f464b 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -14517,6 +14517,41 @@ run_cryptodev_testsuite(const char *pmd_name)
return ret;
}
+static int
+require_feature_flag(const char *pmd_name, uint64_t flag, const char *flag_name)
+{
+ struct rte_cryptodev_info dev_info;
+ uint8_t i, nb_devs;
+ int driver_id;
+
+ driver_id = rte_cryptodev_driver_id_get(pmd_name);
+ if (driver_id == -1) {
+ RTE_LOG(WARNING, USER1, "%s PMD must be loaded.\n", pmd_name);
+ return TEST_SKIPPED;
+ }
+
+ nb_devs = rte_cryptodev_count();
+ if (nb_devs < 1) {
+ RTE_LOG(WARNING, USER1, "No crypto devices found?\n");
+ return TEST_SKIPPED;
+ }
+
+ for (i = 0; i < nb_devs; i++) {
+ rte_cryptodev_info_get(i, &dev_info);
+ if (dev_info.driver_id == driver_id) {
+ if (!(dev_info.feature_flags & flag)) {
+ RTE_LOG(INFO, USER1, "%s not supported\n",
+ flag_name);
+ return TEST_SKIPPED;
+ }
+ return 0; /* found */
+ }
+ }
+
+ RTE_LOG(INFO, USER1, "%s not supported\n", flag_name);
+ return TEST_SKIPPED;
+}
+
static int
test_cryptodev_qat(void)
{
@@ -14766,10 +14801,16 @@ test_cryptodev_bcmfs(void)
static int
test_cryptodev_qat_raw_api(void)
{
+ static const char *pmd_name = RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD);
int ret;
+ ret = require_feature_flag(pmd_name, RTE_CRYPTODEV_FF_SYM_RAW_DP,
+ "RAW API");
+ if (ret)
+ return ret;
+
global_api_test_type = CRYPTODEV_RAW_API_TEST;
- ret = run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));
+ ret = run_cryptodev_testsuite(pmd_name);
global_api_test_type = CRYPTODEV_API_TEST;
return ret;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v4] test/crypto: check if RAW API is supported
2021-07-20 13:11 ` [dpdk-dev] [PATCH v4] " Adam Dybkowski
@ 2021-07-20 13:14 ` Zhang, Roy Fan
2021-07-20 20:48 ` Akhil Goyal
0 siblings, 1 reply; 5+ messages in thread
From: Zhang, Roy Fan @ 2021-07-20 13:14 UTC (permalink / raw)
To: Dybkowski, AdamX, dev, gakhil
> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Sent: Tuesday, July 20, 2021 2:12 PM
> To: dev@dpdk.org; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> gakhil@marvell.com
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH v4] test/crypto: check if RAW API is supported
>
> This patch adds checking if RAW API is supported at the start
> of the test command "cryptodev_qat_raw_api_autotest".
>
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
> app/test/test_cryptodev.c | 43
> ++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index 31201d93e1..25778f464b 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -14517,6 +14517,41 @@ run_cryptodev_testsuite(const char
> *pmd_name)
> return ret;
> }
>
> +static int
> +require_feature_flag(const char *pmd_name, uint64_t flag, const char
> *flag_name)
> +{
> + struct rte_cryptodev_info dev_info;
> + uint8_t i, nb_devs;
> + int driver_id;
> +
> + driver_id = rte_cryptodev_driver_id_get(pmd_name);
> + if (driver_id == -1) {
> + RTE_LOG(WARNING, USER1, "%s PMD must be loaded.\n",
> pmd_name);
> + return TEST_SKIPPED;
> + }
> +
> + nb_devs = rte_cryptodev_count();
> + if (nb_devs < 1) {
> + RTE_LOG(WARNING, USER1, "No crypto devices found?\n");
> + return TEST_SKIPPED;
> + }
> +
> + for (i = 0; i < nb_devs; i++) {
> + rte_cryptodev_info_get(i, &dev_info);
> + if (dev_info.driver_id == driver_id) {
> + if (!(dev_info.feature_flags & flag)) {
> + RTE_LOG(INFO, USER1, "%s not
> supported\n",
> + flag_name);
> + return TEST_SKIPPED;
> + }
> + return 0; /* found */
> + }
> + }
> +
> + RTE_LOG(INFO, USER1, "%s not supported\n", flag_name);
> + return TEST_SKIPPED;
> +}
> +
> static int
> test_cryptodev_qat(void)
> {
> @@ -14766,10 +14801,16 @@ test_cryptodev_bcmfs(void)
> static int
> test_cryptodev_qat_raw_api(void)
> {
> + static const char *pmd_name =
> RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD);
> int ret;
>
> + ret = require_feature_flag(pmd_name,
> RTE_CRYPTODEV_FF_SYM_RAW_DP,
> + "RAW API");
> + if (ret)
> + return ret;
> +
> global_api_test_type = CRYPTODEV_RAW_API_TEST;
> - ret =
> run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));
> + ret = run_cryptodev_testsuite(pmd_name);
> global_api_test_type = CRYPTODEV_API_TEST;
>
> return ret;
> --
> 2.25.1
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v4] test/crypto: check if RAW API is supported
2021-07-20 13:14 ` Zhang, Roy Fan
@ 2021-07-20 20:48 ` Akhil Goyal
0 siblings, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2021-07-20 20:48 UTC (permalink / raw)
To: Zhang, Roy Fan, Dybkowski, AdamX, dev
> > This patch adds checking if RAW API is supported at the start
> > of the test command "cryptodev_qat_raw_api_autotest".
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > ---
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-crypto
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-20 20:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 12:37 [dpdk-dev] [PATCH v3] test/crypto: check if RAW API is supported Adam Dybkowski
2021-07-19 15:25 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-20 13:11 ` [dpdk-dev] [PATCH v4] " Adam Dybkowski
2021-07-20 13:14 ` Zhang, Roy Fan
2021-07-20 20:48 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).