Re: [dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function

["McDaniel, Timothy" <timothy.mcdaniel@intel.com>]

> -----Original Message-----
> From: Eads, Gage <gage.eads@intel.com>
> Sent: Monday, September 14, 2020 3:23 PM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>; Jerin Jacob
> <jerinj@marvell.com>
> Cc: dev@dpdk.org; Carrillo, Erik G <Erik.G.Carrillo@intel.com>; Van Haaren,
> Harry <harry.van.haaren@intel.com>
> Subject: RE: [PATCH] eventdev: add PCI probe named convenience function
> 
> <snip>
> 
> >  /**
> >   * @internal
> > + * Wrapper for use by pci drivers as a .probe function to attach to a event
> > + * interface.
> > + */
> > +static inline int
> > +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
> > +			    struct rte_pci_device *pci_dev,
> > +			    size_t private_data_size,
> > +			    eventdev_pmd_pci_callback_t devinit)
> > +{
> > +	char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN];
> > +
> > +
> 
> Two blank lines -- DPDK coding style doesn't forbid this as far as I know
> (LINE_SPACING is ignored in checkpatch), but just an FYI in case this was
> unintentional.

Fixed.  Will be available in V2 patch-set.

> 
> > +	rte_pci_device_name(&pci_dev->addr, eventdev_name,
> > +			sizeof(eventdev_name));
> > +
> > +	return rte_event_pmd_pci_probe_named(pci_drv,
> > +					     pci_dev,
> > +					     private_data_size,
> > +					     devinit,
> > +					    (const char *)eventdev_name);
> 
> Nit: the cast is unnecessary, the conversion will happen implicitly without it.
> 

Fixed.  Will be available in V2 patch-set.

> With that,
> Reviewed-by: Gage Eads <gage.eads@intel.com>