From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CE01A0350; Mon, 11 May 2020 16:40:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5EB0E1BFEF; Mon, 11 May 2020 16:40:32 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 541F729CB for ; Mon, 11 May 2020 16:40:28 +0200 (CEST) IronPort-SDR: dx6w7WGWbh1Tsp22D5VrqVdmOdZs6nCKiDwcFSD8b/mxihSy74i0OIZOXAXqDjumTG5Eh44iks rk3grbbbxpCQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 07:40:20 -0700 IronPort-SDR: H+fweJwnDhCKbHoO8/v365HMH5k8DItNsULeHVJky9lHEdbJqbdfQ0eK1+ytracW2x2AGjJnmF /COe3gZ+o+3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,380,1583222400"; d="scan'208";a="340569382" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 11 May 2020 07:40:19 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 07:40:19 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 07:40:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GF9Aa2EppPi+62aGCKQJW8/r0VFJcknvfO4WZsXA2wMUCKzIk1b0IRyETxx2FGDeKjMCx5XdnbUANzeDRHh8CUu2sAYTYQXbrYbCvIgWuBO7JdFYuEOleFGAGccvkEt1/yZ9MKDqLdrWGS42/s76SmSV9c/ZxsxihWca9oDTM88Bv11Kw1fS8ecXXlSNvpwLC/LmbBFSeOkAFBpv6OsRfrVR+2YTal9czRByncMuQNhKHAXlSdzZbXDyPtaTzoZSH7pf6lIEQc8Ij2TmWfi5wJYM22nmQ0rfVV/bj9eqz1mcd2ddGiuLxY31wADYNraZH1FBh/J6/PpOm5qHQ16haA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XNRvRa+RtrOfQ3k5FmBK78KVfQ3YgXqUkErCiqWjFBo=; b=Ac0LkAm4nHl1Lo77eKt0ipJ0yQhY8W+cpvufUOEAmPzgmHk88sicycJK441mt1qhKrFPm4bypG0PaHwBX4aHz7GiL4vOtXGNFqnKTxCz9QDNkYOYz6b5+pzpaDL1WRIO6/7awRMIccBtLoN65wN2yJg3A1sx7P4CBar/eoneMZ7CKsKS00pg338T2EwMdkC8YbjS6SmXoeqkwv8st3U3elIsoCh2ya+L2O5msQqG6obunujaS/tN/fk1YKVQ5DmIPmTc/oWyaVlgZtH2nDlVI8pl1gm7D7/2WanMa3dLj0Tn2tpBjzVRe/awNOwoSER0Rl38bbznvq+dzlQSa6oVmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XNRvRa+RtrOfQ3k5FmBK78KVfQ3YgXqUkErCiqWjFBo=; b=kLucm4acfLSUzo4gi76Ziba3wHffl/MQGzYZgcZk27SCjahscZtFACa04jcBssDO3jNyIKHR3Z5gYrAleNqaI6sdM0S8yt3xA1NsVDQ65PhkX5rQ5TTciOuvXat19XKXXsVyHTyQEUh/82r7bpekXM07yoTA7OxRZ21+jyO6KDQ= Received: from BL0PR11MB3090.namprd11.prod.outlook.com (2603:10b6:208:74::23) by BL0PR11MB3218.namprd11.prod.outlook.com (2603:10b6:208:60::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Mon, 11 May 2020 14:40:17 +0000 Received: from BL0PR11MB3090.namprd11.prod.outlook.com ([fe80::9c82:944b:81de:cdfd]) by BL0PR11MB3090.namprd11.prod.outlook.com ([fe80::9c82:944b:81de:cdfd%6]) with mapi id 15.20.2979.033; Mon, 11 May 2020 14:40:17 +0000 From: "De Lara Guarch, Pablo" To: Akhil Goyal , "dev@dpdk.org" CC: "Ruifeng.Wang@arm.com" , "Doherty, Declan" , "asomalap@amd.com" , "anoobj@marvell.com" , "Zhang, Roy Fan" , "Trahe, Fiona" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , Gagandeep Singh , Hemant Agrawal , "jianjay.zhou@huawei.com" , "Dybkowski, AdamX" , Apeksha Gupta Thread-Topic: [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned data Thread-Index: AQHWJlpeT+rSwW7/K0uGQm7U+o+dHaiipduAgAAEzQCAAEx3YA== Date: Mon, 11 May 2020 14:40:17 +0000 Message-ID: References: <20200504215811.15951-1-akhil.goyal@nxp.com> <20200509231217.8219-1-akhil.goyal@nxp.com> <20200509231217.8219-2-akhil.goyal@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.169] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dab9e161-ba6e-472a-3dba-08d7f5b93966 x-ms-traffictypediagnostic: BL0PR11MB3218: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B7rGTZSpptgEHpeQ9NJ1O+LYwHsqkmzodPA7273uQjV1yxSI5eICVUSbgmyagkPr8qgTfUcJbsK+ueVWvw4USz4Rw9WTOpaMcyA2jXgU4vYvOhyvTc/9bMx9pHhXiwV/t6tN3zYZkQ85FzCHMpDxLrrOsHNYPV4CVX8IUHZTwSKqpKfE0Uv33xpgLRb1kofX+0auDYFjBaYoq3+pn3J47w8C3aWaD3LhVAnZc8XfL0V00fwwmfMu7PuZvEQcZM+PHOObXIf/mgZ3BWM4IQo9AsGHmrQodRL/TdCRXo3oGFm0VZYgkgn1veopLVEpw2WODta13scO49yXSoRzhvrOntWQug/699ZpgtmW25BgaGfzybQPV22/xHXTc0E/b8MTkei5I/k1uSRA34BLOaWXeeFiRzftvTWCfV/rIg1paXyOQ7UG8iOF756QZbrzPhpIAP5/V0lZKqU4Slp7ferW3r6minviEYRDLX6eaATnX4R5t+SYtFdHgbnvIEPkxn80phRGwyG+19T/FbsZ0nN7NA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3090.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(346002)(39860400002)(366004)(376002)(396003)(33430700001)(54906003)(316002)(4326008)(9686003)(110136005)(66446008)(71200400001)(66946007)(7416002)(478600001)(66556008)(64756008)(66476007)(52536014)(2906002)(7696005)(86362001)(76116006)(8936002)(8676002)(55016002)(5660300002)(6506007)(33440700001)(186003)(33656002)(53546011)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: cAwX4b0mHo1Fv5XrGLRfbgRxPSmNm81eNjPwu21G5a0nzlTyAaHcnSqf4IBqcnUQb2Mf5uMXYntewQjuG9VcYrRlKyQStMf/UQjfOQf4FL04rxh8Lh6uB7mrv4NaSOFoFCy7VYzg8I5VO12q5X9oY+WNrrNAGiaukE9BWT3TaK78pYmUSz2/6kNJZss3AqLEHm0EDALh7iCEj2I1uSIifyVSvfeVCVpChgAHPwh5rhaEamhTxOAr42kMZM/amDcOthCv3QYjX8L84XjBLl9qEL1Av/Gcr2+oVDZz+gul0XNcFDEKKmbQl6mzzdeiimTV96AtgXUF74MSzMZRcCYD4fPv1ARq2terMUbNsRXLm1XxqVxKtdQfPaWVEUnlfSDpbrMlb5CMxUWc2EqoD7+O3e+v2v+NmAb4Hk2/czSLqNi6bHaB2hymDRUF+zscVkTXoTWqsC2hJNsB5llyT776bSQwhEdXN56k2cT4N9HXNLwNsWYltFj+xOUE4OKLvUGu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: dab9e161-ba6e-472a-3dba-08d7f5b93966 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 14:40:17.4842 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8b+0oMplChc/XXhjIS132GsEXOnw0axg0QwypU/8Astq/jbwtjUXolMI6KpdGgbCFkj5XwTG1Vlc4hlG7tXwXxlKQdPBEt5UqiHU5B3/abY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3218 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Monday, May 11, 2020 11:05 AM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Ruifeng.Wang@arm.com; Doherty, Declan ; > asomalap@amd.com; anoobj@marvell.com; Zhang, Roy Fan > ; Trahe, Fiona ; > rnagadheeraj@marvell.com; adwivedi@marvell.com; Gagandeep Singh > ; Hemant Agrawal ; > jianjay.zhou@huawei.com; Dybkowski, AdamX ; > Apeksha Gupta > Subject: RE: [PATCH v2 1/9] cryptodev: add feature flag for non-byte alig= ned > data >=20 > Hi Pablo, > > > > Hi Akhil, > > > > > > > > Some wireless algos like SNOW, ZUC may support input data in bits > > > which are not byte aligned. However, not all PMDs can support this > > > requirement. Hence added a new feature flag > > > RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA > > > to identify which all PMDs can support non-byte aligned data. > > > > > > Signed-off-by: Akhil Goyal > > > Acked-by: Fiona Trahe > > > > On these PMDs, some of these algorithms do not support non byte aligned > data. > > For instance, for ZUC, the cipher algorithm doesn't support length in > > bits, but the authentication algorithm does. > > All test pass because in the tests we are doing encryption in bytes > > and then we mask off the bits not used. > > Wonder if we need two different flags for this, one for cipher and > > another one for authentication. > > Maybe again this is not enough, since we should have a flag per > > algorithm... and starting with this flag is a step forward. > > What do you think? > IMO, supporting non-byte-aligned data is a feature as a whole, but we sho= uld > not have Per algo basis. It will be better if we come up with something i= n the > capability as we do For validating the key sizes etc. So in this case, it would be something per algo basis. > We should only have a single flag in feature flag list. Or none if we hav= e a > solution which Is generic in capability. >=20 > What do you say? >=20 > However for now I am applying this series as this is the solution that we= have > right now. > We can fix the ZUC issue in probably next release cycle. >=20 Agree to leave this for later releases, fixes the problem for now. > Regards, > Akhil >=20 >=20