From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A94A7A0553; Fri, 10 Jun 2022 09:31:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CD54406B4; Fri, 10 Jun 2022 09:31:45 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B65114069C for ; Fri, 10 Jun 2022 09:31:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654846303; x=1686382303; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=E0XeAhiEbtgYJy5oJToFoCR0BkgZkC9WlOK+DhavZi8=; b=WvgJN8zmC5sIq4HPpAINtd6Mpv2YyxpoWLbAoG9tD8Z3KTGzd8PL1YP/ qrGOQ80xpfm0JnM9Kp6YlsE/eEFZGtqL6ibwo+ilgewUz+0sqhbzQtwWD aV4vDDl48M2cXTwK7LAcPZLtaOEDumvO0Y6US69A1qpbHm86EH/KzEBCd 4rqzi5XmzSigqpvrE6vBD2VvjLNDgKCMNpG4yMUbrx4xNeTgIEIvCnBbO +IsXVMckekwoxkpMjVNAX4A6oJu1LPQr3X4Id5qQ7cUvEwzD3Dhf7q1zQ dLChKg4TuSmcQOGKrm8azelW/EDFMUX+YezRzDyF3MWrvp5utogBGaMpM g==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="302920892" X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="302920892" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 00:31:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="556266266" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 10 Jun 2022 00:31:42 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 10 Jun 2022 00:31:42 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 10 Jun 2022 00:31:41 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 10 Jun 2022 00:31:41 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 10 Jun 2022 00:31:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hQIggf7asGQwzKPXKGMKNLbeUmXd3AMTYR4mh0PoqQ13tA4VAAdPGUgc54/5lve4bQzBZLj8SXiqDJAZA0h9rxBEx/A8wbb3PDLeflxgd9tGWx2LHbwOzwpCvusFnzwU/8pUvZ8ble7vbXo7iZkc+Q/WV3F9zpDPGDhUDrVdzjAdgpWR6vlCueewDWGbhd1bLE+cHxnf84Gq8trSTprkHMEdogdG0NiXrzEeXq9dSBkfemXXUnLn5zeJm8Sasr89bM08VPvRTlQXzCVhEZQ391NEH3SoYBzoxwrRqYZbmX8WnsEbaKebfVkno9oqdqqngatYgNW7qJfi49Opab2LGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E0XeAhiEbtgYJy5oJToFoCR0BkgZkC9WlOK+DhavZi8=; b=e7aC4Fa78zeaU2jtLzOVQKceqZXh9VFkQbu/wWyMVsNfV4LA/6GRvodocumJikm/7ra9CULZU5eX9J/2vztqf24I4n82b36aQ0zYjkFl2VwvyBvJKd4gJ1/UsspeJJYqDEdTKu6ib4E4QxqT9bAx7CZyWGHd91qMNCjmxfm72BuQwr0uTE9l+czV9v4UwK8a1duwqykfmbtmi7UuuGqRjohyHC/Ov9GrcTSLfS8OR8ai6/0Si+BMDJDQXek3uZTCPFOM1BN90ZcwtwxE5zd8f8PyBi8m32QItr5Rqt8OAtm2ylRHQdUjgHldQA62u9svvg3k6Pj+V+J2jeRbnGlIiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL0PR11MB3187.namprd11.prod.outlook.com (2603:10b6:208:67::19) by BL0PR11MB3505.namprd11.prod.outlook.com (2603:10b6:208:7d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12; Fri, 10 Jun 2022 07:31:39 +0000 Received: from BL0PR11MB3187.namprd11.prod.outlook.com ([fe80::914f:e4e5:adad:3551]) by BL0PR11MB3187.namprd11.prod.outlook.com ([fe80::914f:e4e5:adad:3551%6]) with mapi id 15.20.5332.013; Fri, 10 Jun 2022 07:31:39 +0000 From: "Jiang, Cheng1" To: "Xia, Chenbo" , Maxime Coquelin , "dev@dpdk.org" , "jasowang@redhat.com" , "david.marchand@redhat.com" , "Matz, Olivier" , "Ma, WenwuX" , "Zhang, Yuying" , "Singh, Aman Deep" Subject: RE: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path Thread-Topic: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path Thread-Index: AQHYezZTW5vJMGYo1UypFmW2qXY6eK1IA8HAgAA7QCA= Date: Fri, 10 Jun 2022 07:31:39 +0000 Message-ID: References: <20220608124946.102623-1-maxime.coquelin@redhat.com> <20220608124946.102623-7-maxime.coquelin@redhat.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b7ff4392-cf50-42e0-47b7-08da4ab34218 x-ms-traffictypediagnostic: BL0PR11MB3505:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cpvYa5eGSF9why26HwLJ41FGMYxnBaxEIbRFvkx0taZbqg6UEZNtbt9ZF490z2gdRiS2FMcQ1nRWKetpIi44a27ovOq0d9Vi7Vnz15riOmc469ZwUsRDImTeiEZAiMuTGg1PZ/UovBa+JOwV5SRUgf08/FKqpbFO74kKjx4jB9BOal7Y5ftKN6K9OcrJdVRCaY2/17q2BQlLZnUxKxM3RC8ImIgqhPeVLKVTDnlqo5NU79WTGOo0UUlMMv6FE+4wZcWE+D30zygG4fNd5Ya69Qq13qP3cgE62ZEuNyucdj+PfwLXf96QDvSM0fEL0UzLl+pHhCQVHK24QyHXWITc8302z9LnOy7148oaI9BjFJeehfDNbxM1D0hE9EEgk1hji1WyOsUnkRQusPtlckqmnCo3fJEu0hwXrhNdPrGcMlJ+rjpdKzVsNf7y6QUteK/7ObGPHxBZ7HlQ1ArbiVrdRZ4UjCcH3CaIjPltaORhEl/86SOJuME0bSMIQ6mw9ScoGnTMjvi+7Usfpl1QeDuPcZpGIaWfl+qaJYf0Us5Ocr8fxddVCfcmbBAzY7bbM+efHCLfQ3b+lRXOp7SfeZhH1T/EnkXAoiG4Gkta2chVVHm+K37f5pQFrB/r6Cv/XJ3Z9nqWGrRuSr32oi9XXAKCgiow2zQjGG9wpTEjYG8oQ9vJYAkOx5PgP/gjQ1yOQwI0Jmv94/TVH1dzHsR4PHXS2aeNm4yJFJ7o585OdhPlQ5c= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3187.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(64756008)(8936002)(66946007)(66476007)(66556008)(8676002)(66446008)(76116006)(83380400001)(82960400001)(316002)(921005)(33656002)(508600001)(5660300002)(52536014)(122000001)(71200400001)(6506007)(2906002)(7696005)(86362001)(53546011)(6636002)(110136005)(186003)(38100700002)(9686003)(55016003)(26005)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YNA8Z9McJJjZl9tRanbhHs2Ql++76K+2h8xC8SdrqLR5hm22Bzu/Bj1EXmYz?= =?us-ascii?Q?iEie+CXYpgTF4mbyNaY9q8L8DX76GBqrvDX+VFjCSfKPaRr9aGGYCF1WAdWN?= =?us-ascii?Q?3w21gKDyliN/7wCv6yQqBwAWjdYZIenSQhm0IO1IHEpg9jMer9UvV/HFQvuJ?= =?us-ascii?Q?1oUtcdd+5zkZNrXPTNlES18oU0AqFnXnbNmdIecQMVbG476t+6xlvnMBFE9r?= =?us-ascii?Q?pg+KWD+QW2g/GsC6hGoI3+QCLQGkwSnE/Z92a2Q3dRk5Z8Isw5XQKmsjDmmh?= =?us-ascii?Q?M1xfjL+HGqSTeTuDMWhA1SiLUgtz0bIXEup3Z9n8qbVUAgTjYreaQFi05NnQ?= =?us-ascii?Q?/XrneSQh8sUhKTilFRStFrt7xCV14M7j6EiG+rPH0WYTiwPa/MbamOZuKASj?= =?us-ascii?Q?My7+L5tWJtINPdCy6pfBn08sRjJwVn7rFrVNBHf18n+//CcPojh6n7EPu52v?= =?us-ascii?Q?Yo7AGn6wPjXOmRaELGre/5L5TXQddqx798bJhGhcfkjPl55hqKCXRdW0SSpB?= =?us-ascii?Q?zB54GbHjpFm0gVQUvIrxS5FJ13CNbgqdkeiUYk9H5qu9l2gELFuNP76pHAJj?= =?us-ascii?Q?MQGy/sYuSr0JD8dDhnebBsUeN9236YHePL1uA22BLox9QkQ56Zzc2lpJE8Ms?= =?us-ascii?Q?Czd3lc4ri3XT5QEeWkdd/+XoaHW1L4nREWPZrJ5rFxSt+nmiowUeZX0HpOkr?= =?us-ascii?Q?0TFhE5VrIfbYSwpeUPiNoieoAaA2OqLa1qozwlxk1skglsSp/2hDLOjQqypR?= =?us-ascii?Q?GNxJ2XYkavYNGcD61Sw/k40hWNXO4YRbFCf45b95O/0L8B3PL9bvf+3qlpvS?= =?us-ascii?Q?88hOjMnPpNnKgAp9L3SjHHWoO1Dx8BsX0zxDa36AcYX1x/OOgr9pGzgCwTcN?= =?us-ascii?Q?ZrFm845N3tib2Yr/k6MQze7bpCBMtSZgg/ujy5ahCgfef9WwYbScdQksaGOL?= =?us-ascii?Q?jPscVlWf9n7wt63Tj5gEOKnHaOvhBEj52JXaG1nAGE7MHp+UUdh/d06Fhex6?= =?us-ascii?Q?ZkOpgBhEZhFoLcQN9x8I6mCKHetPXtPg4uuF4qVkQffDH/pUkbqAUchYUKqy?= =?us-ascii?Q?lHA+xnY0VLRxWyw5APdQKu4fS020v0BCnJrGOnxU0jOJA2hRXpDlZV4Tof8v?= =?us-ascii?Q?PNWABT4fjGl213qYz4aOyh1aa72ahiEh9Top0ogOjNoH9Ok9/WAI67ptkc9L?= =?us-ascii?Q?/SZOvpCFb9/FbmsqZPLr5la5iN8QMhajdeOF5BlFDyw9VbfVLgAdwGkVr6s6?= =?us-ascii?Q?hmeV6RJYGmuj772lERVUJAXeJuB5mdhSP260Xox+pOxlhso9XccPqSXJEYV6?= =?us-ascii?Q?veBzrQwDg3DxEFNqoY8WJiiYUqCqLROgfuiYHz4hV7qxbMPS6iBV+wg1kudh?= =?us-ascii?Q?21li8kC4TP42SvXM6NHDyOzPR7qR4owSKeLXwKj4gWXfgwCkx8AjUEeEa8LG?= =?us-ascii?Q?3vj+PHQ/4N7Cc5VWKIBiz3PIQSBxjllGKyL/GIQO1Y05XlQMPh7Gemk3v0jh?= =?us-ascii?Q?es260BlQS98c0yLBSLT0HtOByuy9FagzbpBOuG1VmZlThBZxMcfZN0zsfwMw?= =?us-ascii?Q?vGf08y6OXXz+V6XD2EP8l5jDZIK640dB2+eZJItkQW95TL5EPBkrdoYflmdh?= =?us-ascii?Q?KHsYFDA5ApwgSUIy0Bm3zzGPT+njcJb5vmX4fm/4wvZLgcQp3V0EHA1J8yge?= =?us-ascii?Q?YTMXGSJVaXUj1LrzINWTZKoI1kzIfkBBmHSSPlKAo8G1fbReBzGo/xNOKMrI?= =?us-ascii?Q?XEgs41fWAw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3187.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7ff4392-cf50-42e0-47b7-08da4ab34218 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2022 07:31:39.4522 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: suzOQiJMEzvL8dWR1GjTjDLBTk9GmC1Np9wrhC3Ox+WpD+6UTchTqXzg3DoUFe1rDD7nt23cJFnyaDmRhoKIWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3505 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Maxime, > -----Original Message----- > From: Xia, Chenbo > Sent: Friday, June 10, 2022 11:50 AM > To: Maxime Coquelin ; dev@dpdk.org; > jasowang@redhat.com; david.marchand@redhat.com; Matz, Olivier > ; Ma, WenwuX ; Zhang, > Yuying ; Singh, Aman Deep > > Subject: RE: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path >=20 > +Cheng for review >=20 > > -----Original Message----- > > From: Maxime Coquelin > > Sent: Wednesday, June 8, 2022 8:50 PM > > To: dev@dpdk.org; jasowang@redhat.com; Xia, Chenbo > > ; david.marchand@redhat.com; Matz, Olivier > > ; Ma, WenwuX ; > Zhang, > > Yuying ; Singh, Aman Deep > > > > Cc: Maxime Coquelin > > Subject: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path > > > > Virtio specification supports guest checksum offloading for L4, which > > is enabled with VIRTIO_NET_F_GUEST_CSUM feature negotiation. > However, > > the Vhost PMD does not advertise Tx checksum offload capabilities. > > > > Advertising these offload capabilities at the ethdev level is not > > enough, because we could still end-up with the application enabling > > these offloads while the guest not negotiating it. > > > > This patch advertises the Tx checksum offload capabilities, and > > introduces a compatibility layer to cover the case > > VIRTIO_NET_F_GUEST_CSUM has not been negotiated but the application > > does configure the Tx checksum offloads. This function performs the L4 > > Tx checksum in SW for UDP and TCP. > > Compared to Rx SW checksum, the Tx SW checksum function needs to > > compute the pseudo-header checksum, as we cannot know whether it was > > done before. > > > > This patch does not advertise SCTP checksum offloading capability for > > now, but it could be handled later if the need arises. > > > > Reported-by: Jason Wang > > Signed-off-by: Maxime Coquelin > > --- Reviewed-by: Cheng Jiang