DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v2 0/6] Vhost checksum offload improvements
@ 2022-06-08 12:49 Maxime Coquelin
  2022-06-08 12:49 ` [PATCH v2 1/6] Revert "app/testpmd: modify mac in csum forwarding" Maxime Coquelin
                   ` (6 more replies)
  0 siblings, 7 replies; 17+ messages in thread
From: Maxime Coquelin @ 2022-06-08 12:49 UTC (permalink / raw)
  To: dev, jasowang, chenbo.xia, david.marchand, olivier.matz,
	wenwux.ma, yuying.zhang, aman.deep.singh
  Cc: Maxime Coquelin

This series aims at improving Vhost checksum offloading
support.

The first patch reverts overwritting MAC address in
testpmd CSUM forward mode. This is required to be able to
test checksum offloading with real traffic. MAC forwarding
mode should be used if the MAC addresses need to be
changed.

Second patch is a Vhost library fix to be compliant with
the Virtio specification, which requires that the
pseudo-header checksum is being set by the device when
offloading the checksum to the guest.

Third patch enables the compliant offloading mode of Vhost
library in Vhost PMD by default, since the legacy mode
violates the mbuf API by setting Tx flags in the receive
path. A new devarg is introduced for application willing
to use the legacy mode.

Fourth patch is just a small cleanup to represent a boolean
value as a boolean.

The two last patches introduces compatibility layers
that performs checksum in SW when the ethdev and Virtio
features are not aligned.

Note that the two last patches are not tagged as fixes
because they rely on the new compliant offload mode of
Vhost library, and so would casue an ABI breakage if
backported.

With this series, it is now possible to perform IO
forwarding between a vhost-user port and a Vitio-user
with kernel backend port even if the guest has negotiated
VIRTIO_NET_F_CSUM.

With csum forward mode, it now works whathever the
offloading configuration set either on Virtio or Ethdev
sides.

Changes in v2:
==============
- Add the new devarg to validation array (Wenwu)
- Fix typos in commit messages (Chenbo, checkpatch, Yuying)

Maxime Coquelin (6):
  Revert "app/testpmd: modify mac in csum forwarding"
  vhost: fix missing enqueue pseudo-header calculation
  net/vhost: enable compliant offloading mode
  net/vhost: make VLAN stripping flag a boolean
  net/vhost: perform SW checksum in Rx path
  net/vhost: perform SW checksum in Tx path

 app/test-pmd/csumonly.c            |   4 -
 doc/guides/nics/features/vhost.ini |   1 +
 doc/guides/nics/vhost.rst          |   6 ++
 drivers/net/vhost/rte_eth_vhost.c  | 167 ++++++++++++++++++++++++++++-
 lib/vhost/virtio_net.c             |  10 ++
 5 files changed, 180 insertions(+), 8 deletions(-)

-- 
2.35.3


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2022-06-17 14:06 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-08 12:49 [PATCH v2 0/6] Vhost checksum offload improvements Maxime Coquelin
2022-06-08 12:49 ` [PATCH v2 1/6] Revert "app/testpmd: modify mac in csum forwarding" Maxime Coquelin
2022-06-13 12:24   ` Singh, Aman Deep
2022-06-17 12:42     ` Maxime Coquelin
2022-06-08 12:49 ` [PATCH v2 2/6] vhost: fix missing enqueue pseudo-header calculation Maxime Coquelin
2022-06-08 12:49 ` [PATCH v2 3/6] net/vhost: enable compliant offloading mode Maxime Coquelin
2022-06-08 12:49 ` [PATCH v2 4/6] net/vhost: make VLAN stripping flag a boolean Maxime Coquelin
2022-06-08 12:49 ` [PATCH v2 5/6] net/vhost: perform SW checksum in Rx path Maxime Coquelin
2022-06-09  1:59   ` Xia, Chenbo
2022-06-10  3:49   ` Xia, Chenbo
2022-06-10  7:19     ` Jiang, Cheng1
2022-06-08 12:49 ` [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path Maxime Coquelin
2022-06-09  2:26   ` Xia, Chenbo
2022-06-10  3:49   ` Xia, Chenbo
2022-06-10  7:31     ` Jiang, Cheng1
2022-06-10  3:50   ` Xia, Chenbo
2022-06-17 14:06 ` [PATCH v2 0/6] Vhost checksum offload improvements Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).