From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 325AAA00BE; Thu, 10 Feb 2022 15:17:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C987D426EE; Thu, 10 Feb 2022 15:17:19 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id CEEB84013F for ; Thu, 10 Feb 2022 15:17:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644502638; x=1676038638; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=o2LF+/+LXasJ5Pz4dzXeVgqnXpyFcJ5w8ZKERfx57Y4=; b=OUYq4BJ77O3Qsf7gDIdDtKFvRi55sCeQdRf6uRZ3wpLKbI3+arFrrtLp yM7AnUSQhtNheowAlJ/+pCOI44x0q70sJ/ijzuJpxnUrOb383L6CfKAX/ Ot/4Qzw8fE8zljugMEdloYs5vs9Zf6xITFA6LAeodm+MX8wE8N4ZrpMT+ ef1hw9Jn5qolkJfhnABX1YXhNnw+SmhujBbN2Gd1KOxfYsIF2SnP08Yj3 gdKqYVIN9iHnyh0gGHwC797oWKYlEzqzip/RYsiRXe9fWgaHRPDvAaJQh 1f2y8idIvQ/k9bsIO5RpYzpqs7pOugrtHPBBFY9VakjIIEE/FWYGjtAXS w==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="229466118" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="229466118" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 06:17:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="537318718" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 10 Feb 2022 06:17:16 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 06:17:15 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 06:17:15 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 06:17:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GaVWSXzH4790pgtd+M3OGs9Rfb6CZZ9yXdhaUD4d8F/NJ3Y0NlfXq0ZUFNxMimxiptaOc0lVz5V2DfFyNgzQ9HLeDeiyodhbNUnUvWfsn4PfVnPcum3RB2xyJ9IXBqTokvmsd47cHgaHOYy7NGc8rU26K5ovv87VocQB7R4R3/LJmnMAW8oTR+NR03A8wNXobWMe+wiJ3/0KSaJcFQM7pdkOC2wvBJ24neM4Qny+8RkwPI7RhxidnGZdQr1lxfUodg7YcuMyTEjIY/CPcQ5SStkb+qbT4m6IsqPMHDOVc2bJTAcHSsUDMdzu3GPeCzUGFx59WHGf6k9kg5+peS5v9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GkBGYEZVtQrICQL5lEznzLgsboiGXi4aG+V0DopGxGc=; b=B/V5+wWP2LrcXb/MB6+1K5laLoEPwLfy7zuex0QSSwvf/FSsbMRR21VMW8Oh8V57S/c48t0apFemv5nsW4MlwCUkd40eJ2D6G0ug1lcEtkjo9Who0Kxscy/bnNIXSynEGmd8vv7a+Z5dGlt0DsMM7SWroAnU0WdOvKB/YpwCH1CHyH2WaxrHypJpUglgFEHG1nSP9MYb4og8B53/fDUWrKhxtrDC93lv7K26Bga2x4NCOy2yQgFesr7Cioo1D+vsCfGKNSvfCH5xO7m4UrnCB95QZFjR0k4KgTeFs0LXl/ufkv0HevtWJb9+X0pB8ZHC1DuAQvtLa9Zlnz70wtxtMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BL0PR11MB3250.namprd11.prod.outlook.com (2603:10b6:208:63::13) by BL1PR11MB5399.namprd11.prod.outlook.com (2603:10b6:208:318::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 14:17:13 +0000 Received: from BL0PR11MB3250.namprd11.prod.outlook.com ([fe80::d8b1:1ba8:b2d6:a877]) by BL0PR11MB3250.namprd11.prod.outlook.com ([fe80::d8b1:1ba8:b2d6:a877%5]) with mapi id 15.20.4975.015; Thu, 10 Feb 2022 14:17:13 +0000 From: "Xu, Ting" To: Ghalem Boudour , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , Thibaut Collet , Olivier Matz Subject: RE: [PATCH v2] net/iavf: initialize large VF setting at startup Thread-Topic: [PATCH v2] net/iavf: initialize large VF setting at startup Thread-Index: AQHYHmwXjes/TQ384UCZMugw6ovVaqyM1CHw Date: Thu, 10 Feb 2022 14:17:13 +0000 Message-ID: References: <20220203090359.29270-1-ghalem.boudour@6wind.com> <20220210104914.5444-1-ghalem.boudour@6wind.com> In-Reply-To: <20220210104914.5444-1-ghalem.boudour@6wind.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a0c89d83-3813-48e6-557d-08d9eca008dd x-ms-traffictypediagnostic: BL1PR11MB5399:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 670fWOJkP/mouXq7KE79pT1IXE2sSsn7mcInxbk5ZmaoJsw8YcpaJ06s7GUAD3sWOnZrsSBhAfwmp9qTyam7JkJmML8LVZpwygpO6vUd83+a2BHAnrzxkqP3h/0NfhINdFAMgl5EMil7IMtMQKzZHy64yXV5TinN1lSG17epwgJuqax3+L1oRYqhgViKBfiuR/GY98OvFE9CifmTjE73GwsyBwOQw2+zagKIX6gWR5DCrLm+VlKD398cIUPeWgIPKESKiqYT0/ysyfSizIZwfBcuBCPmPuj9mzd//jjLLrLDv+KsKGuH0NH2HL7lAcwkKS6bVorNs2YmU8EInZ0Dj5wFemAizWVUIMhUQSn/dR5DMc7ZITfZwAgEbRn7dFhEn0NNmTYGnFCMPxlHKe3cLk4NHGgClYOoHdHynMLbLUJiB5u9TPeQRXOV1zFC2XLVs/r2MX83VetPK2SJz4XHaxnThRhMkTnYegtLy36UwIbwuFOj1K1pvJ30AKI8mfrO8sfA37ic8GvJ94zZafVPu/IVsHLRbRiaDV3NYMKAqIpCHHyxDzxCjBypYoiiV3w2H6JcX60MY2kRD5MPQ6YB2KMORSAV9sy8KhNGmygmfQMVGYc4193+v5H6C6p9p8ACbB893WcmWueMNiGOtkwcr981iXSSq4HtX8c+iVT7KAwuIR8UbVgotsDPjDgIocBXU3ph4+OiRLVdbUWooU7KxQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3250.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(5660300002)(76116006)(33656002)(66946007)(8676002)(64756008)(66446008)(66476007)(66556008)(4326008)(8936002)(55016003)(38070700005)(71200400001)(52536014)(54906003)(2906002)(316002)(110136005)(7696005)(38100700002)(26005)(53546011)(86362001)(9686003)(82960400001)(6506007)(6636002)(122000001)(186003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5l4UcvIAA1UmP6d2npXOfAtwNp6qkoSCs6cgtLzxq4RtPHgBAiHribWxfhHQ?= =?us-ascii?Q?BlG719qVajyw/bUkeIxM0DUDgcCKpy7f+1cR4ql+Lx/+eWaTxQ8j2YHuvl3R?= =?us-ascii?Q?0bSx8ZLFSIhNhThX+alqwuvFU+vfrEXeXujCMvU4q4506nzzTdY8+7UGowIX?= =?us-ascii?Q?AzvRUI2udtrRMZCsyaI29INqS+iSV8oTBRSCJ/LbEMraw1Xo8pi2nOfBQ8g7?= =?us-ascii?Q?M3UZfqArZLjILUsF73wz6zJiKedZEA4A1sbbnGuXjfktb4E5b46h3q0i3jDI?= =?us-ascii?Q?AJHH80DQDyNLJuIW5Itr/APUwdehsyUNkUx43wuqfTkDzrcENOpVOj0AexO/?= =?us-ascii?Q?xbzhwHSkXBxFdUJvt0cDbSCFf1FVVNptnrTlKz4MFfntRx6SCd8xWO0D/qYk?= =?us-ascii?Q?FDVPlddyLrBkBTzZJZXuB4ssGiyfVEm2VPUObaxvmk23yf8GHwAwHwCO2D5c?= =?us-ascii?Q?YMiOA/9ms8eX7kMsKka+W/ViNRMdnJIwNd814n6LA7KQgm5p13WGYzJuUBTZ?= =?us-ascii?Q?b+ML4msl66znW6EVbuE8ZVFHZTLjpo8DApI6HV6L1PwvmHLWjEW1mixNnpyN?= =?us-ascii?Q?RZKTW7EHmqmy70KzwiYdUqDjJifaxHXcxbzzOlmszTdeG+OicCXHrpF3uDzL?= =?us-ascii?Q?u2kTWVXSjrTODfqCG28PAqdk1Taj1BiV5PgJ5y+BNlJMM+kXlxSrIBCpyayH?= =?us-ascii?Q?FK6Lc8VInyZ2IC0ptecSXv+RqiAZkjBnT747rDlvHbipR2DkHuGTPq/cIa/j?= =?us-ascii?Q?OCu+l+1sBS3sx3gyixHocgetL+jAfos+mtTyFXMqGCax0D3FPA3tGsAgaXOJ?= =?us-ascii?Q?+g9e1pXdxBtBIPtY2LRYmhdKa6Yc4gsjpM3537so4Xv9q+PUorrP/uDfxKmC?= =?us-ascii?Q?IX825+APPgocMS51CsIywfJfn/3Gk03lC95CbTBbmrtVdqMt/UXfI+SADAJE?= =?us-ascii?Q?2wp3WixejIjsPJBDdFcZd2OPDhCwKOAsIOI/08xuUe2HPzCJwUNFLIp5wFPb?= =?us-ascii?Q?4UY4oR5W0Eqyj95D7F8tys0ivgtlFj0ZrWmz6Rm4KJwiqGrGGFCNCX4wD1cF?= =?us-ascii?Q?8JXQeahEiiYktDMoQ4x3fswtHwoobglTbt9nH6hCJ6G4neKx1jirFWRefyRN?= =?us-ascii?Q?WIfsW60jrRHQ1or/AIZ1Cmu2a2QH5nO5ttGznEbPCYJIACuOD0/xwlT7nbce?= =?us-ascii?Q?FV7oIKbUuffUz03v7uerWmpb57olyflsRVRJQ2f6ndmSwigeqq0LQAy3jJha?= =?us-ascii?Q?t+RI5NMRv3QdzhUqOiVI+T+VmzC40tO70dePAuaXn089GplAoScfeMbKsVZ6?= =?us-ascii?Q?28aQ8jMsxKvLu88NxNgrCknN0XXdDyI1E1nldijVcrIpgUt4gkq8zimdGvNC?= =?us-ascii?Q?6Jr3nwyu7GcYkp2Gk731gOAMRaLGjQZRYKRyusoTXoDMljiQGfSSWOiydEBY?= =?us-ascii?Q?lyF2vahZTC3/ZqNRmEYiQL5h31bnLkIHt/lqu5igF6JLxpYwwn3LnRiN7cBU?= =?us-ascii?Q?K9DHAYEmQkG80Q3Vw/mWqpeqH7Fcz5KrKiYZoKIZaCbzfVnRLLVJd3P+Bnim?= =?us-ascii?Q?eyvTz8vpPCY/h++wFAcQdHGWPHH+hiAvwhGCDOOnopUhTlCvoYXvnDm0+qyr?= =?us-ascii?Q?Nw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3250.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0c89d83-3813-48e6-557d-08d9eca008dd X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 14:17:13.6343 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0e9cEycBDYvrtvbOtHGNkBhVPcPFOJFpJRBTb4FVVfv/RVBCACye8gRMklK9sEBCcxRlbj/Bs2Ae9xNL/zKvgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5399 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ghalem Boudour > Sent: Thursday, February 10, 2022 6:49 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Xu, Ting ; Ghalem Boudour > ; Thibaut Collet ; > Olivier Matz > Subject: [PATCH v2] net/iavf: initialize large VF setting at startup >=20 > lv_enabled is used to remember if large VF setting is configured, but its= value > is not initialized at startup. This can lead to a different configuration > regarding the initial configuration of the PF. > For example, a first start is done with 8 rx and 8 tx queues. Large VF is= not > needed and reta size is 64. > A second start is done with 20 rx and tx queues. Large VF is required and= reta > size is 256. > A third start is done with 2 rx and tx queues. Large VF is not needed but= reta > size is 256 as the PF has been configured during the second start. >=20 > In order to have a consistent behavior regarding reta size whatever the > configuration of the PF (may be changed by a previous boot) the lv_enable= d > must be set properly at the init phase. >=20 > Signed-off-by: Ghalem Boudour > Signed-off-by: Thibaut Collet > Reviewed-by: Olivier Matz > --- > v2: > * Enable large VF at initialization independently of rss configuration > --- > drivers/net/iavf/iavf_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index 79397f15e54f..d6190ac24ac6 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -2278,6 +2278,9 @@ iavf_init_vf(struct rte_eth_dev *dev) > } > } >=20 > + if (vf->vsi_res->num_queue_pairs > IAVF_MAX_NUM_QUEUES_DFLT) > + vf->lv_enabled =3D true; > + > if (vf->vf_res->vf_cap_flags & > VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC) { > if (iavf_get_supported_rxdid(adapter) !=3D 0) { > PMD_INIT_LOG(ERR, "failed to do get supported > rxdid"); > -- > 2.30.2 Acked-by: Ting Xu