From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57382A034E; Wed, 9 Feb 2022 03:42:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E56EA410F3; Wed, 9 Feb 2022 03:42:21 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id F22104067E for ; Wed, 9 Feb 2022 03:42:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644374540; x=1675910540; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lUmlDhPhSYqJSAD4s0Bw301E9Dti8wfPbnVsdeIEU/s=; b=Kv+HKcJF63Zbd8Xy2wu6lJt9lq41CUrpl77rxT5p5OJm3c/NA7kP9rtV 64uyIEq8qbEzqL/9GyFWGYwRsvh+U2hDFI9/8tItWqEr1nWWVNefGnhBk 8VMFu8XBYYviSQitD+IQM8QEYqB2fsz3xXassOCxNx6V/I6jmdY6tThmB wWTqRvvaX73b3OkZEhJwa3ZJ24O+KcssS1T6VVnVGtcdTYL4dd7AwbRZQ waBji7CuSc+fBSyHfzTiScpGLo11a0jV7qZe8yRje0fJLCxSfg0KE5LQR kOAdqq/qrhZ7cMQ2/bM7pHZ7A9DcGhPyUsYqS9Z73jZUbCMvUZc68R8/z A==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="273638653" X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="273638653" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 18:42:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="622115815" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by FMSMGA003.fm.intel.com with ESMTP; 08 Feb 2022 18:42:18 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 18:42:18 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 18:42:18 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 18:42:18 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 18:42:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ElPFrKI9VpRrg3zB5u5/wVCiflTL8eEZTLbVPsdBHEw4zua4q8TMsdvQiMO3Czd1J+th7PLBZmNAtBoLURhztLtTAlQMQF4zyu3FgPrnsrulJO7ZgZH13sc0twWHrvtuNI9ZniFPn0HviWuqnD0zuZ5BlfdAq2yxzPHX/Ce4duL0Ij3CpHtvwzxWiZsnfPqhLxptZ9rhRct4Nao5QpNUF8ADO7xKPH1UNQa8O4oRKxbIzIHLRivJTFj0MvKwJOLaymd+Qwo+HTR9bd6pyFCaF3SUnuuu2W0c1+orZWbXD+Edt//jpa9xWjHvLgbXaKjsa/K9whzNa1FkBCDyiL6KAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NCao39oCfvlrqkAUDbQekWLh0guYFeXctZZcDxdhL3U=; b=K6drox7gGkZi3FpqikoNXWflFv6McHRDpgJSzA8P7LgIJvQCEgWr1FtDcEpfOKAKsQUY5z3jlAUiy9jIm9NrlUktYevDQqANTVCU0DcDRrqbyPeVWLXlZA2XPnvwtmpUp4jxZnzQJWkf6ng2lawMnZxOyA/TROrJ9s6B0Qqb6ojQrgIjoLdQ9cfx+7R/uNY2/SVmQob89kyitIVeAbwcSC9yLGsFt1LWkJBytkLqDfXAn1yZYQg8Ne4uh+cXOsdEVLk1/qaHFmxSl3GFiMwpSlYtkXZBxpofJP3qtrWXohzKa8kcosNUKHjnh/cK2jddsp1IoTORDe22IhLbYgq9dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BL0PR11MB3250.namprd11.prod.outlook.com (2603:10b6:208:63::13) by SN6PR11MB3392.namprd11.prod.outlook.com (2603:10b6:805:c5::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Wed, 9 Feb 2022 02:42:11 +0000 Received: from BL0PR11MB3250.namprd11.prod.outlook.com ([fe80::d8b1:1ba8:b2d6:a877]) by BL0PR11MB3250.namprd11.prod.outlook.com ([fe80::d8b1:1ba8:b2d6:a877%5]) with mapi id 15.20.4951.019; Wed, 9 Feb 2022 02:42:11 +0000 From: "Xu, Ting" To: Ghalem Boudour , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , Thibaut Collet , Olivier Matz Subject: RE: [PATCH] net/iavf: initialize large VF setting at startup Thread-Topic: [PATCH] net/iavf: initialize large VF setting at startup Thread-Index: AQHYGN3pPIhi67qxKUeTzwvFVRvRfayKivVg Date: Wed, 9 Feb 2022 02:42:11 +0000 Message-ID: References: <20220203090359.29270-1-ghalem.boudour@6wind.com> In-Reply-To: <20220203090359.29270-1-ghalem.boudour@6wind.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c3bbc283-57bc-4243-9eb8-08d9eb75c610 x-ms-traffictypediagnostic: SN6PR11MB3392:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Xw+qK4C4xz51gsUEReWlp+kNpOa79Ne/Z731WOTaE9PEZusoHe+KTd6yxeRC96HP8vklMWsSAGrmLgWVbTrgXGkA9tLaxHMgu2eGKSF6VqOLIuKAgYLnaoaXQmL92GvRiFWw5uzXAgT4izsqS1WjU8MvpF6XyGF3JN+O5fMUzo7WtU9xGMEM5z12XEUCkkGpdC2UlDalZvcucYwE7l++DO4r0hrBRgJy/Se4KjQ2gdgYTv/kjlQX8psYt0MqnjE4evekmJJDkoH6zafN3jXJsv4/vnA+yVT4rJCdobPpxSymsG9lsU4tQ39o/UzVzZkWszyAygCCYadgWxFNXJ0AmmKNvwD0oBi6o5qQpHOm7yWtkroKuscb+ZBcFEmudLN1MMtgxP3eKr01bmRhjWN1m2NEbijTuu649nX8PhBFE7r4JwABJq5yWwSfIa2Rn3BcTNdhcS7oaA6/gUWn9EvaWMEn2BEHTn5OTdQC6orkxO7NBqAFwsqw8XBn+6S7Gj0KbSzYcjvMDUz3o7RlntRi8DNWZ2nTi/2lMmJE7yq1NkPSsAqR8QgvKzrIQZeNwkvmIIQw4uZLVW4fJnEADPSAIVyyv3tjfjabVj/6zvNjtmQE3C2naV65pZ+KmBSf6vdZ8P5CqGt2e1LROiF+PmeBW/bh19TM2Tou2efXZxK4KQ5/ykmhFHsykmxZ4+GCnKDNxaXzHoD0vZ2UiWeXGtr36Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3250.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(8936002)(54906003)(8676002)(508600001)(2906002)(71200400001)(6636002)(9686003)(66946007)(76116006)(64756008)(26005)(66556008)(186003)(66446008)(38100700002)(122000001)(316002)(82960400001)(52536014)(55016003)(33656002)(53546011)(6506007)(110136005)(5660300002)(38070700005)(7696005)(83380400001)(4326008)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?chB0jzXTiy81iKuFQoCveH9CBKo6NGGMcc3tbBy0oK2FuUr4EcrL/pf9/N+j?= =?us-ascii?Q?7hetDyBPdzajbMpzLlKebtxEF3lkuRkhGiFTuciBGqOH4VMrdZ5jameHn8B8?= =?us-ascii?Q?O/sPStVophyrMLqcDj5h0TVPMGn7D7vEgV1G3WX2qYgjE2FJb5d1+zp0h9o8?= =?us-ascii?Q?IAUmyycZ1/KFJKjb/QMnPhEz/Gn+o6ubH05uMCzuHlXpmJq9lJSp1soWunSB?= =?us-ascii?Q?QDUNhdWuU3iU5M9RrLRE7Z1IJC/elbABD9FLmePc/c+GGeA1ivj3P6eEzxjI?= =?us-ascii?Q?Fwlppd67+Ol8Z8phfVHEOgtLcLqQsXPyoQxMf5oRHjYQc1UPqQ5J8vQCXJpc?= =?us-ascii?Q?XSizB00XZX2PkNqBFon56vtR5OSGzaw16Jn/hDsxS56vuoA4aAE6C+QDHxCk?= =?us-ascii?Q?X+hlotKDCStMArso8gfwpN034cApXqrkApj4FdFAtNpcJz3NUn4lNCswA8Xg?= =?us-ascii?Q?MnNe7Yp9vRkGQ72P0Tlm5EFrG67x3e3ReW7DVfzQiV89orjY9a60Aw+pZc5Y?= =?us-ascii?Q?i87NTThh3Z+zolqXobFlb1Fq6XXYPQr6afXH1v47JotJnWCJc5P/zo8l4Pg9?= =?us-ascii?Q?FbYUxYiIhuizBedPgROm+ISGMhdUTZYKOeapH8wtRn+mN8RM3w0P025yC2Z+?= =?us-ascii?Q?LV3MmP/un0aDoMZeBtmuopb1IaDld9mTSvxaw99RoIDHJwjmLGy3IW1aLryA?= =?us-ascii?Q?0Js5cUf4LuWsu3bmTekTEZ3/YGCVL/gt2ZasQbE0u0TbxUAHNWhqDDg08Rsc?= =?us-ascii?Q?Os12RjWGbctwcTCQLU04dwvdlhzjqCb9n8zZzmQLGUkZLNjwK/n1sMLR6+LU?= =?us-ascii?Q?+WlgOyyfEhTyeQ3eUpaTRXBoJGlX5Ky2NNSwpkypb5etawWfKiVz5Hs1F3XQ?= =?us-ascii?Q?LGUq8u4Qo0GKLENiNNmtD0wfgsehu+Nehm0WbK2wMmNzI91Sx9SpP3+hsFCV?= =?us-ascii?Q?7pJQAcJ6x1fd69JMs9zPgz2y1kbHlTMmISow5JJuT5kAGYEl2gFtlaHSU6fz?= =?us-ascii?Q?iUOCNkehhY/Byxl6koLpVYZU6bIDE+H2ouLHJlanuUQyblyEVsC3ER+NDWqW?= =?us-ascii?Q?NILZS9cb6RjDrWo2xI5a9+Wj6WV91CA5zz0nT5ddVw59QrQ0S/ZvjsfoC0tT?= =?us-ascii?Q?fl0tazD+yGD3MekFJuAGPvGEAiqO2flkEkupFK+vG68BTHkkqR1CNMd6w63M?= =?us-ascii?Q?eC0wlNw1L/mT/5oBoZDDrcfx3PSiVsQFakC5s3gpRh8S6REE5zMGqgMQ8O3q?= =?us-ascii?Q?nZn9XlX79b5NTfnGbQgbckgmvP85YmGRtQOh+9zXWpc6i5RA1I3xfeHwXnaQ?= =?us-ascii?Q?BKSQXRpV/4R5j+n7z+NscCA4aYss+1q2e0tRQl64TQqGqol+v8exFMZS11dK?= =?us-ascii?Q?uKEVL4VipFM1XeaZLsXP/IXA2jftV4lDBwkBD3CmuhM8FnblcsYxXZ++UbK7?= =?us-ascii?Q?YkvZ9oce4yqv4gnY+Nq+iPwyDbL22Hk1y0APzpDyLeDThmMthFSSRQu19Ay0?= =?us-ascii?Q?dzoZ7JiWVptV9o2UJqBk4N2iOWQf4dAaSrnZEcMtajArS+IXnsnOswJymMHo?= =?us-ascii?Q?DEQTX9ffmsWCZOcUO8bmtb98gVB5SigsGBE9M5dUNvmn4kohJQTKSPw3yFDM?= =?us-ascii?Q?tQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3250.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3bbc283-57bc-4243-9eb8-08d9eb75c610 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 02:42:11.5689 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y/DDZYvadSAHOKKVk496jxQKLRMBUES7decFHAwV56KhEncBgG1nNmPuxNmVp3n7dJLiXzAgfTbjkrGVP900fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3392 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ghalem Boudour > Sent: Thursday, February 3, 2022 5:04 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Ghalem Boudour ; > Thibaut Collet ; Olivier Matz > > Subject: [PATCH] net/iavf: initialize large VF setting at startup >=20 > lv_enabled is used to remember if large VF setting is configured, but its= value > is not initialized at startup. This can lead to a different configuration > regarding the initial configuration of the PF. > For example, a first start is done with 8 rx and 8 tx queues. Large VF is= not > needed and reta size is 64. > A second start is done with 20 rx and tx queues. Large VF is required and= reta > size is 256. > A third start is done with 2 rx and tx queues. Large VF is not needed but= reta > size is 256 as the PF has been configured during the second start. >=20 > In order to have a consistent behavior regarding reta size whatever the > configuration of the PF (may be changed by a previous boot) the lv_enable= d > must be set properly at the init phase. >=20 > Signed-off-by: Ghalem Boudour > Signed-off-by: Thibaut Collet > Reviewed-by: Olivier Matz > --- > drivers/net/iavf/iavf_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index 79397f15e54f..09410be4b712 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -2276,6 +2276,8 @@ iavf_init_vf(struct rte_eth_dev *dev) > PMD_INIT_LOG(ERR, "unable to allocate rss_lut > memory"); > goto err_rss; > } > + if (vf->vsi_res->num_queue_pairs > > IAVF_MAX_NUM_QUEUES_DFLT) > + vf->lv_enabled =3D true; Why you put this operation in the part of " VIRTCHNL_VF_OFFLOAD_RSS_PF"? > } >=20 > if (vf->vf_res->vf_cap_flags & > VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC) { > -- > 2.30.2