From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DCACA0523; Thu, 2 Jul 2020 03:15:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B9C41C2AC; Thu, 2 Jul 2020 03:15:05 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 7A7711D596 for ; Thu, 2 Jul 2020 03:15:03 +0200 (CEST) IronPort-SDR: Sf/6zhX/NpgI0CAUiDmJe+hVivSC7RSswuIhrvQaLnFJjrhHRIu/ghi4SygKxFbYg0eUPNXenT UZhjrAD9Gd3Q== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="164805305" X-IronPort-AV: E=Sophos;i="5.75,302,1589266800"; d="scan'208";a="164805305" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 18:15:01 -0700 IronPort-SDR: Gj3FzFTrVualUsEEXo3nzhDel9YErVNZvcnP6c6OQdgr44ud+M9ENXutCgTpy2uRqhyiIuk92m ec2Em+Bp8C1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,302,1589266800"; d="scan'208";a="481519871" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga006.fm.intel.com with ESMTP; 01 Jul 2020 18:15:01 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 18:15:01 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 1 Jul 2020 18:15:00 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 1 Jul 2020 18:15:00 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 18:15:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VkROkJHCESfQzGJbCHbSrwry0a7Qc/251oFn+TSWFXBQzFOg1bgQN/w9qpI6UacpOK0S/+YsspA5beUZ5Jos4X4vtXj8+rQ0eIIMVxLvqO54+rQrX0Gjv4U+//zlWDFN0z/YIke9amf7yvIPsz82cnkg+SM8LLAJwOkfohhsAYHWkdq3S4ziFTzaUMfO8MCEtQsH03anDoA+oCt1pMQPk6tI7YFADLmzHC2nvac1J+opX04gtWJZHseuGXCyKKrLB2lP8/oUxwuWbB86hkMLs8bezbZyOAupSa9JKQ3PYqke61cfIVYyUS4M7R/VoDqqt1We8EGyMBJ5KV77AqZS7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJCbvbEjkKbA2X1YtOVd0EbHjcIYgOEi9kZ6q9ID9XE=; b=RnMISNV1fiBDcC+njJA+oRBoSNo94RR/mi7f0Bm+xjAnU3XzrOcZxuYDiv6cVvGnHOB5oSi8ChfgFgdTWJiv3lGiR9fFa7fPzY8AKvDSRLffm8UXibvtKbSPMG1EHN4xP5RcqY54fg0MWf4zfvIpKawTQbSolpc/w4xFnmy1JylncJTezu/AJGHKDa2E5Rnp8+MczfN2FZsOkEirXtwFQ4qlQ80kxaJIdYjcdu0pc6wQOkWyF3W5S/yTJRo9qWpba5LV4UGCnGa6q0wdSWjDJlTvmRIb30Z9je0iY87uFe4erj3I7zMdA/+NX7d7LUDXcXIpiYQKlwhFlq0oAwPAPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJCbvbEjkKbA2X1YtOVd0EbHjcIYgOEi9kZ6q9ID9XE=; b=dENGlKWG/alcbPmBL9zUNhsqd5BN+zSgtQMgyed5Cuv1MxvHOXMwk+s4fA0ULu3NeRkFqxP1FqhnE/89/dDqjSaCFLnhL/pMTZdI/F5n6Pczb7lBghGhKfhDq1/UhjGBQwQuvDThc9hqnIS+OcfoGJ5/Qf4Q1aB2v7IKVBHncpA= Received: from BL0PR11MB3380.namprd11.prod.outlook.com (2603:10b6:208:69::12) by MN2PR11MB4431.namprd11.prod.outlook.com (2603:10b6:208:18c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23; Thu, 2 Jul 2020 01:14:57 +0000 Received: from BL0PR11MB3380.namprd11.prod.outlook.com ([fe80::71fd:6797:4389:da64]) by BL0PR11MB3380.namprd11.prod.outlook.com ([fe80::71fd:6797:4389:da64%2]) with mapi id 15.20.3153.024; Thu, 2 Jul 2020 01:14:57 +0000 From: "Su, Simei" To: "Zhang, Qi Z" , "Ye, Xiaolong" , "Xing, Beilei" CC: "dev@dpdk.org" , "Guo, Jia" , "Guo, Junfeng" Thread-Topic: [PATCH 1/3] ethdev: add new RSS offload types Thread-Index: AQHWQGCV7DSEYltURU2TehWRMM0ydajy1jiAgADEdfA= Date: Thu, 2 Jul 2020 01:14:57 +0000 Message-ID: References: <1591928407-314618-1-git-send-email-simei.su@intel.com> <1591928407-314618-2-git-send-email-simei.su@intel.com> <039ED4275CED7440929022BC67E7061154849DE3@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061154849DE3@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.222] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 05f19007-2137-45b6-c93d-08d81e2555d9 x-ms-traffictypediagnostic: MN2PR11MB4431: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SG6lWgSk4ePL5xCe+fOm1gt3PprCycmMRg4eQAmoEfXZ8+SE5eb14lHMMxUvSMceBRFok0Q3ymc+qKzSl5PSa40Rk469PeIQ4ovIcPEYcAHSydBZgEgmSaZSHoJYbhVTvI6MahNxXJCLiKq6qJWCXyhlt3nhOaM6GRPWQGQZZbhOcqSoXhilvNFfvXUKlJwnHB58oO7fqzDyVVhflqfPQ3gsZiCV7RdNN784qklVkd9qpm2N5CEp1p75ouRML1eKV0S0iYp2P2qgY6B9vkYGsxCjy/0X8J1MzNZKq56Js9aGXir6jj0ZNFrv+6x3UZjCgZw4VWQQLJCXWgMNLo0tPw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3380.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(66946007)(6636002)(110136005)(54906003)(2906002)(498600001)(83380400001)(52536014)(5660300002)(8936002)(33656002)(9686003)(55016002)(107886003)(7696005)(186003)(71200400001)(8676002)(76116006)(6506007)(53546011)(26005)(86362001)(4326008)(66476007)(66446008)(64756008)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 8fCgybQrsff3P1nB4QNG7sFxi2WlYcmPsis2bYwYzSJ9qhQoY34DAq4etBc5nRh6TeAz9q5LKOXv7obt29oQKnZbS8ValP2fO5gprLtW7krWXVVHcQuivhJ+xk9QuzwgMhsN8+COBdAs3VgJ1qPxn6ZymL3+dzlZ98lP1SmnA84Af2xrCvBx8nGqo2xoAJnacK1yvpcMwb3k/+PfFMF8pBX8WdXOdLl6RtDnVDDQvyYuvqs2+hHfIlrwOJqqljrzA9MuJoMkbD8cosalFbp/z761T8KeR5toTf69vX348RwQK86sUmQEe11K9E21Y7nE+nKqaMdPaVUwF0XTrSCT+psFCovdL7ZAozu0KklFug8LG+sg6Og33o0Z8ioCpRT7wK/G5Z3Ks3zQvXDWTMPuzdlKSo95VRR8fn+haFEI+J/ZackMDjQOZGHQReIgTJ+2r6oo+6GtoEpE41NRJqtrH20ZkglG61a2PyKLq4BdUd2fvyz49ulLpbvTiH9Zba3E Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3380.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05f19007-2137-45b6-c93d-08d81e2555d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 01:14:57.4525 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i0uqM2U7xR7mVnxlWSc03BAqBfZgp0VhtJiffd2jdO96hWj9DsLOvBllV+AYMmTo4RLSn3+oYBg7aJ1pVvRCow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4431 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add new RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Qi > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, July 1, 2020 9:28 PM > To: Su, Simei ; Ye, Xiaolong ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > > Subject: RE: [PATCH 1/3] ethdev: add new RSS offload types >=20 >=20 >=20 > > -----Original Message----- > > From: Su, Simei > > Sent: Friday, June 12, 2020 10:20 AM > > To: Zhang, Qi Z ; Ye, Xiaolong > > ; Xing, Beilei > > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > > ; Su, Simei > > Subject: [PATCH 1/3] ethdev: add new RSS offload types > > > > This patch defines new RSS offload types for PPPoE and session id is > > assumed to be the default RSS input set. >=20 > Not sure if it is necessary to force the default RSS input set as session= id for > PPPoE, So maybe reword to below: > Typically Session Id would be the RSS input set for a PPPoE packet, but a= s a > hint each driver may have different default behavior >=20 I mean if we use ETH_RSS_PPPoE, itself represents the input set "session = id". Maybe I can reword: session id is assumed to be the default RSS input set for ETH_RSS_PPPoE. Do you think it's ok ? Br Simei > > > > Signed-off-by: Simei Su > > --- > > lib/librte_ethdev/rte_ethdev.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_ethdev/rte_ethdev.h > > b/lib/librte_ethdev/rte_ethdev.h index a49242b..631b146 100644 > > --- a/lib/librte_ethdev/rte_ethdev.h > > +++ b/lib/librte_ethdev/rte_ethdev.h > > @@ -521,7 +521,7 @@ struct rte_eth_rss_conf { > > #define ETH_RSS_AH (1ULL << 28) > > #define ETH_RSS_L2TPV3 (1ULL << 29) > > #define ETH_RSS_PFCP (1ULL << 30) > > - > > +#define ETH_RSS_PPPOE (1ULL << 31) > > > > /* > > * We use the following macros to combine with above ETH_RSS_* for > > -- > > 1.8.3.1 >=20