From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EBDDA00C3; Fri, 15 May 2020 10:33:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A5DF1DA79; Fri, 15 May 2020 10:33:20 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 96E011D943 for ; Fri, 15 May 2020 10:33:18 +0200 (CEST) IronPort-SDR: WJ6melH5GbUI4FfZcBGEpxvk2jF3tqa6DcOX6A9VK/NZ9lKeYLjXKrgmaEg6if1gcE0LA5HqsN qRos+knzB2Bw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 01:33:17 -0700 IronPort-SDR: N13fYxtQk/6DuagXKAJ01qIZDZgxs6M+bzddDPp2hj79v+r+qAkDP2btZAIjhjELVDiW/cwrtQ znqJuLuKH/jw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,394,1583222400"; d="scan'208";a="253739860" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 15 May 2020 01:33:16 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 May 2020 01:33:15 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 May 2020 01:33:15 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 May 2020 01:33:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TSZBqFvR/fxA5G+rcKDH+8NNTx5GuzUMSyqRmZ612b9Xo5Qc0ppq8ASnWm/bJ8z36zN4EOIxbd6idYEG0CF0ZMEs6j2TUECYZlq7URonSMMhuOKeSeAXxEeS5CSYVV7YMq+mTbc5L+I45IKcZlTArU7Xo4RRtpVpWnm86l4y/DI8cSvkTrfVZTJ82/SY1RDH39v2TpLPZr2HL49tGutpinDHy2+/mNF8THScJU4ZVPe8G2dj4hFcD8FmISC6KqBBRA/stxgOXpmvgqMzvSiygCuPetDSrxxclhnXQDLGeAYgmEXguycPvLhJX73PCEpzUg4B2iO0gSY/BJVsWZmBxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=odLgCLaMe9p/MdH/b7enVHXFj8aqZvT03OzmqTJ8rEA=; b=kz1Knm9vekW5uUnxvV0sSvFO9VK5M61CLoVL7G589VVtQje3fQPU9h7eKVZXtIR2aEDUMePnygeP9JuWl14iEKrHA0EmGcmJx2o9p8NPMSjGLC5BeK+ey8KDOYNHnX6RW6qaTio8sGU1Ls5s+d+HUyZXwNfJbq90+JQvNK+kz2vUS6M4YrrdRcuplr9cUUEX3TIefhQtC4R2mhpJwEaZdwE3gU5M0gNdfNNd+WSUHzGSyP5ZKyomv52fjIsMYJlYv6oFwHIq9ms77QzCuFt3lZo8NyDMconIWGtXo/i4g+3EHcJy5Y0DOwd54WtyVByP8AKQfA+vjo//cPFE0lAZUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=odLgCLaMe9p/MdH/b7enVHXFj8aqZvT03OzmqTJ8rEA=; b=sjw0MRhhowxrhrdmJv7LNqe5hA8o0ghsGTTQenJgaBDjFdI49svFWwrRKQMS42JdV8sJ4YhV1t0usi3leDYgG4Kp44DVUb2RoBr9RsAOZEnOIzarSdt5ROHt2hl04MDYEs9Nf6DVUR7HIA6VqFz3gYUAqlsC+A4xsWZ6pxgnZC0= Received: from BL0PR11MB3380.namprd11.prod.outlook.com (2603:10b6:208:69::12) by BL0PR11MB3057.namprd11.prod.outlook.com (2603:10b6:208:76::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Fri, 15 May 2020 08:33:13 +0000 Received: from BL0PR11MB3380.namprd11.prod.outlook.com ([fe80::2c08:5b44:ebfd:6ea6]) by BL0PR11MB3380.namprd11.prod.outlook.com ([fe80::2c08:5b44:ebfd:6ea6%6]) with mapi id 15.20.3000.022; Fri, 15 May 2020 08:33:13 +0000 From: "Su, Simei" To: "Ye, Xiaolong" CC: "Zhang, Qi Z" , "dev@dpdk.org" , "Cao, Yahui" Thread-Topic: [PATCH] net/ice/base: fix FDIR rule passthrough mode Thread-Index: AQHWJNfS0kJTV/HVrUKXoSmoi3lU5aiowHIAgAADsAA= Date: Fri, 15 May 2020 08:33:13 +0000 Message-ID: References: <1588900942-380047-1-git-send-email-simei.su@intel.com> <20200515065006.GB114443@intel.com> In-Reply-To: <20200515065006.GB114443@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f021b0ab-372c-472a-9cd3-08d7f8aa9b89 x-ms-traffictypediagnostic: BL0PR11MB3057: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1060; x-forefront-prvs: 04041A2886 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OmNqM/0SlLtkwrfAoxdDOTEmrnZ9iPnT/ajViN5gZbTn1thNp4oObRfr2VtN5vMd+ln1256/r0XH1r6zhGuavPag/wbURzTkIpo/3NOwGKAfdqUrY8VEKB2WTZyr+XhFZAQmXFIrj3COMb0k9jLD3px2m2gC04ywNxO2CGfYb275vLP5nLCUFEsGofVZyqzXTUorClvmQlp3uc9/pa65aY+WAEyTfM6xXF1LE8EkdtbNDRMbCE3Llu8TfKthHlkfzJBUIzZoaW8zF1VEoLWZ3jdRzFs3siGZ49aiWOK/YwRgOOGpkCYdQCK2xvS7aFXAyOAXXLYDwxrZsoCD24r0InpGXSODnS5lQNhDWuwd3Ron8vUj64G9tM//geaSSpvkkJm40ue/RUxl9hICQ93XxEAccbjbmxdE3rPRiSNd1dpWvxgVKmHz+rPMCqAI6r1B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3380.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(136003)(376002)(346002)(366004)(39860400002)(66556008)(64756008)(4326008)(6636002)(86362001)(33656002)(66476007)(5660300002)(2906002)(76116006)(66446008)(52536014)(71200400001)(54906003)(53546011)(8676002)(316002)(478600001)(107886003)(9686003)(66946007)(7696005)(55016002)(6506007)(186003)(26005)(8936002)(6862004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 6ndDyWVkY2yIuOUImabYC8xcfg41jkVMpmGSvJOlZTSVyPi0lhwWSLWZj1kFADvCmC4l9Ql1Q8BBnbRxfHHexj3DHITlQRYKoI4J6PsZx1azc0jb5trWqqXAnG1O/8Wd7l7DctHyiYK4hyFmdT+yBf8Ap/ODnBotgi/pz5XT7qWJbwU0wxlTytDS4+u1E4oqZeWs/kWoxDWfPeufwXDVSUBHDgbhJaGb82XfCiwsESox47x8Nj2/FWCQJAICb4d3hFEzU2DsVo7hrJadIeyAdnSX5PIiiautOR1wKjp5oM7i3TdvrC7etOc3M5G2x20uvPTR4Vps9L/U/udiWlrJJkWU6mMrgXi5mvTSL9V5q+KgprLL5PL4UCOPJRI/ckaVcMHgaSPMejQ7OvPv2QtDJ55Mxp24/FOpAG8WrhtY0xiOYIRp+Q/19gnCYanFZLUUkYjg0HIW1VfBqLetb5uJL4QYa+8sIqu3GiwNDVark6k= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f021b0ab-372c-472a-9cd3-08d7f8aa9b89 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2020 08:33:13.1901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9tXqd2+sjlAolXF43QgG62AnSCEq8PwtE0g7HYsM7BK1N+hbzxT/GZPeQ9oQiq7RKuSwnerUIhA6FOxQDgcgIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3057 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, xiaolong > -----Original Message----- > From: Ye, Xiaolong > Sent: Friday, May 15, 2020 2:50 PM > To: Su, Simei > Cc: Zhang, Qi Z ; dev@dpdk.org; Cao, Yahui > > Subject: Re: [PATCH] net/ice/base: fix FDIR rule passthrough mode >=20 > Hi, simei >=20 > On 05/08, Simei Su wrote: > >This patch adds support for FDIR passthrough mode. When FDIR rule hits, > >FDIR just forward this packet to the next stage filter. > > > >Fixes: 55daca4e45fc ("net/ice/base: change function to static") >=20 > This commit doesn't make sense to me, it just change the function to stat= ic, so > should have any functional impact. >=20 > Thanks, > Xiaolong Besides changing the function to static, it also removes passthrough mode s= upport. So it leads to a bug that it doesn't support fdir passthrough. Br Simei >=20 > > > >Signed-off-by: Simei Su > >--- > > drivers/net/ice/base/ice_fdir.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > >diff --git a/drivers/net/ice/base/ice_fdir.c > >b/drivers/net/ice/base/ice_fdir.c index c703a7c..33a1732 100644 > >--- a/drivers/net/ice/base/ice_fdir.c > >+++ b/drivers/net/ice/base/ice_fdir.c > >@@ -465,6 +465,10 @@ > > if (input->dest_ctl =3D=3D ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) { > > fdir_fltr_ctx.drop =3D ICE_FXD_FLTR_QW0_DROP_YES; > > fdir_fltr_ctx.qindex =3D 0; > >+ } else if (input->dest_ctl =3D=3D > >+ ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) { > >+ fdir_fltr_ctx.drop =3D ICE_FXD_FLTR_QW0_DROP_NO; > >+ fdir_fltr_ctx.qindex =3D 0; > > } else { > > if (input->dest_ctl =3D=3D > > ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP) > >@@ -476,7 +480,10 @@ > > fdir_fltr_ctx.cnt_index =3D input->cnt_index; > > fdir_fltr_ctx.fd_vsi =3D ice_get_hw_vsi_num(hw, input->dest_vsi); > > fdir_fltr_ctx.evict_ena =3D ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE; > >- fdir_fltr_ctx.toq_prio =3D 3; > >+ if (input->dest_ctl =3D=3D ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) > >+ fdir_fltr_ctx.toq_prio =3D 0; > >+ else > >+ fdir_fltr_ctx.toq_prio =3D 3; > > fdir_fltr_ctx.pcmd =3D (add) ? ICE_FXD_FLTR_QW1_PCMD_ADD : > > ICE_FXD_FLTR_QW1_PCMD_REMOVE; > > fdir_fltr_ctx.swap =3D ICE_FXD_FLTR_QW1_SWAP_NOT_SET; > >-- > >1.8.3.1 > >