From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3050A0526; Thu, 9 Jul 2020 09:32:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B991D1DBBF; Thu, 9 Jul 2020 09:32:20 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id EA1911DBB6 for ; Thu, 9 Jul 2020 09:32:18 +0200 (CEST) IronPort-SDR: N1dbOazMjI8Chwyi87xUjDZfpOQNZtaBVBwe445gK6+tYTH7y6Z7Hz8UNIrse7QF5H5+nyhhJj 1MYVPrSfliHg== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="209480260" X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="209480260" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2020 00:32:18 -0700 IronPort-SDR: X3hK1H+zHBhh2yVU9WKJFdI83Uozgae13toBj/28U0Q/IgaWv8iUcgx2Ejc7BXCsifiLB3x2sN hVk8TKhEpqFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="314874791" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 09 Jul 2020 00:32:18 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 9 Jul 2020 00:32:17 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 9 Jul 2020 00:32:17 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jul 2020 00:32:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ODGOSGlFKfBE8G0p//6+wphA3Cf34no4XLWAB0t7oS8bkz4lpLsG4hd05S4iz0sZILbSy1zCxuURf5+tqfvqdsm8rfRQM7wr0N9Dugl1RBVzEQID2uag7e6NV12ptf/uH5WgaDzUX2yALyfpVi5ZZw0nC2tZEjC9c/5Obw864Wp2XAqFv/j9YkSfOM+x1hGYmJPywVXSczGZT3OuEYGmBCtGETPk3LoMJ4lBBfZ6nwkQpLfKGYs0QEVN2IXkSRn2hUIjmNvNNzxruIidevWaoPcT9VWnA4xBQ9wwAJJIZZFuB4/Blzb6lFfnE6/elUgq+eP3Wt5hX0kFyahhZ5EplA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Ir6Jjt/RwuGkRTqzRJreHZJwo0a6kE4LKrNsghbGjw=; b=llVmOuY3FLeHVYCs8niC9toH2QEcQNidc5GWX0VEjTjfybyPeQgiI8sgHlF9HUWrNtAEItTzKQq/H/fYiom7Hm70mNH+Qr4aNyn0Fb+BEQJEaoSFrv/FZxPYiwV++151q7zes7uZOYQZam3EWASgIzBoomzECNX1YWjEw9mR4epnipd0OaKzOzTc8aRcQ3IqEp77So3qP3OOw/bIj1tNy+Vjt7KJAaM/PpDCkor8T7uQS1g4JJIrnzbfcMWBL0BwcyOGdX0mqjLAzssO31ILAINjO9PfJs4hyH41iyW+2ynzPRmNnpieropXgbbnho3Bn7XMIFF79IV3sE8xsY0oVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Ir6Jjt/RwuGkRTqzRJreHZJwo0a6kE4LKrNsghbGjw=; b=HlsgWtkdsGk5UU9VQaLrQVMemWWCElEk6MYFIS6ASlWZosWoMIfRWt9mhB2LUtvtCvdcggRzlx6Cb+gylHXvJq6pLCT1oEHJLNJH7n/CCOnkoZTbfaaSfxy4sx0t+VpBGcaeTdqL6LSjwLutw6o8Hxzj3mBaAaAIGzJvVSPpuBU= Received: from BL0PR11MB3380.namprd11.prod.outlook.com (2603:10b6:208:69::12) by BL0PR11MB2961.namprd11.prod.outlook.com (2603:10b6:208:76::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Thu, 9 Jul 2020 07:32:14 +0000 Received: from BL0PR11MB3380.namprd11.prod.outlook.com ([fe80::71fd:6797:4389:da64]) by BL0PR11MB3380.namprd11.prod.outlook.com ([fe80::71fd:6797:4389:da64%2]) with mapi id 15.20.3153.029; Thu, 9 Jul 2020 07:32:14 +0000 From: "Su, Simei" To: "Zhang, Qi Z" CC: "dev@dpdk.org" , "Guo, Jia" Thread-Topic: [PATCH] net/ice: fix invalid RSS type Thread-Index: AQHWVbobHnXRh2tULUWXowU27g43dKj+zemAgAALnKA= Date: Thu, 9 Jul 2020 07:32:14 +0000 Message-ID: References: <1594275994-318254-1-git-send-email-simei.su@intel.com> <039ED4275CED7440929022BC67E70611548594D2@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611548594D2@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.212] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bd384d1c-409a-4460-5db6-08d823da339e x-ms-traffictypediagnostic: BL0PR11MB2961: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LzR8L6k8AKHU2+6T8QRqdzhuCDd047enK18x/KZ+ZwvMFytXL+7TwZcDzf0rGxPLrN3ropargRarBq/+8CDRiys9TvaLXwk8n9oIqf60elaRIV1eKhMA64V+84IyDEjaO8jYqFTVzDciSVv/JwJbnMfEiB2Nizq6pryQzrYOv2P5JUO9/xPWyaPduC4eLYWHpL46/WihepbOoO36fScZqIyNh3+6w/Um4UMbBcudiKiCqiZ1JI2Dn6DOD7TBgZEjHB0vneWjkorK2YOT3ObHB1oLRbMvtJYLAGAk1IWY+Fk26nWy38iXu4TkBBOhTY+x x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3380.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39860400002)(396003)(346002)(136003)(366004)(478600001)(33656002)(2906002)(76116006)(6636002)(5660300002)(66476007)(66446008)(64756008)(66946007)(52536014)(86362001)(71200400001)(83380400001)(66556008)(107886003)(6862004)(4326008)(9686003)(8936002)(55016002)(8676002)(6506007)(7696005)(186003)(54906003)(53546011)(26005)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: skZFHCdgbIrAJgJfhg9GF1EKjz8PScLps9mdlpDpOr8eYG10p2I9L8xd4n72kHN+nsGo9uxqpbMPQQR6StfoklNcGc22qcFXHF093wco1AvE0KhtOgLksMAx1BGgUsBE+7R0mIrJWMJ2lWovA+ZUJxf6s9v8MLY10aI+UkuY3eXM3M1LuZ4/IO8GPfJQ5bY4wITXC3UNQ0zFf7+W1Rsbzlure5cPkVovE0/hYa4Hqk6uBUwKlyVI+/Z/Hxd8llhU+7bGU6AiC5Fl4a7NcHDH0xesrVsQlNoFtpdo3p1+xmdHQj44+VdRFnJjT9HNaRxKvq/X6UDpzYGJfiQ/KDdHRfIKbSdYoNH54MYBstCK0AAN9I066xIB7t4Gbk3N1reTTu4OYWCtSq9GWbYKIBqDFh2x3sP5umUicM5D+IhTOWqihYJ+VvWixMotMEqeQVj+cVOxruRA6VAbcxM7/MS07PTUJqV6AeeA3NUM1OPVMZAuqUMSYauiJGCcHHkt38HN Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3380.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd384d1c-409a-4460-5db6-08d823da339e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2020 07:32:14.7225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +u4UK/ibZkGfhVHMy1m4BzzrPSJltf3ah+qTNl316zyAKSnN9qPzgVPQ23O3w8QiSc0afP9LOO0bMTvroAtkrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2961 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ice: fix invalid RSS type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, July 9, 2020 2:47 PM > To: Su, Simei > Cc: dev@dpdk.org; Guo, Jia > Subject: RE: [PATCH] net/ice: fix invalid RSS type >=20 >=20 >=20 > > -----Original Message----- > > From: Su, Simei > > Sent: Thursday, July 9, 2020 2:27 PM > > To: Zhang, Qi Z > > Cc: dev@dpdk.org; Guo, Jia ; Su, Simei > > > > Subject: [PATCH] net/ice: fix invalid RSS type > > > > When a RSS rule with only RSS type modifirer L2/L3/L4 SRC/DST_ONLY, it > > should return failure. This patch adds invalid RSS type check. > > > > Fixes: dfaedcf20170 ("net/ice: refactor PF hash flow") > > > > Signed-off-by: Simei Su > > --- > > drivers/net/ice/ice_hash.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c > > index cbd6116..777bd6d 100644 > > --- a/drivers/net/ice/ice_hash.c > > +++ b/drivers/net/ice/ice_hash.c > > @@ -721,6 +721,11 @@ struct ice_hash_match_type ice_hash_type_list[] = =3D > { > > * of the same level. > > */ > > rss_type =3D rte_eth_rss_hf_refine(rss_type); > > + /* Check if only L2/L3/L4 src/dst-only exists. */ > > + if ((rss_type & 0xffffffff) =3D=3D 0) >=20 > Why 0xffffffff? We should not hard code. Ok, got it. My purpose is to check if rss type is 0 except SRC/DST_ONLY bi= t to make sure there exist ipv4, ipv6, udp, tcp or sctp type, etc. I will m= odify it in v2. Thanks. Br Simei >=20 > > + return rte_flow_error_set(error, ENOTSUP, > > + RTE_FLOW_ERROR_TYPE_ACTION, action, > > + "rss type with only L2/L3/L4 src/dst only is invalid"); > > > > combine_type =3D ETH_RSS_L2_SRC_ONLY | > > ETH_RSS_L2_DST_ONLY | > > -- > > 1.8.3.1 >=20