From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B8F2A0548; Tue, 20 Apr 2021 12:33:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 989DC416EB; Tue, 20 Apr 2021 12:33:34 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2050.outbound.protection.outlook.com [40.107.93.50]) by mails.dpdk.org (Postfix) with ESMTP id 08440416E8 for ; Tue, 20 Apr 2021 12:33:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E67k7g7o92AkzZaI56R67oAMTNUpKAz5oCtX7OhElhWz4zUQHjusECzniOvkhngmrr1VHT03FoQCg3ixbN5nLorF/F7KP6XIHaV3PBEsItSD79wkueSJMgauFGsio9CDlVOAXj45RlgWRji4inb6ykOdSs+OuRrcsUlxtllHycKBUJ+JYv1WgNJHa4RTn7658nyF3LiOyXO0nKVwG/JkZQxM2JYrxInV1kw96OqILPPmPO03WCYhykuhn5tze2l0Pa8jb0UkQ7HVWiBtkHCupxMukAdQfLRHsGilPRzYSNvwqppae5YRxYIPeAtwJLFDCjX6IkruAHbDJVdPaPz27Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HIZM+lkpMN8rYg+Q435XuvJGhHG1OtOr7W8uL1qsjFU=; b=alPudI52kDUKKAMTD3gTdqJ4scIWChrrbdjvGzzRU6VFbUpdUFl6GCjnQT6Xg3CnH8X7FCK1sQ7w4i1J48tIIT7cf1W/TcrRCYu7zpE8tnyu3dFk/1A2OOXqYZdfzGzK8WM2OEnGD0nkKz7xednAMxDHnalf4QT/t5cfKZrGVO8oUuIDrKLBmR3eNlE/AGdSWb0sn+zJiM5JMT4HQIJlBdqUxTCP9v2CWjRNuxJv/D11FkgN+v/qVU9gM6NnI8u7jOMA3SnpJ+0aD7uuVb5YbXTVH++CU66kMMrm/wiy09ujcWY90Qx0EsMApvpvZe31T3LutgL95Ya10HHWySCfUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HIZM+lkpMN8rYg+Q435XuvJGhHG1OtOr7W8uL1qsjFU=; b=fgBoLtTYUMR3aJci4uTK3NWcTWNSBg3p81G657hKN1fMdhcsPAmNFyvcE+07vpKzcKC2nti7qRzHSoETPiKYttgdnRxQnvDkM21Q8eBqGaTlhcx8tgVb6yJRT0zSg9dU+sYXcKShqD98IJbxaRWR4hOpQCPG2IS6LvTRsbIzHt6MtFkzr1lVphuG0GSxQV4IdASoM8i3mCldXo5BbtkvEcirDtzrJz0yeY0fj2bRHah2OhkEgNoyeubJML05/plmT//EyI2wrpUL1U8cv0uDuu/JRgqFVzAScYwDJnet8bQMg+zycf+fuJR1phoVukIWRo69Q5/cZVyJ+Aw55gxHoA== Received: from BL0PR12MB2419.namprd12.prod.outlook.com (2603:10b6:207:44::27) by MN2PR12MB4520.namprd12.prod.outlook.com (2603:10b6:208:26f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.19; Tue, 20 Apr 2021 10:33:31 +0000 Received: from BL0PR12MB2419.namprd12.prod.outlook.com ([fe80::7979:5ea5:f490:d87f]) by BL0PR12MB2419.namprd12.prod.outlook.com ([fe80::7979:5ea5:f490:d87f%5]) with mapi id 15.20.4042.024; Tue, 20 Apr 2021 10:33:31 +0000 From: "Jiawei(Jonny) Wang" To: NBU-Contact-Thomas Monjalon , Li Zhang , Ferruh Yigit CC: Ori Kam , Slava Ovsiienko , Matan Azrad , "dev@dpdk.org" , Raslan Darawsheh , Asaf Penso Thread-Topic: [dpdk-dev] [PATCH v5 00/14] Add ASO meter support in MLX5 PMD Thread-Index: AQHXMgmpYSVKj1G3tUiaJ1KTxE58rKq8Zb8AgAAEloCAANDE0A== Date: Tue, 20 Apr 2021 10:33:31 +0000 Message-ID: References: <20210331073632.1443011-1-lizh@nvidia.com> <20210415151135.2098674-1-lizh@nvidia.com> <2c4adae7-e0b5-7125-5bb6-6e8ec6840fef@intel.com> <13272139.9o7rTQ05r0@thomas> In-Reply-To: <13272139.9o7rTQ05r0@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [163.125.179.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b32285d1-6eec-4e6b-c0e9-08d903e7be41 x-ms-traffictypediagnostic: MN2PR12MB4520: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QNHZ63ZAz0GF7IlrjgjbhBEbH5IObUmTQoDBmMfe8WqTWj2anU8+KzcxbW+slaENa9Se0n/mtS9xGRReu1yPkci0RYUjPNa3Q4A7LAer2CkqUlzQP7lW9o7DJ1RlRKFtxgdRBVpAn9gCHxlb1tS9KCIMd/vKcQTRSpqivgiCvsXpCgWu4gKYADdeVQzhnZUrk6FAvjPIzjReenw0LkgwOTYzVwr7VvrZ+NbJm5XfWtdkRWxskJ/UiB9x5zpS1cqcfsxiRQqkzRsFpf23McHfRTTJHvqJ2c04djAbTe5/vQKaOSKTVGUQxzviHegG1jOTXq1nVWVXUpAMfbHgpbX50o2FKYA3BZcedKsJmpZwGYYH4Rcy0kFS+HyWf7U8+tYZDFkRy9Bsul4K2omACUUtavessvhODOMVyxK+3e9YQ+9+IiIB4aanYsWB7N7h4mVk6L3wNang7tHfoKcKAaFFS+OEwXdoNgsPc7UH820rf7d+8TFpc5mbprqRNfabScTpYfQOUyE5RSXIEhnOAYiGY0PjPWFcHxSFgUEU9o32keDHkK8wPQoCBrND9jjrymggKAQLgkSHKsB4t5R2Ll3dJcfKm/pizJf5BerKpiZRYYk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR12MB2419.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(66556008)(9686003)(8676002)(5660300002)(66476007)(66946007)(33656002)(55016002)(478600001)(4326008)(53546011)(26005)(76116006)(64756008)(186003)(66446008)(83380400001)(316002)(6506007)(86362001)(71200400001)(8936002)(54906003)(2906002)(110136005)(7696005)(107886003)(122000001)(38100700002)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?QgkjLVAKffsCULu2fkk7YuNFgPNH4plGHQeZE1yQ7LMOqz47q4sPdLLcO68K?= =?us-ascii?Q?UT3U03SeXKxyv5yzcpmOL2LBLHiNLCaF7I74GUsLz5XHU8MKLXp4atHl2LuJ?= =?us-ascii?Q?kV4qbEIZMnuVeq/Pzj1pprBk2CLKHfg5Ty0YpDO/kUW9EjztHrJje6Ya3NA0?= =?us-ascii?Q?R3StweRj3AP6iTwRgxxQ02dW+5X5NEvHX6aiv6H6JLK0zuyG5ZiTS5MdXgms?= =?us-ascii?Q?RJs8SZvUR6mAjyChqVCU+f4y8ZHBv7ux8fsDa65eYQ7etY3vrkfCQ0WaG80V?= =?us-ascii?Q?ssY26H2ua8ETWDW3crRHmOa0sFRizr86vPgNnQQuYYlp7b/J6l5oMqFLmO94?= =?us-ascii?Q?yLzQPMTEJqpZIapPq9d8oVLOytjcmAVyzO6wS5d4GylHg/z8AtYz6u7bipGt?= =?us-ascii?Q?u2WOtJFHwryfrdhbbQKG2NATEcYbFg7U4oSpOC2/2xj3KN2VDZivGcTF6+Kx?= =?us-ascii?Q?l7Kgsrjif4Cq4Rk4V74leh3fRo7/zgX5/AM+cFFnBaYFy0Vwf88JNv/HibBX?= =?us-ascii?Q?69m9M5ZMcB7kDH2459/H0XK5eH9rb87x2eAdACIqsyNrSHhjw5tszV+q8G3T?= =?us-ascii?Q?/eKuCQBE+r7IYHnWOZKd+3GJrDaEQxZeq0dBtHq+R1pZJ0a0zOpYQbY1actX?= =?us-ascii?Q?uofiphEB+J91okI8GdwEvl8Ajo25AQPi1ys8Md1A/zlODD85KohRydcvDtjr?= =?us-ascii?Q?O8mW8bVD/j5fqa0qYEofN0uPFKLGO4bTpwlPeFdZjGxoWXsrbW27c8wqdh4g?= =?us-ascii?Q?AEWX5SSANVxyzdzSa3BWJem0kvlyeahUjH7ruhpnoJ9maLdv6HaQVxF/3Pxx?= =?us-ascii?Q?JA+hCDLS2RgKkDaO1T9ZCPjfOk2fr1y80890f3BntOD55y4lqYf3A22r5p1g?= =?us-ascii?Q?Aiw31ONWF+DeNmNCgeQpqnT6kPTrqWQ1uCgtxRQgOiEhoTqEdD2ZoIkwmRo6?= =?us-ascii?Q?JyI0wJRZF8HTx2CPyeZO54wVTzajH7IEpIT0zcsg9oPT4+yMSdfX6JfQnxwS?= =?us-ascii?Q?ifK8iSLpjElaVzReSBwHnoFqeFKbiS998JD6xNpN0bop95DxFQKw+H0hfFLr?= =?us-ascii?Q?N/VGBQIXcPiaaeVyTZQb24m9PdNxO7ynFhqTFyqGqSBtjBunpj9ymH8D2u5g?= =?us-ascii?Q?JXPBF9z+zLcck7eLNZwrBB2ZFW10cZPxtttTmL3/z+iX4LruLmmnWUGsC0V6?= =?us-ascii?Q?mzwaM8aZDKnrwkwMVcQU/tJo7C3vFY5EAYF2mwS6K2ACyZ2O6cI7PtEVxWYj?= =?us-ascii?Q?SDypeKE12hIcGaU84XT80/CtfK3mHWwuQ6OQPOygywUySfJYcdjQo6WTXik2?= =?us-ascii?Q?ZC+aNNsmUOxDGwencyv9baXF?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2419.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b32285d1-6eec-4e6b-c0e9-08d903e7be41 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2021 10:33:31.2405 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GpiDLMcLmfFxUcZX6q3CSkStInJ1i9N3mrhVagjoQcP1+O+qy0S/6QNx4Oayj08muKj4nYSMNZdHMXBqoM07lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4520 Subject: Re: [dpdk-dev] [PATCH v5 00/14] Add ASO meter support in MLX5 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, April 20, 2021 5:59 AM > To: Li Zhang ; Ferruh Yigit > Cc: Ori Kam ; Slava Ovsiienko ; > Matan Azrad ; dev@dpdk.org; Raslan Darawsheh > ; Asaf Penso ; Jiawei(Jonny) > Wang > Subject: Re: [dpdk-dev] [PATCH v5 00/14] Add ASO meter support in MLX5 > PMD >=20 > 19/04/2021 23:42, Ferruh Yigit: > > On 4/15/2021 4:11 PM, Li Zhang wrote: > > > To support more meters and better performance, MLX HW provide ASO > > > flow meter. > > > It can expose millions of ASO flow meter context's in HW. > > > This ASO object can allocate the large bulk meter objects. > > > This patch set implement the ASO flow meter for mlx5 driver. > > > MLX5 PMD driver will be responsible for ASO flow meter manage to HW. > > > > > > > What is ASO? > > Search yields "Advanced Steering Operation" but that seems Mellanox > > jargon, would you mind adding some mlx documentation to describe it? > > If there are some design considerations around it, it may be good to > document that too. Yes, ASO means (Advanced Steering Operation) and it's MLX5 internal usage, we adds the usage in the commit log. > > Also please provide the long version of the abbreviation in the commit > > log, at least at first usage of it. > > Ok, will add it. > > And what do you think mentioning from this new support in the release > notes? >=20 > Yes, new PMD feature should be announced in the release notes, it seems t= o > be a miss. >=20 Yes, will add the description in release_notes_21.05.rst > > > doc/guides/nics/mlx5.rst | 6 + > > > drivers/common/mlx5/mlx5_devx_cmds.c | 68 ++ > > > drivers/common/mlx5/mlx5_devx_cmds.h | 26 +- > > > drivers/common/mlx5/mlx5_prm.h | 81 +- > > > drivers/common/mlx5/version.map | 1 + > > > drivers/net/mlx5/linux/mlx5_os.c | 20 +- > > > drivers/net/mlx5/meson.build | 2 +- > > > drivers/net/mlx5/mlx5.c | 98 +- > > > drivers/net/mlx5/mlx5.h | 258 +++++- > > > drivers/net/mlx5/mlx5_flow.c | 334 +++++-- > > > drivers/net/mlx5/mlx5_flow.h | 212 ++--- > > > .../mlx5/{mlx5_flow_age.c =3D> mlx5_flow_aso.c} | 289 +++++- > > > drivers/net/mlx5/mlx5_flow_dv.c | 792 +++++++++++----= - > > > drivers/net/mlx5/mlx5_flow_meter.c | 873 ++++++++++++---= --- > > > drivers/net/mlx5/mlx5_utils.h | 90 ++ > > > 15 files changed, 2320 insertions(+), 830 deletions(-) >=20 >=20 Thanks.