From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88B67A0524; Fri, 8 Jan 2021 09:31:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70018140E7E; Fri, 8 Jan 2021 09:31:53 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mails.dpdk.org (Postfix) with ESMTP id 652EF140E55 for ; Fri, 8 Jan 2021 09:31:52 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 08 Jan 2021 00:31:51 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 8 Jan 2021 08:31:50 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 8 Jan 2021 08:31:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FfSb4a5QLYOk2eGH94UE58ildlrwe7Fs53s6d1Lkn2fULT4iZx1ODgzgN6/3wgnDUhQRo/Fo4zrcqXmqmKG6SfHLUywk1FPVf//ex6px0yadk+4QhHASpKMAxCardKo+9TVQ7aLpnao1BMS8+l3d/uyRyF63i8NJZ0xks8aIDNkQJtHzRnIl7RSUH+VR5VFlJFy8Bmm3oJA7jbXOcx0HpMNGH7kJKc3pcIRih4CxtM/VOtO8pQ/Bat75XlGqPBA2xnFVjHskJ4KvBlGT3wa7U1alrOp8AE51Nn5QyrDLNNz8HXszF4GSp3/c1HFlObgSJh4p1mkOrzgWZXmMWyNYtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kBO+h9aNn4UGqTVvkruqYeO0b9q3gTA5zwO/DKYv2RE=; b=cf9ycrd1IlJG4mQv7nSJN8KVOmUCGLGPCaMyf06iWLrJlqV4QBogsLfjprZN+A6ORQ3WmgcrQ4s/Zs8ax5H7+1o8x+LTFpukQCTO0t2tQ4Ms5N5TL1ycdy0gzhbL5FYvDDEb83ouog5Rom1sQ/LB5qz+7R96AVnFUavmeRZiqa4CjD5np3/K47O6ujeGQBGZe1329nKBWi+/0637nDtcipfui3cETqyvTmy764u8G5xmIb68vZEZdxiFk2PmdSwUEo5XVfQyAbF++fdsaYuYLWLD6PcNBQrtl6+/+Mi5gUY2Z/Mnin/gWyO3DjaeG0yyAfoqooouQVkPvt41stXCSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BL0PR12MB2419.namprd12.prod.outlook.com (2603:10b6:207:44::27) by BL0PR12MB4963.namprd12.prod.outlook.com (2603:10b6:208:17d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Fri, 8 Jan 2021 08:31:49 +0000 Received: from BL0PR12MB2419.namprd12.prod.outlook.com ([fe80::9de8:500a:666f:4312]) by BL0PR12MB2419.namprd12.prod.outlook.com ([fe80::9de8:500a:666f:4312%6]) with mapi id 15.20.3742.006; Fri, 8 Jan 2021 08:31:49 +0000 From: "Jiawei(Jonny) Wang" To: Stephen Hemminger CC: "ferruh.yigit@intel.com" , "wenzhuo.lu@intel.com" , "beilei.xing@intel.com" , "bernard.iremonger@intel.com" , Ori Kam , Slava Ovsiienko , NBU-Contact-Thomas Monjalon , Raslan Darawsheh , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6] app/testpmd: fix testpmd packets dump overlapping Thread-Index: AQHW5DYqn/Jr8cirhEWP2p20YpKsnKoawGIAgAKiT3A= Date: Fri, 8 Jan 2021 08:31:49 +0000 Message-ID: References: <1606129239-379967-1-git-send-email-jiaweiw@nvidia.com> <1609942417-259610-1-git-send-email-jiaweiw@nvidia.com> <20210106075550.1565ca32@hermes.local> In-Reply-To: <20210106075550.1565ca32@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [163.125.176.202] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 824565db-aa0e-43fe-cf98-08d8b3afd7f2 x-ms-traffictypediagnostic: BL0PR12MB4963: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J6BmfjjFzSB0AqSJw7znZk69LTc58xnCxrXRkLhw0F/AvY7oemJlcBuaNzLEy5SgvjuijywJDU70+DZ0yA/w4sIS8efHe6HnUT2gRiYbmVJfXPhXL02BUOVGhVUQQQJ6M4He9f5LypErVjMyp4MH5QSaf6pwYx32kxN49b+y1aOcyiiMC5wo88aHmq8RrJpBOamBFvCCMIpmd9l7AS4uNZOtxyuVnlyp+L9lPtO20EQZc/dy1jlKLJ1V/0aF3FnjKrJQu23ZEymqOGMRe4mdYbemm5f43BYlYbLPgo64uz1ONmDUo9ADVY7TQmX3J0I0hRx2EUYKkWe4WNhJKxjJg8XJM92ulCD0lcDYbsrQ0Vudbo2F6D5Koh06LhmDBbgs/DXtyy4u/UCyJNDdUT2JHw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR12MB2419.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(366004)(136003)(376002)(39860400002)(26005)(83380400001)(7696005)(86362001)(316002)(33656002)(9686003)(186003)(53546011)(6506007)(71200400001)(2906002)(8676002)(8936002)(6916009)(66476007)(54906003)(76116006)(64756008)(66446008)(66556008)(55016002)(52536014)(5660300002)(4326008)(478600001)(66946007)(4744005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Y0WHtE4hZF9NFETYX9unYeObAWjqqykuKX3WKXypsvWU7IBSvXetKHyxTBCO?= =?us-ascii?Q?zYr0lULSfyWQyNvGpNG+Zq6/2PGZORaiaai5LmE83AqEM8rsKKCTi9wA6ygy?= =?us-ascii?Q?a9FFcalf7BOJwYtEETShYX6BbETPIep5tjHNeinvak3GjqNU6r8D8unyNQ3m?= =?us-ascii?Q?FZVlQH1JNhruSEAM7pb0GtU6SZ6/7KIhEFQ92phA0yN93c5iliM8Pb9zJiuQ?= =?us-ascii?Q?sJolwZTjeadK0FYK+CU9Si52RZFtnoqo5qeWyxPPnlJRXFJaCI0viV5ifFK9?= =?us-ascii?Q?6uWF72ZcyZ4cqYqyw4+sGO0RXh5qg2JsTl+2eQ/B08YfRMhod8KWNIr4bYd4?= =?us-ascii?Q?6/S7BTKCYzZGpz3yEW/hhcX1PKWe+D5FyTMNiH3lsNxizpD3r4xEuQF8X/Sk?= =?us-ascii?Q?Ha30j4Fc2YGijK6/22c2wra17SAiMuEULXeUNOYcePw/32UVGRV5O2wdthj1?= =?us-ascii?Q?oLkiZHGhN9ZKTrYJ8euGTHiVcvmPo84NUMlYlQDVGrYtQ35mh9BS1lRqzgzN?= =?us-ascii?Q?AqQOniRvO0iAdQ3r/gbp7JFlYJjR9OGAxQsCF5ixxU/nSAy81XP8NZl0BLoJ?= =?us-ascii?Q?jsjkuG6dlS7tX2Y36NfgHuIdLbIL44Epy/iwfUWP8cL83fdWRNQ1jru1Eznv?= =?us-ascii?Q?MRmftC4gd0Wvb74J7795oDcwrHJfZU0PulAyatD6SLGDa4zEZsaxmXB7uhN/?= =?us-ascii?Q?kfhM+qG0AEzLM1DZAYd4xBaLm+EQ5hSCjhfPwxHNQVm/3CF9J/PVqUJHrLZu?= =?us-ascii?Q?brUTc4PNnlC6QZA1lAGEdk5dOA+B7w/Pbm1j/NsuP9CRFYDe2AEAxGRACKVj?= =?us-ascii?Q?rItkbQxiBocP/izXVlXIqQD0WoGNLpZZ8ZeMxrmpdFwQrHQS/ECq9EYOVkPV?= =?us-ascii?Q?d5G+aQ7IFSHmpkkIrfR9FuYvAlN1PLEebOUwUtMqnm8+4gb/ytOtocHRqN75?= =?us-ascii?Q?ba7oZtjS095VucJmbso7WZ0ip+AiNyXbTBPgoz86MReHE/m3KMbxCLJTZGXw?= =?us-ascii?Q?jaIC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2419.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 824565db-aa0e-43fe-cf98-08d8b3afd7f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2021 08:31:49.6068 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pjRLJ9/09BjxnLfULA3i7RkQe/ewFfeIgVetDHHU6ugo31Lk+6oPsSHQUpXylkTIkFtLfuL9+oWtjCY4CLOP2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4963 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1610094711; bh=kBO+h9aNn4UGqTVvkruqYeO0b9q3gTA5zwO/DKYv2RE=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=dQS+oHizGQ9y+SnMIjvkju6Q5zzgKneIW89WODmnMJ8htXdkB7FRLAMyrrlJhMx+N tEt2czJ0xjL7eJBOwmfou9AWne6GSfvwmYyclycAoEKmJJb/LMbi0LJJGEqoblKePx 5bVPXBzSQTRFIqisoO6eAbF3wqSMorXpAjkMz5WmRhocz7YN/tqm9+YcPsUT0UFEd2 yud4u+XwLPUAxL0CLGKb55bEhl+h4WsCWIc5YvlKLNGP0YS5PBSY6Qwnf+UrS6c8Wl /0HQ5UZdrfWQFxWWlQ89aFQ7o0z0oyjvRciWugZ4usF2V+e0tVQrMfEtLTNWPTvWyW ZbQvYB26BfKIQ== Subject: Re: [dpdk-dev] [PATCH v6] app/testpmd: fix testpmd packets dump overlapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, January 6, 2021 11:56 PM > To: Jiawei(Jonny) Wang > Cc: ferruh.yigit@intel.com; wenzhuo.lu@intel.com; beilei.xing@intel.com; > bernard.iremonger@intel.com; Ori Kam ; Slava > Ovsiienko ; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6] app/testpmd: fix testpmd packets dump > overlapping >=20 > On Wed, 6 Jan 2021 16:13:37 +0200 > Jiawei Wang wrote: >=20 > > + int buf_size =3D MAX_STRING_LEN; > > + char print_buf[buf_size]; >=20 > Don't use dynamic sized array if you don't have to. > Various static checkers can see look for out of bounds access to fixed si= ze > array. Ok, I will change to : char print_buf[MAX_STRING_LEN]; Thanks.