From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DEE8A034F; Tue, 30 Mar 2021 11:00:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83227406B4; Tue, 30 Mar 2021 11:00:59 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2047.outbound.protection.outlook.com [40.107.93.47]) by mails.dpdk.org (Postfix) with ESMTP id 0046F40691 for ; Tue, 30 Mar 2021 11:00:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejHbhEC6iL5gg1t7O69tMBxaHqdbFxGKx0q8DstPqz5WeuOZCV0qUj8nHoC99kZ+GmCqykh2wAXWkwbxVv5Njrbcla1fng0lp5HNcbFkvvk1JXjVyQRUEoLfDtcWqQr85Ud5wRrsXku7v0ptw+LwW2+Jj5Pj1/UeQ3N3pFfD5bb0HWvwgguEsBv1tzJUySIUYyhvaBJiE6HX+9ZUFpk1jRfQpwaJmd8MCTuMJJ/m+QSl8KB93xKBJmviyEgJlCf9e6KQFxUgDHlAxeoYyrM+BY20AZAVdolfsngER5KQwgkG9R0nZtfIcxRU6yZRB9O2xnbMPOAbAJJ7whflPapDYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cacouPONjr++KpN2M4rPx7dAofyMc9XzX64zdukklLQ=; b=Mwpegp0CnWg067ou4/vK/tVK8lq8L28yYriAcGeEsGDTT64K4vMtdRDQkMKwww8sFgAtk2iV1iR31oSDby5wnnOjA288aU51AvlpCTfgGAjEWPmEP6W8ZBWA8ZrhKXLJg7W6DkHAuYBI88of1smoqrd8gn8JpR3Dt1iNBe166Cu86zS7z8g5VUWDl3Bvc/0Tgm3Pmgvn83qdy1sfN4GKT3gmE+4MrDg7AUebkq6vlTQQpI+O/Qg1v9IldzB6Gu4t9bCyQWFmMs9Nlc/WGLkKecw4zsYyedd12YkaVnSCOQQFPgeS0PKJfe7s/2eVEJHhoHqQp3cV0Q7GhalaBQbdpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cacouPONjr++KpN2M4rPx7dAofyMc9XzX64zdukklLQ=; b=Ur9dZTAC3h2/jDVv2J5ooUxmyvskK+ywm1Kg4Dk86ogrxTbCHFWOEy3cTKjQvpy0k5YrKCC1m61LsF5qEs54UozQhofH1jgGBFX8r02Gk+J38m4YdsGwKQgti0oKX8/LMZIuTlHLV1x1tKBshU6dkOr6tEavpqilr7NhVwpzp7n8WUuU/4+dbktprK7qY6Qyb71AFOnluqRvnDLCc1FWA0CFTPSIT3xjsKeCIvudLt1IU1pBDiup6hVs4jsoGTQVTRy2HBbMT1hS8JSghJzOzpxx86lJ+XhwJ+UYXEM5VmnZyhajmdCKGhPP2qbWR1avw2VwNU4VZ8+5f+CC13Bpew== Received: from BL0PR12MB2577.namprd12.prod.outlook.com (2603:10b6:207:42::20) by MN2PR12MB4222.namprd12.prod.outlook.com (2603:10b6:208:19a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Tue, 30 Mar 2021 09:00:56 +0000 Received: from BL0PR12MB2577.namprd12.prod.outlook.com ([fe80::3c43:105f:fc60:7786]) by BL0PR12MB2577.namprd12.prod.outlook.com ([fe80::3c43:105f:fc60:7786%6]) with mapi id 15.20.3977.033; Tue, 30 Mar 2021 09:00:56 +0000 From: Suanming Mou To: Slava Ovsiienko , Ori Kam CC: "dev@dpdk.org" , Matan Azrad , Raslan Darawsheh Thread-Topic: [PATCH v3 2/4] regex/mlx5: add data path scattered mbuf process Thread-Index: AQHXJTti6lzNvaPxKUqfQBUdqWwBt6qcO13w Date: Tue, 30 Mar 2021 09:00:56 +0000 Message-ID: References: <20210309235732.3952418-1-suanmingm@nvidia.com> <20210330013916.1319266-1-suanmingm@nvidia.com> <20210330013916.1319266-3-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [183.159.148.182] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6a1e55fb-5f5f-4be7-e0d1-08d8f35a54c7 x-ms-traffictypediagnostic: MN2PR12MB4222: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yTJGeGSTkapZzO/TwiYjQQ8ofZtgaZBSi2MV4l1XAlEIpt7izp9yUP2zdMEpbQ0dOHkRX05vgryzYCM2+vSOftjkyqpxhAV0Hz+q9dis8osNO11SUELk0ItkMG61MUf5hI2+RSj5vZpcwQWnsaGwCiv8W50LSzAvehgSZzWu8BC278yd7DaX6KB/8wkz0GdHHDiyL0x5ji6heAth6BU6udCIeJmHfcBVvengS+LUnSDZ3ljZy9ssgRT5cO4MAR+YpjwmdpEFgd/vFehoxBP/TUkYoaTM3s6H7Z84UQvEJZAheUVQ+MFuyvJ5H46IB+vIBLkPeg8MVKEIKLiXuKsZhCcBnLYllDCbq3pwaMBhlrD/KCdliaVrH1ABWM0G+78dORx8qeHk/Cr0hsT66WvwTmPKzJZ+AIoydxFrXQkWRcJ6QUILy5MznJ6hGcHB5O0VDr0X+M3z/kgUreaNBEf2PJiWQ9Nafgp11kNYl7YCDYeeQlYo5UK97b4a36FhuV6jS+QHYViBaGXVoq3wYLbfGLIfLvpXLM6bQIkAqX/I3LGAaphpIJ0WUryvQbphaGnTMtDi4VphCAGf8tBRkbuM2SV5d8KvXuKkVpQfgUrivnW8pnGuJIYvMTMNCu9KgoqLTh+g3BVHHwI5LhQqpDTPrRpflKoeyBXbb6NjgU5X+I8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR12MB2577.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(346002)(396003)(39860400002)(376002)(8936002)(316002)(26005)(8676002)(186003)(107886003)(66446008)(76116006)(64756008)(83380400001)(5660300002)(33656002)(54906003)(71200400001)(110136005)(2906002)(6506007)(9686003)(38100700001)(478600001)(55016002)(66476007)(52536014)(6636002)(53546011)(66556008)(4326008)(7696005)(66946007)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?tRMYgd2DD/QCcJXJpVWmlLwUxaePdHurX2SqG0pt23nLS5TlrqZIwRrIv7Ey?= =?us-ascii?Q?s8csmQTSVvUn6suCp0+E4AhywW1kt6Kh01WUiep9zF8HGaiUnXyyIiFZeEVZ?= =?us-ascii?Q?+PzE1OF2mOxC5boo1Vw/cR+eawa1VZtB0IQ70pLRPgn/WT0ZwM7ncjNvZ2fd?= =?us-ascii?Q?e6WeVCFsYLIPVI1d7EQ5APHYegGMjnggaUBeCsWB8TTGxpoA08fUaou4xPPI?= =?us-ascii?Q?Frmwsrcv7RvOBlUeNB+qW9v3BzGepzGACBbzMp6NTKTY/bH/iTI1CaUDj1OP?= =?us-ascii?Q?DI+uTrty8nY7YZbbNUcLj146IYl13Cw+87wINCFFUTD9kRPpY7KMWWTLudyk?= =?us-ascii?Q?zNeVkA5elaS+XCReYIY8c9VrsqTfwfQMRyVfcSs+BiDVeKd/szJDYAPJSYfI?= =?us-ascii?Q?Az5FJJ+UwbmVJ+C7/zB6PaG9v32HtuiPMKFsWtP+JnZtBBQF4E0rFuJaVzfU?= =?us-ascii?Q?h2tKfFEdaVw6BJ+JFSFu+3JPvGr5Z9My+7XYkNo+9Yh6Jvrk4V6hILOtn0eO?= =?us-ascii?Q?HZBTa2J95w9wzU44kjJBg2zS9yRuPG9IimZvY6d9G8dnHUuT8MjEl3LgcxQP?= =?us-ascii?Q?0s/cjhW1bUa+wWUDWxthUW3fS5dw48aBMLkvS9ZRpSmJLqx2rf++WrkCdZDr?= =?us-ascii?Q?naxM+fZ3MuYeBtSImQiV8HFu5/zvIbLBfRHI9U9LO7xFm4Xv9dGnML0qgz82?= =?us-ascii?Q?uIDq9kcq06PTehFyDbY32uHePnFy5Y5X0uy13eICqIbImv4VMSftQ/GMZtG8?= =?us-ascii?Q?Hsuu3xlfg3Pes1M/LrCLa6MAmoshYabMJ7EoezghhFmgZqTTO2A0qvJiblke?= =?us-ascii?Q?lt2hN5KzOkKsNkWqBvqjGucC6hSCRY75MJridxqRvgO2Ye+XveBq8aCTGlaR?= =?us-ascii?Q?LJTUzqkIpvx8igEdIq/wVStS05cdn8UIXA+KPIjEzWzALLGLBnARU3RLa9kx?= =?us-ascii?Q?1ho88IHJpdgvLZD8sciSgjqm3+eswQrjqjohbrx8GaUaHE/o2NjHZPkI+J0S?= =?us-ascii?Q?hXPFFXrMrAkUNMZXnCWXUpkwZ2JKGTGMk4Cxy0pZ6b27c0DWXA54Pv92jmO1?= =?us-ascii?Q?vh+1WOXNKS/Nucj0KcPd4dkCSjQI0pCwZJA7hhPqtpj8pIXMKCfHMbLKT+Uw?= =?us-ascii?Q?Y6GBh0FAkucD4UxGnvwfxO3TpTqksLuho/IHUS5e0x6+H6QJDY5Z/CGWcmV0?= =?us-ascii?Q?ZAENb1O0cLBOe/6mGxVfe4Q8JGahp+8Hl9ziP/OwbbbnRLdSfBJlYpLIPGp1?= =?us-ascii?Q?beR0KxwHXwQrNdaNW2LdLjV4ui8y2BYU8bl1HXn4kGxMk/GZTOMgKe1bJbu5?= =?us-ascii?Q?k6OQvFb9SD/PfYhpDJ9KDoVx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2577.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a1e55fb-5f5f-4be7-e0d1-08d8f35a54c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2021 09:00:56.6437 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KlH6XE28z52Tc3I531piJ0dbcUC78UiwxASoN8UTw99jRCA7BtqT5h3PbVw2Vq2yIWYLrqPOq8mEt/5lBuF0Lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4222 Subject: Re: [dpdk-dev] [PATCH v3 2/4] regex/mlx5: add data path scattered mbuf process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Slava, > -----Original Message----- > From: Slava Ovsiienko > Sent: Tuesday, March 30, 2021 4:05 PM > To: Suanming Mou ; Ori Kam > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > > Subject: RE: [PATCH v3 2/4] regex/mlx5: add data path scattered mbuf proc= ess >=20 > > -----Original Message----- > > From: Suanming Mou > > Sent: Tuesday, March 30, 2021 4:39 > > To: Ori Kam > > Cc: dev@dpdk.org; Slava Ovsiienko ; Matan > > Azrad ; Raslan Darawsheh > > Subject: [PATCH v3 2/4] regex/mlx5: add data path scattered mbuf > > process > > > Nice feature, but I would fix the typos and reword a bit: >=20 > > UMR WQE can convert multiple mkey's memory sapce to contiguous space. > Typo: "sapce?" >=20 > And rather not "convert mkey" but "present data buffers scattered within > multiple mbufs with single indirect mkey". >=20 >=20 > > Take advantage of the UMR WQE, scattered mbuf in one operation can be > > converted to an indirect mkey. The RegEx which only accepts one mkey > > can now process the whole scattered mbuf. > I would add "in one operation." >=20 > > > > The maximum scattered mbuf can be supported in one UMR WQE is now > > defined as 64. Multiple operations scattered mbufs can be add to one > > UMR > Typos: "THE multiple", "added" >=20 > I would reword - "The mbufs from multiple operations can be combined into= one > UMR. Also, I would add few words what UMR is. >=20 > > WQE if there is enough space in the KLM array, since the operations > > can address their own mbuf's content by the mkey's address and length. > > However, one operation's scattered mbuf's can't be placed in two > > different UMR WQE's KLM array, if the UMR WQE's KLM does not has > > enough free space for one operation, a new UMR WQE will be required. > I would say "the extra UMR WQE will be engaged" >=20 > > > > In case the UMR WQE's indirect mkey will be over wrapped by the SQ's > > WQE move, the meky's index used by the UMR WQE should be the index of > > last > typo: "meky" >=20 > > the RegEX WQE in the operations. As one operation consumes one WQE > > set, build the RegEx WQE by reverse helps address the mkey more efficie= ntly. > typo: TO address >=20 > With best regards, > Slava >=20 Thanks very much for helping with the log improvement, I will wait for one = or two days to see if there are other new comments and update it with the n= ew version. BR, Suanming