From: "Agarwal, Nikhil" <nikhil.agarwal@amd.com>
To: "Gupta, Nipun" <Nipun.Gupta@amd.com>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"Yigit, Ferruh" <Ferruh.Yigit@amd.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
"Rohila, Shubham" <shubham.rohila@amd.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v2 1/2] bus/cdx: add support for devices without MSI
Date: Mon, 6 Nov 2023 17:54:38 +0000 [thread overview]
Message-ID: <BL1PR12MB5333B30702F9F88C75B896D39DAAA@BL1PR12MB5333.namprd12.prod.outlook.com> (raw)
In-Reply-To: <8816597c-a4f5-4fa2-a3fa-90d9fd68dbfe@amd.com>
[AMD Official Use Only - General]
Hi Nipun,
> -----Original Message-----
> > diff --git a/drivers/bus/cdx/cdx_vfio.c b/drivers/bus/cdx/cdx_vfio.c
> > index 8a3ac0b995..8cac79782e 100644
> > --- a/drivers/bus/cdx/cdx_vfio.c
> > +++ b/drivers/bus/cdx/cdx_vfio.c
> > @@ -101,13 +101,12 @@ cdx_vfio_unmap_resource_primary(struct
> rte_cdx_device *dev)
> > struct mapped_cdx_res_list *vfio_res_list;
> > int ret, vfio_dev_fd;
> >
> > - if (rte_intr_fd_get(dev->intr_handle) < 0)
> > - return -1;
>
> Why is this check removed? If VFIO fd is not there we may not proceed with
> other VFIO cleanup?
This check was removed from here but added later for interrupt specific cleanup
section. It was causing other cleanup in the function to be skipped in case device
does not support MSI.
next prev parent reply other threads:[~2023-11-07 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 16:22 [PATCH] Add bus master enable/disable APIs for CDX devices Ferruh Yigit
2023-10-27 16:24 ` Ferruh Yigit
2023-11-03 11:20 ` [PATCH v2 1/2] bus/cdx: add support for devices without MSI Shubham Rohila
2023-11-03 11:20 ` [PATCH v2 2/2] bus/cdx: add bus master enable/disable APIs Shubham Rohila
2023-11-07 14:25 ` Gupta, Nipun
2023-11-12 13:36 ` Thomas Monjalon
2023-11-06 17:04 ` [PATCH v2 1/2] bus/cdx: add support for devices without MSI Gupta, Nipun
2023-11-06 17:54 ` Agarwal, Nikhil [this message]
2023-11-07 14:25 ` Gupta, Nipun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL1PR12MB5333B30702F9F88C75B896D39DAAA@BL1PR12MB5333.namprd12.prod.outlook.com \
--to=nikhil.agarwal@amd.com \
--cc=Ferruh.Yigit@amd.com \
--cc=Nipun.Gupta@amd.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=shubham.rohila@amd.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).