From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C3E942BE2; Tue, 30 May 2023 12:46:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B80CA40A82; Tue, 30 May 2023 12:45:59 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2066.outbound.protection.outlook.com [40.107.243.66]) by mails.dpdk.org (Postfix) with ESMTP id A26C6406BC for ; Tue, 30 May 2023 12:45:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m1rPudSYscYsPGeJyocyhHhcp17muyFLcrxMn9tHDTtN0psY6AWP2dPMKxm3S2RZnYf5h6m4OQBdEHWB9bbYHqzkBFyRq27cJQxyys0J0v5aFKSPyU6wjjK4Rc2aRJAxtRU0CiGF+LIOpSYcRgOQ1Kag4MInxPIkt+eD4ks9Bg2j/w6ZnxOk95aovlOjOwDT/i+fBFBNem++Bwh2cetsYzKxrxIg+QusH+9gmlj/5zrso7A4VSD4LH8J0CGYfBzv3kid0v0Oy0i0ssNoiR7WMK/9KtiG/yqW8nqIYkmt4i/2R/5kjL5FGmTgq4l3e77u3pLteOtOpcRgTuJ2J9A+vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hRhg8ptzwnGyA43M+XrQDzOMLsfOQMD8aS+LwrPPWzY=; b=YA+/+QCTkWBxewKSyFmWrHq3ACY6OwrHyQMcbAhZiL6ix972zs8sLJhcY+T4EvI1STot3hZqI8OHFN+d1NH9UfKtwfE/lubdyntE+pnKDKCttOdfvvB2QNJlgPJq7fCY1EiDC8Di0v0e+i+HBlYxS/2XtadLYidAXUvuN9jNpGndCCNELGzM8g5Rh53xvV5sZXhg4WRzEreOiE3T8H3diJB+g7esTSmSE5bLXO4Y7kwWklJCsfhWQoRDYVsIaldvBrDLuDfGQvB7GH56JyrdsVPcAPx1Ttr9Ep5DyXSgQpQTogN2Mt4nfxrka08Ugh5mD/J8QJGBhpom2+tkfNa7WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hRhg8ptzwnGyA43M+XrQDzOMLsfOQMD8aS+LwrPPWzY=; b=40B0f0D6MQ4fNxSUqO0+Elr6sdDRPqVK8cvfvX+fXQsY2rNCVdBq2EHcuMGiLJj7xc4gf8CkmdI/26jS+ntZGMFvdQXdYN1Z3giympPAyaljnCReSHUUe/kJSqxBymmdaXrDaU8oMxtRVeUB0YdX4QxbQuAyo3m+BNu/1qw3pcs= Received: from BL1PR12MB5777.namprd12.prod.outlook.com (2603:10b6:208:390::21) by DM6PR12MB5519.namprd12.prod.outlook.com (2603:10b6:5:1b5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Tue, 30 May 2023 10:45:56 +0000 Received: from BL1PR12MB5777.namprd12.prod.outlook.com ([fe80::1c3:699b:de02:1146]) by BL1PR12MB5777.namprd12.prod.outlook.com ([fe80::1c3:699b:de02:1146%2]) with mapi id 15.20.6433.022; Tue, 30 May 2023 10:45:56 +0000 From: "Tummala, Sivaprasad" To: Thomas Monjalon CC: "david.hunt@intel.com" , "dev@dpdk.org" , "Yigit, Ferruh" , "anatoly.burakov@intel.com" , "Laatz, Kevin" Subject: RE: [PATCH v1] power: support amd-pstate cpufreq driver Thread-Topic: [PATCH v1] power: support amd-pstate cpufreq driver Thread-Index: AQHZbSSj7rgg18fr80OVRbgrRBYL3q9qBfSAgAjjoFA= Date: Tue, 30 May 2023 10:45:56 +0000 Message-ID: References: <20230412095244.967182-1-Sivaprasad.Tummala@amd.com> <3000723.687JKscXgg@thomas> In-Reply-To: <3000723.687JKscXgg@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=4db5c51e-9b21-413a-93ca-aad2cdeb83c7; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-30T10:31:46Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR12MB5777:EE_|DM6PR12MB5519:EE_ x-ms-office365-filtering-correlation-id: 343dfd7a-56b8-4afc-e7c8-08db60fb0c50 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gL4aOnBS6/PYBDEUmkh5VsHqUtddPngkMYwwhpbK2O/m+RlrcO1oOUxpVeSaQ31Pw+FwQO+FbR4YlKFBa4Ip9gmEqgKtYiQrpw7738G2zi3y+XpIs+jF4CorVqepEI8lBdMuFc4Qsex8mEZpGs7Ji4rRj6eRb3T4CFi3F3wtcBCCHrd+koXFtWD2oBvjc52PKpe7xsHH7hVJ0nf6JMin7H09JqEt2cY+cJNmtxdFvf+ow6c7tp8rX4S6dlGrKS7Bt+4n1HCb3VjZ+POF7QqE/puH+w1Y2JhKaGCiYKgUjuBo5GMs0tU0/9xYxE+XHJ/URQCbOTO0I8nTIvBOFrYp2gNZ/9riGH/Uk92rjIHjpk/ck0FPAU7S33r3kRPIqGaHMzF4VhvqXi33yLMWUsfecLW0wB/2j8IdWkQLkDyX7s4fT+xHG4KQFJIdGWOPvI7BLNXII6WgxkIo8np6DcG/1YNFqNqiZP1g50S3sT6QRftKC6wGX1VvMTsaIVNF73iiwQEB33g0lGg/RnmgCEYQM8N7Pbbnbz5DH2sSQXTSXXsun2LbexIZsKA2N77JQNKfp1dLnLoWDF+ljG7WRbBe8u1xmkIy36zgubJ06aqNwld0pKbqNbBhVJRBtI+pLpk+ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL1PR12MB5777.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(346002)(39860400002)(396003)(136003)(376002)(451199021)(71200400001)(478600001)(54906003)(8676002)(8936002)(5660300002)(52536014)(33656002)(38070700005)(2906002)(86362001)(6916009)(66556008)(76116006)(4326008)(66476007)(122000001)(66946007)(66446008)(64756008)(316002)(55016003)(38100700002)(41300700001)(26005)(55236004)(83380400001)(186003)(6506007)(53546011)(9686003)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JfjKSA6E2JE/gOQFR1xZGtizKT/79/hseW5X7S3VJ9oqYGn6pn73M81rgQwd?= =?us-ascii?Q?ulhnTZQQAhotkMU0rosXrkbsHb5L1Yeh1t7Ufa7mNHk3V+cEvz5VzqJ9HBfh?= =?us-ascii?Q?2xjyeXl9LUeYDfl+P6hXC/6dpHxItWwYPYZxwXINBuANE/ZvdnpTSZZsc5B3?= =?us-ascii?Q?1QG3KHqX3LzOG7wvCXVVRurtfsKa3xI8o2I/AsGRnyWF9f/ZglQvnCqfOQlg?= =?us-ascii?Q?YVVa0sRQN/+3xR+ZkohVohWRly4loRZzfM28RVGHdBYXHEqMhnovG62BtMSN?= =?us-ascii?Q?MKcZgYj2gVp3mdgs5SnlZE/HB3GSq+gLyDiDS1opu0hKGMiQFUCbVrdVeix4?= =?us-ascii?Q?9C/A6bpqSGKdTC0qgLTuPtEWpqqaiuqQde+mt3O//8r21Z+DZISW7ZwCDc4L?= =?us-ascii?Q?StAIAO9TLsepwNnKmVI+mLOb4Du25eftWnRJ3KJbC/2Tz4Rt2fqoGTdp4X3U?= =?us-ascii?Q?x/y36veMiUpziSdOwilocaa3UOPbs9/GI3JtpO7L1sShpkZiyb4UlMihFSmh?= =?us-ascii?Q?6toQJn9rTi+AyRRZxqDLCWUaooPzUlFnTAHb+ma7KeVoI0yG+E2daSOQYmFu?= =?us-ascii?Q?hUvrdBWGG/cY+lNfpiAqGMebddAU9EtzTfa1epquvX4/v1xzox9vA4p2G8dB?= =?us-ascii?Q?dQnG1elWnSRKgAxfUzQ1yDLPuzVVP6qqfW8uSWFOH02MkggpfAyeAKtr36C6?= =?us-ascii?Q?phoDZHybsOsLot7ji6j/qN6CIaVF3yGBc+AWNr5cUPmOrHmJ5gQnr9G8i+cv?= =?us-ascii?Q?+ZFDiFKx8Abm5vJCMmFMEXEyhkzrFFxQ5sQA+1E6/ao8jlSZKwBI2xR2KgUc?= =?us-ascii?Q?Q2dcvg3p86U/iiwfzSapyAxia3wxLgiHIl56UV0J5GPBWUaj8Nic9WyBLs80?= =?us-ascii?Q?+kNmOe60ZwgnGBH1HJVToFZzu+9ctMdVOMytIB/iXT3SmS94Le8GGeGE4Ore?= =?us-ascii?Q?hEojpxXvvklnGEmCCE73xkELLinvLbTTv8viqYxnHr/edYJoTVZcInxwvFzd?= =?us-ascii?Q?1cbbCJTaSjCDh7Ls0sT24LHeW23KEfqDff2knO5XZo5L/lTuG2mEbztvdQIh?= =?us-ascii?Q?tZ/ksyR9CyZgoVoF9QEe7bs5++gX5XgoXOGPMolYv2FhvKoYUT6PtrjaslkV?= =?us-ascii?Q?RJKys1HqrwH9xaxyJXDHIrAb3D0sU4kNPtKtWAAEJR7lMuPGzHKuMSzbbutH?= =?us-ascii?Q?bqwfiz/wrNvyslZ4Po/JYMwiKmIZ/kePRgJC1+QzdLTq7wQKzP+0tE4Mw3yZ?= =?us-ascii?Q?vPrD71JJ3qyRdI9/hmYk9aK5AtvX0w+ReUmOaoqG/918/EtO2SmkboqOpu1d?= =?us-ascii?Q?wJ5C0kqk0FfwsfidCIgsuiZnn0fMbRysF4i4st68VBySdcNYlH1q4e2FrbC6?= =?us-ascii?Q?g3kvHIclmLwbEJ5Lm1ndLGUmvsEdCMlB4SWhb2Eb9HjoV6JbZHHUDOTAzSt2?= =?us-ascii?Q?x1lNoHKrzqHV8HtY3DX8EugmuxYBkwlB51th94psg/9yiyQN/GNEWGamovag?= =?us-ascii?Q?Qkt2Io+qOHhnABNFGf+ArAht4hI5YMKPv23EM4JtRco9M2SheWgYN7hkTN/I?= =?us-ascii?Q?lx+yYD6p1upHWCuaOng=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5777.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 343dfd7a-56b8-4afc-e7c8-08db60fb0c50 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2023 10:45:56.2425 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g+lsTdha+kPG8W7m2dji1r4qtV5h3pS2VOJEoo8D6/j5WxN1YLN2l+ic/cxZ0zcILf8ppVv15lDH/VWIUtiJJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5519 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [AMD Official Use Only - General] Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, May 25, 2023 12:17 AM > To: Tummala, Sivaprasad > Cc: david.hunt@intel.com; dev@dpdk.org; Yigit, Ferruh ; > anatoly.burakov@intel.com; Laatz, Kevin > Subject: Re: [PATCH v1] power: support amd-pstate cpufreq driver > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > 12/04/2023 11:52, Sivaprasad Tummala: > > amd-pstate introduces a new CPU frequency control mechanism for AMD > > processors using the ACPI Collaborative Performance Power Control > > feature for a finer grained frequency management. > > > > Patch to add support for amd-pstate driver. > > > > Signed-off-by: Sivaprasad Tummala > > --- > > app/test/test_power.c | 1 + > > app/test/test_power_cpufreq.c | 5 +- > > doc/guides/rel_notes/release_23_07.rst | 3 + > > examples/l3fwd-power/main.c | 1 + > > lib/power/meson.build | 1 + > > lib/power/power_amd_pstate_cpufreq.c | 698 > +++++++++++++++++++++++++ > > lib/power/power_amd_pstate_cpufreq.h | 219 ++++++++ > > lib/power/rte_power.c | 26 + > > lib/power/rte_power.h | 3 +- > > lib/power/rte_power_pmd_mgmt.c | 6 +- > > 10 files changed, 958 insertions(+), 5 deletions(-) > > I'm not comfortable to merge this patch without a word from David Hunt. > Given there is 0 review, what do we do? Yes, we are waiting for feedback from the community on this patch. > > > > Also, make sure to start the actual text at the margin. > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > =3D=3D=3D > > > > + * **Added amd-pstate driver support to power management library.** > > + > > + Added support for amd-pstate driver which works on AMD Zen pro= cessors. > > Looks like the indent is not correct. Sure, will fix it in v2 patch > > > 'power_pstate_cpufreq.c', > > + 'power_amd_pstate_cpufreq.c', > > Can you say briefly why AMD has a different pstate? > Does it mean power_pstate_cpufreq.c should be renamed > power_intel_pstate_cpufreq.c? amd-pstate is the new AMD CPU performance scaling driver based on CPPC. It is implemented as a new kernel driver and we need a different library fr= om Power_pstate_cpufreq. Yes, it makes sense to rename this, inline with the Linux kernel as indicated below. linux/latest/source/drivers/cpufreq - amd-pstate.c - cppc_cpufreq.c - intel_pstate.c > > > +++ b/lib/power/power_amd_pstate_cpufreq.c > > @@ -0,0 +1,698 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2010-2021 Intel Corporation > > + * Copyright(c) 2021 Arm Limited > > Why is there copyright for Intel and Arm? > Does it mean you copied some code and did not try to keep common code in = a > common place? Yes, few internal functions follow similar notion as power_cppc_cpufreq.c > > > + * Copyright(c) 2023 Amd Limited > > Thanks & Regards, Sivaprasad