From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB4A6A0544; Mon, 20 Jun 2022 07:43:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B93C40F19; Mon, 20 Jun 2022 07:43:43 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2087.outbound.protection.outlook.com [40.107.237.87]) by mails.dpdk.org (Postfix) with ESMTP id 42C2C40150 for ; Mon, 20 Jun 2022 07:43:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QJXwSD7spb8anfIKJFFUmQC9l+rr0c1aLxjPGLQOsAYHWujmLEBelBDJkqzsEqnPD4AhCAHLLV9B4k/UW9UbFNN32TaULCvKSgdIs9uWJk6nK40CRvKQNjTgVOOhfHKk4SFbZz5pB/Yj9EeKWRwvXEqgbxDC8PAuUrJlnEReEHcxhgk+P7J7SAMeuKN3bFw41E8+AAszCyLZUr9gUUlmPPp6MefDtH4Tv3g6E/Mkpd6R7BPoAWr6OSzve0N5mbMVqnjUp6ZCL03P2cXUA/hK/OTxChQWupvQ7i6uIF0E2TGCEbhSA9rj9+/0rsLxjiKksrvbOjylECVQz1Z+/+7mTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xpDJ3Ve9kVJbaiF75sBstNMozguQy8jhBdVjDdQPzUY=; b=Q2s7oZsfZQnYrC0oU0qIQrBPI1YJY89pqiGJ5f4nSWbkMrh17Dx6Koy06wiQUsSyq0yhiwGRTQZnLgtXIESdpogyLJtP8lmRsb0dahwF4GJYbBuMtGSr28NrPQ33Asbu+f8lDyP/lrlEYU5z6t/6HvP25aY9xOVGwT/WNTBt5C0IG5OoGZQn+QoLy1t1OUDSgvJ2kqBPUWNp5WC24ReptBNqIsu3YP8QWfGFV37YlWz1Gct20o8KxPHYbHlIUArWjnExDlrF+Khc7un808z/kmUrWzm+CFbHdXYA+gj+DeaJvxJaO6OONJ2mhcYAOickG9v3nJmAODCWDtOu+rhv8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xpDJ3Ve9kVJbaiF75sBstNMozguQy8jhBdVjDdQPzUY=; b=qyjP4SEh9PN0y/1C+MG8zftWoiU3hj0NdigAA3HHMgZ+Hz1e1iAVb6g9yYw/Nij9eS3kVxi3UoDhfwROc5O4w296N8zaXjrsifFN+BzUy8oNXLljLCV5JETFRUH1MuiJRMWK7nzQhKDX3OBK8AZHeqfSSQGu1s06/YWA5JGryNO1r+AWws7TVkvtyGgqgf4I/WoNLg46/KTOnDOjeMRSBWGcRJnr+wX6Nx1dG3EvzZV90s/GFDxJucwSyLkaz4PIaTgUTJCXXomDhSotBT/nPKi/eEkMhXcQjatbi01yOzfPvZ7pbS2h9hl9UlCMo1Q1ngl7MkUfLajYOayno+ounQ== Received: from BL1PR12MB5945.namprd12.prod.outlook.com (2603:10b6:208:398::14) by MW5PR12MB5624.namprd12.prod.outlook.com (2603:10b6:303:19d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Mon, 20 Jun 2022 05:43:40 +0000 Received: from BL1PR12MB5945.namprd12.prod.outlook.com ([fe80::9951:cab3:3606:671d]) by BL1PR12MB5945.namprd12.prod.outlook.com ([fe80::9951:cab3:3606:671d%5]) with mapi id 15.20.5353.014; Mon, 20 Jun 2022 05:43:40 +0000 From: Dmitry Kozlyuk To: Bruce Richardson CC: "dev@dpdk.org" Subject: RE: [PATCH v2 2/4] usertools: add option to change mount point owner Thread-Topic: [PATCH v2 2/4] usertools: add option to change mount point owner Thread-Index: AQHYgjz4uWmPcW47AUGt2pObU106Ya1TwEKAgAQKwKA= Date: Mon, 20 Jun 2022 05:43:40 +0000 Message-ID: References: <20220607234949.2311884-1-dkozlyuk@nvidia.com> <20220617112508.3823291-1-dkozlyuk@nvidia.com> <20220617112508.3823291-3-dkozlyuk@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 75f6ecba-6028-43d0-f998-08da527fd498 x-ms-traffictypediagnostic: MW5PR12MB5624:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LEzRCEs0Vq+uosc1ua3TJIcmWCnNSZgFYnAxKiwU0jIbLLk8QUUoiDJfp9zX2+/88tHFYac0vVVXUsAmUcb+/7+3wTFfHBgZClNclNEwuM/bfRlY/qdy5+25daaKnJsdQfbT6ZWJC8eQ6GUWPs513+L39HV7imiISJ5p2WJoWzsK82KzEin/0Ld6JcFpfY33jKDLYIlM/+sMbi1eEtM7aRkGTlwTLS6MUO9fyq2C3hHypE6DzwX1ODt7eRVIijXZX85k38HwUAbdVUKiTDhlHszbHc67YSRzXoTmvd+p8lTIhE6WYFryA3cy17kisjBs/+TY/2PvGpK7ltSLYDof628MU1tEyy6OJRyo9Fzp1bIR5VWVIt82c3HNoL+huoXm5u8JhFEMqE3vP3ooFzVvZWGqcKLP9vv1h71ze08sagBpJX9hP7ngump1qGT79eBfsx3WSBLp1LlqFBTOzu1Jyh0FR5iTNszOsAUyhDmZIp4HIrAG7rtij9otLntkziGdZJGhgfNXJJHeCKjYmziAJkE0wZQhrMQyXx6PH1DBlBmINXxr56Ex+q62ietI8Prk6cx1MaVrp2WAY3/aWrhf4YJHClT9rsY5rD1jf5DJ1lPuospwkuXbW/wZkOboHgSZzk1/bpgkIXpWgGnYcVYnlomo91hJcN9RLrd4VhC68BaMLOPS6cHrr3okJzlMwLxkTrUMBRyePfY6O4qV8Vhp+w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL1PR12MB5945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(7696005)(316002)(26005)(5660300002)(33656002)(4326008)(86362001)(8676002)(64756008)(76116006)(122000001)(66946007)(498600001)(6506007)(66556008)(66446008)(38100700002)(6916009)(55016003)(8936002)(52536014)(38070700005)(71200400001)(66476007)(83380400001)(2906002)(186003)(4744005)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?khKl+lf7BLuIXzzDmcZa2ZrQEDJERIPbxGuKh3MomhMM6asKgxvF+Lo3q63z?= =?us-ascii?Q?d+9eaJf/vCS9EtgHPtT+TPy1gQAZuseBryz0ACTDjjTus/h2PHA1je32xmtY?= =?us-ascii?Q?9Ezl6+6gJT4NnB4N15zGWDPW9H+KF3usYBHUEDcOpMbAzxrjTwwfw6vXnc7E?= =?us-ascii?Q?qQQjrk+WoUngSoj1i3xDvADqsfzjvjiAaLVHwUUfchy96Jjhkr/IcSJXVZeN?= =?us-ascii?Q?z+ZmWM4qGG6SQIQsTtWu5xrl5MgB+bW5/U7q1eXM1zNMdktw3ixTm7gZ3NEf?= =?us-ascii?Q?Exu3XPFiGbOnCMrphopA1Z3L4vV7WJsnHeZ/5xozz63pUmPSOLdWgoM+syz0?= =?us-ascii?Q?zWa97/VMktCE59OCEM/8MOlvmxSJaVe9JFLu8KYLi3Cds8d0T8rYuot5LHPV?= =?us-ascii?Q?NSBvsmC5cgwzjfebW/R3cHDu419TUaxdBD8dKrmbvHb0xWGkvoOjlmfhUy2y?= =?us-ascii?Q?ljPiN5syPinTueQh+k9ubFJNrBM+xaPyVKi8CqGBpljbrEDPOJrMVJjlBocE?= =?us-ascii?Q?tHSgLJJZG2gnpreVxJJFzp9xYaf+JT16J3t736NIex6zD94VhG2/mVOwkDDM?= =?us-ascii?Q?/Sw77ZUSrPa6dDeaMmqlGMigTt3fMEofrROYhu49fGUoAWrMgTAEEGY+7Yn4?= =?us-ascii?Q?rN5PRvTYH2UDXX6crscSHdbVW/1BPUf3T5wnRyWL2fpeudsESXwncdD7Bfw6?= =?us-ascii?Q?qKNlpNFOVymrrjZ9yBBfzMZdkPier9Yk/Cr6HRmF5AsXN1q93KlMhNtD2OtI?= =?us-ascii?Q?QPIT+aZ+vRGtllISOsBuf7BjNZeSBY3xb/9s6aA+2rSTJByD+gF+FSaqdH3b?= =?us-ascii?Q?nJFcvAgVwh85tdlfutXdDu0jNHsgmYmFkF22FMGDKz1lyLb9tPp/KeLga+rF?= =?us-ascii?Q?Huil6F55i3S2+VO09N1brT7D3Y2GalYONjmw5qChZj9AfJACUNv8zQJfdNCl?= =?us-ascii?Q?JzdjrlDqIz/jNnkERL1YkJkbt7GPsU/HFoMIZVGADUbrMJ9A7Rrajc4qkrJt?= =?us-ascii?Q?j9pLXz8IxMF0fhjX7EnyA9MqWnJMWmzFSwrLJz4iZ3+nl9fpQU0uPtipzAtQ?= =?us-ascii?Q?WA7OxjUoJyNfj5PWxtalJ6/XP+2ecu+sA7QGG26DYhf597qq8Djb4Rj/+1bZ?= =?us-ascii?Q?EflDcR4dIva1xepziasP2aF0Nu+pPpzEcx+Unk4EUiWxOK2md4n2ajB/HJxn?= =?us-ascii?Q?ufo5Af4uX5o0wCEGF949rScIarTiGKVzdErrH5AKoLQ2GRwJAWLmacciENuc?= =?us-ascii?Q?7Rzv9tUlHYwQtXKY0QJozbw+xXYOAPFFsb9xKP1bjfjRmypklVv7UVL9iV7M?= =?us-ascii?Q?yPCxX61vCNyY5QF5c+u9+TDVWyXSsYEwslrvAv447l0vc3F0b5F8beKD08kq?= =?us-ascii?Q?GDGqWd65QiWWT+6mh6cL2l4DgO0Pc21UYtgM9O41ms40seufnxxbH4+VwUOP?= =?us-ascii?Q?76suLDnO8aZDZrXTHGbySmc1zRayUslHxGgWNr4OAWXMDedAOL0aWwotv5XB?= =?us-ascii?Q?voEM3wm8TKKUQACmessexHmqmmlzpi9kya4XeSYCixkPFR0NNvGgiIJt5dmP?= =?us-ascii?Q?0AAZ0ZjZcMTxKQHn0KBPKNBTbi1WtgE9ntEaqc1M9bbom+TfHw1955PX6YVw?= =?us-ascii?Q?yAvJe6Q40LU8oDTY/X3TheFrnnIYqbCExEv5eTyAg2oAgo1k/CBvtMFyGfBf?= =?us-ascii?Q?WhW648Ufc81ANDYooKW8CJp4vTglMUBNFsXwGAjN51WMyQe53Daa4jX8R+c+?= =?us-ascii?Q?jw+YdZLjVw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75f6ecba-6028-43d0-f998-08da527fd498 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2022 05:43:40.7153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tuz2/6U77DqLq/gYo8PdR9/8ra1dZ394zTaO99ex3sknLJsza+yWpRTgJk0e9yz0J+rWuENhGhuajR52stf3CA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5624 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Bruce Richardson > Sent: Friday, June 17, 2022 6:53 PM > [...] > > + if owner: > > + uid, gid =3D owner.split(':', maxsplit=3D1) > > + cmd +=3D ' -o uid=3D{},gid=3D{}'.format(uid, gid) >=20 > I'm not sure about forcing the user to always provide a "user:group" > format parameter. How about: >=20 > 1. checking initially for the presence of a ":" and if not present > just working with the uid parameter? > 2. alternatively, what about adding in separate parameters for user or > group, so they can be specified independently? Explicit is better than implicit, especially in security configuration. If you insist on changing, I prefer option 2 to clearly indicate what is configured and what is not.