From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Rasesh.Mody@cavium.com> Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0045.outbound.protection.outlook.com [104.47.37.45]) by dpdk.org (Postfix) with ESMTP id 6F7E5BC26 for <dev@dpdk.org>; Wed, 26 Oct 2016 19:01:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=031SVhwimZTJwyVFx3/qkvDj8mWrWuv3QnUD0vrLO2g=; b=VZ3C5FaOV82krz6yVo7ag5PNgi/nTUP5SXWHMbwixGLtm9IC5oP98GHWL7hNaf/kaPO7eMEivC7NfEr8IJ+AhPxesxImNMl30Z0+o9gTKbCJ9lbNdEPSbtMh+IPFujvOi7LhBaTzqbUZ+50bT1zFUGIKPSQsylJaypDo2rPurXs= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1569.namprd07.prod.outlook.com (10.163.84.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.12; Wed, 26 Oct 2016 17:01:08 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0679.015; Wed, 26 Oct 2016 17:01:08 +0000 From: "Mody, Rasesh" <Rasesh.Mody@cavium.com> To: Thomas Monjalon <thomas.monjalon@6wind.com>, Rasesh Mody <rasesh.mody@qlogic.com> Thread-Topic: [dpdk-dev] [PATCH v4 00/32] net/qede: update qede pmd to 1.2.0.1 and enable by default Thread-Index: AQHSL5x7ZDyG5mbBIk+8anP8F8//WqC67pdQ Date: Wed, 26 Oct 2016 17:01:08 +0000 Message-ID: <BLUPR0701MB15720A8FD1978C0BC30631309FAB0@BLUPR0701MB1572.namprd07.prod.outlook.com> References: <1476850306-2141-1-git-send-email-rasesh.mody@qlogic.com> <20161024134150.GB27760@bricha3-MOBL3.ger.corp.intel.com> <39933081.0D9pxCKPPb@xps13> In-Reply-To: <39933081.0D9pxCKPPb@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [173.186.134.106] x-ms-office365-filtering-correlation-id: 6768aac3-fd38-4407-92fb-08d3fdc1ae6c x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1569; 6:GKUzMNYiU13pfbgh9d/exg5/oO+T+Zbf33yh3z7cTPLM2AUlHmCELYbeyADRvQhH4Q270En98zj9Zdwi1T7AqoTsxc23MzF5MpCnEWvQJbZ6w4IjlSV8O01jUIs2FCfkcJdeTiiu1YO4uexPxERJlSHyC5MswfvRQRRGpBdwsNs1qQzRr6jSUUF5wsjBvT+zXKZneQ4RHWLcC5X7m8F/Atlko7FmZ21VVW5XP4DsdGHd2lTGJrytsTZCy7x3qtq2lfiQ/aiDQTRe6lXssIAkVJHSyG7yHc5SvuOM2dF5sHWlKJAH3ca4pEXx7+R1uibX; 5:+EhCc/955vhUk+FnnXVBPSx0j8XOMGX/x4nGCXBfXMrhvZOmm3SCRkErHNjtVT9nI6XqRybTPnjsY0ofUdP/YjiB5IvAPaZxHJT42t/Nic0snNZwSjj+fD2nSPKAdtV1bmX4N19RMZV746EnM8x8zA==; 24:2g4Kl5UD0+yAT7P5poW1syx2KQ4xZ+pTkp7Vaz6LxruF/5wpt1CuW3CAuL3oCGrwkVYo9btlQ9K0wuPIFAgBpJsk7AAp+M7vsekXfWBrwtw=; 7:5GEH/ddJixN9EvB/dBNt5S8uafHdJY+GEY6JXuyGGn31igOmA76mdV8k2tCP58bgLuEl+NWYG9yJaDnNIGgh0SSdQOTSbm71pkB+/gZY6jbMLzBpXMI4/KJ5PowW20X5Kz+C2C2RJcM79urz0emVQWAM6EJQR63LQ0LItwSYCKOwz9kuirMVrTSmGq5TUPxBLEJAnPemYzpl8PTkaXEeWzYEc0jIVSaoiO6GnX557LG07LcAX06D98CyTnh7Eci2O2cXTXfA5JWkz27dzx1Wd2wN4LCPjDJCv0mP7hrwMR4rIysRJo+sLYs0U7AGKMq2W1UYTjHNOATlZ9lio/cTkFGOKSwMupWAWPZFOmtTXRM= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1569; x-microsoft-antispam-prvs: <BLUPR0701MB15690B3524F180DCE3144D249FAB0@BLUPR0701MB1569.namprd07.prod.outlook.com> x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BLUPR0701MB1569; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1569; x-forefront-prvs: 0107098B6C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377424004)(199003)(377454003)(189002)(24454002)(2900100001)(101416001)(76576001)(77096005)(76176999)(9686002)(2950100002)(87936001)(5660300001)(19580405001)(99286002)(7846002)(105586002)(305945005)(106116001)(74316002)(86362001)(106356001)(122556002)(7736002)(54356999)(66066001)(50986999)(7696004)(3660700001)(3280700002)(2906002)(4326007)(33656002)(11100500001)(5001770100001)(97736004)(5002640100001)(10400500002)(6116002)(102836003)(8936002)(68736007)(92566002)(19580395003)(81166006)(586003)(81156014)(189998001)(3846002)(4001150100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1569; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2016 17:01:08.3738 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1569 Cc: "dev@dpdk.org" <dev@dpdk.org>, "Dept-EngDPDKDev@qlogic.com" <Dept-EngDPDKDev@qlogic.com>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com> Subject: Re: [dpdk-dev] [PATCH v4 00/32] net/qede: update qede pmd to 1.2.0.1 and enable by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 26 Oct 2016 17:01:11 -0000 Hi Thomas, > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, October 26, 2016 8:20 AM >=20 > 2016-10-24 14:41, Bruce Richardson: > > On Tue, Oct 18, 2016 at 09:11:14PM -0700, Rasesh Mody wrote: > > > Please apply to DPDK tree for v16.11 release. > > > > Patchset applied to dpdk_next_net/rel_16_11 >=20 > It breaks compilation because it is enabled everywhere and zlib.h is stil= l > included without checking CONFIG_ECORE_ZIPPED_FW. > The patch removing zlib dependency was not tested without zlib installed. > I will fix it while applying with this change: Sorry, we missed to test the patch removing zlib dependency from latest pat= ch set when zlib headers are unavailable. The zlib.h include is not needed in bcm_osal.c. It got left out there when = zlib.h was included in ecore.h file by patch "[PATCH v4 03/32] net/qede: us= e FW CONFIG defines as needed". In ecore.h it is protected by ifdef, howeve= r, same is not true about bcm_osal.c. Hence compilation complains when zlib= .h is not available. --- a/drivers/net/qede/base/bcm_osal.c +++ b/drivers/net/qede/base/bcm_osal.c @@ -6,8 +6,6 @@ * See LICENSE.qede_pmd for copyright and licensing details. */ -#include <zlib.h> - #include <rte_memzone.h> #include <rte_errno.h> > --- a/drivers/net/qede/base/bcm_osal.c > +++ b/drivers/net/qede/base/bcm_osal.c > @@ -6,7 +6,9 @@ > * See LICENSE.qede_pmd for copyright and licensing details. > */ >=20 > +#ifdef CONFIG_ECORE_ZIPPED_FW > #include <zlib.h> > +#endif >=20 > #include <rte_memzone.h> > #include <rte_errno.h> >=20 Above change looks fine. Thanks! =20 > I won't do any quality review of qede patches but from what I've seen > before, there is some room for improvements. >=20 > Another nit, important to help reviews, please use --in-reply-to when > sending a new revision of a patch to keep them in the same thread and all= ow > us to understand the progress. > I plan to do an automatic nack for patches missing the --in-reply-to. Sure, will do. Thanks! -Rasesh