From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Rasesh.Mody@cavium.com> Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0041.outbound.protection.outlook.com [104.47.38.41]) by dpdk.org (Postfix) with ESMTP id DF5193277 for <dev@dpdk.org>; Tue, 28 Mar 2017 23:04:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ottCpD5VSiUmyNkVDN+342REBmZB3AkCaTSO6dSYOkY=; b=hMb28h2FFAmK6MoB6KLKfYmxsOO/Aiq7q1N02r7s1vdynPHDSidZ+TdzJTz0xD5wWdNxdpX5qETociXMY2gJ7aEVmpaC1zHT0vOF9KNe0Jk2Sk8ixZLXJvkMDq6qcCygGjlcYwoFpBuabi3UxKHi+hBeL3CfzP5gjKUbIejln0s= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by CY1PR0701MB1259.namprd07.prod.outlook.com (10.160.149.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14; Tue, 28 Mar 2017 21:04:23 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0991.020; Tue, 28 Mar 2017 21:04:21 +0000 From: "Mody, Rasesh" <Rasesh.Mody@cavium.com> To: Ferruh Yigit <ferruh.yigit@intel.com>, "Patil, Harish" <Harish.Patil@cavium.com> CC: Bruce Richardson <bruce.richardson@intel.com>, Thomas Monjalon <thomas.monjalon@6wind.com>, DPDK <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v7 1/7] qede: add base driver Thread-Index: AQHSD+6XSWTV7QUsSkmcnvnEK3erGaGrSY8AgAB989A= Date: Tue, 28 Mar 2017 21:04:21 +0000 Message-ID: <BLUPR0701MB1572A1118B7B8CF3248EAD899F320@BLUPR0701MB1572.namprd07.prod.outlook.com> References: <1461766722-7745-1-git-send-email-rasesh.mody@qlogic.com> <1461766722-7745-2-git-send-email-rasesh.mody@qlogic.com> <225ecab3-f6af-afaa-ec13-4f53d3f3b566@intel.com> In-Reply-To: <225ecab3-f6af-afaa-ec13-4f53d3f3b566@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-microsoft-exchange-diagnostics: 1; CY1PR0701MB1259; 7:wVLAwdGAgwcgDEkvt14pb2TART4/5aMsqNOhNjjmWn7MGe45tDwqv2Llrl53fQpTpWtmlQerkjmwu47TFhP33cFq4tAkQ6RitC6Aif5bpVUEQYBFq0F9ME39SKtGAMMvSYemUAqKF3XavqvfxLrCO8AWxuSfJuECNd1Cr+zgUnRXKv9PEuFuvzOtZFHuLr12NgaXQuaPtyzbQbwCP2K+faoxljsdLq4Kkftp4bDIsa2CG7oalcu/wTs5DSm5KxraMy3X9BUzX0JqUFbj1HZdcPDxf37U68x2O0Cxdp3SqiVk/jj1rbYQlEM9113W5hzTkGxwaUxEtO1/RzkfRB7xjw== x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(39400400002)(39850400002)(39410400002)(39840400002)(39450400003)(377454003)(24454002)(122556002)(77096006)(53936002)(66066001)(38730400002)(2906002)(6506006)(81166006)(99286003)(3660700001)(53546009)(25786009)(3280700002)(86362001)(54906002)(8676002)(6436002)(9686003)(55016002)(4326008)(54356999)(6116002)(3846002)(6636002)(189998001)(33656002)(102836003)(74316002)(8936002)(305945005)(7736002)(5660300001)(229853002)(76176999)(50986999)(2950100002)(2900100001)(7696004)(6246003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1259; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; x-ms-office365-filtering-correlation-id: 24179947-b370-4a17-4171-08d4761e01be x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423066)(201703031133072); SRVR:CY1PR0701MB1259; x-microsoft-antispam-prvs: <CY1PR0701MB1259EDD61D83C0CA10C06F999F320@CY1PR0701MB1259.namprd07.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040441)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(201703131423066)(201702281528066)(201703061421066)(201703061406066)(20161123560025)(20161123564025)(20161123558025)(20161123562025)(20161123555025)(6072148); SRVR:CY1PR0701MB1259; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1259; x-forefront-prvs: 0260457E99 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2017 21:04:21.5073 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1259 Subject: Re: [dpdk-dev] [PATCH v7 1/7] qede: add base driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 28 Mar 2017 21:04:25 -0000 Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Tuesday, March 28, 2017 4:16 AM >=20 > On 4/27/2016 3:18 PM, rasesh.mody at qlogic.com (Rasesh Mody) wrote: > > The base driver is the backend module for the QLogic FastLinQ QL4xxxx > > 25G/40G CNA family of adapters as well as their virtual functions (VF) > > in SR-IOV context. > > > > The purpose of the base module is to: > > - provide all the common code that will be shared between the various > > drivers that would be used with said line of products. Flows such as > > chip initialization and de-initialization fall under this category. > > - abstract the protocol-specific HW & FW components, allowing the > > protocol drivers to have clean APIs, which are detached in its > > slowpath configuration from the actual Hardware Software > Interface(HSI). > > > > This patch adds a base module without any protocol-specific bits. > > I.e., this adds a basic implementation that almost entirely falls > > under the first category. > > > > Signed-off-by: Harish Patil <harish.patil at qlogic.com> > > Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com> > > Signed-off-by: Sony Chacko <sony.chacko at qlogic.com> >=20 > <...> >=20 > > diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile new > > file mode 100644 index 0000000..febd41d > > --- /dev/null > > +++ b/drivers/net/qede/Makefile > > @@ -0,0 +1,81 @@ > <...> > > + > > +# > > +# Add extra flags for base ecore driver files # to disable warnings > > +in them # # BASE_DRIVER_OBJS=3D$(patsubst %.c,%.o,$(notdir $(wildcard > > +$(SRCDIR)/base/*.c))) $(foreach obj, $(BASE_DRIVER_OBJS), $(eval > > +CFLAGS+=3D$(CFLAGS_BASE_DRIVER))) >=20 > My eyes just caught this one, above line adds $(CFLAGS_BASE_DRIVER) > many times to $(CFLAGS), but real intentions is add to obj specific CFLAG= S > and only being limited to base files. >=20 > Like: > $(foreach obj, $(BASE_DRIVER_OBJS), $(eval > CFLAGS_$(obj)+=3D$(CFLAGS_BASE_DRIVER))) >=20 > Can you please fix this? We will look into this, we plan to submit the fix as separate bug fix patch= in 17.05 timeframe. Thanks! -Rasesh >=20 > Fixing this may give some build errors on non-base driver files, although= not > sure. >=20 > Thanks, > ferruh >=20 > > + > > +# > > +# all source are stored in SRCS-y > > +# > > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D base/ecore_dev.c > > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D base/ecore_hw.c > > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D base/ecore_cxt.c > > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D > base/ecore_sp_commands.c > > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D > base/ecore_init_fw_funcs.c > > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D base/ecore_spq.c > > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D base/ecore_init_ops.c > > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D base/ecore_mcp.c > > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D base/ecore_int.c > > +SRCS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D base/bcm_osal.c > > + > > +# dependent libs: > > +DEPDIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D lib/librte_eal > > +lib/librte_ether > > +DEPDIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D lib/librte_mempool > > +lib/librte_mbuf > > +DEPDIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) +=3D lib/librte_net > > +lib/librte_malloc > > + > > +include $(RTE_SDK)/mk/rte.lib.mk >=20 > <...>