From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Rasesh.Mody@cavium.com> Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0089.outbound.protection.outlook.com [104.47.33.89]) by dpdk.org (Postfix) with ESMTP id CC5E36A95 for <dev@dpdk.org>; Tue, 11 Oct 2016 01:32:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uwcnocSKW9b1jqUeL5h7AcjnMo1CMaIQqvfvZfKZHKQ=; b=c+LUXjGhFTjh1ZzNvmVNUq5wT7USmNkRjXmyCTWQqt3+Uj0jeenkxO1a3g6JsbtKc3PHbZstUthozgXMh0LLXU/jxRemK/hze34QKhepRDNeYZUGu8ne8utNg+jc4zB+YgCepjj5D3cSkZ0gXwMNeweetih4LvzTTLYY+gz7hEk= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1571.namprd07.prod.outlook.com (10.163.84.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Mon, 10 Oct 2016 23:31:59 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0659.020; Mon, 10 Oct 2016 23:31:59 +0000 From: "Mody, Rasesh" <Rasesh.Mody@cavium.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> CC: Ferruh Yigit <ferruh.yigit@intel.com>, Rasesh Mody <rasesh.mody@qlogic.com>, "dev@dpdk.org" <dev@dpdk.org>, "Dept-EngDPDKDev@qlogic.com" <Dept-EngDPDKDev@qlogic.com>, Bruce Richardson <bruce.richardson@intel.com> Thread-Topic: [dpdk-dev] [PATCH v2 04/22] qede/base: update base driver Thread-Index: AQHSGulJfPs5Zag8IEai9RKYC1uotKCSPiAAgAAXReCAB8AHAIAIL4Ow Date: Mon, 10 Oct 2016 23:31:59 +0000 Message-ID: <BLUPR0701MB1572ABF24E93E04067A57F579FDB0@BLUPR0701MB1572.namprd07.prod.outlook.com> References: <1475219169-8774-1-git-send-email-rasesh.mody@qlogic.com> <1ac6d74c-cc78-4efd-275c-9645952fb8a0@intel.com> <BLUPR0701MB157207202A7D8EB817D33DA59FC10@BLUPR0701MB1572.namprd07.prod.outlook.com> <2423952.d1lHHhMD9K@xps13> In-Reply-To: <2423952.d1lHHhMD9K@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [173.186.134.106] x-ms-office365-filtering-correlation-id: 48450a00-d6e4-48c1-4d1e-08d3f165a1cc x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1571; 6:6y4ae3GrAB/0hSO0Yp5QNzPQvuwBefJb7I+Y4HD7tZZeTTouG/yfDENbL2wMjYWOh6bGphRPHtGV5z4knxFJOIeyvdMtoUzrWtC+dvRwQiJXaOkXNFmtSFvvzuwjLMtThmwpi17d+w8GMQ1203SxOkYWjikJ4sr//B6qOoLQ1S8mxqLqCdzogqhE9pL1zPIvHwD7HVUE1ptn+kv+0tejKalOtlpUCmBVmME6b8+sAUnO7hgITMCJuqLilZL9hZeMrHW6tAbop9RNBelpN7DJu2hUQvIsO7CZY+X/2d3d7rCN1xCT3827BhlAzHl/Qvds; 5:juVJcvgQ7MhF4npuemZn2EX7R5r7poqQrHeBFzYgyUHfn0mV/Hnx93jdJ3Q38+xS08p1hAQJJchvWcKKi8FjEVPGg9Wr4wxLYB0D3cDuatN2a9szJjx6I23dXHwl0mZfPgJCGh1GBm07ijQM2AZLJw==; 24:fot0V1PqbAqS1DUrB5OgHAH+NdBv2IzCdG0FwAF20ojZk5X0QIsfwb+Z5fjwit191WwnSX3XhCtsB9MBn+tIMG+WCNRJ4nKQNyK3+lOBzEo=; 7:wLsKuKn+pg5dmz4kecRuf0ItMrnFKLs+XthkIc8vaZeK9tdopk0gx8733hrhHDEpBcVVfii8C2dbKa6iDGSGlpMcKkWs7YeSkR84elRghKIwA8fYhR7WL4qZ+YXSiNGHq4KNP336NDtuuMXuoswseoZ8xYtxcJet5ryMOFKqsHoqK9J53z+XUb4Vq9nPQBmZsy8zrRhWZcSpdQufvMUUUCDAdrEYmzLokczetUg8EYtx1zuSd7pB5r5PvWuir82N/7HbKEK8EsmjbKuNcsSnfjUTHhCSkwvjd3/Tkc9ky0ddMdjSEuJ74xJ85JIx2HZObiXwu702pBWoNxmEC1YkvuYqXxRQdFz9lPMo+wKj3Ws= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1571; x-microsoft-antispam-prvs: <BLUPR0701MB1571EA89B1E865DAF15E68299FDB0@BLUPR0701MB1571.namprd07.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BLUPR0701MB1571; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1571; x-forefront-prvs: 0091C8F1EB x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377424004)(377454003)(199003)(189002)(33656002)(122556002)(86362001)(76576001)(7696004)(10400500002)(87936001)(5002640100001)(9686002)(15650500001)(345774005)(5660300001)(2950100002)(8676002)(6916009)(81156014)(81166006)(68736007)(305945005)(189998001)(7736002)(8936002)(74316002)(97736004)(54356999)(76176999)(66066001)(3660700001)(6116002)(77096005)(93886004)(7846002)(2906002)(19580395003)(92566002)(50986999)(19580405001)(106116001)(11100500001)(101416001)(106356001)(99286002)(586003)(105586002)(3846002)(110136003)(4326007)(3280700002)(2900100001)(102836003); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1571; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2016 23:31:59.2678 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1571 X-Mailman-Approved-At: Tue, 11 Oct 2016 09:41:32 +0200 Subject: Re: [dpdk-dev] [PATCH v2 04/22] qede/base: update base driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 10 Oct 2016 23:32:02 -0000 Hi Ferruh, Thomas, > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, October 05, 2016 9:29 AM >=20 > 2016-09-30 18:40, Mody, Rasesh: > > > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] Thank you for the > > > update, base driver patch update now reduced from > > > "14653 insertions(+), 8536 deletions(-)" to > > > "10857 insertions(+), 4853 deletions(-)" > > > > > > But this is still to big for reviewing, specially there are some low > > > hanging fruits for cleanup, like big chunk of comment updates or > > > whitespace updates or non base driver codes in the patch. > > > > > > If the expectation is that somebody non maintainer review the code, > > > understand it and highlight any possible defects, I believe this > > > patch is too big and needs to be split more into logical pieces, but > > > since this is a driver code and a little special, and it may not be > > > possible to completely understand the code without knowing > > > underlying hardware, I am not sure how to proceed and adding Bruce an= d > Thomas to cc for guidance. >=20 > As you said it makes contribution really hard. > So it is missing the point of sharing its source code in Open Source. >=20 > > This 8.10.x.x base driver is a common code shared by multiple drivers. = It has > gone through extensive testing. > > We have split the base driver patch into smaller logical patches. It wo= uld be > difficult to split this patch further. >=20 > Please check how Intel updates its base drivers and try harder. > We all know it requires some time, but it provides a valuable knowledge > base. We are working on the feedback and will be submitting the edited patch set = this week as soon as they are ready. Thanks! Rasesh=20