From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Rasesh.Mody@cavium.com>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0046.outbound.protection.outlook.com [104.47.32.46])
 by dpdk.org (Postfix) with ESMTP id 20CE3475D
 for <dev@dpdk.org>; Wed, 19 Oct 2016 15:46:18 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=CG0TU3mLNkVEln8bFEiDMbJeLdFMFPiGdjgN7703avw=;
 b=H677wSX9cbSLhv3oKN08KyWIqzT+4FuiCKk6zev2KD4ufE1IBdQPRdriDgwWy2aDXekOsYawqWWTa00KMvSq43JaJFIWXTj00RCc+5cfQ2BWS63+yL6g2oJyYP/2gOJrZ0XIQrxi+9EX0i+LUM8BB2qDqxhW90tcSuI8JUsdidY=
Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by
 BLUPR0701MB1570.namprd07.prod.outlook.com (10.163.84.144) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id
 15.1.659.11; Wed, 19 Oct 2016 13:46:16 +0000
Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by
 BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with
 mapi id 15.01.0659.025; Wed, 19 Oct 2016 13:46:16 +0000
From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Rasesh Mody
 <rasesh.mody@qlogic.com>, "thomas.monjalon@6wind.com"
 <thomas.monjalon@6wind.com>, "bruce.richardson@intel.com"
 <bruce.richardson@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Dept-EngDPDKDev@qlogic.com"
 <Dept-EngDPDKDev@qlogic.com>
Thread-Topic: [dpdk-dev] [PATCH v4 04/32] net/qede/base: add HSI changes and
 register defines
Thread-Index: AQHSKb8QE8LCzVW2NUesvwxatc3/p6Cvt60AgAANxFA=
Date: Wed, 19 Oct 2016 13:46:16 +0000
Message-ID: <BLUPR0701MB1572D45BF6E2749D57F9F5DE9FD20@BLUPR0701MB1572.namprd07.prod.outlook.com>
References: <1476850306-2141-1-git-send-email-rasesh.mody@qlogic.com>
 <1476850306-2141-5-git-send-email-rasesh.mody@qlogic.com>
 <e20fca51-a554-8aa7-40e8-569e1a9ae575@intel.com>
In-Reply-To: <e20fca51-a554-8aa7-40e8-569e1a9ae575@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=Rasesh.Mody@cavium.com; 
x-originating-ip: [50.152.202.100]
x-ms-office365-filtering-correlation-id: 1ed0caca-137a-4a3b-ecff-08d3f8264c70
x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1570;
 6:1ghavcdHzBhi09I6RJelRP/SrcpnEQ9bmxtA+YX5cTtf1TOdka12Bd8B4mAUcGjCoOqd8ozR5oIwE0hXlU68RKUS3m1WxxiDDc3XW+gHmytv0zLuRhhJv75SZbidex+dmhG0uHPSJ5XJ8nnUBmT7vYEFQ4kpEcqLxU4WcYLqYxRAFciL9RmnrZURhl0KMIZt+b0diP5LWsrat5EfAJLZxypBA5rxSXjrbXcpNSGYB/+wIffHnA7tQp3Msf8dPtDMEnocalYAsjEdO/f73Zb0EMT++xH+cT/rd1zzEn0sCj4Vg/h9DSW8rvJLaRf8EvLv;
 5:fUZC9xQgYbHekazH04S4O1d13uzlJmZKCj++6KnWSqoflnFwQ+WIda6OtSaMfFWMIMxoR0bqgIaXuNhohFTCWBSuFPY6JRlh8z44zGGAyrT2dUWoXZdIbVWix/IuX0iBH3knzwuALFE4Q0hwCNRXIA==;
 24:tj9UXv1Re2xI/59XQaXqs6QRlQfET62y5IxRDWnG18FdGbst4JXwjTVbwRoOOfmI44ufgb8lAYZct+5JusBjlr+2OfXK88A5fl2O3ZersfQ=;
 7:tQ7PdHg7eUwFrHKbI2zxcJP36jVV7+bgxrF65OolO+ZxoGSjh6ncmRdTLKrWZYxa/RHv7Tc5AMSo/FZH3lfG/0sO6uq6NbbYwTIjd1nj5X0378JOCP9ySdlmyg0xAn5a3UMTnkGGijO5ae0FQDA3VaO6P53YtT3Wfv6FDVtLkxl8fgDF6DDiFoxt8YdUwiyMkTQT/AVYtcMEdJ7A1QxOwVkFSeF+/WXq7LHUYlZuqjLnayVnCXE12/Rdeu1nMsjef5SaAjYEQVeov9ERoqP71WUVuvkDFEEF3IF37PxFYlpKFhSvCBMhXAfIdCDeXYuAEaYUtKIzPVWzjMz6Kg1tWSxlJUjmJMyECFasv2zSVPE=
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1570;
x-microsoft-antispam-prvs: <BLUPR0701MB15703BFA1C14139602E1F8499FD20@BLUPR0701MB1570.namprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(228905959029699);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
 RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);
 SRVR:BLUPR0701MB1570; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1570; 
x-forefront-prvs: 0100732B76
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(6009001)(7916002)(199003)(189002)(24454002)(43544003)(377454003)(99286002)(8936002)(19580395003)(5001770100001)(92566002)(2501003)(122556002)(189998001)(2900100001)(102836003)(3846002)(81166006)(305945005)(7736002)(586003)(66066001)(33656002)(3280700002)(68736007)(87936001)(2906002)(7696004)(3660700001)(9686002)(6116002)(2201001)(76176999)(4326007)(54356999)(2950100002)(7846002)(5660300001)(8676002)(50986999)(11100500001)(81156014)(106356001)(76576001)(97736004)(106116001)(77096005)(19580405001)(5002640100001)(101416001)(105586002)(86362001)(10400500002)(74316002);
 DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1570;
 H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords;
 A:1; MX:1; LANG:en; 
received-spf: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cavium.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2016 13:46:16.2194 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1570
Subject: Re: [dpdk-dev] [PATCH v4 04/32] net/qede/base: add HSI changes and
 register defines
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Oct 2016 13:46:18 -0000

Hi Ferruh,
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Wednesday, October 19, 2016 5:38 AM
> To: Rasesh Mody <rasesh.mody@qlogic.com>;
> thomas.monjalon@6wind.com; bruce.richardson@intel.com
> Cc: dev@dpdk.org; Dept-EngDPDKDev@qlogic.com
> Subject: Re: [dpdk-dev] [PATCH v4 04/32] net/qede/base: add HSI changes
> and register defines
>=20
> On 10/19/2016 5:11 AM, Rasesh Mody wrote:
> >  - add the hardware software interface(HSI) changes
> >  - add register definitions
> >
> > These will be required for 8.10.9.0 FW upgrade.
> >
> > Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
>=20
> <...>
>=20
> >  /*
> >   * Igu cleanup bit values to distinguish between clean or producer
> consumer
> >   */
> > @@ -1376,7 +1572,7 @@ struct dmae_cmd {
> >  	__le32 src_addr_hi;
> >  	__le32 dst_addr_lo;
> >  	__le32 dst_addr_hi;
> > -	__le16 length /* Length in DW */;
> > +	__le16 length_dw /* Length in DW */;
>=20
> This cause a compilation error [1] in patch by patch compilation, when de=
bug
> is enabled. Fix seems straightforward [2].
>=20
> Do you confirm the fix?
> If you confirm, you don't need to send a new version, fix can be applied
> while getting the patch.

Please apply the fix [2] while getting the patch. The error [1] is due to d=
ebug option not enabled for individual patch compilation. We did test after=
 applying entire series with all the config options enabled.
For our upcoming submissions, we'll take care of enabling the debug option =
when compile testing all the patches individually.
=20
Thanks!
-Rasesh

>=20
> Thanks,
> ferruh
>=20
>=20
> [1]:
> =3D=3D=3D=3D
> In file included from .../drivers/net/qede/base/ecore.h:36:0,
>                  from .../drivers/net/qede/base/ecore_hw.c:12:
> .../drivers/net/qede/base/ecore_hw.c: In function
> 'ecore_dmae_post_command':
> .../drivers/net/qede/base/ecore_hw.c:478:20: error: 'struct dmae_cmd'
> has no member named 'length'; did you mean 'length_dw'?
>       (int)p_command->length,
>                     ^
> .../drivers/net/qede/base/../qede_logs.h:47:11: note: in definition of ma=
cro
> 'DP_VERBOSE'
>          ##__VA_ARGS__); \
>            ^~~~~~~~~~~
> .../mk/internal/rte.compile-pre.mk:138: recipe for target 'base/ecore_hw.=
o'
> failed
>=20
>=20
> [2]:
> =3D=3D=3D=3D
> diff --git a/drivers/net/qede/base/ecore_hw.c
> b/drivers/net/qede/base/ecore_hw.c
> index 72bc6de..5412ed1 100644
> --- a/drivers/net/qede/base/ecore_hw.c
> +++ b/drivers/net/qede/base/ecore_hw.c
> @@ -475,7 +475,7 @@ ecore_dmae_post_command(struct ecore_hwfn
> *p_hwfn, struct ecore_ptt *p_ptt)
>                    "len=3D0x%x src=3D0x%x:%x dst=3D0x%x:%x\n",
>                    idx_cmd, (u32)p_command->opcode,
>                    (u16)p_command->opcode_b,
> -                  (int)p_command->length,
> +                  (int)p_command->length_dw,
>                    (int)p_command->src_addr_hi,
>                    (int)p_command->src_addr_lo,
>                    (int)p_command->dst_addr_hi, (int)p_command->dst_addr_=
lo);
>=20