From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0121.outbound.protection.outlook.com [104.47.32.121]) by dpdk.org (Postfix) with ESMTP id B9B615958 for ; Tue, 5 Jul 2016 20:10:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qlgc.onmicrosoft.com; s=selector1-qlogic-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=d56OOf7lUZUl5RTzgOeQ8bji90Dxkn3WeJXJEP5ESb0=; b=GuJNSXcaGcriPsHxZ4EKDHa3Y5lrgYHYN3qdSMvFMZKUFxzYCSnuOtElCqHcZogT0bMEiprv9JvhqRJzYOPijfLTslmgUjWgr3XevkP5ku/bb93X9Q1UhlgzHLDsNIo18uOjYUpLtd4sJWsDJlu3rCHUb4J6mDThFywfotczAS8= Received: from BLUPR11MB0370.namprd11.prod.outlook.com (10.162.91.11) by BLUPR11MB0371.namprd11.prod.outlook.com (10.162.91.12) with Microsoft SMTP Server (TLS) id 15.1.534.14; Tue, 5 Jul 2016 18:10:06 +0000 Received: from BLUPR11MB0370.namprd11.prod.outlook.com ([10.162.91.11]) by BLUPR11MB0370.namprd11.prod.outlook.com ([10.162.91.11]) with mapi id 15.01.0534.015; Tue, 5 Jul 2016 18:10:07 +0000 From: Rasesh Mody To: Remy Horton , Thomas Monjalon CC: "dev@dpdk.org" , Olivier MATZ Thread-Topic: [dpdk-dev] xstats performance Thread-Index: AQHR0hyDgcdo+/1aRkGeWCiordEWf6AAm18AgAAKMgCAAqhsgIABAemw Date: Tue, 5 Jul 2016 18:10:06 +0000 Message-ID: References: <5773EB79.1090509@6wind.com> <8870166.MVVViF2IlQ@xps13> <99e03d76-b896-2146-274c-2f3d83eee899@intel.com> In-Reply-To: <99e03d76-b896-2146-274c-2f3d83eee899@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasesh.mody@qlogic.com; x-originating-ip: [2601:646:8180:be50:3915:14f8:b977:fb3a] x-ms-office365-filtering-correlation-id: 63ee9a8d-8ce2-41e8-ab05-08d3a4ff987f x-microsoft-exchange-diagnostics: 1; BLUPR11MB0371; 20:Yj3MWqfYsiLK/Jy1Gz8RVOpvk3wYGoty3pZaHQyRcvFk/gSZYtEEC+CHahqpbp/wWNZuxsTdv6tzbDCJwM6X2aa1/AXjZmCQlUFonEPEBI+RbgUATqfZJr8gXlq3JOkZym8FAVGwlimfQ5gHmc3pSUufOSY28jGJgqnF+uHjn5s= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR11MB0371; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:BLUPR11MB0371; BCL:0; PCL:0; RULEID:; SRVR:BLUPR11MB0371; x-forefront-prvs: 0994F5E0C5 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(199003)(377454003)(189002)(24454002)(106116001)(5002640100001)(81156014)(102836003)(92566002)(19580405001)(81166006)(6116002)(2950100001)(74316002)(2900100001)(19580395003)(87936001)(106356001)(101416001)(76176999)(8676002)(4326007)(54356999)(586003)(7696003)(86362001)(10400500002)(5003600100003)(122556002)(7846002)(7736002)(50986999)(3660700001)(77096005)(33656002)(9686002)(97736004)(76576001)(5001770100001)(3280700002)(93886004)(99286002)(189998001)(8936002)(68736007)(105586002)(2906002)(305945005)(3826002); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR11MB0371; H:BLUPR11MB0370.namprd11.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: qlogic.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2016 18:10:06.8448 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR11MB0371 Subject: Re: [dpdk-dev] xstats performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 18:10:09 -0000 Hi Remy, > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton > Sent: Friday, July 01, 2016 2:15 AM >=20 >=20 > On 29/06/2016 17:40, Thomas Monjalon wrote: > [..] > > I don't think it is possible to standardize stats ids, for two reasons: > > - it is hard to maintain and avoid conflicts between drivers > > - the drivers would have to lookup the names which degrades > > performance >=20 > I designed it that way to keep flexibility down the line rather than spec= ifically > for the above use-case. >=20 >=20 > > I think the idea of Olivier would improve the performance of stats retr= ieval, > > which was the idea of this rework :) > > Unfortunately we need someone available to fix it quickly for RC2. >=20 > For all the current drivers xstats_names[idx].id=3D=3Didx so it would jus= t > involve removing the references to the id field and updating the > documentation. Complication is coordinating with QLogic for the bnx2x & > qede xstats patches. We could incorporate this change in our re-submission. =20 > ..Remy