From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F004A00BE; Mon, 20 Dec 2021 11:21:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3E5B40040; Mon, 20 Dec 2021 11:21:35 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 33A234003C for ; Mon, 20 Dec 2021 11:21:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639995693; x=1671531693; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=z3mk2QIhigbAw1z9XU0FPZjCVN58bifzMPWu50x1C5k=; b=XCuSZ6Pq7gfHAV5WaZ5r7rHUY20drG4IBh93+zlR+X370QJVn1no4UsE K/SUw8jAFX7n1fDl403+GXFVLqaO0zimhUQmAgJOObiUMXRpfi3VSYQj4 BSfYdNVinMaj5Uw+X0GTX2uEHNibR2uaHWbtgDS8MDUZLzhzDqPRxEnEj dX/NVhmgcl5TCIocLiV+6+KE+6kVC0An6xluZjO/YXCm/DLaZfv1ayCFz 97wcwXCY4v1q4IiSNpZ3SoV1s6uNWwpRcHpb74GLN3R7djVtr1Xmrqqpk MHhMthJO6FcAhkTK4YFFQPIFwjJCfMP5UTGMF/o7IBDxhmrAzOfsGclt+ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10203"; a="220150656" X-IronPort-AV: E=Sophos;i="5.88,220,1635231600"; d="scan'208";a="220150656" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2021 02:21:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,220,1635231600"; d="scan'208";a="757245638" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 20 Dec 2021 02:21:31 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec 2021 02:21:30 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 20 Dec 2021 02:21:30 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 20 Dec 2021 02:21:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=me3Zi98XPPGUPrAFZPq3zmFUsJGLPYA40qcYgz5kHsVw5B3jK7gDSEDyG/1G5S66aXfrWLDaML3FEe+CUxRvX++fwr6jqRh8ZQ8SbogD+cpDXXFHJ1Qkdb6J0PbCP0ng+hQNJn8abg4OJRzR3W+M8G/l0IGTEJwwHvA33G327Khg4DTKVKlXAe9E2MLyDwXe5aRBWLttwtvB6UdqPBHGvuCcfJEK1SuRDP9FWwSj2I87NiwtRIzGHlS5HLPHZqc1Qk2vEonLBfrK+QM5w/+aVeUxb8Wb6szZAS777oLavkwwomN6CD3t9OvJHAvaxOkRhr0e8jXSZ5ZUTc4+bi5TiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fXbc/6N3TuBFO/PKc4Ax5fGyLlo8qhgbw0NmzKZiv+o=; b=SflfwdpawbIp+U/3v5dy53oN1i+nyggK73rNbPnI+fjOQ+XTtcGsk2L1X5o4StNtx45+zP6JOD9IkG4MROEiyDP4PVTZ50+q9DOgGIxTwfFvyXTF5msBeDQsiGgEVkb4YKvHtNEZzPODzlP6eTHGWmVMmCiCV4zJR7igSEoz9gWlb3Pk7mUZhNyk5E/ApZApcQNVT+gnbFKheAhIr1bvR6jnBvxk9/dsl1s8Qa4/qVVb1mlggiojf/NXmhUavKmflLPLm3kcZB/4RKIGP8oXKe3Fi7DMYj9q6rhZsTppguGbfXdzsf42rBWjCCzyRDHfKSVh6dT6GfRwdk6qqKbNxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN0PR11MB5712.namprd11.prod.outlook.com (2603:10b6:408:160::17) by BN8PR11MB3843.namprd11.prod.outlook.com (2603:10b6:408:88::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Mon, 20 Dec 2021 10:21:28 +0000 Received: from BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::343c:58e8:2190:8e7d]) by BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::343c:58e8:2190:8e7d%4]) with mapi id 15.20.4801.020; Mon, 20 Dec 2021 10:21:28 +0000 From: "Van Haaren, Harry" To: Thomas Monjalon , "Randles, Ronan" CC: Jerin Jacob , "dev@dpdk.org" , "Richardson, Bruce" Subject: RE: [PATCH 05/12] gen: add raw packet data API and tests Thread-Topic: [PATCH 05/12] gen: add raw packet data API and tests Thread-Index: AQHX8PS2vuKotAJBk0+65GoyaSBuEKwzgAAAgAMOMTCAAFOYAIAERw+A Date: Mon, 20 Dec 2021 10:21:28 +0000 Message-ID: References: <20211214141242.3383831-1-ronan.randles@intel.com> <6332947.G0QQBjFxQf@thomas> In-Reply-To: <6332947.G0QQBjFxQf@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 45420fb6-44f2-4696-c900-08d9c3a27bf5 x-ms-traffictypediagnostic: BN8PR11MB3843:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yFZ+Y+MS0q9K782vT9pCayanwQ8vHeYQwQD5g93oURxUrNJraLdB8iDgGOI+oPeIILIX/dcu+XZzPgJoMDweMRsGVND9YT546iemR4EtOIAnp2sWM7GzlO4doL+Vy6gI55uOfdy7nYLv3Jqm/Vg6PjEMFsgZOvvssfimY6LJCKG+Bcp84qml8BK9pUOZp5ksgc1a37Zy1Jwkb3noOESLUI8tYibx2mp5PkrvwiX2Mg1u7ASFv+fMqUE69iPJW2s8qGPuc4qc3/xjxZgZ0eXxtDJSDNSgWyfleIrcK/cQr33q5/sC99iU77VZC+2dqZgjPDURGXFuLlIJmPInOAuqw4xkYJ5D4yQheDzM/BvMvC7J6jr2zq1KyBGtoca9k21OYC5rkVj8wUfZavh8rVLK2ihWEXM/avx/U32MtvqIbH5LptzL8DZSsa7jaUxPjUwkTZqYfWUoemOQaRL525kljihCSq4jOeJJd4GYj4Pmx20gsYnoUzVQ5FSX7nYQcwfKTCmEnYkBBezMjyA6JKe/dhjggpvq3gVsGcFmNoGq29VZY6id8v4jD1mZrfeCRuTqcBPzK+NvzOfQ6mLYBzpuwOu/GQzF+SSXVNn8GoZNnW8PVJ1WfU5hbTqeUx3xsTg/6HlZrv6SmvO0P1O+BOFA9737WE/yoR5N6GGted/02SWkZQQOYIpuFacZUUuRANvEXB0up9TItJJAUqNtPfzPagMmonTZO31SunWc+/zNkL0jnuy7QYGit+N41z8AgFytfpvYKk7hZtwyB+j/EFTZqR1cBBab3BMtZvCIhLzyxvLbWwMoxUxwVvJ7JZTXzF8V3Z+TzYZ+dtHWwu2dbMZnYg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR11MB5712.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(9686003)(966005)(122000001)(508600001)(66476007)(38100700002)(66556008)(54906003)(110136005)(52536014)(64756008)(66446008)(38070700005)(33656002)(76116006)(82960400001)(55016003)(66946007)(7696005)(26005)(107886003)(15188445003)(186003)(71200400001)(5660300002)(86362001)(4326008)(53546011)(6506007)(83380400001)(316002)(6636002)(66574015)(8676002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RfosyLMjeUZNJm8mIQHf6Yf8QFjYdh0uY3wN4XtyzfcoGqUJ4cCqLdBKW3oK?= =?us-ascii?Q?GVV19QSKh/awP0gO4Tmms+KAf7mK2sdQV4CvMBLy/J/UvAZ4JPCai7Wkw/br?= =?us-ascii?Q?u2EdeuCd+1rP6Umj91wwKlV8U1agMBJgSiN56XtoT9eCr9Jku92qcyrHMu+T?= =?us-ascii?Q?APesvAR5Ua+Iv/N2A4zuo08WFI4Y8fl0F8nlRrZCo1uRuyJF5wERB5OHxP2N?= =?us-ascii?Q?P0C9L5mozcCxjyYu6HhcFjQ9oJq+nDVNOeNOAZ0KaUBQ8FSkpwEZsK9sq98z?= =?us-ascii?Q?rC0NWVo80PHBOY3ofUP9IWhFnJquvVox9DSfYVXY+dt1UUnW7ioNOgIpHjcd?= =?us-ascii?Q?OE0VLeniQeSMMsQv3jvcSq3w4rFKeHhshlq4+44nO+zKgc/pruWV6fBaBH0y?= =?us-ascii?Q?N4zWRNOAyqriCHtzYxBaMOuEvzHGjhiuBeoVktHZwQ4rreS0r6dHkWgKhWDB?= =?us-ascii?Q?Fvsl8kXr1qYt3F1c3VrspsuV6RspQ2njvv1lK8vjmNZLs+QDOMf14QejYwdB?= =?us-ascii?Q?HyjV08mSGaZAJfd7En598cHD1vUyfcHJoRK4tyDNyHhspXhITWnUebrisZ0P?= =?us-ascii?Q?ExS7eYzrfRNZoKIC2sSzzIq/fuPeBCQ01jc18RFE1uBI0NFbaKvFVCZkQDnk?= =?us-ascii?Q?arsOQXtV1bUTJH5NWgzJ6etCcLFWOdLs4hRol8YtiAcU/X5iUdkwFtI8HDdF?= =?us-ascii?Q?3mGfHvoEHOYW1j/64iQb9K49o95X3gstFOMt9S3guEMdqLNY8uaGN5vIBTBo?= =?us-ascii?Q?aAuVkiEdbu8xZLQeWZCoQJ2TBy1ucnyYBYXFWl5yRALRhvHXKaUdQkUevGyr?= =?us-ascii?Q?jgPWvrTOIYfqwifv21sukL7BfChDWqnPB+b6miWWwaF14M+k1VUpcvBTPrEh?= =?us-ascii?Q?YVaZ6jWIR3nDAGikOlr1efnzAXRUG16YtJPAvfLYHnUfan6hqKkx/gC1t98C?= =?us-ascii?Q?6ZYGaWrJHCssoRhJWyfmKFdqoEYmgFzK5fVidAAgKdUITkbE/1hCWJWVjkum?= =?us-ascii?Q?mlJ6UmQCYLDuyXPVXx+2oBZESGI+Z7qep/pLIs3vDD0oASXzHASvFkprQur9?= =?us-ascii?Q?2VWAo9g+T1ZbL2jxb+ZvvRdavoUEHCYE/CSBcoqmhZX71hXh41OT5r0Tvu74?= =?us-ascii?Q?iKykwVmF3ex9eDA1z+L2B/WlucM2dD+hxsdK76jNakoi85LcJydVBCBmAJ0e?= =?us-ascii?Q?d8HiP1K8Itx9tKG6phsXAkP8e1drAM04Ia5xtdupou0n5QZgnLXpOhLLohRx?= =?us-ascii?Q?l8UCAHQfRD7fU26AfuTan4g16LVyhgChTU1qIxpeUdwAXYwckuPRsHnV1AoZ?= =?us-ascii?Q?bkfvvKbXi1LQuBPefryztWbMQbUbAGRHgb0u8F9ramx6jG1VWqs8xflVB06n?= =?us-ascii?Q?DB1h5aNP5BldI5tE2syAyBNMCxvvn2ATTc5v0GsI4yejn3mLbWPmDOtyEiVp?= =?us-ascii?Q?MRZ1gM82iu3/QqhTV16RSeDadxX8PnI0UyH9Z9dYUmYent7qWqRLMNQ0+Mhq?= =?us-ascii?Q?D/AcIFHRbtROddr088dhsLSIJeqVtPZ0hUmM+TJ6Gqbtw2dYTILYiaxS94sr?= =?us-ascii?Q?VMc/U0n+52nM04WBQrafIvHUBzJpShFUbssICInmpm8R4vNj+/utZlXvnDf1?= =?us-ascii?Q?dv/5x5rLxlnAuLgMsO+3qMuW1/7mMAtCQc8pPq6ed0gCmTSJfxF/6avPfUar?= =?us-ascii?Q?59OTOg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5712.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45420fb6-44f2-4696-c900-08d9c3a27bf5 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2021 10:21:28.0834 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wsopZ1uJNZyy8JenIA69iIdT/l0++Iqtt9muNfYMPHPffK2BBewzPYtJzMRjfeNdtndcQz8plf86CwknNHGDBHP2FKw4h6ur1tuR5meey9U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3843 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, December 17, 2021 4:19 PM > To: Randles, Ronan ; Van Haaren, Harry > > Cc: Jerin Jacob ; dev@dpdk.org; Richardson, Bruce > > Subject: Re: [PATCH 05/12] gen: add raw packet data API and tests >=20 > 17/12/2021 12:40, Van Haaren, Harry: > > I could ramble on a bit more, but mostly diminishing returns I think... > > I'll just use this email as a reply to Thomas' tweet; > > https://twitter.com/tmonjalo/status/1337313985662771201 >=20 > My original question was to know available applications, > not integrating such application in the DPDK repository. >=20 > I may me miss something obvious, > but I don't understand why trying to add a user app inside DPDK repo. There are likely a few points-of-view on this particular topic; and I'm gla= d you mention it so we can discuss it clearly here. There are two main parts to this patchset, the first is a packet generation= library, with an easy to use string-based syntax. The *library* is designed to be ex= tended in future to a range of "useful stuff" to do while generating packets. The pac= ket generation *application* should have minimal features, and focus on ease-of-use (as su= ggested below). In order to test the DPDK code, we need a variety of unit tests, and a samp= le-application to show users how to use the library (as well as docs etc). For me, the interesting= part is that it is a small step from a simple sample-app just for testing to a minimal tool for high-r= ate packet generation.=20 I think many users of DPDK first install DPDK, then wish for a tool to gene= rate high traffic rates to test DPDK, and end up with a usability problem; DPDK does not include a = usable packet generator. To highlight this point; our own DPDK Docs simply ignore the requirement of= packet-generation to actually have packets processed by skeleton: http://doc.dpdk.org/guides/sam= ple_app_ug/skeleton.html=20 Our "quick start" on the website uses PCAP vdevs (avoiding the problem) ht= tps://core.dpdk.org/doc/quick-start/ Even searching the entire docs for "generate packet" doesn't give any relev= ant/useful results: http://doc.dpdk.org/guides/search.html?q=3Dgenerate+packet&check_keywords= =3Dyes&area=3Ddefault#=20 Users could internet-search & find pktgen, moongen, trex, or similar tools.= These tools are fantastic for experienced developers such as devs on this mailing list - we should *NOT* replicate th= ese complex tools in DPDK itself. However, building any tool outside of DPDK repo requires more effort; another git-cl= one, another set of dependencies to install, perhaps another build-system to get used to. Particularly for people starti= ng out with DPDK (who are likely finding it difficult to learn the various hugepage/PCI-binding etc), this is yet an= other problem to solve, or to give up. So my proposal is as follows; let us add a simple DPDK traffic generator to= DPDK. We can define its scope and its intended use, limiting the scope and capabilities. As before, I do = NOT think it a good idea to build a complex and feature-rich packet generator. I do feel it useful to have an e= asy-to-use application in DPDK that is particularly designed for generating specific packets, at specific line-= rates, and reports mpps returned. Thoughts on adding an small scope-limited application to DPDK enabling ease= -of-packet-generation for new users? Regards, -Harry