* [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue @ 2023-06-21 1:15 Wenzhuo Lu 2023-06-28 7:32 ` Jiale, SongX 0 siblings, 1 reply; 5+ messages in thread From: Wenzhuo Lu @ 2023-06-21 1:15 UTC (permalink / raw) To: dev; +Cc: Wenzhuo Lu The SCTP tunnel packets cannot be forwarded in AVX2 mode. As 2 features are developed in parallel, 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path") doesn't consider the impact of 4f8259df563a ("net/iavf: enable Tx outer checksum offload on AVX512"). So, the wrong TX path is selected. Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path") Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com> --- drivers/net/iavf/iavf_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 4c59c1a..a22abb1 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -3919,7 +3919,7 @@ struct iavf_tx_context_desc_qws { check_ret = iavf_tx_vec_dev_check(dev); - if (check_ret >= 0 && + if ((check_ret == IAVF_VECTOR_PATH || check_ret == IAVF_VECTOR_OFFLOAD_PATH) && rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) { /* SSE not support offload path yet. */ if (check_ret == IAVF_VECTOR_PATH) { -- 1.8.3.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue 2023-06-21 1:15 [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue Wenzhuo Lu @ 2023-06-28 7:32 ` Jiale, SongX 2023-06-29 8:57 ` Zhang, Qi Z 0 siblings, 1 reply; 5+ messages in thread From: Jiale, SongX @ 2023-06-28 7:32 UTC (permalink / raw) To: Lu, Wenzhuo, dev; +Cc: Lu, Wenzhuo > -----Original Message----- > From: Wenzhuo Lu <wenzhuo.lu@intel.com> > Sent: Wednesday, June 21, 2023 9:15 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com> > Subject: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue > > The SCTP tunnel packets cannot be forwarded in AVX2 mode. > > As 2 features are developed in parallel, 5712bf9d6e14 > ("net/iavf: add Tx AVX2 offload path") doesn't consider the impact of > 4f8259df563a ("net/iavf: enable Tx outer checksum offload on AVX512"). So, > the wrong TX path is selected. > > Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path") > > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com> > --- Tested-by: Song Jiale <songx.jiale@intel.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue 2023-06-28 7:32 ` Jiale, SongX @ 2023-06-29 8:57 ` Zhang, Qi Z 2023-07-06 1:26 ` Lu, Wenzhuo 0 siblings, 1 reply; 5+ messages in thread From: Zhang, Qi Z @ 2023-06-29 8:57 UTC (permalink / raw) To: Jiale, SongX, Lu, Wenzhuo, dev; +Cc: Lu, Wenzhuo > -----Original Message----- > From: Jiale, SongX <songx.jiale@intel.com> > Sent: Wednesday, June 28, 2023 3:33 PM > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com> > Subject: RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue > > > -----Original Message----- > > From: Wenzhuo Lu <wenzhuo.lu@intel.com> > > Sent: Wednesday, June 21, 2023 9:15 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com> > > Subject: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue > > > > The SCTP tunnel packets cannot be forwarded in AVX2 mode. > > > > As 2 features are developed in parallel, 5712bf9d6e14 > > ("net/iavf: add Tx AVX2 offload path") doesn't consider the impact of > > 4f8259df563a ("net/iavf: enable Tx outer checksum offload on AVX512"). > > So, the wrong TX path is selected. > > > > Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path") > > > > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com> > > --- > Tested-by: Song Jiale <songx.jiale@intel.com> Applied to dpdk-next-net-intel. Thanks Qi ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue 2023-06-29 8:57 ` Zhang, Qi Z @ 2023-07-06 1:26 ` Lu, Wenzhuo 2023-07-06 1:32 ` Zhang, Qi Z 0 siblings, 1 reply; 5+ messages in thread From: Lu, Wenzhuo @ 2023-07-06 1:26 UTC (permalink / raw) To: Zhang, Qi Z, Jiale, SongX, dev Hi Qi, > -----Original Message----- > From: Zhang, Qi Z <qi.z.zhang@intel.com> > Sent: Thursday, June 29, 2023 4:58 PM > To: Jiale, SongX <songx.jiale@intel.com>; Lu, Wenzhuo > <wenzhuo.lu@intel.com>; dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com> > Subject: RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue > > > > > -----Original Message----- > > From: Jiale, SongX <songx.jiale@intel.com> > > Sent: Wednesday, June 28, 2023 3:33 PM > > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com> > > Subject: RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue > > > > > -----Original Message----- > > > From: Wenzhuo Lu <wenzhuo.lu@intel.com> > > > Sent: Wednesday, June 21, 2023 9:15 AM > > > To: dev@dpdk.org > > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com> > > > Subject: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue > > > > > > The SCTP tunnel packets cannot be forwarded in AVX2 mode. > > > > > > As 2 features are developed in parallel, 5712bf9d6e14 > > > ("net/iavf: add Tx AVX2 offload path") doesn't consider the impact > > > of 4f8259df563a ("net/iavf: enable Tx outer checksum offload on > AVX512"). > > > So, the wrong TX path is selected. > > > > > > Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path") > > > > > > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com> > > > --- > > Tested-by: Song Jiale <songx.jiale@intel.com> > > Applied to dpdk-next-net-intel. > > Thanks > Qi Sorry, this fix is not good because of some misunderstanding. Would you like helping to revert it? We'll send a new one to fix the issue. Thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue 2023-07-06 1:26 ` Lu, Wenzhuo @ 2023-07-06 1:32 ` Zhang, Qi Z 0 siblings, 0 replies; 5+ messages in thread From: Zhang, Qi Z @ 2023-07-06 1:32 UTC (permalink / raw) To: Lu, Wenzhuo, Jiale, SongX, dev > -----Original Message----- > From: Lu, Wenzhuo <wenzhuo.lu@intel.com> > Sent: Thursday, July 6, 2023 9:27 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Jiale, SongX <songx.jiale@intel.com>; > dev@dpdk.org > Subject: RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue > > Hi Qi, > > > -----Original Message----- > > From: Zhang, Qi Z <qi.z.zhang@intel.com> > > Sent: Thursday, June 29, 2023 4:58 PM > > To: Jiale, SongX <songx.jiale@intel.com>; Lu, Wenzhuo > > <wenzhuo.lu@intel.com>; dev@dpdk.org > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com> > > Subject: RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue > > > > > > > > > -----Original Message----- > > > From: Jiale, SongX <songx.jiale@intel.com> > > > Sent: Wednesday, June 28, 2023 3:33 PM > > > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org > > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com> > > > Subject: RE: [PATCH] net/iavf: fix SCTP tunnel packet forwarding > > > issue > > > > > > > -----Original Message----- > > > > From: Wenzhuo Lu <wenzhuo.lu@intel.com> > > > > Sent: Wednesday, June 21, 2023 9:15 AM > > > > To: dev@dpdk.org > > > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com> > > > > Subject: [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue > > > > > > > > The SCTP tunnel packets cannot be forwarded in AVX2 mode. > > > > > > > > As 2 features are developed in parallel, 5712bf9d6e14 > > > > ("net/iavf: add Tx AVX2 offload path") doesn't consider the impact > > > > of 4f8259df563a ("net/iavf: enable Tx outer checksum offload on > > AVX512"). > > > > So, the wrong TX path is selected. > > > > > > > > Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path") > > > > > > > > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com> > > > > --- > > > Tested-by: Song Jiale <songx.jiale@intel.com> > > > > Applied to dpdk-next-net-intel. > > > > Thanks > > Qi > Sorry, this fix is not good because of some misunderstanding. Would you like > helping to revert it? We'll send a new one to fix the issue. Thanks. OK, has the patch has not been merged in main branch, I have reverted in dpdk-next-net-intel. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-06 1:32 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-06-21 1:15 [PATCH] net/iavf: fix SCTP tunnel packet forwarding issue Wenzhuo Lu 2023-06-28 7:32 ` Jiale, SongX 2023-06-29 8:57 ` Zhang, Qi Z 2023-07-06 1:26 ` Lu, Wenzhuo 2023-07-06 1:32 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).