From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0050.outbound.protection.outlook.com [104.47.38.50]) by dpdk.org (Postfix) with ESMTP id 0EB8B6CA4 for ; Wed, 7 Sep 2016 04:11:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Fba7S4rwTqlostz9OtGRCP4PEz+mcfcsmfY8RE8Jd/U=; b=EwRqy+cwNlzhZ8cXVwydx9ptSyNxqWCR2udpBiB0fBa4jcT+Yhhc0Hb0paNRXF/RiI+LqSZ8iSy8PCUbMb8oT19gK1618OrgpetliGPkuOOr6uPnfpPOlqO5A0NumCgr49HQa2zeEI0Fo6wwkwxB4qXWjszRdvUCj+Fnhv2ibtk= Received: from BN3PR03MB1494.namprd03.prod.outlook.com (10.163.35.145) by BN3PR03MB1496.namprd03.prod.outlook.com (10.163.35.147) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Wed, 7 Sep 2016 02:11:53 +0000 Received: from BN3PR03MB1494.namprd03.prod.outlook.com ([10.163.35.145]) by BN3PR03MB1494.namprd03.prod.outlook.com ([10.163.35.145]) with mapi id 15.01.0599.016; Wed, 7 Sep 2016 02:11:53 +0000 From: "Dey, Souvik" To: Maxime Coquelin , "stephen@networkplumber.org" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] add mtu set in virtio Thread-Index: AQHSAkl6WQg/4EBiA0S3i2wQUSIyp6BhI8iAgAQTtoCAAJTNgIAHiL/Q Date: Wed, 7 Sep 2016 02:11:53 +0000 Message-ID: References: <20160829230240.20164-1-sodey@sonusnet.com> <49bce2ef-ffbd-96ff-6f9c-6c37bb7c7a90@redhat.com> In-Reply-To: <49bce2ef-ffbd-96ff-6f9c-6c37bb7c7a90@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sodey@sonusnet.com; x-originating-ip: [66.30.138.194] x-ms-office365-filtering-correlation-id: 48e3e139-5e11-4081-85c2-08d3d6c455df x-microsoft-exchange-diagnostics: 1; BN3PR03MB1496; 6:VFaLn8dcWX2Tg/urviYQitoystlZQF5CF/5ohS0ZvGL+Y9zM+plEIQakeXs+gum2N/Y8MoCEcwe+ROLVQC6v49jNNtFR4xknUl/dl/Q6mzmenqMKaiuORPGOQ5OscUxJB7U5z8IQOGuQv9cjJGuW7+zQgtLEYWmILVzMBAl/BAnAsuVgdwpByU34HHdxeaIVUpcThMCFqVCIJOpo8Yax5+DKpPRN+t4zTNJQva6RNRiSwdhbReT6Q8WvTdxKEw04u/ey3cmVBg/eH3JZk6isev3ClcwmI3XTVYVcdc4RXR0=; 5:iH9wb61mujE61iQVA6Y108agaTZHiU4azOMWsOKwpG9JWDYhiHXJ5rIk+wHKGTPzXZwH0B8dEI3cAEhz9vR6Mo6EbHS5OKPzsKMxcFSk0+Ek/YbysgiCOLBxMYnw5LEQGheGHfNztkLenrikNjT0Qg==; 24:dJXz+LR3y0WkdnmMlJPfsXBc2W6wlhp5Pwze0cyhU7J13Jz8nzgskPXBU6GYJOvWUGqnU0mcqOuE8ZV2X2e3hbxr8z6dRATYENgbcYzua48=; 7:jotXWN9giARuNtGZIKxCRamJuROAf22jWp/9KXmPc8FxYCFJ84D1aGRa0nYiNnNPUSK05sxRZlMMcBlRKB8j+0ECj/kwcThxLbpEhWgyPcxrBsZTl/UUAzAS6zEWKOj6Xe46tPjrfd3zJ3oeAD9CPj34AOe+/c0RuXAwltBnNor31zTo+kAfFIt2NAFyVLS01Cj8GdTKUTI8d4bkg0Z5UVaa5aAMglVjmsWOKELdCYRzQCGBAq/SKey7rpi0TK+Q x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1496; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BN3PR03MB1496; BCL:0; PCL:0; RULEID:; SRVR:BN3PR03MB1496; x-forefront-prvs: 0058ABBBC7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(13464003)(199003)(189002)(24454002)(377454003)(69234005)(99286002)(2950100001)(3660700001)(15975445007)(76576001)(105586002)(4326007)(86362001)(2906002)(77096005)(106116001)(106356001)(3280700002)(92566002)(74316002)(8936002)(5002640100001)(81166006)(122556002)(8676002)(7696003)(81156014)(2900100001)(9686002)(7846002)(5001770100001)(68736007)(189998001)(101416001)(10400500002)(33656002)(2501003)(93886004)(5660300001)(6116002)(66066001)(50986999)(11100500001)(54356999)(76176999)(19580405001)(102836003)(3846002)(87936001)(7736002)(586003)(19580395003)(305945005)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB1496; H:BN3PR03MB1494.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2016 02:11:53.1549 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1496 Subject: Re: [dpdk-dev] [PATCH v2] add mtu set in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 02:11:56 -0000 Hi Maxime, In that case let this fix be there till the time the new implementation co= mes in. We can re-visit the changes again in the new implementation and the= n decide to keep this or remove it. Hope this serves all the purposes. -- Regards, Souvik -----Original Message----- From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]=20 Sent: Friday, September 2, 2016 3:06 AM To: Dey, Souvik ; stephen@networkplumber.org Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] add mtu set in virtio Hi Souvik, On 09/02/2016 12:20 AM, Dey, Souvik wrote: > Hi Maxime, > When is patches or new implementation going to come in the release ? if = it is not 16.11 then, can we keep this change till the new virtio changes c= ome in the release. And if it is already planned for 16.11, then can I get = a little more information on that. > I'm currently working on qemu part implementation, first RFC should be sent= next week. Goal is to have it in 16.11, but I cannot commit, as the spec update has no= t been acked yet. For more information, you can start by having a look at the spec review: https://lists.oasis-open.org/archives/virtio-dev/201608/msg00056.html Regards, Maxime > -- > Regards, > Souvik > > -----Original Message----- > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] > Sent: Tuesday, August 30, 2016 3:58 AM > To: Dey, Souvik ; stephen@networkplumber.org;=20 > huawei.xie@intel.com; yuanhan.liu@linux.intel.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] add mtu set in virtio > > Hi Souvik, > > On 08/30/2016 01:02 AM, souvikdey33 wrote: >> Signed-off-by: Souvik Dey >> >> Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey=20 >> ") >> Reviewed-by: Stephen Hemminger >> >> Virtio interfaces should also support setting of mtu, as in case of=20 >> cloud it is expected to have the consistent mtu across the=20 >> infrastructure that the dhcp server sends and not hardcoded to 1500(defa= ult). >> --- >> drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > > FYI, there are some on-going changes in the VIRTIO specification so that = the VHOST interface exposes its MTU to its VIRTIO peer. > It may also be used as an alternative of what you patch achieves. > > I am working on its implementation in Qemu/DPDK, our goal being to reduce= performance drops for small packets with Rx mergeable buffers feature enab= led. > > Regards, > Maxime >