From: "Dey, Souvik" <sodey@sonusnet.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "huawei.xie@intel.com" <huawei.xie@intel.com>,
"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] add mtu set in virtio
Date: Sun, 28 Aug 2016 22:43:54 +0000 [thread overview]
Message-ID: <BN6PR03MB2740F9921796A56FB6E06EE0DAEE0@BN6PR03MB2740.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20160827171541.5f6b17c2@xeon-e3>
Hi ,
Currently as you have mentioned, I have changed the code to:
static int
virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
{
struct virtio_hw *hw = dev->data->dev_private;
- if (unlikely(mtu < (uint32_t)hw->vtnet_hdr_size + ETHER_HDR_LEN)) {
- return -1;
+ if (unlikely(mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN)) {
+ PMD_INIT_LOG(ERR,"Mtu should be between 64 and 9728."
+ return -EINVAL;
}
return 0;
}
Yes, we should support till 64K as the kernel does , but I need to go through the changes and test it properly before submitting it for review. Moreover I was thinking with the changes in the mtu, we should also support multi-segment buffers in kni. What do you suggest ?
--
Regards,
Souvik
-----Original Message-----
From: Stephen Hemminger [mailto:stephen@networkplumber.org]
Sent: Saturday, August 27, 2016 8:16 PM
To: Dey, Souvik <sodey@sonusnet.com>
Cc: huawei.xie@intel.com; yuanhan.liu@linux.intel.com; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] add mtu set in virtio
On Fri, 26 Aug 2016 20:54:28 -0400
souvikdey33 <sodey@sonusnet.com> wrote:
> This functionality is required mostly in the cloud infrastructure.
> For example, if we use gre or vxlan network between compute and
> controller, then we should not use 1500 mtu in the guest as with
> encapsulation the sixe of the packet will be more and will get dropped
> in the infrastructure. So, in that case we should honor the mtu size
> sent by the dhcp server and configure the same on the virtual
> interfaces in the guest. This will also keep a consistent mtu through
> out the infrastructure.
>
> souvikdey33 (1):
> Signed-off-by: Souvik Dey <sodey@sonusnet.com>
>
> drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
Thanks for the patch, it is a good step forward but it looks like more code is needed to do this safely. At a minimum, need to check that MTU is not greater than VIRTIO_MAX_RX_PKTLEN.
And error return should be negative errno not -1.
Something like:
if (mtu < VIRTIO_MIN_MTU || mtu > VIRTIO_MAX_RX_PKTLEN)
return -EINVAL;
Looking at Linux driver, it allows MTU of up to 64K, yet DPDK only allows 9728. That should probably be fixed.
next prev parent reply other threads:[~2016-08-28 22:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 0:54 souvikdey33
2016-08-28 0:15 ` Stephen Hemminger
2016-08-28 22:43 ` Dey, Souvik [this message]
2016-08-29 19:33 ` Stephen Hemminger
2016-08-29 22:49 ` Dey, Souvik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR03MB2740F9921796A56FB6E06EE0DAEE0@BN6PR03MB2740.namprd03.prod.outlook.com \
--to=sodey@sonusnet.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=stephen@networkplumber.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).