From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BD38A0524; Mon, 10 May 2021 07:02:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E58D640140; Mon, 10 May 2021 07:02:25 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 754214003E for ; Mon, 10 May 2021 07:02:24 +0200 (CEST) IronPort-SDR: hUbhxN1hKjtg6nQcBB/w0fhaBWc+Tpz/KvKnb9D4S0uGnraH88dO/aHR8KyNDH7QgsSXiljOOM wIoDHoUld5cw== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="196018359" X-IronPort-AV: E=Sophos;i="5.82,286,1613462400"; d="scan'208";a="196018359" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2021 22:02:21 -0700 IronPort-SDR: Ubfj07cPuLL3MKbRU2TYxeSChMvvoNN2YuFhYafPWsWynOhKGxKG/z++h07XdeCF6gsnWfuH/t A9it3DPj92lg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,286,1613462400"; d="scan'208";a="435979470" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 09 May 2021 22:02:21 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 9 May 2021 22:02:20 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 9 May 2021 22:02:20 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 9 May 2021 22:02:20 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 9 May 2021 22:02:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m4gVEzf7/U1b7u2rgCj6aocleK3k6+kAvviBJhyjuv7trL7D0ICBxSgEC2m4VG+Q1BffNwtDZux/7VE6Mgwyfeis+Ra8KDAJO5peKVExFES2+b7J1RX4AeHiT00YI5dOX2Ph2oIwoQlfxNWLC+KC21k14EpFqa8wWIOCmFq7XJXHNgQiwF9rv5mVuG/Dxl/1v9atGyh9Cf1NdMEWySVTKRJrn6oiHFobNRC7n2ISXZG5q1h38+EDLA5bfzgvBrwZO7KCGTQYrhhM2Z06UQt2HxFWxiomGLpGacboUC8O9qhsKqDLwO3FCuKPZcN4U/JPGNIxsio7VH2OqkER88E4Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=21qxNfRXspZ+SLd8ZnKaVun1LWGnViLyg/hYoMPMeO0=; b=BMx6XxnqwyTFd3jEylRXY/NLHGFjej3T4xCNhgvdpAbxgfehPGl9niGPshLEgBpE4/PwIfLCWrFmjmRzsWPG06CKv6ABsJBEaqLhvuNsOH8HxY+ajd3HN53nxM7s+kD+A8Xty+w2LSOa5O2n5PwJXSHPnIMzF4UzJZMiylkbUg9ewuyhOvXGm19Or93hwIPYHfG3uppQTwBQ4CqqOqgACcu+JlbWbeXLYHnEp5NmDLSuuoaIfh9N+yi/kAXiMbmK/g2kgA2y8JxQkWpayDET+bUxBRUt/0eIz2XZWrxukagohVu0fbMsfy81+7zaesK0lbytbD2DHIUL1uyC+l22eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=21qxNfRXspZ+SLd8ZnKaVun1LWGnViLyg/hYoMPMeO0=; b=QvO4S/FwOxjxAV4ToL6txv++WN5CiHtR97xsVHKBQGXj5aKZcMBwVE6naS6kAQt7eHuA0MSanaU0neYAE4Vk9gjP4aYDcNrMKzr5ks21JeasQNIfX4C9tz57NfAc4/NbkXDsM3ObvvPwP7JP3oaLd6lf+i2CfV65DamVJKVcpfU= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN9PR11MB5307.namprd11.prod.outlook.com (2603:10b6:408:118::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24; Mon, 10 May 2021 05:02:16 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::7174:b069:13a2:2538]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::7174:b069:13a2:2538%4]) with mapi id 15.20.4108.031; Mon, 10 May 2021 05:02:16 +0000 From: "Yang, Qiming" To: "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/ice/base: remove unnecessary code Thread-Index: AQHXRUtX9FQaeb6um0SQqgY2nF1RGarcKI+A Date: Mon, 10 May 2021 05:02:16 +0000 Message-ID: References: <20210510032326.3163171-1-qi.z.zhang@intel.com> In-Reply-To: <20210510032326.3163171-1-qi.z.zhang@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6d4def0d-d9e5-4fcd-17fe-08d91370c800 x-ms-traffictypediagnostic: BN9PR11MB5307: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Wkd0uYyy70wmVHPhvIGPuzGBvJieQ3Br199hnO94A46Fb/k3tczNicB122eFvNR/1tSincln23rHLYUhJ7YMyiJ+RVR4ktzyz/OSgD8pUD481i6wsAtu9pm+HiCn6CZFYsPFIUDEu4smzmEdccT8OPnSclHRFI7k5yuDV7+Hd7j6zY1XXTsSr4bAE6+x3XrP/pWlrKbmMJ2cYWH4beGX79CWMfngVcL7MRssIAcgxzoTzXo9PXAwCqBjCJqTQi4lkxYeomHRXMugRoo5SdTQK9iuemP/rfl6JcDl+d2zoovFMecM1HVI7IH52IOWpKLXKtkf8wwogsoXu2rP+tsOL/PtSXaDnTkCdMIHZIM1EKBWydtXRAFdHU6Ct2NJO5TMvk4f394f4iGndBSs4tp+v7A87WhwUs2nVPQqcjaD7qScLYDmQM7v+pO1whKus0uBvqMDkynDn0iKXpaNDfuXJAFpc/UKb7YBbTVSeg+QuTO+EIWOBTMGAD4CqGkDjbbYliA0MztJGqDe+zbnwt9NKs4TIZ7kgO/qcMgcFvJVx1oyCCxUSsOLr9adORy2l6CY9YJL9sIM787JmfFXPSn+pMUJ4UdjUB+AsRxJEq2a/sw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(366004)(39860400002)(376002)(346002)(396003)(66946007)(9686003)(5660300002)(38100700002)(86362001)(478600001)(76116006)(55016002)(52536014)(186003)(4326008)(7696005)(6636002)(83380400001)(26005)(66446008)(8936002)(66556008)(66476007)(2906002)(64756008)(8676002)(33656002)(6862004)(122000001)(53546011)(6506007)(316002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?y6RQcCeWxKQwJqxoGata9xFoMGG5xPooZ6r7aqalKtjuxxO89VJQ1YWAKXJ3?= =?us-ascii?Q?FxuSEDX+H5dYecvAqikCYtBBz9NEigEt6ReG++PQDtAq264jLTMthBsKOOng?= =?us-ascii?Q?DsGSGZMmrq5r+uy2p0zSeQblHWhFupqEb41S5tAByWCsaRO5igksOmZOL49L?= =?us-ascii?Q?GBGfJWMRc/1XDXOt1u+4Fm5IziSiwmtrJzC1EdUqHI4qu3jwl3Vza52gpTDv?= =?us-ascii?Q?SWySnaImEAPnSowovPfVDEpz4/zYbGPXSbpZxWQ5IzfXb6navXwVXuUbgIDw?= =?us-ascii?Q?dlVBOGsiUAkmnNAuPZN1qhVsk/6FtlsSEiqm5hytmS05UUzuMoiUy/bnc2kt?= =?us-ascii?Q?4herghIa1PSecItHwhjqqjkO6CY7/mSceMEeQQLApUkJMdHD4QIUk9DEf7aS?= =?us-ascii?Q?oYPBTooMtnneV7w5Wc1nn+AkBn8tcIiqgU5w1T6WS9FBs0kvJ3vDSPY66/cS?= =?us-ascii?Q?X9Uo8YPzm7yhaGRDJyL11oBAdAxYQNdRkFhsF8FlnY6Mh93bl7g9m+wldWv7?= =?us-ascii?Q?cDusz7y9yYwp9o9wZxwnADoU6FBtKf61za/fJZEPopftbM2wdcD2oKVoO5CL?= =?us-ascii?Q?9BpEy50sZejXiJd6m9xOufIo5KMir5wHcPVDmFB11f5SIJF+EUvciiohnn6g?= =?us-ascii?Q?XeUpcElszneDVYc+GiIMAb+YuAu5YEODfSYeoZStIlZKMph2WRcEm40pq9Ur?= =?us-ascii?Q?tzryDUFdd2iock//DU5iR7MIq06Y08eFXlRtIHy8IYgrrpoupNr1Gh4qd+39?= =?us-ascii?Q?PljUh8n21iqhVeqGiFxB9E+9rBXEIBJy6lnYCwAsJFv4B0UpYv9g2azb31BP?= =?us-ascii?Q?Z/gLx8k6HjtMQ/5vpTtd5S+xtvqQJzWcZHXO6eEsxgkM4ea+yXS3DbVXFThr?= =?us-ascii?Q?KHmFNqZ6Qq47VcoXHMnva6kEI5KezzQwjQ1bfjrHenRkEW6o6Pq+pnqqpIjR?= =?us-ascii?Q?6vFCq6qMl5F7OUVeENSe5wXFi1mbNKGf3bl+bK6RAslHi2ChO3uy6MyEdTFW?= =?us-ascii?Q?Ze2PDeu+BRpRl53PTnFvXQwmJT0uPkqJTo1RlnjBS/LQP/58D7BJWqxlqdaz?= =?us-ascii?Q?ODJqvu9LHPNoKVajkmIkb1VneJFvIL6PTFQY2w3WjaC8xWL/YBI9OMkdIcLi?= =?us-ascii?Q?Df5VBpFeQTlDd4Rc5MWjjkU7yVVA39mgXsxIMDsg09q9BGp4GaKSdBOb+9iE?= =?us-ascii?Q?hRVTRoCNcApa1d6DRi721rm4ITlbNf9oMEIryShWZPFriYsxZyeMdNeSVPxr?= =?us-ascii?Q?iP2ypQ3PM/s+0DNuHguQ6glvNHPyv4IfVDimIDGWcuPqDd+OPfRw9Yj99BAv?= =?us-ascii?Q?Ly15o1DWfOvjP/hGeZApcYwI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d4def0d-d9e5-4fcd-17fe-08d91370c800 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 05:02:16.1100 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0smKhqBUlj77SWl6jqkns1CBMceLiqaJ4B164uDfknI95EF4xQPn1Vr6FQ6S/f6BGiiytsfa2f7TSfo6B5tqSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5307 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ice/base: remove unnecessary code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, May 10, 2021 11:23 > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] net/ice/base: remove unnecessary code >=20 > Coverty issue: 370613 > Execution cannot reach this statement: "break;". > Remove the unnecessary if branch. >=20 > Fixes: 2913bc4155d2 ("net/ice/base: sign external device package > programming") >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/ice/base/ice_common.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/net/ice/base/ice_common.c > b/drivers/net/ice/base/ice_common.c > index ac412a1aa7..cf0a7d4e7f 100644 > --- a/drivers/net/ice/base/ice_common.c > +++ b/drivers/net/ice/base/ice_common.c > @@ -2009,9 +2009,6 @@ ice_parse_common_caps(struct ice_hw *hw, struct > ice_hw_common_caps *caps, > { > u8 index =3D cap - ICE_AQC_CAPS_EXT_TOPO_DEV_IMG0; >=20 > - if (index >=3D ICE_EXT_TOPO_DEV_IMG_COUNT) > - break; > - > caps->ext_topo_dev_img_ver_high[index] =3D number; > caps->ext_topo_dev_img_ver_low[index] =3D logical_id; > caps->ext_topo_dev_img_part_num[index] =3D > -- > 2.26.2 Acked-by: Qiming Yang