* [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments
@ 2020-06-05 11:48 Sarosh Arif
2020-06-23 9:19 ` Sarosh Arif
0 siblings, 1 reply; 5+ messages in thread
From: Sarosh Arif @ 2020-06-05 11:48 UTC (permalink / raw)
To: dev, reshma.pattan; +Cc: Sarosh Arif, sergio.gonzalez.monroy
rte_exit should be called when the application exits due to
invalid EAL or application arguments.
Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
Cc: sergio.gonzalez.monroy@intel.com
Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
---
examples/packet_ordering/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c
index b397b318e..edaf810d9 100644
--- a/examples/packet_ordering/main.c
+++ b/examples/packet_ordering/main.c
@@ -675,7 +675,7 @@ main(int argc, char **argv)
/* Initialize EAL */
ret = rte_eal_init(argc, argv);
if (ret < 0)
- return -1;
+ rte_exit(EXIT_FAILURE, "Invalid EAL arguments\n");
argc -= ret;
argv += ret;
@@ -683,7 +683,7 @@ main(int argc, char **argv)
/* Parse the application specific arguments */
ret = parse_args(argc, argv);
if (ret < 0)
- return -1;
+ rte_exit(EXIT_FAILURE, "Invalid packet_ordering arguments\n");
/* Check if we have enought cores */
if (rte_lcore_count() < 3)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments
2020-06-05 11:48 [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments Sarosh Arif
@ 2020-06-23 9:19 ` Sarosh Arif
2020-06-23 9:22 ` Pattan, Reshma
0 siblings, 1 reply; 5+ messages in thread
From: Sarosh Arif @ 2020-06-23 9:19 UTC (permalink / raw)
To: dev, reshma.pattan
Hello,
This patch has been sitting around for more than 3 weeks. Is there
something that needs to be done further for acceptance?
Regards,
Sarosh
On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif <sarosh.arif@emumba.com> wrote:
> rte_exit should be called when the application exits due to
> invalid EAL or application arguments.
>
> Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
> Cc: sergio.gonzalez.monroy@intel.com
>
> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> ---
> examples/packet_ordering/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/packet_ordering/main.c
> b/examples/packet_ordering/main.c
> index b397b318e..edaf810d9 100644
> --- a/examples/packet_ordering/main.c
> +++ b/examples/packet_ordering/main.c
> @@ -675,7 +675,7 @@ main(int argc, char **argv)
> /* Initialize EAL */
> ret = rte_eal_init(argc, argv);
> if (ret < 0)
> - return -1;
> + rte_exit(EXIT_FAILURE, "Invalid EAL arguments\n");
>
> argc -= ret;
> argv += ret;
> @@ -683,7 +683,7 @@ main(int argc, char **argv)
> /* Parse the application specific arguments */
> ret = parse_args(argc, argv);
> if (ret < 0)
> - return -1;
> + rte_exit(EXIT_FAILURE, "Invalid packet_ordering
> arguments\n");
>
> /* Check if we have enought cores */
> if (rte_lcore_count() < 3)
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments
2020-06-23 9:19 ` Sarosh Arif
@ 2020-06-23 9:22 ` Pattan, Reshma
2020-07-13 13:28 ` Sarosh Arif
0 siblings, 1 reply; 5+ messages in thread
From: Pattan, Reshma @ 2020-06-23 9:22 UTC (permalink / raw)
To: Sarosh Arif, dev
From: Sarosh Arif <sarosh.arif@emumba.com>
Sent: Tuesday, June 23, 2020 10:19 AM
To: dev@dpdk.org; Pattan, Reshma <reshma.pattan@intel.com>
Subject: Re: [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments
Hello,
This patch has been sitting around for more than 3 weeks. Is there something that needs to be done further for acceptance?
Regards,
Sarosh
On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif <sarosh.arif@emumba.com<mailto:sarosh.arif@emumba.com>> wrote:
rte_exit should be called when the application exits due to
invalid EAL or application arguments.
Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
Cc: sergio.gonzalez.monroy@intel.com<mailto:sergio.gonzalez.monroy@intel.com>
Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com<mailto:sarosh.arif@emumba.com>>
---
I will review it.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments
2020-06-23 9:22 ` Pattan, Reshma
@ 2020-07-13 13:28 ` Sarosh Arif
2020-07-30 21:21 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Sarosh Arif @ 2020-07-13 13:28 UTC (permalink / raw)
To: Pattan, Reshma; +Cc: dev
Did you get the time to review it?
On Tue, Jun 23, 2020 at 2:22 PM Pattan, Reshma <reshma.pattan@intel.com>
wrote:
>
>
>
>
> *From:* Sarosh Arif <sarosh.arif@emumba.com>
> *Sent:* Tuesday, June 23, 2020 10:19 AM
> *To:* dev@dpdk.org; Pattan, Reshma <reshma.pattan@intel.com>
> *Subject:* Re: [PATCH] examples/packet_ordering: Use rte_exit in case of
> invalid EAL or application arguments
>
>
>
> Hello,
>
> This patch has been sitting around for more than 3 weeks. Is there
> something that needs to be done further for acceptance?
>
>
>
> Regards,
>
> Sarosh
>
>
>
> On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif <sarosh.arif@emumba.com> wrote:
>
> rte_exit should be called when the application exits due to
> invalid EAL or application arguments.
>
> Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
> Cc: sergio.gonzalez.monroy@intel.com
>
> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> ---
>
> I will review it.
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments
2020-07-13 13:28 ` Sarosh Arif
@ 2020-07-30 21:21 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2020-07-30 21:21 UTC (permalink / raw)
To: Sarosh Arif; +Cc: Pattan, Reshma, dev
13/07/2020 15:28, Sarosh Arif:
> Did you get the time to review it?
>
> On Tue, Jun 23, 2020 at 2:22 PM Pattan, Reshma <reshma.pattan@intel.com>
> wrote:
> > *From:* Sarosh Arif <sarosh.arif@emumba.com>
> >
> > > Hello,
> > >
> > > This patch has been sitting around for more than 3 weeks. Is there
> > > something that needs to be done further for acceptance?
> > >
> > > Regards,
> > >
> > > Sarosh
> > >
> > > On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif <sarosh.arif@emumba.com>
> > > wrote:
> > >
> > > > rte_exit should be called when the application exits due to
> > > > invalid EAL or application arguments.
> > > >
> > > > Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
> > > > Cc: sergio.gonzalez.monroy@intel.com
> > > >
> > > > Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> >
> > I will review it.
Not reviewed, but applied anyway.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-30 21:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-05 11:48 [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments Sarosh Arif
2020-06-23 9:19 ` Sarosh Arif
2020-06-23 9:22 ` Pattan, Reshma
2020-07-13 13:28 ` Sarosh Arif
2020-07-30 21:21 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).