From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CFA5A0559; Mon, 16 Mar 2020 08:04:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 43A7F1C037; Mon, 16 Mar 2020 08:04:36 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B3E511C02D for ; Mon, 16 Mar 2020 08:04:34 +0100 (CET) IronPort-SDR: +8BtqC/pSBswOih3fsFHUZuFOighxuC0ipHdK42hJXrWPAQg8cQrqb46k+b370WFbNHqlX4puh XqUW2rS3V2OQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 00:04:33 -0700 IronPort-SDR: XzgxoFr5SYkwLMFI5jdSNsYYhisvdEOZcgHjs2Eit0CehGzwSDDY2eQ4NUv1RhlMzIiber0+bC VgTM8E9XyT0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,559,1574150400"; d="scan'208";a="235941166" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga007.fm.intel.com with ESMTP; 16 Mar 2020 00:04:33 -0700 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Mar 2020 00:04:33 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX158.amr.corp.intel.com (10.22.240.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Mar 2020 00:04:32 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.57) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Mar 2020 00:04:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K5VltUe8BLN1kPWCouHL+XwBpHvccreP9C2T6r9aSh/1Itnwvzs4bwEuxTZiBmNsJOHZm4HlcE8e4lUfL5ccZR8u38xX0WMN3IDf6cWdzJ0Rt1sIBFYqeGtT3Cb0jYHaE5phv8JU63Hts8wqqA6CLp8n/C3vSLeyJRVaip0O9nE+2As+nKORgu6Arp5Eg90K+kHJUFR8saj9ynTHu2Dk1aAA2bSGLKoQZmoNEBgjmizy84tB5dkSfH/tuJKiZDKLfDXl0GLWY1t4F2c+oNsjNRWU8b9W+6yKXsOj6fxGisgrbUFTCDjMhXLTny0lIhcSJF06G/XTdwqc01ysSiYKjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PrIH/tWwvCRd4FOt7sdMrZzGUb/LNLz2RNjcmCDEaX4=; b=KdXrgip+bGbaIvvWbiaVmg8e5wjBJVFBSepoAYFsi6vz23ig/IkVYZg8zQMcAZjO7V1Q4Iihk9Y2V2tu1DlW8ZZzHLB8KZowU2VkrEUnto4GXOfJg9uuibyBRQ/UT+tt1/98/xlaGzbO0eZ3YJLzZJxaPjuNP56veF8uyqHpHBvGHWHlAbHEY3dIYjtMDO3uBW0LwD2MVApLTlWBO0B24dx56r4faAy2dS8j3Yl2mRkKg+Wx3vGTMJ9Cm2cfhLa052/XTYxRxUS9jYJ3p6iJXPHeK1B2Cg/ZalrWmcrBWlH3lxfvVOHtAcF7RxACQYd6MebvVSFPiguF5kkbeVatRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PrIH/tWwvCRd4FOt7sdMrZzGUb/LNLz2RNjcmCDEaX4=; b=yD58vLMyxr92b4zzwhJYmU0ODLEh7wi4e+1mgy1WL58NgrPd3GbewH8D3Qk+pf+l0abgN70hLs4QB+RMFKiNPZrA1OFboS9/kBZLklqDsE6ta9M3dIqzznXc+tBetCer8q5DveOQcthciq7ZioORlVpi4BabcJzzaTz2qc7pNrQ= Received: from BN6PR11MB1473.namprd11.prod.outlook.com (2603:10b6:405:a::16) by BN6PR11MB1810.namprd11.prod.outlook.com (2603:10b6:404:fc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.21; Mon, 16 Mar 2020 07:04:31 +0000 Received: from BN6PR11MB1473.namprd11.prod.outlook.com ([fe80::d013:5d99:e57e:570e]) by BN6PR11MB1473.namprd11.prod.outlook.com ([fe80::d013:5d99:e57e:570e%7]) with mapi id 15.20.2814.021; Mon, 16 Mar 2020 07:04:31 +0000 From: "Wang, Xiao W" To: Xiaojun Liu , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "Keller, Jacob E" CC: "dev@dpdk.org" Thread-Topic: [PATCH v1 3/5] net/fm10k: add ffu and statistics and config file functions Thread-Index: AQHV7hKeADMDjVSTKEiq/IXv5s3+eqhK4e7Q Date: Mon, 16 Mar 2020 07:04:30 +0000 Message-ID: References: <1582207174-31037-2-git-send-email-xiaojun.liu@silicom.co.il> <1582879102-17977-1-git-send-email-xiaojun.liu@silicom.co.il> <1582879102-17977-4-git-send-email-xiaojun.liu@silicom.co.il> In-Reply-To: <1582879102-17977-4-git-send-email-xiaojun.liu@silicom.co.il> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiao.w.wang@intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c510017-275a-4628-2ccb-08d7c9784665 x-ms-traffictypediagnostic: BN6PR11MB1810: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 03449D5DD1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(136003)(396003)(346002)(366004)(199004)(4326008)(26005)(2906002)(186003)(53546011)(478600001)(66556008)(66946007)(9686003)(66446008)(64756008)(52536014)(66476007)(55016002)(6506007)(6636002)(71200400001)(5660300002)(81156014)(81166006)(76116006)(8936002)(110136005)(8676002)(316002)(86362001)(33656002)(7696005); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB1810; H:BN6PR11MB1473.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZymuChKGYtidgS7+BMbPRbloi420ZpOnqAwtz9AOmkkUVsfPUVWRDDOrx+FAkZNdEbkdlmWSb3CJbyQ1yAYddTpntyqC+dnroP7JiaFsbN47BT5Vc/S1nPmSDJOI2ouhedAgAWDZh8z/SiGaHBIilX0ja3xblvh6A149WXqqv3DCBym7Fi4380QsZQG4f5zdbnLTSZkXc1u61VaGgemAsgoFDLRlnaMPop5i7+aeYjmco279sDYXXcYUdIvirJWnVPwhpB7KinYRyfQ+5yNddBb6RJJbT6Rsb/fFQkHw1iK3bbTp8gOo92abNZpaypyK9a6pDwDUOf9pgvDdqjIN81ZwJOzESmsDprdWaddQLAs4m/JCZPacnoJsMS5EpCli6lO96sVMFeWub4zu03Otj5nZcap4ekwz6kUlOqHV+kgY1V6GfYQPz+LVABM6cCWj x-ms-exchange-antispam-messagedata: SJxjsXE6EaG7aPAu0A01YnSETa8I8PgmBjqgAsHcReWM/+6xqpZUw60R1+LWISO1uJ5snARm8irxukffKZU3ocO+h49GJQ9hNtW3ZxLwvDh4evkFdlWFVJRr8ILFqeaSo3sW/YkkQuLy0BVj2vWX2A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7c510017-275a-4628-2ccb-08d7c9784665 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2020 07:04:30.2502 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LGVTkKB1+E2Q4HGDnM9hEsckKEcUbWCeSyuUWL+X2GH7tBTI+32r8kfdNrBr9sRoSIq8S5zBlkW1nYIfamTOxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1810 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 3/5] net/fm10k: add ffu and statistics and config file functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Comments inline. Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Friday, February 28, 2020 4:38 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Kelle= r, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v1 3/5] net/fm10k: add ffu and statistics and config file > functions >=20 > Add ffu to support offload flow into HW. > It supports forward, mirror, push VLAN, pop VLAN. > It also supports flowset for a group flow definition. > The config file can configure debug log, port speed, > epl port mapping dpdk port, flowset. All these configuration > will be used by switch management. > Statistics includes epl port, ffu rule, dpdk port, and error. > All these statistics data are read from HW. > Modify switch header file to support getting logical port > and glort and device info. >=20 If new features are added, please doc them in doc/guides/nics/features/fm10= k.ini > To enable the switch management, you need add > CONFIG_RTE_FM10K_MANAGEMENT=3Dy in > config/common_linux when building. [...] > + > + /* GLORT_DEST_TABLE > + * Field Name Bit(s) Type Default > + * DestMask 47:0 RW 0x0 > + * IP_MulticastIndex59:48 RW 0x0 > + * Reserved 63:60 RSV 0x0 > + */ Please fix the alignment issue around here. > + temp64 =3D sw->mcast_dest_table_idx; > + temp64 =3D temp64 << 48 | 1 << lport1 | 1 << lport2; > + fm10k_write_switch_reg64(sw, > + FM10K_SW_GLORT_DEST_TABLE > + (sw->glort_dest_table_idx), temp64); > + sw->glort_dest_table_idx++; > + > + /* MCAST_DEST_TABLE > + * Field Name Bit(s) Type Default > + * PortMask 47:0 RW 0x0 > + * LenTableIdx 61:48 RW 0x0 > + * Reserved 63:62 RSV 00b > + */ > + temp64 =3D sw->mcast_len_table_idx; > + temp64 =3D 1 << lport1 | 1 << lport2 | temp64 << 48; > + fm10k_write_switch_reg64(sw, > + FM10K_SW_SCHED_MCAST_DEST_TABLE > + (sw->mcast_dest_table_idx++), temp64); > + > + /* MCAST_LEN_TABLE > + * Field Name Bit(s) Type Default > + * L3_McastIdx 14:0 RW 0x0 > + * L3_Repcnt 26:15 RW 0x0 > + * Reserved 31:27 RSV 0x0 > + */ > + temp64 =3D > + sw->mcast_vlan_table_idx | 1 << 15; > + fm10k_write_switch_reg64(sw, > + FM10K_SW_SCHED_MCAST_LEN_TABLE > + (sw->mcast_len_table_idx++), temp64); > + > + /* MCAST_VLAN_TABLE > + * Field Name Bit(s) Type Default > + * VID 11:0 RW 0x0 > + * DGLORT 27:12 RW 0x0 > + * ReplaceVID 28 RW 0b > + * ReplaceDGLORT 29 RW 0b > + * Reserved 31:30 RSV 00b > + */ > + temp64 =3D vlan1 | > + fm10k_switch_pf_glort_get > + (lport1) << 12 | 1 << 28 | 1 << 29; > + fm10k_write_switch_reg64(sw, > + FM10K_SW_MOD_MCAST_VLAN_TABLE > + (sw->mcast_vlan_table_idx++), temp64); > + temp64 =3D vlan2 | > + fm10k_switch_pf_glort_get > + (lport2) << 12 | 1 << 28 | 1 << 29; > + fm10k_write_switch_reg64(sw, > + FM10K_SW_MOD_MCAST_VLAN_TABLE > + (sw->mcast_vlan_table_idx++), temp64); > + > + return dglort; [...] > + for (i =3D 0; > + i < sizeof(rx_port_cnt_map_table) / > + sizeof(rx_port_cnt_map_table[0]); > + i++) { The style looks strange. No need to switch to a new line as " for (i =3D 0;= " is so short. [...]