From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AC3CA0559; Mon, 16 Mar 2020 07:49:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 044E21C028; Mon, 16 Mar 2020 07:49:10 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E540A1BF7E for ; Mon, 16 Mar 2020 07:49:07 +0100 (CET) IronPort-SDR: 29Wp9M0R+IDRqSuyhExhq5GPnrFTZodc7oHGuVgvh9ReBSSAqYdxiBAtG1N7wSsRWp7nFQxKUj RN6EFbh+nFrA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2020 23:49:06 -0700 IronPort-SDR: CKEu/remVmY/hwvdmzpjGYd99MlFs/OZbuI8wF/77P2nk6o91jjFvQuzB42dhHY7YKW84qpyuE lo2oMBEtlB+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,559,1574150400"; d="scan'208";a="235938344" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 15 Mar 2020 23:49:06 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 15 Mar 2020 23:49:06 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 15 Mar 2020 23:48:31 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 15 Mar 2020 23:48:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jV0BWwdm5Q7izwR4gHDf5YydaRELxATE1k6FdpmGnD4JnGC5KRDSTaEFJGG1ipkVQUpa0fzYb4nmXdoqP4pJ1kPQsNawhF211zq214w8X7QkTR5+xOxeaLv1wARfGNZxFURPKDWxFRaR5Vd206i0C9/czZIXkhkYKJeP7eDEFnQE6a/P4mvR2QV/7bzICFZAV+wg70F4Pt0ZdoH7jCySD0RxzCcZuekjniCO3ICJ7zX7EikMju6Zu2s/d+mPV9OPudVo2Cu/wKu2FAWtuwC/97UlD26ZzeipQ+tdsw2x8m4yU39oaq2ByHiz1G/BTAt7JxWbLTEiKpdQMwt8jS956w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AeZqdsMIVkANEzrUX8xBoFg2o0DEXm11jQjuB+bEa9Y=; b=mscMN913ahV2k2ucsbjPQoq/48qG83ZdLE4xQ36nFKqc75y6flKLezoWIUVeLTJZelw4bOjf3pMR9XqE5EGPzgM0EQe1novwb4gtgyqNr4wfZI3CiD12qQiKPLW6rP4uALhZqYdY7FoIf1NdbAlDrr6Lr+COVoKbY6vO+WKiifV46qDS8dem3uLA4oaTSaSol1dCZKQSENS9Ys65PgasGgz8+zyixlWq00nlWt/cVlSHjgv2dcBggp44QWJmYON0JX9+cAG45AI4gi0FCmS+P6hkTBaZIphEGG8Ralnwx2o5dMHDhXOt2XeJxp9cBjkbQ1bHltDstROluTl741S6Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AeZqdsMIVkANEzrUX8xBoFg2o0DEXm11jQjuB+bEa9Y=; b=gskc9pejthzpbYSwam1AMnRDRQER7q9k9W2RzoZEFZDikIpeJ5AmikipKlg+Tx34lC9WFUdhYj2jhV6iUk96bA/D/06i+9iznjhAOplT5NZAjI7itXc0HkT2y50ojeTfHqaN8f1hDfwT6+SLVMZQqmwhz36yRMOoZ+nHkP81nb8= Received: from BN6PR11MB1473.namprd11.prod.outlook.com (2603:10b6:405:a::16) by BN6PR11MB1604.namprd11.prod.outlook.com (2603:10b6:405:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.22; Mon, 16 Mar 2020 06:48:28 +0000 Received: from BN6PR11MB1473.namprd11.prod.outlook.com ([fe80::d013:5d99:e57e:570e]) by BN6PR11MB1473.namprd11.prod.outlook.com ([fe80::d013:5d99:e57e:570e%7]) with mapi id 15.20.2814.021; Mon, 16 Mar 2020 06:48:28 +0000 From: "Wang, Xiao W" To: Xiaojun Liu , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "Keller, Jacob E" CC: "dev@dpdk.org" Thread-Topic: [PATCH v1 2/5] net/fm10k: add epl serdes and port control functions Thread-Index: AQHV7hKeyBqE/is3ZkWbf9W5rvIk6KhK3sAQ Date: Mon, 16 Mar 2020 06:48:28 +0000 Message-ID: References: <1582207174-31037-2-git-send-email-xiaojun.liu@silicom.co.il> <1582879102-17977-1-git-send-email-xiaojun.liu@silicom.co.il> <1582879102-17977-3-git-send-email-xiaojun.liu@silicom.co.il> In-Reply-To: <1582879102-17977-3-git-send-email-xiaojun.liu@silicom.co.il> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiao.w.wang@intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f124e6a1-d601-469c-b6b4-08d7c97608da x-ms-traffictypediagnostic: BN6PR11MB1604: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 03449D5DD1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(376002)(39860400002)(136003)(346002)(366004)(199004)(110136005)(478600001)(316002)(66446008)(66556008)(64756008)(76116006)(71200400001)(66946007)(52536014)(33656002)(5660300002)(66476007)(186003)(2906002)(7696005)(86362001)(4326008)(8936002)(8676002)(81166006)(81156014)(6506007)(53546011)(9686003)(55016002)(6636002)(26005); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB1604; H:BN6PR11MB1473.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lAeyy6rR/N1IEAqeH2S0u9UvYDariZFgfHTGdZSTVo6CWlgVlOjejPJNNXlBe1KiwnMOsgVuOdqYd4qUYQwdiQKO7GqlLjTlo5+tmO0sE/DOnsl7QqUbfzVpiYwgiOGxRFsH0wm8xZUgw3JAte0hq6EsCCyjLoQpagfrzNxH+rtr5k35dmI3R1ciN+ez6XCJ1CM6qA6HicRAOrdK9h6AO23Tt+A7YSJHL3IxWcFiyuFmTU3gBxnsCAriqduUCVmoRPnr2mQyUIx5c7/6xLPt1McPy/HOIuZzmW8qpCBHyfKCjyhnduPxGKxJ6ZswsB/7qy3/bIwv/bxBp40rEVK7QM3wWz9PPKw0Kar61qfWjOTMvdvAWEnvd5wJUvnJrMc9f6aPgVKeH7hg+vK4EC+FXf1RuUQATyaYT35UA5fVxOXZuVISGYiDAwEP3vcjEPQB x-ms-exchange-antispam-messagedata: KAEoXTMr1HuODnyWJ72YVTh5bC1/bYUj/wGH2HrbT5hHoMEFHdLVT3M6QoArbmetEy48/nbeqAxmsb5o7JSsOMNcG0oK/X8JLaprOlSL4SiP3E6qXQsvEr/XP3helP6n7F1ii+aTsO1wX0AdJiklMA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f124e6a1-d601-469c-b6b4-08d7c97608da X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2020 06:48:28.7390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DbwjAv9dghzbgl7i+4bslgQ6Rqe95DeKAo/EKsxHl3haqAtytd852XBiG/ugUiCpIvPyk031iSUMxUamUM1SuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1604 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 2/5] net/fm10k: add epl serdes and port control functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiaojun, Comments inline. Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Friday, February 28, 2020 4:38 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Kelle= r, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v1 2/5] net/fm10k: add epl serdes and port control functi= ons >=20 > Add epl serdes include loading spico, > controlling pcsl, dma, dfe, ical. Add spico code. > Add state machine for epl lane and port, it creates > a pthread to handle the state changing event. > Add external port management, which will use > state machine to handle the event from lane and port. > The lane state will change between DOWN, WAIT_PLL_LOCK, > WAIT_SIGNAL_OK, WAIT_DFE_ICAL, WAIT_DFE_PCAL, UP. > The port state will change between DOWN, WAIT_LANE_UP, UP. >=20 > To enable the switch management, you need add > CONFIG_RTE_FM10K_MANAGEMENT=3Dy in > config/common_linux when building. No need to add above section in every patch. I suggest to put it into doc/g= uides/nics/fm10k.rst, and you can have a more detailed description about this big feature there. Please also check the empty lines and alignment issues.