From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A742FA057B; Thu, 2 Apr 2020 10:41:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 119C31BEA8; Thu, 2 Apr 2020 10:41:49 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0CF2E1BEA6 for ; Thu, 2 Apr 2020 10:41:46 +0200 (CEST) IronPort-SDR: D+1NJM5vLaw6LF1aGxGk4XKRXfOfh/31FIs+6r41j6B8Xuk/EXzyXISkDWAony8nDyGfzF0yB2 YfUlNoppfQDg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2020 01:41:46 -0700 IronPort-SDR: QU1klzyPl+0dVnkUk0DoJBQMxknDnrBFFqXoyliAMfXGRLWk5lJs/VMna3QPmpcBtxlRxHBLOw GrNTAaMMf0kw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,335,1580803200"; d="scan'208";a="252923733" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga006.jf.intel.com with ESMTP; 02 Apr 2020 01:41:45 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Apr 2020 01:41:45 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Apr 2020 01:41:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fUyT1FTNs50S9BmSQbPVYLFfaaB4iKWtVj4Cb5wqaatPedBHmzsbO286ceMCEZBsLApbMa3kpCDQSgslObR3an8LNasi6VVSmGNGtgHjcKV15fd8kQbGPp32YBOn82u4UCTpMU/4LjPd0149pAW5KhVYMYzn5+MluPFGQ5ZXT//dXQReOMhUuiVjuDzQ00TVJ0JbKtOigFdcgmQX2bA6aY1uli0mNHDFYtdrgvNAlev4EVFdc+t2XXks8lWuU0drMGSaVISVNpdX2bszBtX1PQZy5SN73z5mOODtDfGtWijhclNjJpZnma4EP0UshmU30PUm92M7q/6yUzg8XfQ+Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zOSpu3uj+ol+PPWX6H7A9rQji0HGy5PmMVv/Rm9rghc=; b=aGx6y4hhdMJfQdaUFtltpVMDoPqsg0vjnESkz0/wULAqaIAYDIAZitdKJ1MGNfnliKy2BAc2tJgBmT/o6/Vxsnl7Qz6A5q7C9ynKHF86pVyyZCQ+pMgX4TbpZDSIJRbKMNCXbeAYGMWDTjK51ldpxx+uEDiL0JGw8Il/E1y48jiuqm8WHZ+D9EhupZ/7r6h3xTHfO+BPPF9x6dEgOeJ3hGmCWVKiZJ8QLJz7EFvsIB9+OH4TB4S1AXfU5gMOyv7aGExKa/czH9C3D+WO4vSGyZAvywQUg2qZtQIbzWcraTDfj5y8jTYGzTf9Ye2FcUTEQ2hFnAOnO437sj83zSL0+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zOSpu3uj+ol+PPWX6H7A9rQji0HGy5PmMVv/Rm9rghc=; b=U/jzkM2ZkwtZxhOydfjh20Ba4SOZOH2guwM9FoZJWJ+bzxzje+qhxqqAd6F0fiUPtD3Axn7c8y5mKH8fENgmzzFzq3MV3eReo3r3Rsr67qeecWynBazya6undaG7bgVO1d+Qa6gPf4iooG9v2LhquaeafLrAolo1SWGntg3FUkI= Received: from BN6PR11MB1473.namprd11.prod.outlook.com (2603:10b6:405:a::16) by BN6PR11MB1521.namprd11.prod.outlook.com (2603:10b6:405:e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Thu, 2 Apr 2020 08:41:42 +0000 Received: from BN6PR11MB1473.namprd11.prod.outlook.com ([fe80::d013:5d99:e57e:570e]) by BN6PR11MB1473.namprd11.prod.outlook.com ([fe80::d013:5d99:e57e:570e%7]) with mapi id 15.20.2856.019; Thu, 2 Apr 2020 08:41:42 +0000 From: "Wang, Xiao W" To: Xiaojun Liu , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "Keller, Jacob E" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 1/5] net/fm10k: add basic functions for switch management Thread-Index: AQHV/oU9v+9O9wLl2EqP8/QHYsRfYKhllMMg Date: Thu, 2 Apr 2020 08:41:42 +0000 Message-ID: References: <1582879102-17977-6-git-send-email-xiaojun.liu@silicom.co.il> <1584687523-19362-1-git-send-email-xiaojun.liu@silicom.co.il> <1584687523-19362-2-git-send-email-xiaojun.liu@silicom.co.il> In-Reply-To: <1584687523-19362-2-git-send-email-xiaojun.liu@silicom.co.il> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiao.w.wang@intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2562f04a-1190-4a16-1ace-08d7d6e1ab09 x-ms-traffictypediagnostic: BN6PR11MB1521: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0361212EA8 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1473.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(39860400002)(366004)(346002)(376002)(396003)(136003)(5660300002)(66446008)(7696005)(33656002)(66476007)(26005)(8676002)(6506007)(186003)(4326008)(52536014)(76116006)(53546011)(86362001)(66556008)(64756008)(71200400001)(66946007)(81166006)(55016002)(81156014)(2906002)(6636002)(110136005)(966005)(316002)(8936002)(9686003)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Sx/33imde9gMb83W16Bz6FLlfSgG4kMQUP2k+tMQ+NE2hhg9pnYDjb9pSqy2nBX1qk9zU0wIj7g4WJVkM2ny6z2d8g6Vqtox7rgexLVfLbfpW0Ys0Bolc6dzqxO+BI6ghoaFUxEHvAvsmJ5AudkAKuW1fpqsS6SDHaplhSGjfqPMiI4jz3Y2NdgG9r6WL7O1WABCwln0YglMjrfbxD6NiwdfNyTyvBiZph5r5N8bgckKrUPbnUPFOwLxZI7QrORVC3+T3RKJ66fpz0DsDLDkG8LLVS4XYq2kQXTtEgw22+QPZa+KpPBYG6inVJPLye1NI0PR+/Ad2z4xgvra0sEgpOtbn80WKf14ONReGFE3Cz+G5WXpLBr8Wc2CLpDE9BbYhxeRHiTg4sS1vwHzy40hGquy1ia+l5EkRps92DupTPNg4G7l4ga5JAqXR0tryccKcKfKnplC5bQMlzRYX/hNkDWVYY5eYl09LrnzqhJw2e7RxiwQL/wobXWBwKKm0ZIpLjRZTlJJReJn9LSumnvYAA== x-ms-exchange-antispam-messagedata: Q94vH8yCQMgu1vLGG1VVXNc8y3Ci70onOhzxxmVJc58ZVX+sgCOh6Z7hQyD65Cug3OmIphswcRcL24UJ1S9lcfCWoJCOubLobY1I53xvtoB0VZUrJfkiYfmPSvUazjimvPcbtwFWJ4Aj7npDlwoBSQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2562f04a-1190-4a16-1ace-08d7d6e1ab09 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2020 08:41:42.1071 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yawvarlVgvzZSy57sUzqEASacAlW2d88nLR2oZ1Pdjt5D67wmU3dl3Nk/Pg7LIl5v9QjNgEKKV2fZE9LvzsuUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1521 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for switch management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiaojun, Just comments on the alignment issue, things like below looks not nice. If = you are using vim, I recommend " set tabstop=3D8 " setting. +#define FM10K_SW_BIST_CTRL_BIST_RUN_PCIE(p_) (1ULL << (p_)) +#define FM10K_SW_BIST_CTRL_BIST_RUN_EPL (1ULL << 9) +#define FM10K_SW_BIST_CTRL_BIST_RUN_FABRIC (1ULL << 10) +#define FM10K_SW_BIST_CTRL_BIST_RUN_TUNNEL (1ULL << 11) +#define FM10K_SW_BIST_CTRL_BIST_RUN_BSM (1ULL << 12) +#define FM10K_SW_BIST_CTRL_BIST_RUN_CRM (1ULL << 13) +#define FM10K_SW_BIST_CTRL_BIST_RUN_FIBM (1ULL << 14) +#define FM10K_SW_BIST_CTRL_BIST_RUN_SBM (1ULL << 15) +#define FM10K_SW_SCAN_DATA_IN_SHIFT_IN (1 << 25) +#define FM10K_SW_SCAN_DATA_IN_SHIFT_OUT (1 << 26) +#define FM10K_SW_SCAN_DATA_IN_UPDATE_NODES (1 << 27) Check more at http://patches.dpdk.org/patch/66973/. Please take care for ne= xt version. I'm wondering if we could have a tool for automatically check this kind of = alignment issue. Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Friday, March 20, 2020 2:59 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Kelle= r, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v3 1/5] net/fm10k: add basic functions for switch managem= ent >=20 > Add I2C to control the inside LED and PHY. > All the operations of I2C are using fm10k I2C register. > Add SBUS to communicate with spico(micro code in serdes) > by using fm10k SBUS register. This is like I2C operations. > Add registers defination, which include all the registers > will be used in the driver. Add switch management log API. > Add switch management structures. Modify Makefile to add > new files building. Add CONFIG_RTE_FM10K_MANAGEMENT=3Dn > in config/common_linux. >=20 > Signed-off-by: Xiaojun Liu > --- > config/common_linux | 5 + > drivers/net/fm10k/Makefile | 11 + > drivers/net/fm10k/switch/fm10k_debug.h | 19 + > drivers/net/fm10k/switch/fm10k_i2c.c | 309 +++++ > drivers/net/fm10k/switch/fm10k_i2c.h | 55 + > drivers/net/fm10k/switch/fm10k_regs.h | 2302 > +++++++++++++++++++++++++++++++ > drivers/net/fm10k/switch/fm10k_sbus.c | 291 ++++ > drivers/net/fm10k/switch/fm10k_sbus.h | 40 + > drivers/net/fm10k/switch/fm10k_switch.h | 335 +++++ > 9 files changed, 3367 insertions(+) > create mode 100644 drivers/net/fm10k/switch/fm10k_debug.h > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.c > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.h > create mode 100644 drivers/net/fm10k/switch/fm10k_regs.h > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.c > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.h > create mode 100644 drivers/net/fm10k/switch/fm10k_switch.h >=20 > diff --git a/config/common_linux b/config/common_linux > index 8168106..6e62b99 100644 > --- a/config/common_linux > +++ b/config/common_linux > @@ -66,3 +66,8 @@ CONFIG_RTE_LIBRTE_HINIC_PMD=3Dy > # Hisilicon HNS3 PMD driver > # > CONFIG_RTE_LIBRTE_HNS3_PMD=3Dy > + [...]