From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F7F3A0556; Thu, 20 Feb 2020 16:39:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39E011BFA2; Thu, 20 Feb 2020 16:39:56 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 6510B1BF9A; Thu, 20 Feb 2020 16:39:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2020 07:39:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,464,1574150400"; d="scan'208";a="230159192" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga008.fm.intel.com with ESMTP; 20 Feb 2020 07:39:53 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Feb 2020 07:39:53 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 20 Feb 2020 07:39:52 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 20 Feb 2020 07:39:52 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Feb 2020 07:39:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JqKNRG6+0VBwwdgUfKmonQV/whu+gQgjvGfCCeWspEKOrNOBForbQMi4yUNDd+QVPBttiL3YIKUA2NFJq/j8AU7lP1yjCcluvZ0EO+cZARKOR2ABe3sH00Cs49OTEocOZMJBm7W7pkLTt0X2f+80Ov9o3xc0U8Z6+FSqSyOoNHTPvhVd0kohBVHMQAIJy7ki/d34x2JlBMvpM4Givvuyvwjv/yW6NvahQylFUwvwaGq+tTg3HQOQCVg+cl8rJyXpq2J0CuhwijDYu0hTyQvvQtAoSPAFq2JT/xJafrpKzMvG5HMrJsrSFouvgxSCaCsJHi0vPotdO9tEGI7T90iLQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Oe0w0nfZFACvn7GzVgYES4Qh1jJpNtS6x1pIj7+6hY=; b=kZIWTQgBhrbG9sLNw1tZxvqKKkgfWEWU8paDUEOQLqCPP01txdy3lAmL9dzmFfKWrYqaZPt3+4Syx2EB0P9s9p6EnDq1V/oymemJ5Lf2s+SqgegQpJy6R0ki4Zcpn9CHdnhhUXByY5Q2UYUUyxwZtHWTIQ5h0Q7Igm65/o5J9aiMbtVvRBgvs9/+csT71BSI1YLYZ3qoMnP2i84zSJPBIi/0mGilc6zjVsrUw3LaXCPgEQhGwb8tSU4j5srEFGI2TkTzJ61GPq9Fxi9Bt9pDSMsL8G03L95ZI5WpdT2VnDa5ucqkoH7CDwBZ0bCFeIRM1m4DydXCkvwGYKlJJMMFrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Oe0w0nfZFACvn7GzVgYES4Qh1jJpNtS6x1pIj7+6hY=; b=MRF6Du8lFjCwiCdCkFjmk6wKi+ri0djhjgEDNV9kjjKi7dlHS37ZEVdwuSTHIk6WuBtrWnOlmyu21bjCFKj/8ZVleWmYUU6jxNeg3des+4zAvxu2O17juR0tlUPbiENoRJ7OHMbF0eKISTDasxHRxmG3wL04CctLx9P4dnAzvfQ= Received: from BN6PR11MB1796.namprd11.prod.outlook.com (10.175.99.136) by BN6PR11MB0052.namprd11.prod.outlook.com (10.161.155.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.31; Thu, 20 Feb 2020 15:39:50 +0000 Received: from BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4519:125f:2122:de07]) by BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4519:125f:2122:de07%3]) with mapi id 15.20.2729.032; Thu, 20 Feb 2020 15:39:50 +0000 From: "Trahe, Fiona" To: "Dybkowski, AdamX" , "dev@dpdk.org" , "akhil.goyal@nxp.com" CC: "stable@dpdk.org" , "julien.meunier@nokia.com" , "Trahe, Fiona" Thread-Topic: [PATCH] cryptodev: fix missing device id range checking Thread-Index: AQHV5//w1aC2/sfvp0uSCMI7uaRCDagkNvbg Date: Thu, 20 Feb 2020 15:39:50 +0000 Message-ID: References: <20200220150415.32091-1-adamx.dybkowski@intel.com> In-Reply-To: <20200220150415.32091-1-adamx.dybkowski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOThhYTQ5OGMtNDNkNC00MjczLWJhMTktMTNiZGVhMGNiZmI5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidTM0TDFjSDVEK1lURm9vbUM3bEk3aldtd2JWQVQ2b3Zub0JKaFlDbnErUndWc1B2RzVZbktBR3RLeFY3T2hXSCJ9 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 64210cd0-4680-42e2-8bc8-08d7b61b1f4f x-ms-traffictypediagnostic: BN6PR11MB0052: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(396003)(346002)(376002)(39860400002)(136003)(189003)(199004)(478600001)(316002)(4744005)(9686003)(107886003)(71200400001)(81156014)(54906003)(52536014)(33656002)(5660300002)(2906002)(110136005)(186003)(7696005)(8676002)(86362001)(55016002)(6506007)(8936002)(26005)(4326008)(76116006)(53546011)(81166006)(64756008)(66556008)(66446008)(66946007)(66476007); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB0052; H:BN6PR11MB1796.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: beVOIG/g7NBV2uX5zN9MN7WGkT87ozJMZlidLUHP3AajgEfG+GqEl98V7BlBLaL2/See0CknIs8IPYGYsXeCs0BtlFPd100adJv5/+jgndEnyvPq0VyrRWE5FkJFbZ5eSF7S+fgtqQDIHYlZB5ST+3HXwAd9pf1eIfedqVHZsGM5fMXumtoSBVupV/DxJpgpt4Ei+51mjswtqKE55mk/+pzA+ZcAthRpjmCMVhZo76RxNaPCv/vvT86u5WnbNCXRVgi5naFJ7FdDwa0LUCgfqHfTNr0o4NU3RnVIEwUYrExvV7vqfjsyrQQNxpyhoCX43xguEkeNMmFaO8fJgLUgrqSZy1XJ7LNYRDV3tUCy0iDL2IGhtkOGxUX9RVi4rm5WQ3xUQrVUc04EHfxTRV+5xcgQYYSiXmJlp33Dmt/bHrxr3meba36Ja2jD6+TrVW7G x-ms-exchange-antispam-messagedata: s3ebSmx1SxmavKoLldIkh5PTJm6djKZrob7ZExFJfaJkYVA5JZlC6mxNxvRy4gp6VmUvEQ4FInkfsMiU4yEbd5Yi8ZdqG6bT9EmkKbxMRvHQzwbYsLSYdmjMXFgv+GejGLelmOYYavf20CeJJgwjrw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 64210cd0-4680-42e2-8bc8-08d7b61b1f4f X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 15:39:50.0844 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eBsxu6xjjfDM2cl7VXU2hM4UwlE1o8yRDUOYskRf76mPpa0W9YouMskAPUpa2peIutB9Y5prrN9SsUFaHutm1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB0052 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix missing device id range checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dybkowski, AdamX > Sent: Thursday, February 20, 2020 3:04 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.goyal@nxp.c= om > Cc: Dybkowski, AdamX ; stable@dpdk.org > Subject: [PATCH] cryptodev: fix missing device id range checking >=20 > This patch adds range-checking of the device id passed from > the user app code. It prevents out-of-range array accesses > which in some situations resulted in an > application crash (segfault). >=20 > Fixes: 3dd4435cf473 ("cryptodev: fix checks related to device id") > Cc: stable@dpdk.org >=20 > Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe