From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88E9FA0537; Tue, 4 Feb 2020 18:47:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 65EFC1C204; Tue, 4 Feb 2020 18:47:05 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 36ECE1C068 for ; Tue, 4 Feb 2020 18:47:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 09:47:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,402,1574150400"; d="scan'208";a="224371856" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 04 Feb 2020 09:47:01 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 09:47:00 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 09:47:00 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 09:47:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aXkozZMNiGnGuS4OIR88F22Fhc/8ahfZxLLQhLfdEAeiNcCX6A6tR/6VsDR7fGzQvj4MGq9/h1VLXjS0k//eYXR6IuBamLyIY3pvIGB/6Y+3quN6whuv4BJLMC8TEqhWv7M+pXJpy6g/g+eTiZsQY/kuo5XM/xIYYH88Q8fCczsYLQ29aaEf0TmT9AB3KhdFFiyzMLLrt9KpSWFDyziVJaPh7aKmVw2ViDW8RfNZixR+yVS9/KycYC2WkoS50V8yCNoB4RmASxTijswydCC4BZaKGecimNdRZBqH7FqlaVLPkZv4MySun1K2dY7bpa0KZZWVJzvyHdaWUUzxCZALjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y+3lm3gbFI8vIAhhFJ0CGJ1+4Lb7rA14GeD7bIY8xx4=; b=TAt3XjqyYoQa1Y3VMtHCd4ht2suwXPbVp0ShkmuYHx4zAZjTXhAW/7/tKi3AhdWs70G5OpK19YcpVMZ8I4g0WSX23FBzYoTn796eioLzuBW4ejIVtMH9BDh83w/A7VyB7j9gqrzIyaBRTriKF0lHF8j4XeNXmCStDVkb1MfmcdacM3qsihFbHvq73T+41+GV0BL7s+7+fWPNQMkyumaEyAU+J7d7OEJUbZSYMLrGYqIIdC3NECBt1/yde2brCp33BjysXOIm+vN5j3uAy8nwfIAi41aEH65cXXeQBZlMetzQRqzIBweSUvsTt6mttWoC9z+JZ+LDxouoVAqUBqRoPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y+3lm3gbFI8vIAhhFJ0CGJ1+4Lb7rA14GeD7bIY8xx4=; b=lRTQ3L2RGBHkMPx2BgoWcMuRMJwXHz+egHt7eayIIh34iwcfbyqKSyOT62cN7ymuQIQJ17jNGq4vR3cN8udD8rKNYDRFa6BcMX7pKpwzSqvrgMb9GOxm2XL9NjDi1CsNEAzuDPnWvS1/d1O1gH4c4Rlgz4Cyb9EP6CbHpQ9oNyo= Received: from BN6PR11MB1796.namprd11.prod.outlook.com (10.175.99.136) by BN6PR11MB1249.namprd11.prod.outlook.com (10.173.27.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.33; Tue, 4 Feb 2020 17:46:44 +0000 Received: from BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4519:125f:2122:de07]) by BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4519:125f:2122:de07%3]) with mapi id 15.20.2686.034; Tue, 4 Feb 2020 17:46:44 +0000 From: "Trahe, Fiona" To: Thomas Monjalon CC: David Marchand , "nhorman@tuxdriver.com" , "bluca@debian.org" , "ktraynor@redhat.com" , Ray Kinsella , "dev@dpdk.org" , Akhil Goyal , "Yigit, Ferruh" , "Ananyev, Konstantin" , "dev@dpdk.org" , Anoob Joseph , "Kusztal, ArkadiuszX" , "Richardson, Bruce" , "Mcnamara, John" , "dodji@seketeli.net" , "Andrew Rybchenko" , "aconole@redhat.com" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH v2 4/4] add ABI checks Thread-Index: AQHV1smFGAWDLtMfdkaM/74xTf+RAKgB6XuAgAAHoQCAAB+HAIAAAt+AgAFOQgCAAEVxAIAA3urQgANfUACAABrKgIABOz0AgACAVwCAAAb/gIAAFsaAgAAktQCAAN6iAIAAJLJQgAAxliCAAAdmAIAAGrIw Date: Tue, 4 Feb 2020 17:46:44 +0000 Message-ID: References: <20191220152058.10739-1-david.marchand@redhat.com> <7712335.T7Z3S40VBb@xps> In-Reply-To: <7712335.T7Z3S40VBb@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTliNWY4ZjUtMWIxMy00ZjJkLWFlNTEtNjE4M2Q1MzNiODg5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSXZDQmJKMGttUDQwNXR1THJadFJ3VEZcL0xkV1JCMlBSeTV1aEx6TEE0RmlzazF2U3NOTkgrUnhSTUljVFBBaVMifQ== dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1149632-5e49-4bff-3173-08d7a99a336a x-ms-traffictypediagnostic: BN6PR11MB1249: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03030B9493 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(39860400002)(346002)(366004)(376002)(136003)(189003)(199004)(55016002)(52536014)(5660300002)(81166006)(81156014)(86362001)(9686003)(107886003)(33656002)(478600001)(8936002)(8676002)(6916009)(53546011)(7696005)(54906003)(2906002)(316002)(7416002)(26005)(71200400001)(4326008)(66446008)(66556008)(66476007)(64756008)(66946007)(186003)(6506007)(76116006); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB1249; H:BN6PR11MB1796.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +AM6jQCcyRJrcWe6OcqRE4IazlbWNvorvidzJjdr6yIoJjKhNO5gcMB9CeE1DogLkbcbScBwM07yaKtsrkNdbyhhQuiS+evCMyipuxwY6XFX8EteVvu7OVTS5Ylw1Yqwk+EyGE4+xB3roEpSBND4+LHTXW8f60M1KPuqvFGrmUTcbYnL6G0YHuGazAmKDFZmcHckLaDmPp0sDLVV2tV2MXjuLdWMellkUcNXHX0MAbwpm+PvnGmrmh5Qtu5qxPdKae3p3FknkB+k9JSN3t0F+0eTU8j61hytE8HGYJZQpn+bDX5zzT7ibKVbLHGK6IPM1qRSvdFBQQGSRVxNBrSphU6+2z7HN9i5twVuc7L0n5Frl0A89vA4FuURPzzkghBIw640uZokbmNgpBVOLggw7hn53xPsraDkGpppSjcBMIXe/KEiATZNz3fGEEwZrObh x-ms-exchange-antispam-messagedata: +QNCnPDquQ8yF0ngy+I65CSh3jTECJbV/5ukBO2hI4ofjyoHb0PBbHWvTSeXTW+ExIraJBuUvcCq/viOBoJJ/eH4SVXmi3V503ApKFktTsXBZOkU2/0DzqxK9AyiqgmO8aE7587T5zorNIetUYPwcw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f1149632-5e49-4bff-3173-08d7a99a336a X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2020 17:46:44.6665 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wu1OCF5aJ1RcMMHISeF25DhqFioSLjuuu1SMW+j39ZILhL3d2ei54lBCKFSIlG6s8AFqVy2XWEG88/JIn1533g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1249 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, February 4, 2020 4:00 PM > To: Trahe, Fiona > Cc: David Marchand ; nhorman@tuxdriver.com; bl= uca@debian.org; > ktraynor@redhat.com; Ray Kinsella ; dev@dpdk.org; Akhil Go= yal > ; Yigit, Ferruh ; Ananyev, K= onstantin > ; dev@dpdk.org; Anoob Joseph ; Kusztal, > ArkadiuszX ; Richardson, Bruce ; > Mcnamara, John ; dodji@seketeli.net; Andrew Rybc= henko > ; aconole@redhat.com > Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks >=20 > 04/02/2020 16:52, Trahe, Fiona: > > > > > We are working on a patch, when it is ready we will send it. > > > If it's not ready by end of your today, of course, go ahead with (b) = and > > > we will work towards 20.05. > > > > We will not be sending a patch today. > > The patch we're working on will provide two versions of rte_cryptodev_i= nfo_get(), > > both call the same PMD function from the dev_ops info_get fn ptr. > > The default version operates s as normal, the 19.11 version searches > > through the list returned by the PMD, looking for sym.aead.algo =3D Cha= ChaPoly, it needs to strip it from > the list. > > As PMDs just pass a ptr to their capabilities list ( it isn't a linked = list, but an array > > with an end marker =3D RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST) if the = API > > layer detects Chacha it must allocate some space and store a local copy= of the > > trimmed list. This must be stored only once per device. >=20 > I don't understand what you have to store. > Can't you just set the algo to 0 if it is ChaCha? [Fiona] it returns a pointer to data in the PMD domain, which the API could= n't and shouldn't overwrite, e.g. static const struct rte_cryptodev_capabilities qat_gen3_sym_capabilities[] >=20 > > This versioning will apply to any PMD which wants to take advantage of = the new API between now and > 20.11. > > > > Note, I expect the ABI checker tools will still complain of ABI breakag= e as the LIST_END value will still > change. >=20 > Right, you need to update the ignore list for the tool. >=20 > > We are also reviewing all other cryptodev APIs in case there is any oth= er API which needs versioning. > > > > Anyone see any problem with this approach? >=20 > The other issue is with all other functions accepting this enum as input. > We should continue returning an error if getting Chacha as input with > 19.11 version of these functions. > But I would tend to consider this small ABI breakage can be ignored > as it is in the error path. [Fiona] The QAT PMD tests for and handles this error. I expect other PMDs d= o too.=20