From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC4ADA04E0; Thu, 28 Nov 2019 12:47:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21DC5293C; Thu, 28 Nov 2019 12:47:39 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E9A43A3 for ; Thu, 28 Nov 2019 12:47:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 03:47:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,253,1571727600"; d="scan'208";a="212050001" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 28 Nov 2019 03:47:36 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 28 Nov 2019 03:47:36 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 28 Nov 2019 03:47:35 -0800 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.50) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 28 Nov 2019 03:47:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aGLm+PbfuzTX8XibmdNIvzHTkxMaIaH76BiLVts6c1rl2b+9LMrl8xVrPwJ6iledoGJlgRsCESzIPvyfxBwYYmI4Y0hrdOFZcWIt15HZJK7cndYnFq4BODPr4XaNY7i66vevGyVRuC9gXHw6T41gtRuxCbs0kJocYiuiGx/QQwcNpK/zMJvHyfRL3gP4yESQbQH6KOct1MWlgc5GS85QDwX83NJgEFczpRcYw1URCWpNNpf/B4960RbOelZCzECZThzLrJlGOeoAMCdyLA+yLtNRcz4ww5Mi6S/fvH/ZfPeOwOTC2JQwqvohbanKeTPahRl6pvBl+oJOeNaweP/tTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JOZjjacEDCEAQS0O44G02O6auV/eAIwIx1EkIn//f48=; b=OLXSsVeVaC6StBzi0XLV1bNMATxep7R/VvJvxdjjkObv1ArEEVxEvFkwlSxYp8VOxfts9EZqO/fGR9Pt3YcUbKd9pR2JAiNPGa+6nxyo0k888u59WQ7eczeUN4lxMxUGVD2EQ8XhpwUw03QMeytt9SPAOvvZgFqrb/zsKZtwKjLngrEOk5ZQjZUus8//sEYrB0Ed01fre1mB1raJ4qgGqTtdCTbwNCh3oNMEl9mqr5t73swixCMYDL05oc7tqJ7CX3C0zmyKecNgQvaGbMH9GzFuqTdVkyLzeOZ0h8dRO5+8/sdeA7qGOB5gYV2ozADF+MvUHyFUdvlCBWXEOcxx4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JOZjjacEDCEAQS0O44G02O6auV/eAIwIx1EkIn//f48=; b=cPVe+P9hsPN78utBHdONuFcKHbvEcwiDZUVYhXR4c6iAp0BGsG0JPijpzlf8+iX+SPrZ7H/STjbo3xgFqTM1YX76jitHNj1/P12mceF0GBS/HvVPG6gdJEvzoQKWsWK9Tu+ZPRUbTc9JllDF+LnZaZrwgbIyYMDZVzmo2rfyKEA= Received: from BN6PR11MB1796.namprd11.prod.outlook.com (10.175.99.136) by BN6PR11MB3875.namprd11.prod.outlook.com (10.255.130.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17; Thu, 28 Nov 2019 11:47:20 +0000 Received: from BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4016:7fc:ea36:328f]) by BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4016:7fc:ea36:328f%7]) with mapi id 15.20.2495.014; Thu, 28 Nov 2019 11:47:20 +0000 From: "Trahe, Fiona" To: Thomas Monjalon , "Mcnamara, John" , "Kovacevic, Marko" CC: "david.marchand@redhat.com" , "Yigit, Ferruh" , "dev@dpdk.org" , "Richardson, Bruce" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH v2] devtools: control location of test builds Thread-Index: AQHVpXa8CP22gSe0hUGgADem1/2V0qegdUkA Date: Thu, 28 Nov 2019 11:47:20 +0000 Message-ID: References: <20191009101026.49019-1-bruce.richardson@intel.com> <20191127230055.23608-1-thomas@monjalon.net> In-Reply-To: <20191127230055.23608-1-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjBiM2I2OTgtZjZiNS00MjljLTljM2UtYzc2NDJiMGFiMzMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTG9sOWRGQjZMdWt3Rll5VXJuVWtWd2ROSVVkSE9jOEh1RE1qeURaeHd4TjFFbUVWWFNVNkw2cEFoZm9yeFRkUSJ9 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.169] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 16ece1ec-03c3-47b9-2d45-08d773f8b9fa x-ms-traffictypediagnostic: BN6PR11MB3875: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0235CBE7D0 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(366004)(396003)(376002)(39860400002)(136003)(189003)(199004)(13464003)(66446008)(6246003)(107886003)(81156014)(316002)(8676002)(81166006)(64756008)(102836004)(76116006)(53546011)(66946007)(76176011)(3846002)(6116002)(4326008)(229853002)(54906003)(7696005)(99286004)(25786009)(26005)(14454004)(9686003)(6506007)(478600001)(110136005)(186003)(8936002)(2906002)(6436002)(55016002)(11346002)(6636002)(86362001)(33656002)(256004)(66476007)(66556008)(446003)(71190400001)(71200400001)(305945005)(52536014)(66066001)(7736002)(74316002)(5660300002); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB3875; H:BN6PR11MB1796.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aFUhkLoo4O/neG7Pp+7SxPvE7GLu/0Lx/16xWIKzEDXOX9wBby4juKS0P0wTVSfhgl+xnTNQX5pBYE4Ju8Ow9kH4x2ByqjWXY279pUBuIC5QPB2jWZ+5HddqjTHfYZGoGp/+lecDc93nNxBYLvPCZafQqwHqc10CLROqRzxP+03I8tkb9fPm8DjJsCWXF8lBAF5coMuZZU92Sh48FahEvErmcl29Zvl/I8lAl7SU5ynuycIsi/UUogWekbPAKQtFOvbVpAe19u6JH+PZUVcdDw/ekVv8EEenYP6Mr2MAA4ztWISzRDYRBJHxV52pbcBuYn7Ox/uE/JsTTLcDB4TWTq17hNpcgffnbgR4jjvhr8d+fasCd8xWEkwE335DKSWbzwh4Lu9UDXGQYY+mFBJxH3qDGRFD3nS5eh7hCjJEjwip3ewp1BZve2Ig42fye57b Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 16ece1ec-03c3-47b9-2d45-08d773f8b9fa X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2019 11:47:20.2160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ka12Flk/zHMUwkgWM6uyYPMjAfJYevVC/p7AbsgjMTlm43uMtLGmk5s6N1yaBRPc0Aam7mH/MRrvtWv6lJhB8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3875 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] devtools: control location of test builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" HI Bruce, Thomas, Doesn't the RTE_OUTPUT environment var already resolve this issue? Fiona > -----Original Message----- > From: dev On Behalf Of Thomas Monjalon > Sent: Wednesday, November 27, 2019 11:01 PM > To: Mcnamara, John ; Kovacevic, Marko > Cc: david.marchand@redhat.com; Yigit, Ferruh ; de= v@dpdk.org; Richardson, > Bruce > Subject: [dpdk-dev] [PATCH v2] devtools: control location of test builds >=20 > From: Bruce Richardson >=20 > By default, both test-build.sh and test-meson-builds.sh scripts create th= e > builds they generate in the current working directory, leading to a large > number of build directories being present when testing patches. This > patchset modifies both scripts to use a DPDK_BUILD_TEST_DIR environment > variable to control where the build outputs are put. >=20 > For example, doing: > export DPDK_BUILD_TEST_DIR=3D__builds > ./devtools/test-meson-builds.sh && ./devtools/test-build.sh \ > x86_64-native-linux-clang+shared i686-native-linux-gcc >=20 > gives a "__builds" directory with 14 meson and 2 make builds (with the > meson build count depending on compiler availability) >=20 > Signed-off-by: Bruce Richardson > Signed-off-by: Thomas Monjalon > --- > v2: > - rename DPDK_TEST_BUILD_DIR to DPDK_BUILD_TEST_DIR > - add comment in devtools/test-build.sh and its guide section > - load from config file in test-meson-builds.sh > --- > devtools/test-build.sh | 4 +++- > devtools/test-meson-builds.sh | 9 ++++++--- > doc/guides/contributing/patches.rst | 7 +++++++ > 3 files changed, 16 insertions(+), 4 deletions(-) >=20 > diff --git a/devtools/test-build.sh b/devtools/test-build.sh > index 2bedbdb980..f55d3120aa 100755 > --- a/devtools/test-build.sh > +++ b/devtools/test-build.sh > @@ -7,6 +7,7 @@ default_path=3D$PATH > # Load config options: > # - ARMV8_CRYPTO_LIB_PATH > # - DPDK_BUILD_TEST_CONFIGS (defconfig1+option1+option2 defconfig2) > +# - DPDK_BUILD_TEST_DIR > # - DPDK_DEP_ARCHIVE > # - DPDK_DEP_BPF (y/[n]) > # - DPDK_DEP_CFLAGS > @@ -63,6 +64,7 @@ print_help () { > [ -z $MAKE ] && echo "Cannot find make or gmake" && exit 1 >=20 > J=3D$DPDK_MAKE_JOBS > +builds_dir=3D${DPDK_BUILD_TEST_DIR:-.} > short=3Dfalse > unset verbose > maxerr=3D-Wfatal-errors > @@ -234,7 +236,7 @@ for conf in $configs ; do > . $(dirname $(readlink -f $0))/load-devel-config >=20 > options=3D$(echo $conf | sed 's,[^~+]*,,') > - dir=3D$conf > + dir=3D$builds_dir/$conf > config $dir $target $options >=20 > echo "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Build $dir= " > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.s= h > index 07d42985e6..571deec257 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -12,8 +12,11 @@ PIPEFAIL=3D"" > set -o | grep -q pipefail && set -o pipefail && PIPEFAIL=3D1 >=20 > srcdir=3D$(dirname $(readlink -f $0))/.. > +. $srcdir/devtools/load-devel-config > + > MESON=3D${MESON:-meson} > use_shared=3D"--default-library=3Dshared" > +builds_dir=3D${DPDK_BUILD_TEST_DIR:-.} >=20 > if command -v gmake >/dev/null 2>&1 ; then > MAKE=3Dgmake > @@ -50,7 +53,7 @@ load_env () # >=20 > build () # > { > - builddir=3D$1 > + builddir=3D$builds_dir/$1 > shift > targetcc=3D$1 > shift > @@ -125,8 +128,8 @@ done >=20 > # Test installation of the x86-default target, to be used for checking > # the sample apps build using the pkg-config file for cflags and libs > -build_path=3Dbuild-x86-default > -export DESTDIR=3D$(pwd)/$build_path/install-root > +build_path=3D$(readlink -f $builds_dir/build-x86-default) > +export DESTDIR=3D$build_path/install-root > $ninja_cmd -C $build_path install >=20 > load_env cc > diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributin= g/patches.rst > index 2140303464..e3246aca5e 100644 > --- a/doc/guides/contributing/patches.rst > +++ b/doc/guides/contributing/patches.rst > @@ -471,6 +471,7 @@ Examples of configs are:: > The builds can be modified via the following environmental variables: >=20 > * ``DPDK_BUILD_TEST_CONFIGS`` (target1+option1+option2 target2) > +* ``DPDK_BUILD_TEST_DIR`` > * ``DPDK_DEP_CFLAGS`` > * ``DPDK_DEP_LDFLAGS`` > * ``DPDK_DEP_PCAP`` (y/[n]) > @@ -495,6 +496,12 @@ Compilation of patches is to be tested with ``devtoo= ls/test-meson-builds.sh`` sc >=20 > The script internally checks for dependencies, then builds for several > combinations of compilation configuration. > +By default, each build will be put in a subfolder of the current working= directory. > +However, if it is preferred to place the builds in a different location, > +the environment variable ``DPDK_BUILD_TEST_DIR`` can be set to that desi= red location. > +For example, setting ``DPDK_BUILD_TEST_DIR=3D__builds`` will put all bui= lds > +in a single subfolder called "__builds" created in the current directory= . > +Setting ``DPDK_BUILD_TEST_DIR`` to an absolute directory path e.g. ``/tm= p`` is also supported. >=20 >=20 > Sending Patches > -- > 2.23.0