From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96CAFA0524; Thu, 30 Jan 2020 14:06:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 65AA51C014; Thu, 30 Jan 2020 14:06:44 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C72CB1BFFA for ; Thu, 30 Jan 2020 14:06:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2020 05:06:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,382,1574150400"; d="scan'208";a="252991381" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga004.fm.intel.com with ESMTP; 30 Jan 2020 05:06:41 -0800 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jan 2020 05:06:41 -0800 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.52) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jan 2020 05:06:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mrYHZb+gmdo8aWKD+qyBJ61MP8UtN6eBJHLcThRa1ob0FEnVukJsq2L6eRjg9QWkNUQErFJ9mYON90D8feihbd3xx60jZWN0J9j53SXCjV9jtxitdFYlg+n15x9FgeF1KXsMsLOluyLCYgE1Z5x3SzbXFI0oxQKSgTPdDCh+/DFpA0c0IMQogBqO+w5YtPc+Zay0LHa4tw/48don0M7/RZ5GEb0G7lI6+dUp6A4yIdYdBmJqtrjjhM3p3l40s6CS2LwAZAOzaysN2L2BXqJemEYZMBlnH3cT/h1KcBBKfWh2v7iblK9j8tZHhljmAUdv3k7MRX9PIozP2RaMU4rDEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xOUXbHfyUFoKmMbLTk4YuReF/6ttIMBbmz+wLgw6eZU=; b=BCeQE0Z6LLW6Km/p2xW4+at+77VpM6JBU1iVhRLLGmb8neKwmXViIcigB5E46gsYS1Uank63OqVY9hihP9wkGGk3nfzzEZzuiigC1fTGBD3bOGCyhV0LnCzvsc54oPLu48k0r/1ODuMFMRUddLCznDhsM8pbKA2TFxiE5uSDWXoltEiI828RY9K6j3l4cu/8UsHFAZutxx69C1gXyLclJXIasaxW6H6wZDPpsQ+bzBANEYthogqGniWl0zSRcNalwBDv8DPxn0KBS1vME4Es4fgzhx/DaSNS+ybbAh2/h/Z252rsxtVvkZfLpIzwfCAfuaaDRlvZ8hm/2lJjzD9fOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xOUXbHfyUFoKmMbLTk4YuReF/6ttIMBbmz+wLgw6eZU=; b=nYC2nKyxZboVfQgOhKaiJGQqRjRYcte1p6k6KcJPdNvG3rADR1yiT9MCQPQ9+OY2jurpAFl8zy8hJT/vr1+B6A3RPum2/1tOsAfbmZG/0bygdIeaU7HnaPimpBb/ACBIUExSnCPiDbO2FkzcatNgF/Dln2uKYJBEGoVYygKUz9U= Received: from BN6PR11MB1796.namprd11.prod.outlook.com (10.175.99.136) by BN6PR11MB1907.namprd11.prod.outlook.com (10.175.100.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.27; Thu, 30 Jan 2020 13:06:39 +0000 Received: from BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::e035:bb6c:aa3b:e2ff]) by BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::e035:bb6c:aa3b:e2ff%11]) with mapi id 15.20.2665.027; Thu, 30 Jan 2020 13:06:39 +0000 From: "Trahe, Fiona" To: Anoob Joseph , Thomas Monjalon , "akhil.goyal@nxp.com" CC: "dev@dpdk.org" , David Marchand , "Richardson, Bruce" , "nhorman@tuxdriver.com" , "Mcnamara, John" , "Trahe, Fiona" , "Kusztal, ArkadiuszX" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v2 4/4] add ABI checks Thread-Index: AQHV1smFGAWDLtMfdkaM/74xTf+RAKgB6XuAgAAHoQCAATxBQA== Date: Thu, 30 Jan 2020 13:06:39 +0000 Message-ID: References: <20191220152058.10739-1-david.marchand@redhat.com> <20200129172621.28565-1-david.marchand@redhat.com> <20200129172621.28565-5-david.marchand@redhat.com> <1827847.CQOukoFCf9@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTk3YTE4YjQtNmVmZS00NmM1LWJiYzMtNjM0YjM5Y2JmOGViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS0JwaVJ4bVRmY00ra0R6M1F6VUdoQ0VRUVdpM1ZjYkR6WVFUZEFlcXQ2MDE0U1JHdzF3eEt2empzY2JCUkpHSiJ9 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 750fbae8-cea7-47a8-f737-08d7a5853e8a x-ms-traffictypediagnostic: BN6PR11MB1907: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 02981BE340 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(366004)(346002)(136003)(396003)(39860400002)(199004)(189003)(33656002)(2906002)(186003)(7696005)(86362001)(316002)(55016002)(54906003)(478600001)(4326008)(110136005)(107886003)(8676002)(5660300002)(6506007)(53546011)(71200400001)(66946007)(66476007)(66556008)(64756008)(66446008)(8936002)(76116006)(52536014)(26005)(9686003)(81156014)(81166006); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB1907; H:BN6PR11MB1796.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZirwrRRUQmv0ivLyNcEpAX0UyrGQ7zumGMABs9UddxRvWp9zdU8W0//eG6w6+ZOCRb7p/5Pm0+nBLJpo7YhvGxp4WAWlOUkXwxRAS99NLCnTrZ058WnOXJE4qNfDoH54FvMmdNZJOGMsvP4Hu+cNVZ2Qjzmvjq6iPPzSg+9QQSP/2TzZWkXCwyNfufoSUBBCngUQjXKu/3tBy3WMOnUU9QcaNqKOxSeYJLbwIYA8wiu6r0IN+gwEnfbeqliSAxjcY91N1qiyNGup2U04+64eP3qlGMe/dPuavSVyPK//uZHfuVCNT0xckF8zt/GRHWmkBdANpofnVNGkw2YZ5iZJTzPL0C+nOVygArtMl92qfe5vsh1dNvbIAENbzumP3jezyvhyy8F5AnJuX8+Fdup6Ywoc0Ib7tZh0u3uViOGgUiksjO58qAQ8nNDzbZgLGwtN x-ms-exchange-antispam-messagedata: /f3nHuB74NP8qm5sXMRCs0A+AqS57qwPB9khSi/rU+i2YGTwbHhpL6Il0ItbQl4DMlJYaI2AyF8MsE2l+ShAXqCWG+MSigE037g5ZEWi8TIcpzTFJmBi8/pOmQBs5xm8kqwZ7MOr4X29PyOrrXHo/g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 750fbae8-cea7-47a8-f737-08d7a5853e8a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2020 13:06:39.3853 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rrEENcAKtHuSN8c+eQr9BAMAAMglBrvmOXKZqcGC7PMD/x1c63B5/J9rX0PlfFldBt/WKDRY9pakTuTtwvdWqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1907 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" We were unaware the LIST_END change could constitute an ABI breakage, but c= an see how it affects the array size when picked up. We're exploring options. I agree with Anoob's point that if we don't allow the LIST_END to be modifi= ed, then it means no feature can be implemented without ABI breakage. Anyone object to removing those LIST_END elements - or have a better sugge= stion? Would have to be in 20.11 I suppose. > -----Original Message----- > From: dev On Behalf Of Anoob Joseph > Sent: Wednesday, January 29, 2020 6:10 PM > To: Thomas Monjalon ; akhil.goyal@nxp.com > Cc: dev@dpdk.org; David Marchand ; Richardson,= Bruce > ; nhorman@tuxdriver.com; Mcnamara, John > > Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks >=20 > Hi Thomas, >=20 > The asymmetric crypto library is experimental. Changes to experimental co= de paths is allowed, right? >=20 > Also, I was wondering why changing the LIST_END would cause breakage. Bef= ore we introduced the ABI > checks and ABI freeze policy, it was always allowed to add enums to the e= nd. I'm just trying to > understand the real impact of this case. >=20 > If we don't allow the LIST_END to be modified, then it means no feature c= an be implemented in > between. And the best way to overcome that would be to just remove the LI= ST_END or set LIST_END to > a very high value. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: dev On Behalf Of Thomas Monjalon > > Sent: Wednesday, January 29, 2020 11:13 PM > > To: akhil.goyal@nxp.com; Anoob Joseph > > Cc: dev@dpdk.org; David Marchand ; > > bruce.richardson@intel.com; nhorman@tuxdriver.com; John McNamara > > > > Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks > > > > Anoob, Akhil, > > > > Please we need to revert or fix the ABI breakages in cryptodev very soo= n. > > The FIXME section below must be empty. > > > > Thanks > > > > 29/01/2020 18:26, David Marchand: > > > We currently have issues reported for librte_crypto recent changes fo= r > > > which suppression rules have been added too. > > [..] > > > --- /dev/null > > > +++ b/devtools/dpdk.abignore > > > +; FIXME > > > +[suppress_type] > > > + type_kind =3D enum > > > + name =3D rte_crypto_aead_algorithm > > > + changed_enumerators =3D RTE_CRYPTO_AEAD_LIST_END > > > +[suppress_type] > > > + type_kind =3D enum > > > + name =3D rte_crypto_asym_xform_type > > > + changed_enumerators =3D RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END > > > +[suppress_variable] > > > + name =3D rte_crypto_aead_algorithm_strings > > > > > >