From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63913A0534; Tue, 4 Feb 2020 13:44:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30D0D1C0D7; Tue, 4 Feb 2020 13:44:44 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 27E862BFA for ; Tue, 4 Feb 2020 13:44:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 04:44:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,401,1574150400"; d="scan'208";a="225494494" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 04 Feb 2020 04:44:40 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 04:44:40 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 4 Feb 2020 04:44:40 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 4 Feb 2020 04:44:40 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 04:44:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JP9FQyFd2zUJUZxAs4Z9QUM2Rc4ga3Qb6aXeQoBG0d0TM0ie00ljU0kXeuEUCHKXVboPFCK2U4ss2oeXejl6g0R82vPmSdSOXKfKBIM1yMd7WUtCGuBUaV2X1N8aqsgfSDcR0UeKRqQAsZGvgoAPvu3P3YO2Pn/OX4Wl2jl6yzUhXbnD4T2XtJcXgmRrARnVJsQci9OrDjq9wdjP5R1Tki2wqLQVAPP3GsGvHvCkb24GtRFni/ls8OJGehGWDlkeleEvB2was0Zq/jVwVAqipAX7XKR+EVb9Ym+roLAuNJoKLOirSfPxYd+fJKoc64S+ZVxbEREuhG+tc/QE3KQ+JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EjpL/zdVaznqwoiDhtUr3ZKvJtg6zlm3fVIK7DCKlVI=; b=VwnY72GcGUdfIPhL1da2EQwN9wyrjObVesPa6YiNj4fz5gSB5T+o2Ogd/qHDxZUbnR4Mim6LYdWLLeui8v2v4Q7C0SxCToprgsLwdxMgeaVHgJc29s5XyITTAdaqYoo/SAO/NobupXovI5QT55Td2Q92wj4Hq8e11PtRfJTgL39+1MFONkx+wA5suNxnBQRXCDiUObLcUD/HEAaalMSH+zyu86GEDDZDRzzSQr+X0bwhdyk1B5b1EaGSC181iul8lsXMw3T6trkRWgktM3KuahZjQ23SA1Qo+xT/kIN+RPQK7cLHwcn85g7Vm0TU3GxQKY29gW6ieZVM2p9awyOF7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EjpL/zdVaznqwoiDhtUr3ZKvJtg6zlm3fVIK7DCKlVI=; b=ngyMIHq57m7md+2ep8cMTmSulkYbK69kLKmLiMu/RmM+vMa90jiTflfMFLocqMNcBc1kGEp+R0ZnC+LqTNneoWlV2bDX5yReBeSrgHrah/8vD3zOnhvm25ktTJKpYzuwqy5iDCP4PqVNMf1kfY83Hdx37D7t3aLBzMsmIelzfUE= Received: from BN6PR11MB1796.namprd11.prod.outlook.com (10.175.99.136) by BN6PR11MB2035.namprd11.prod.outlook.com (10.173.26.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Tue, 4 Feb 2020 12:44:09 +0000 Received: from BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4519:125f:2122:de07]) by BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4519:125f:2122:de07%3]) with mapi id 15.20.2686.034; Tue, 4 Feb 2020 12:44:08 +0000 From: "Trahe, Fiona" To: Thomas Monjalon , David Marchand , "nhorman@tuxdriver.com" , "bluca@debian.org" , "ktraynor@redhat.com" , Ray Kinsella , "dev@dpdk.org" , Akhil Goyal , "Yigit, Ferruh" CC: "Ananyev, Konstantin" , "dev@dpdk.org" , Anoob Joseph , "Kusztal, ArkadiuszX" , "Richardson, Bruce" , "Mcnamara, John" , "dodji@seketeli.net" , Andrew Rybchenko , "aconole@redhat.com" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH v2 4/4] add ABI checks Thread-Index: AQHV1smFGAWDLtMfdkaM/74xTf+RAKgB6XuAgAAHoQCAAB+HAIAAAt+AgAFOQgCAAEVxAIAA3urQgANfUACAABrKgIABOz0AgACAVwCAAAb/gIAAFsaAgAAktQCAAN6iAIAAJLJQ Date: Tue, 4 Feb 2020 12:44:08 +0000 Message-ID: References: <20191220152058.10739-1-david.marchand@redhat.com> <4ed777ce-8320-4636-2c9c-62bb96b66392@ashroe.eu> <2546229.NgBsaNRSFp@xps> <6660180.4vTCxPXJkl@xps> In-Reply-To: <6660180.4vTCxPXJkl@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmI4NDA5MDYtMjRlOC00OTFlLTg2ODYtM2IwODhlZTg2YjZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNUliQXB3QzkwY1VnYjIwT0Y2UlNFNVwvZ2FYUHY0UjN1YzNBdEFWQjlCM1VuYTJKWklLakx6SE1sbXdZbWpNZloifQ== dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 58538517-bd97-4e37-e194-08d7a96feda0 x-ms-traffictypediagnostic: BN6PR11MB2035: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03030B9493 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(346002)(136003)(39860400002)(376002)(366004)(199004)(189003)(71200400001)(2906002)(8936002)(6636002)(33656002)(66446008)(478600001)(66556008)(64756008)(66476007)(5660300002)(8676002)(81166006)(81156014)(55016002)(9686003)(7416002)(86362001)(186003)(66946007)(6506007)(53546011)(26005)(4326008)(76116006)(7696005)(54906003)(107886003)(110136005)(316002)(52536014)(921003)(1121003); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB2035; H:BN6PR11MB1796.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3UiR3teuBCA9APrpDcFbn9OIbZ0S0Y93A9Mg8I/1byhFj1gkEo8fo8Yhm4AsfmWuLne7szpTJUCYzNJQwfmcaXsOQqL/BlvQi8UiV0dHhcYOAQUe0R+rA99dUAEHQCgBESzSNPu6RcoTQAdAHZuixg9riHV5b7y/2tZUHmPoZ0VZvxGfw4la1fSKFM/ZkX18lmv8Qw7DNo5Y61tiIEedv8D5cj4UgxG2HwNdKSiF6gQ7KYApvaTa6o0CfOUtN621Cj+CBw3iU6SA+vC7dMhTkNh6NKhQnqBC4uPfbgGx5WzXdAkPE6GS8fNuiIFSPSiCGCY5618NgZxDe//yLUhI6OgssibW2POhI5GAuHHUfNhB5CiPlNCJ21B4BxXmD4Sl7sN1s+4Li5akZoh8fYsh0vFrU7JpskdASIWWlpzMYZi0wp/aORoCR9uLFARyh+dloX1Z8m89r01kysgEjZPJw8nnzGPcmbDOMzb3igskn6dguvh6Tq/gFOO/+onkUEVj x-ms-exchange-antispam-messagedata: wUwmSAJVRRUiXhjEdUlRA90urSCiNrnhQWwr676D9fZPSSuztf6xU7dJ6Lk/N1k7jMRHAu719WDShKbgREJk8oSOhLxMX2rsMEUWMh0Qf0Nzn4KBxVf0gGwIKxUZ6BBShcCd0TS3NloY2GZY99xTHQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 58538517-bd97-4e37-e194-08d7a96feda0 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2020 12:44:08.4789 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9vtwLmfNrWVQE1Gp/j6FayDupzLQA4VBMep00h+YCvSIvBCHJvZRceaZjgs6YnFx7Pyjg/PFyovFYqXe13z47A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB2035 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, February 4, 2020 10:24 AM > To: David Marchand ; nhorman@tuxdriver.com; bl= uca@debian.org; > ktraynor@redhat.com; Ray Kinsella ; dev@dpdk.org; Akhil Go= yal > ; Trahe, Fiona ; Yigit, Ferru= h > Cc: Ananyev, Konstantin ; dev@dpdk.org; Ano= ob Joseph > ; Kusztal, ArkadiuszX ;= Richardson, Bruce > ; Mcnamara, John ; d= odji@seketeli.net; > Andrew Rybchenko ; aconole@redhat.com > Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks >=20 > RED FLAG >=20 > I don't see a lot of reactions, so I summarize the issue. > We need action TODAY! >=20 > API makes think that rte_cryptodev_info_get() cannot return > a value >=3D 3 (RTE_CRYPTO_AEAD_LIST_END in 19.11). > Current 20.02 returns 3 (RTE_CRYPTO_AEAD_CHACHA20_POLY1305). > The ABI compatibility contract is broken currently. >=20 > There are 3 possible outcomes: >=20 > a) Change the API comments and backport to 19.11.1 > The details are discussed between Ferruh and me. > Either put responsibility on API user (with explicit comment), > or expose ABI extension allowance with a new API max value. > In both cases, this is breaking the implicit contract of 19.11.0. > This option can be chosen only if release and ABI maintainers > vote for it. >=20 > b) Revert Chacha-Poly from 20.02-rc2. >=20 > c) Add versioned function rte_cryptodev_info_get_v1911() > which calls rte_cryptodev_info_get() and filters out > RTE_CRYPTO_AEAD_CHACHA20_POLY1305 capability. > So Chacha-Poly capability would be seen and usable only > if compiling with DPDK 20.02. >=20 > I hope it is clear what are the actions for everybody: > - ABI and release maintainers must say yes or no to the proposal (a) > - In the meantime, crypto team must send a patch for the proposal (c) > - If (a) and (c) are not possible at the end of today, I will take (b) >=20 > Note: do not say it is too short for (c), as it was possible to work > on such solution since the issue was exposed on last Wednesday. >=20 [Fiona] Thanks for your understanding and help with our scheduling Thomas. We are working on a patch, when it is ready we will send it. If it's not ready by end of your today, of course, go ahead with (b) and we will work towards 20.05.