From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD1CEA04F8; Fri, 20 Dec 2019 13:38:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85A931F1C; Fri, 20 Dec 2019 13:38:41 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 824C41252 for ; Fri, 20 Dec 2019 13:38:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2019 04:38:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,335,1571727600"; d="scan'208";a="210802471" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 20 Dec 2019 04:38:38 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 04:38:38 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 04:38:37 -0800 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.56) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 04:38:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AQzszLtlQaV5kTIUF/o3l8kLoTC0fbq4b9mp0OYoZjEYuGV/4DLROl9gf8ZwMqyiZ0vpxmrYGS8/xJ10NjFub0XYIkI4sEJkR29poHRgizqwz2eUeA1GDZyugEH7+IKOv9Lz4bRMpHPXDfOE44eJ9iuyp7uUAJGB39UbUtsXIztB/Eizt7e7MdFnvbAt7ZqiD1NurMIiWBOJkfKn7orzgn/eXdgh49m7TPH5lNsoVfXnzvQA6NepLFopKdiuhUnX0Mf49jPpRen+8CXhhkjEGB1+ALbmVXm3vV8x1SHZhIVgstUhR4mmt2hJhIu7lD1R/+PZJA9hQK+4HCDMStvoPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lwQKsVTvKXri35e9UfFxhsMs9+jHCZn+bZhIn//zIIQ=; b=DjFg+gLvA+uniPNjmFNIHCfeSCasLhuzEUj4GEhLbgTnC8hIxcM0RtmIvPuI+h0qDFvlERAUU7dHVoshiXrpXFwOFv5m/a/jNoPDI49dGwGIBxpSp6fJmvDPsKUd2KKQ0zTSLIe5Eex/2HIEJKMiNi9k54uUmg9LLJWpdYGQE6p2Vkk2rmRpxSfBC//X0FQZ9RxvTtvDY5iTqhaqrldFwHUgPlxmr9h4ixf6dnKirC3uTcAMMmUSUx0azX01+1DZQshwAw8qWfXmqhJurTEvWdMRTxiLaxyeUdlImFYMzqx41rzallwQgN+pwOu5HSRDkAgMh0JasGbIX+GKRvivsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lwQKsVTvKXri35e9UfFxhsMs9+jHCZn+bZhIn//zIIQ=; b=ScGMCMPDe8CzFhgWxj4o6CLQWvdchjos7CMi4z3RnWtMm/bY8Pyhev10C7m1VXtP9JP9Bm51ZA06Mo2lguT+d4hTfA7tgAT0BQR2GD4DAIl5qf5ksvECeKQ1CIdroyOsSLUicLtzt21ji9s15JoCoqCgD9kv81g4blOXUr98OzU= Received: from BN6PR11MB1796.namprd11.prod.outlook.com (10.175.99.136) by BN6PR11MB1620.namprd11.prod.outlook.com (10.172.23.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2559.14; Fri, 20 Dec 2019 12:38:34 +0000 Received: from BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::e035:bb6c:aa3b:e2ff]) by BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::e035:bb6c:aa3b:e2ff%11]) with mapi id 15.20.2559.016; Fri, 20 Dec 2019 12:38:34 +0000 From: "Trahe, Fiona" To: "Dybkowski, AdamX" , "dev@dpdk.org" , "akhil.goyal@nxp.com" , "Doherty, Declan" CC: "Trahe, Fiona" Thread-Topic: [PATCH] test/crypto: add operation status checks Thread-Index: AQHVtyvpCoejZrX81UGMy9TNy4MkX6fC75Mw Date: Fri, 20 Dec 2019 12:38:33 +0000 Message-ID: References: <20191220115004.2713-1-adamx.dybkowski@intel.com> In-Reply-To: <20191220115004.2713-1-adamx.dybkowski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.170] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6bca5442-757d-4b16-2347-08d785498708 x-ms-traffictypediagnostic: BN6PR11MB1620: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 025796F161 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(39860400002)(396003)(346002)(376002)(366004)(199004)(189003)(13464003)(81166006)(55016002)(2906002)(8676002)(64756008)(66556008)(66476007)(9686003)(66446008)(7696005)(316002)(110136005)(6636002)(5660300002)(52536014)(66946007)(33656002)(76116006)(8936002)(107886003)(71200400001)(4326008)(86362001)(81156014)(478600001)(53546011)(26005)(6506007)(186003); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB1620; H:BN6PR11MB1796.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kAGR98tr7Rx1FhXjbKs9PpGqef0aVMLMK8N7s92OQHq3WMRGvPpRFl0atdGKnRlPfT6Z0i63kwTR+atTvRaP/J7pUbwIQ5BUv9koRcBA5Sh9pAfqYxXfX6aQIS22SFn+g4He0KKzqNCeaz0HdmqQEXC65iy/quz/HugkPFE0a3v5HLUz2V12q6jicqMB2T0FXI8p5uXpvHmtkMHMh4UdSbWf3xaqwqg72HckuzUVXKMK7HAUVKR8pdgs+MhHOz5Q8ViJ1ekUzkFR3R81WTcXXvpCRwKa48/HTI636A+ruyrJR9TSxc0ua8f5w3XUJsRupvqC6y2EzmULt7vvJO4rALzvO3YsZbOvinUEpl6KmBJu4LTgQJyyiOkwS9naJyiwIjvCy0vJZydlmwSClMzcW4zxRHXWc5q3tqWNdmG9eX3a7c4d75GsuX8PFDj7HN7cGOZfpeXpKS/RZXSfvbOEJRvTbnhbv27TfJv0TYgCJFgWOL8DP0RlAnFLGRpTQCH5 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6bca5442-757d-4b16-2347-08d785498708 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2019 12:38:33.4631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GRUonohZC+A4tYEYckZ50K59YYtz8yiJFa66biNNiwAB7T7nAU1sa2wvkE5axt/5k763aW7v1COt5QAJlyOEtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1620 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] test/crypto: add operation status checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adam, > -----Original Message----- > From: Dybkowski, AdamX > Sent: Friday, December 20, 2019 11:50 AM > To: dev@dpdk.org; Trahe, Fiona ; akhil.goyal@nxp.c= om; Doherty, Declan > > Cc: Dybkowski, AdamX > Subject: [PATCH] test/crypto: add operation status checks >=20 > This patch adds checking of the symmetric crypto operation status > that was silently skipped before. It fixes the wireless algorithms > session creation (SNOW3G, KASUMI, ZUC) and passing of the digest > data for the verification by PMD. >=20 [Fiona] This should be marked as a fix for backporting > Signed-off-by: Adam Dybkowski > --- > app/test/test_cryptodev.c | 96 +++++++++++++++++++++------------------ > 1 file changed, 52 insertions(+), 44 deletions(-) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > index 1b561456d..241a1f97a 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -143,7 +143,7 @@ static struct rte_crypto_op * > process_crypto_request(uint8_t dev_id, struct rte_crypto_op *op) > { > if (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) !=3D 1) { > - printf("Error sending packet for encryption"); > + printf("Error sending packet for encryption\n"); [Fiona] Can you replace this with RTE_LOG while you're modifying it please > return NULL; > } >=20 > @@ -152,6 +152,11 @@ process_crypto_request(uint8_t dev_id, struct rte_cr= ypto_op *op) > while (rte_cryptodev_dequeue_burst(dev_id, 0, &op, 1) =3D=3D 0) > rte_pause(); >=20 > + if (op->status !=3D RTE_CRYPTO_OP_STATUS_SUCCESS) { > + RTE_LOG(DEBUG, USER1, "Operation status %d\n", op->status); > + return NULL; > + } > + [Fiona] are there any negative tests - e.g. that expect to see an auth veri= fy failure or invalid session - that would be affected by this? If so should the actual status be returned?