From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A257BA04FA; Wed, 5 Feb 2020 15:33:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C54E01C1D0; Wed, 5 Feb 2020 15:33:47 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 859B31C1B3 for ; Wed, 5 Feb 2020 15:33:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 06:33:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,405,1574150400"; d="scan'208";a="378751109" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga004.jf.intel.com with ESMTP; 05 Feb 2020 06:33:44 -0800 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 5 Feb 2020 06:33:44 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX163.amr.corp.intel.com (10.22.240.88) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 5 Feb 2020 06:33:44 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 5 Feb 2020 06:33:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RWtadTtFCo5ESndJ9Cx1RRZugtdI5uTiagGoukSWpiZWoETz0jBwWean3upN5EUkW/wvt6tqJ4WwrUMdHaNikrmbmTxapZ0vm1GTHQ4VNBi1i0WBjOKreoG8a09WOn67LPej6VtZAKS42bfxVY1+aoTAZEy2y5wUgtBa0JCwjEdaGgJ/1TTKl43YAMR2D2uYnpiBoCpO2/uzj6YxrWtxtJQj3WwKO+cMOF9p0Gmvp2np8u5Hqf93TOJ/218unfxuR9OFQeuqz+RLuH5kYsu9nG6vyngkwosviovgnnkPfurdrAzbKLdwKYYFVccmg0qIkiwQToBXn5AFDWntru6TBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8YhVc7/2O/2qCy2YPI7/4sln5mxnvjjk17tHQ4KJaEs=; b=A2D14ZgrkDno48PnhQ3FdgEv4XOK0xyPHKSvgX6yWUs6cc51qZ9EDO+gj9WZw1LZYHIw9piOJcEDWnxRNQa3rkSo3RPP/MTF0XkvJsKlzWSTvEiRjkAZuufmU7ZiI2/Y4mtBD23lUT3DKjKxL6OFj3YfxBG/aGRqs5M2fbG/8F/Xfe5Y3Ij+cRQsz9kw2XVUQlfwJRAn4wulkn5NvCKf+OMAhvxecgHSUZy4DUUy6Ne2EmTB6bih5VDF5pNdevIreFeYRSmQIVVlJ43xUfVDDQdBkJCMenNoezRc1QuAlJyg5QOSHSOTkzyKY156ITo3d0bTxhzIX9NJxREdt/yPhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8YhVc7/2O/2qCy2YPI7/4sln5mxnvjjk17tHQ4KJaEs=; b=UEAjbsUHiHZ5yGcBTmr9PdSrOKgHCldEew1c3lt/ZEya3fks8xrzlv+gTj58eu+0xrtTyaEfI24Uqrt/b5NVbJP92m1PMnC/9MsWUKrJUWPAiSYmpsFykNB+n/HZ3vFtUELL7ZhMlb1lt2rEdNNeZTy5Yp+bcjKRD3kstgs2vqI= Received: from BN6PR11MB1796.namprd11.prod.outlook.com (10.175.99.136) by BN6PR11MB1314.namprd11.prod.outlook.com (10.173.31.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Wed, 5 Feb 2020 14:33:41 +0000 Received: from BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4519:125f:2122:de07]) by BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4519:125f:2122:de07%3]) with mapi id 15.20.2686.034; Wed, 5 Feb 2020 14:33:41 +0000 From: "Trahe, Fiona" To: Anoob Joseph , Neil Horman , Akhil Goyal CC: Thomas Monjalon , "Yigit, Ferruh" , "Ananyev, Konstantin" , "dev@dpdk.org" , David Marchand , "Kusztal, ArkadiuszX" , "Richardson, Bruce" , "Mcnamara, John" , "dodji@seketeli.net" , Andrew Rybchenko , "aconole@redhat.com" , "bluca@debian.org" , "ktraynor@redhat.com" , "Trahe, Fiona" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks Thread-Index: AQHV1smFGAWDLtMfdkaM/74xTf+RAKgB6XuAgAAHoQCAAB+HAIAAAt+AgAFOQgCAAEVxAIAA3urQgANfUACAABrKgIABOz0AgACAVwCAAAiiAIABFnIAgAADLwCAAAEIgIAAwxsAgACHuICAAIWO8A== Date: Wed, 5 Feb 2020 14:33:41 +0000 Message-ID: References: <20191220152058.10739-1-david.marchand@redhat.com> <78e8ecf2-2239-897e-e34c-aee7227f3d42@intel.com> <3830195.LM0AJKV5NW@xps> <20200204221020.GD13754@hmswarspite.think-freely.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTY3Y2Y2NmEtNzM5ZC00MTY2LWIxMDItMDdjNGNkMDc0ZmY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVlwvaGhERjM5VzUzY2JVN1wvdUVvUzgxbUJ3ZElENWlxUHloK1wvZDVDTm5WMkN3NSs2Rk11SDVpUk5Fa2IzbEJ5TyJ9 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ac64542-978b-4b6f-4f6c-08d7aa4865c4 x-ms-traffictypediagnostic: BN6PR11MB1314: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0304E36CA3 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(136003)(376002)(366004)(346002)(39860400002)(199004)(189003)(4326008)(186003)(9686003)(8676002)(52536014)(81156014)(316002)(81166006)(478600001)(66446008)(64756008)(66556008)(110136005)(76116006)(66476007)(66946007)(8936002)(7416002)(53546011)(5660300002)(6506007)(2906002)(55016002)(71200400001)(86362001)(54906003)(7696005)(107886003)(33656002)(26005); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB1314; H:BN6PR11MB1796.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YJHGLbPGk0MAhzr1KmI663b/BlWldUp9z0HqJbQ1Fz8nVvhz7fjNNkn0uU4SvMpjQ3VSYqlXKykjMheFJ0Wii/l2yS1ThWbWnHVn2+0QHSu0iQcJ9KDDj6ug/QsvBdlfmXqEucUWbkHSDlNqALnzVJ9WJ7jYkOXVvtGmqx4bxjOv73KKhXijxOdW5GmiFIfwN0gSThHOxKLRwR+FIQaIVCG2C7bIHjVYhL3WFE86D35c4u6qP+wFt+8Yfqn3Lk1SFivfUgmSHMtF7omgIG54siMYYzuxD2zWMUib/PDcoW7gdDZ+d3mkbVN0OcZk9o4SOl0YgWctK05fE1DmLB0kxe/sfMXt7wtQbiCVvUNef/z3X6gLGdPJBq++uENw19aBI1QlhEXX/1JY6oq4CD0KDtw4c04UCgOkwUaOyiYj+WcssVPw7xweKf8PwwD+N50t x-ms-exchange-antispam-messagedata: B1DrpwvqESm2kfocEkoenkYog7HjEFOAAT8dDPC2xHQnnieeXkvV/EORRgLcHM1OJGhV57mCO7LumcU4i7vnNQUadvNUOA728Dcq0ki6R2PpBq2dTnzwery/fS1e3cy37rVYL2p2ub9QPp/M1bIA2A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3ac64542-978b-4b6f-4f6c-08d7aa4865c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2020 14:33:41.4792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P4tNX5ZIEvSYQ0aNv/lYNWDurtZ+2/3GN6h1aVT1keTBJuJivM2egy7eMMOYDtPhHv1oX0hk6n3y1H1xTh7KnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1314 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, > -----Original Message----- > From: Anoob Joseph > Sent: Wednesday, February 5, 2020 6:16 AM > To: Neil Horman ; Akhil Goyal ; Trahe, Fiona > > Cc: Thomas Monjalon ; Yigit, Ferruh ; Ananyev, > Konstantin ; Trahe, Fiona ; dev@dpdk.org; > David Marchand ; Kusztal, ArkadiuszX ; > Richardson, Bruce ; Mcnamara, John ; > dodji@seketeli.net; Andrew Rybchenko ; aconole= @redhat.com; > bluca@debian.org; ktraynor@redhat.com > Subject: RE: [EXT] Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks >=20 > Hi Akhil, Neil, Fiona >=20 > Sorry for the late response. I want to propose a new change in line with = what you folks had proposed. >=20 > May be we can treat the new features EXPERIMENTAL until a new stable rele= ase. >=20 > enum rte_crypto_aead_algorithm { > RTE_CRYPTO_AEAD_AES_CCM =3D 1, > /**< AES algorithm in CCM mode. */ > RTE_CRYPTO_AEAD_AES_GCM, > /**< AES algorithm in GCM mode. */ > RTE_CRYPTO_AEAD_LIST_END, > /**< List end for stable */ > /** EXPERIMENTAL */ > RTE_CRYPTO_AEAD_CHACHA20_POLY1305, > /**< Chacha20 cipher with poly1305 authenticator */ > RTE_CRYPTO_AEAD_LIST_END_EXPERIMENTAL > /**< List end */ > }; >=20 > And then introduce an experimental API, >=20 > const struct rte_cryptodev_capabilities * > rte_cryptodev_get_exp_capabilites(uint8_t dev_id); >=20 > The PMD owner is expected to add new capabilities (only new ones) to this= one until the new feature is > deemed stable (ie, in one of the next stable releases). We don't expect u= sers to change their API/ABI. > For applications using EXPERIMENTAL is allowed to use the above capabilit= ies to get the EXPERIMENTAL > features. >=20 > This does involve moving around code in PMD when one feature is added, bu= t that's the risk PMD > owner is taking by upstreaming as EXPERIMENTAL and not in stable release. >=20 > Thanks, > Anoob [Fiona] Thanks for the suggestion Anoob. I like the enum part of the idea - but not the new temporary API as the app= lications need to be aware of it and would have to change again when it's r= emoved. I explored an alternative way of using the current experimental infrastruct= ure, i.e.: enum rte_crypto_aead_algorithm { RTE_CRYPTO_AEAD_AES_CCM =3D 1, /**< AES algorithm in CCM mode. */ RTE_CRYPTO_AEAD_AES_GCM, /**< AES algorithm in GCM mode. */ #ifdef ALLOW_EXPERIMENTAL_API RTE_CRYPTO_AEAD_CHACHA20_POLY1305, /**< Chacha20 cipher with poly1305 authenticator */ #endif RTE_CRYPTO_AEAD_LIST_END, /**< List end */ }; No new rte_cryptodev_get_exp_capabilities() needed. Any PMD that implements the experimental API must do the same: #ifdef ALLOW_EXPERIMENTAL_API #endif Same with test code. Any 19.11 production code that wants to run against shared objects from 20.02 can be expected to build DPDK with ALLOW_EXPERIMENTAL_API disabled, so will not pick up the new feature. However, it appears the flag is not globally consistent, i.e. most PMDs hav= e it set, even if the application doesn't set it. So this probably wouldn't= work. We're testing the approach outlined yesterday and believe it satisfactorily= resolves the issue, so will stick with that.=20