[dpdk-dev] [PATCH] crypto/qat: fix missing release note for dual thread feature

[dpdk-dev] [PATCH] crypto/qat: fix missing release note for dual thread feature

[Arek Kusztal]

This commit fixes missing release notes for dual thread feature.

Fixes: 026f21c0b951 ("common/qat: support dual threads for enqueue/dequeue")

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 doc/guides/rel_notes/release_20_02.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_20_02.rst
index 661969c..b45d9a5 100644
--- a/doc/guides/rel_notes/release_20_02.rst
+++ b/doc/guides/rel_notes/release_20_02.rst
@@ -166,6 +166,13 @@ New Features
   armv8 crypto library is not used anymore. Library name is changed
   from armv8_crypto to AArch64crypto.
 
+* **Queue-pairs are now thread-safe on Intel QuickAssist Technology (QAT) PMD.**
+
+  Queue-pairs are thread-safe on Intel CPUs but Queues are not (that is, within
+  a single queue-pair all enqueues to the TX queue must be done from one thread and all
+  dequeues from the RX queue must be done from one thread, but enqueues and dequeues
+  may be done in different threads.).
+
 Removed Items
 -------------
 
-- 
2.1.0

[dpdk-dev] [PATCH] crypto/qat: fix not included release note for coalescing feature

[Arek Kusztal]

This patch fixes not included in original patch release note

Fixes: 6cde900bd59d ("common/qat: remove tail write coalescing")

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 doc/guides/rel_notes/release_20_02.rst | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_20_02.rst
index d19a7f5..661969c 100644
--- a/doc/guides/rel_notes/release_20_02.rst
+++ b/doc/guides/rel_notes/release_20_02.rst
@@ -184,6 +184,15 @@ Removed Items
   the Technical Board decided to disable all the kernel modules
   by default from 20.02 version.
 
+* **Removed coalescing feature from Intel QuickAssist Technology (QAT) PMD.**
+
+  The internal tail write coalescing feature was removed as not compatible with
+  dual-thread feature. It was replaced with a threshold feature. At busy times
+  if only a small	number of packets can be enqueued, each enqueue causes
+  an expensive MMIO write. These MMIO write occurrences can be optimised by using
+  the new threshold parameter	on process start. Please see qat documentation for
+  more details.
+
 
 API Changes
 -----------
-- 
2.1.0

Re: [dpdk-dev] [PATCH] crypto/qat: fix missing release note for dual thread feature

[Trahe, Fiona]

> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Friday, January 31, 2020 7:29 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] crypto/qat: fix missing release note for dual thread feature
> 
> This commit fixes missing release notes for dual thread feature.
> 
> Fixes: 026f21c0b951 ("common/qat: support dual threads for enqueue/dequeue")
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH] crypto/qat: fix not included release note for coalescing feature

[Trahe, Fiona]

> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Friday, January 31, 2020 7:29 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] crypto/qat: fix not included release note for coalescing feature
> 
> This patch fixes not included in original patch release note
> 
> Fixes: 6cde900bd59d ("common/qat: remove tail write coalescing")
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH] crypto/qat: fix missing release note for dual thread feature

[Akhil Goyal]

> >
> > This commit fixes missing release notes for dual thread feature.
> >
> > Fixes: 026f21c0b951 ("common/qat: support dual threads for
> enqueue/dequeue")
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto

Squashed with http://patches.dpdk.org/patch/65413/
As both are adding release notes for related features.