From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C08EA04E0; Fri, 29 Nov 2019 12:02:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7145D1E2B; Fri, 29 Nov 2019 12:02:36 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BF2F99E4 for ; Fri, 29 Nov 2019 12:02:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 03:02:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,257,1571727600"; d="scan'208";a="384058146" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 29 Nov 2019 03:02:33 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 29 Nov 2019 03:02:33 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 29 Nov 2019 03:02:32 -0800 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.52) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 29 Nov 2019 03:02:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ieSg4ybuL4SsaBRa50NBq+w/yuOGyljEMpcS5wq54QruYFI93jsNkLX8WwWYYpDtl4cltmeWiNJZ++cJNUy0yBsxPXo54u5ljLOQK5a1wkIMRS6DigVIq9V8B/qmgK6ZwDk4cbEieCqmjMwjV2B8pZqO0JRa0SNPZO92LpSEUOJuwY6iTmOrdbrpOWZ/qBmURlMVWfVQU4Ak12aq4FNPUe8v0503spT8Omvm5pnVAzzXd8IyPQAm9r/Q26ZucEmEQfGuAqHEzxt/I7l/vNK3nh12ZDR00R7pLQFC68M14igyqLzKFKeip3f35vCk5Frcc2vzbzyljbK6P/0oM5XNDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j1wSxZ2ITfmNRcnWExdmg/0vFIomQsCul5iuhhtq2Ww=; b=ZgklwcYm82kQmi+kYPvZcd6n+dxxHguJXPnDIZFGqQmGnCAiDaMAUSC3Xn4Au9N6zFG5D9bQBerBqKv6SrTS50JFG5JmG1U6qN7bk4Op+Dv2U3pwj/QNwkijA8tGBKCGM87kjM2OnL346alEtdDzkFMQwgdmMej0rPsUymb5h68/Tzqb+3xN8RT3sx2pUT2KuJsOKvFagAn5Us/7ygNVvMfXqWhDrA/1msvJtSjIQ1acsOx0q4iUBCwbnjwvrDYpdIRKePjDAdrp+5ymEOczqUTr4cPaiV4vPsKTRMKWA1rb8mSdmVgCrM6dYBg9YbEG6zhWcLSLhQbv5YwZY6T/6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j1wSxZ2ITfmNRcnWExdmg/0vFIomQsCul5iuhhtq2Ww=; b=TiLSA5xJdX501HjlvQmSD7zTudmMQV6GdiuDTegSUTsyzXFE1eVyBJdJPRk+8mRptSxWQQ9k6YGjfPLNLjD6hchH21y95N7fuYyJIyUrRN8qX1Wu2TWK+6deNw/eI5nEbG+StruCNAQdu/vMQseSBN+40Ytn6Gt8iqZE/CAiEsc= Received: from BN6PR11MB1796.namprd11.prod.outlook.com (10.175.99.136) by BN6PR11MB3876.namprd11.prod.outlook.com (10.255.128.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.18; Fri, 29 Nov 2019 11:02:30 +0000 Received: from BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4016:7fc:ea36:328f]) by BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4016:7fc:ea36:328f%7]) with mapi id 15.20.2495.014; Fri, 29 Nov 2019 11:02:30 +0000 From: "Trahe, Fiona" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Mcnamara, John" , "Trahe, Fiona" Thread-Topic: [PATCH] cryptodev: add chacha20-poly1305 aead algorithm Thread-Index: AQHVpoKrzEhc6WHRmkCcZlOxyHGE1aeh995Q Date: Fri, 29 Nov 2019 11:02:30 +0000 Message-ID: References: <20191129065746.12756-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20191129065746.12756-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2JkNmQxNTEtMzFjMy00M2JlLWJhZDktNDdhMWQ5OGFlYzlkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidFwvK0hYMzdRaGw0QXppMXZTenI1bW1rT2hrUVQ1bStcL0NVYzR4V2l4dXdFbzNac2FVbFZYdHlzR1kyUnFDMldwIn0= dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.169] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dc8cdd2c-becb-4043-dee0-08d774bba0d0 x-ms-traffictypediagnostic: BN6PR11MB3876: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0236114672 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(396003)(376002)(39860400002)(136003)(366004)(13464003)(189003)(199004)(316002)(446003)(76116006)(6506007)(26005)(99286004)(53546011)(4326008)(8936002)(55016002)(2906002)(305945005)(102836004)(81156014)(2501003)(6116002)(8676002)(229853002)(7696005)(110136005)(186003)(74316002)(3846002)(7736002)(256004)(14444005)(33656002)(11346002)(86362001)(9686003)(76176011)(6246003)(25786009)(107886003)(66066001)(6436002)(81166006)(478600001)(66476007)(66556008)(5660300002)(66946007)(66446008)(54906003)(14454004)(71190400001)(71200400001)(64756008)(52536014); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB3876; H:BN6PR11MB1796.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6oPl6L0Ex/elA14+ZqxrALbcR4NOGr7GRfB7KHR04ioU8xTbNY/Vzv7KWj+Z1KdDbaF4JGcy5pH3NXYwl6cljqlpkrWk6mHo8+cICdB/hQPbja5Swi6NND/1DiFwt8r3yNTwAsipkWfYwYcX0hW5NGPjUzBrOSQfHBSFtOR3CVaa/kRusALHj6FzNeQ0kgKqGERi91jPHd5WqVovTpwseyVUFLj1oAf82t1XnXkpL9bAGPIZlOruspkFjwZFWIrUPxRtVPvX85BXo07aQAS59Jy3tmG4tl2g02lIqIf3TCEZ8Mj+Vj4G1YWa09iA+kPNuA7Ps7UKZ4Wr/UHQjDAvW3NPUXteRTbs6Z04pftx2uEvzhbWuQ8pENniJHm72UTTaNCMh3dt4e5jSk5B5DPh6Srum5oEgxwpQWBbEIByG3/ftu341Xa1OhkRUsQFC4ey Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: dc8cdd2c-becb-4043-dee0-08d774bba0d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2019 11:02:30.1494 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vQKRylQQFmQCD3LCgNv5BXYxFZntcqrezeWrOI73Po1kMg7lRh1C6fP/kOjHya09fc18ubCvcBBJzObESOLgLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3876 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] cryptodev: add chacha20-poly1305 aead algorithm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil,=20 doc question below > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Friday, November 29, 2019 6:58 AM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona ; Kusztal, A= rkadiuszX > > Subject: [PATCH] cryptodev: add chacha20-poly1305 aead algorithm >=20 > This patch adds Chacha20-Poly1305 AEAD algorithm to Cryptodev. >=20 > Signed-off-by: Arek Kusztal > --- > doc/guides/cryptodevs/features/default.ini | 13 +++++++------ > doc/guides/rel_notes/release_19_11.rst | 4 ++++ > lib/librte_cryptodev/rte_crypto_sym.h | 9 +++++++++ > 3 files changed, 20 insertions(+), 6 deletions(-) >=20 > diff --git a/doc/guides/cryptodevs/features/default.ini b/doc/guides/cryp= todevs/features/default.ini > index b7f9a0a..2a3ff48 100644 > --- a/doc/guides/cryptodevs/features/default.ini > +++ b/doc/guides/cryptodevs/features/default.ini > @@ -93,12 +93,13 @@ SHA3_512 HMAC =3D > ; Supported AEAD algorithms of a default crypto driver. > ; > [AEAD] > -AES GCM (128) =3D > -AES GCM (192) =3D > -AES GCM (256) =3D > -AES CCM (128) =3D > -AES CCM (192) =3D > -AES CCM (256) =3D > +AES GCM (128) =3D > +AES GCM (192) =3D > +AES GCM (256) =3D > +AES CCM (128) =3D > +AES CCM (192) =3D > +AES CCM (256) =3D > +CHACHA20-POLY1305 =3D > ; > ; Supported Asymmetric algorithms of a default crypto driver. > ; > diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_note= s/release_19_11.rst > index 48c80e5..d07a396 100644 > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -315,6 +315,10 @@ New Features > "--iova-mode=3Dpa" option can be used, IOVA_DC bus iommu scheme can = also > result in IOVA as PA. >=20 > +* **Added Chacha20-Poly1305 algorithm to Cryptodev API.** > + > + Chacha20-Poly1305 AEAD algorithm can now be supported in Cryptodev. > + [Fiona] This is targeting 20.02 but there's no release note file available = yet, so temporarily putting in the 19.11 file. In future can we get the release note file created earlier in the cycle? Ma= ybe after the rc2 of previous release? This would enable earlier pushing of patches and avoid respins >=20 > Removed Items > ------------- > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev= /rte_crypto_sym.h > index ffa038d..bc356f6 100644 > --- a/lib/librte_cryptodev/rte_crypto_sym.h > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > @@ -348,6 +348,8 @@ enum rte_crypto_aead_algorithm { > /**< AES algorithm in CCM mode. */ > RTE_CRYPTO_AEAD_AES_GCM, > /**< AES algorithm in GCM mode. */ > + RTE_CRYPTO_AEAD_CHACHA20_POLY1305, > + /**< Chacha20 cipher with poly1305 authenticator */ > RTE_CRYPTO_AEAD_LIST_END > }; >=20 > @@ -391,6 +393,11 @@ struct rte_crypto_aead_xform { > * be allocated, even though the length field will > * have a value less than this. > * > + * - For Chacha20-Poly1305 it is 96-bit nonce. > + * PMD sets initial counter for Poly1305 key generation > + * part to 0 and for Chacha20 encryption to 1 as per > + * rfc8439 2.8. AEAD construction. > + * > * For optimum performance, the data pointed to SHOULD > * be 8-byte aligned. > */ > @@ -407,6 +414,8 @@ struct rte_crypto_aead_xform { > * > * - For CCM mode, this is the length of the nonce, > * which can be in the range 7 to 13 inclusive. > + * > + * - For Chacha20-Poly1305 this field is always 12. > */ > } iv; /**< Initialisation vector parameters */ >=20 > -- > 2.1.0 [Fiona] Apart from doc comment above Acked-by: