From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB334A04B2; Mon, 4 May 2020 19:26:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2F881D16B; Mon, 4 May 2020 19:26:43 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 75FD51C21E for ; Mon, 27 Apr 2020 11:22:42 +0200 (CEST) IronPort-SDR: 1uamDevQ7oMkFGtSDT8/FZCYUr8+X3Ej7/2N5mQHkr3+wc9SzHjNfC+Z+SqafgO1O6UWFkIW8f 6CJ/I96WkLeQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 02:22:41 -0700 IronPort-SDR: p+q6v8WUqRdupIYspWKCzxuUPW5aVBLFQN5BHwxpT1Fq+Ph5RgLUECGz0c5/38wVN91fzoapMB M7Zz4fkyhdig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,323,1583222400"; d="scan'208";a="292414810" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga002.fm.intel.com with ESMTP; 27 Apr 2020 02:22:41 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 02:22:41 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 02:22:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2CGz/nbbeGEFLT37TvA7z1X/pPXichiNMhWw8j+3Qr/czQ7QPyUZDxl5i4MwborCp7AQLWQJdXDUePwrQ8qzCVpV7lcBpFW8uyZmH3QnpaJKOlTZ9yojrAs/G3O4bX26SnCDH6GOctfLnu09c/KE6OynrB/4q5Xico8tOgbi9iiLLDyHcRb7pARV8heeSQykgvS/QG8oIMHeKOY3I8lYRb8zhsH00k6ZOkcAL+ZzUI0CDoeG6kSjELkZNGZ63dPYTvo23ajcNszM5H6+647G+L4DV71tRwtEHBtvIvobourlJjXwM6zCdORdsYP/nVBfv6joVWfGYKmAgU8KlgqmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jaDzOA0AMTqrH1OIPsWdUGkQOViD/0hAYZet0YgJ+m4=; b=QNO0ji9XtTE/TrSsFkO0nelCuiaFcVnleFbceqvh/Bq/RSUbeASGKMeikfsjI+JhVz9G3+aWhRFG03VS4DEKXGS23m5DqKraEwPJo/0ObUzGmf8e80shXMDl0cIYppjputFnEQQgztGyAZ+RNvAeQLAN3aHNsA9c1efeekNUIQRpTWPFV2bLG9M+qHTNvDCxrur/lwDkUayTeRZZlq+g481Ig2Gwj1c2nFknoI7ISP/zssRwJUeu42+tN45TvfqohplmT4sCW0QifkDaNnxCjak08ZLXKJWO8smGztF/+HjwTLLlJNDKxw5DdDzpFPpEioyxpuMv0ZVGuZrOWiux/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jaDzOA0AMTqrH1OIPsWdUGkQOViD/0hAYZet0YgJ+m4=; b=eWa06B2ytnv+qtBMInYsXt+fzm8sw7YMHRtgU9rxQ+SDovVrwl/RstmePXsMoL2SGEJf6E6su6Iu3cGxzyg+1SKqjz27ng2ZvGS+cXK41Gie32h7RQ+YXeP7rERorPncPQE6w1MUxHf4PvivgtuoEwpGL6Pzxu/Oy1xLrC0nP0A= Received: from BN6PR11MB1938.namprd11.prod.outlook.com (2603:10b6:404:105::11) by BN6PR11MB3906.namprd11.prod.outlook.com (2603:10b6:405:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Mon, 27 Apr 2020 09:22:38 +0000 Received: from BN6PR11MB1938.namprd11.prod.outlook.com ([fe80::6978:d09c:16e7:b569]) by BN6PR11MB1938.namprd11.prod.outlook.com ([fe80::6978:d09c:16e7:b569%10]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 09:22:38 +0000 From: "Kinsella, Ray" To: Thomas Monjalon , "nhorman@tuxdriver.com" , "Laatz, Kevin" CC: "dev@dpdk.org" , "Richardson, Bruce" , "Van Haaren, Harry" , "david.marchand@redhat.com" , Ray Kinsella , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH v4] eal/cpuflags: add x86 based cpu flags Thread-Index: AQHWE95mQISzOqH75UaYzJwidwL7V6iKDpcAgAKKdwA= Date: Mon, 27 Apr 2020 09:22:38 +0000 Message-ID: References: <20200330121502.25555-1-kevin.laatz@intel.com> <20200416110040.42819-1-kevin.laatz@intel.com> <1651663.4herOUoSWf@thomas> In-Reply-To: <1651663.4herOUoSWf@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=ray.kinsella@intel.com; x-originating-ip: [192.198.151.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ad523ccc-0f42-4e86-0e28-08d7ea8c8793 x-ms-traffictypediagnostic: BN6PR11MB3906: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0386B406AA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1938.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(346002)(39860400002)(376002)(366004)(396003)(71200400001)(478600001)(33656002)(55016002)(107886003)(2906002)(26005)(9686003)(53546011)(7696005)(6506007)(316002)(6636002)(76116006)(110136005)(54906003)(186003)(52536014)(81156014)(86362001)(66476007)(4326008)(66556008)(64756008)(66446008)(8676002)(5660300002)(66946007)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: omnRwj4vRSKt1Ust0Vdlz3xsDxSs1SKP5UEV2zvtrPtz9viPGLAHxCIQX9ufATvjogMKsSvtW1ntiJTqYfTQQ6jZ71pbaaiAjHSrl04PKSmStvwoL02mHQMd8inhVPaNkJVhYbzDI4WDF1HCa87H34CRRQ6QyQJx2TYhUqQgeeeeoSTCCzmeboLkY2ljtCLLrg9hJCQcZvGB0c3jPj5hFHBB1eCt+ucc+aKHg6CUYFM/wA7kYOCMefCHA8ofOGE+z5CxZhB9SDqPA2iCMjVZm7RU3O8UOjs8DVTTdQmcCFvS+BL6MEyAuBrpAKr/RaKdw1LbwVi8+C3Oha+JKBIKZchnJGwHINh8BnV/THSAD9qiLIHAgRpjt8KcHpvG65zZo39n48Y23myF/y1MjgVzNQGZwNT92LWwAxs4SrYGMfKd15NgGILai48Vmb/SXXcO x-ms-exchange-antispam-messagedata: vYDDWVeEx7H378EdwdY8wLXigJBsYhE/LLRwoZ9F5Tnylx42Z4bW7aph7IAAg2gDbLu57gcPALJqzVK4sT/JQAS8Y0AWk9c1NvG5bXtdgdwwFu11PelcghVeuvrsfpbf4fLbGyzL+QG66ga6F3ysLutnRc18UvxxG70xKhbykad+XmhB8OjijJt1gt3TWuuN78OaPCqw17Rsa5OHHD/gH/JYeKFnmXJhQHdOjF2G9/Sw/H/6Qfb7NAJgP0blUyceaS6fAo63uw2KYRABrYEio5awB+cOT2aueLUHz2cCB3D7l6RvccoEZ0QKVbId3Y9eEYCihM08HrRjSA7pi1waJqTSs7jCJF1cSxYQqJEookSbIAvEDBdManMZbVOE7LGuMHVwS84pkRKJ93d36nC22XOCmtU3UhimRpV5X+pEbQ5H/WgkVet18sMc5GIRZFqfgD1CLRfeNpDuuTrGEY1Ea9TxT6TyeP74/dNFhIZXhj5DIchRlUHHEQoYl1yhxR04muNqi7s/c//SLB3+mNwuGRregzCgwv03/jfetv4XNJJlLeMwIg8uwp5jO+BRzcOr6iXnlJjtK3K9L86//8X5lvQHm7GWit6z4a5WSbPBgwgNqMXBDUOwb0fXwS9jdWOITMWDlLhaPjyc4yP+NEWEr9TqNY+Ak6vp9zHYj2IzvVfHJ2MlKQLGX1IOa7zZ2zMmc1/LNxkRh51A3oQbYiIuTNJxBGrkcR6DGDU2z6d1HLPtmgK0I7+KgGlu3YqAow2J0m3dJom5FYWGQa/N/hjLKHvWeb0YpIPEfoxK18J9CpeQOzEPRAQ7260/r0CU2iEk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ad523ccc-0f42-4e86-0e28-08d7ea8c8793 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2020 09:22:38.6387 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TuovPPHfLgJE4DFTvyvJUtXlHkTrq9qjNXS3c4yBg8HAs8KOkXCuI599N8Q+n4lHOeNx6RPV5CcMAGiIABVQqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3906 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Mon, 04 May 2020 19:26:43 +0200 Subject: Re: [dpdk-dev] [PATCH v4] eal/cpuflags: add x86 based cpu flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Saturday 25 April 2020 17:04 > To: Kinsella, Ray ; nhorman@tuxdriver.com; > Laatz, Kevin > Cc: dev@dpdk.org; Richardson, Bruce ; Van > Haaren, Harry ; david.marchand@redhat.com > Subject: Re: [dpdk-dev] [PATCH v4] eal/cpuflags: add x86 based cpu > flags >=20 > 16/04/2020 13:00, Kevin Laatz: > > This patch adds CPU flags which will enable the detection of ISA > > features available on more recent x86 based CPUs. > [...] > > --- a/devtools/libabigail.abignore > > +++ b/devtools/libabigail.abignore > > +; Ignore this enum update as it should not be allocated by the > > +application [suppress_type] > > + type_kind =3D enum > > + name =3D rte_cpu_flag_t > > + changed_enumerators =3D RTE_CPUFLAG_NUMFLAGS >=20 > The justification is not correct. > The application is allowed to use RTE_CPUFLAG_NUMFLAGS in array > allocation. > But no API is returning a CPU flag, so the new flags will remain > unknown to the application. >=20 > However, there is a behaviour change: > The functions rte_cpu_get_flag_name() and rte_cpu_get_flag_enabled() > will now accept new values, which were previously considered as an > error. > Is it an ABI breakage? I would say no. We saw something similar with the Cryptodev's rte_crypto_sym_xform_type als= o. Libabigail appears to be particularly sensitive to changes to enumerations.= =20 Leaving it to the user to decide if there is a problem.=20 I am seeing a bit of weirdness though between versions of libabigail. 1.7.1 seems to fine with the change, however 1.2 is reporting an issue.=20 Kevin - what version are you using? >=20 > PS: Who is REALLY maintaining the ABI? > We really miss someone who carefully check all these things, and take > care of the doc and tooling. I would say that I am missing these changes to libabigail.ignore, which wou= ld be useful.=20 Should we consolidate the ABI Policy and ABI Versioning sections of the MAI= NTAINERS file?