From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBBAFA04E7; Mon, 2 Nov 2020 03:11:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D685592B; Mon, 2 Nov 2020 03:11:19 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 7184A5916 for ; Mon, 2 Nov 2020 03:11:16 +0100 (CET) IronPort-SDR: 13u5BCi5/yzXPAxpC7jCP7MkmrSON1pC8POq0VONxNsXoB8Sqno1F/Kc3mNBPS559qmH4QfPQg 7H2RUAvgH2kA== X-IronPort-AV: E=McAfee;i="6000,8403,9792"; a="148107878" X-IronPort-AV: E=Sophos;i="5.77,443,1596524400"; d="scan'208";a="148107878" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2020 18:11:14 -0800 IronPort-SDR: 8byId44fIHjNUm5A8oCRMHwJM0FCXm+f12UshRPWjpKgpOn5nm0pbVL7HoDj2dhji6lMGaAJ3Y MRCITJlVQRNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,443,1596524400"; d="scan'208";a="363090879" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 01 Nov 2020 18:11:14 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 1 Nov 2020 18:11:13 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 1 Nov 2020 18:11:13 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 1 Nov 2020 18:11:13 -0800 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.57) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 1 Nov 2020 18:11:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mHwgMMrzihbDdYh4CzcfhpZCE4LjWTREX5bwiQ2bpjw7H4jrJPT8ypbV7nMWaeh6d/HKlexopQcKTzZiKkcq8PHj5BjewMZfGK+hOa/dwFeDlMm9daFi+HTU5YZaHVX0RpigciAVWG3gPshTjV23O0TVVEOL6FklxNIFyqgF0LsRmzOP2lDMYwzj0mqgXFOLJpyjSM34k4kMQ6Zo9qqVSDsMmwOAa/cyJ2OhuvPWqASoNEviXDUeqxjo0E0MQox+YQfAcCXyMuorLeG5nUGBpurLEvBiH/ihLsxsJAjpntK66XG3hLL7TvmWCj2l/TtCmZocARRsseeJ6ac86bLEaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QMpdsazcZb1FfdjFJpH1mIPFGAjJ/t8XWKU/Y13SaBM=; b=HSSM0W26BkRFq/dhG3TSsFnGv34FnLJn8As2KrH2STBzb/dT2Iz6sJ4CJREiwvIoPtw9MCJIuVLhwXei/cEkDbhidLVi4NMFlCPhxb+qTyVuAbrVwjTSFx/FXNpA46IJgi0pbw24YkRYuxn136SxzqCGARM06ENR8UkVxLdcpV2RiBTr2gARJXOH4tplXr1VrIOL0mMQZ5eIvXdI4C/qRPqb3Rvm6n/G2s49h+kn+Lii4UjRKhKvduqWtetVK2JiocUgIsB7WWsyMb0pbgsrk2W7V9EstF1fStsGXsrCLeMvJOmonIn4ySYuiMSz4vMRbSXr52EwPezjMqHQSzK4kQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QMpdsazcZb1FfdjFJpH1mIPFGAjJ/t8XWKU/Y13SaBM=; b=EIfKC9sLkm3FvOTbFxgk+qCU32I2ZnQNP7dPTREmSDD7e1CVGvDvLkMscASsMRjVGAH8T+DnDsgZiWVHPngDThgCe0iYFTuipFeGh/XgvKj+Ho2ZNfpZBLVQ768HmC8RYpJOylwrzu8Sr3kid/bvg/suJboZxbnypNVRc17vLb4= Received: from BN6PR11MB4035.namprd11.prod.outlook.com (2603:10b6:405:7a::38) by BN7PR11MB2625.namprd11.prod.outlook.com (2603:10b6:406:b9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.29; Mon, 2 Nov 2020 02:11:06 +0000 Received: from BN6PR11MB4035.namprd11.prod.outlook.com ([fe80::b54c:c80:ccd1:5950]) by BN6PR11MB4035.namprd11.prod.outlook.com ([fe80::b54c:c80:ccd1:5950%5]) with mapi id 15.20.3499.029; Mon, 2 Nov 2020 02:11:06 +0000 From: "Su, Simei" To: "Zhang, Qi Z" CC: "dev@dpdk.org" , "Guo, Jia" , "Guo, Junfeng" Thread-Topic: [PATCH] net/iavf: fix invalid RSS type Thread-Index: AQHWrmx5xhLcvttxMUi/EzhrQcdghKmv5MqAgAQ494A= Date: Mon, 2 Nov 2020 02:11:06 +0000 Message-ID: References: <20201030031638.370766-1-simei.su@intel.com> <466af3c9e05d44cfa39a8b80ac834ff9@intel.com> In-Reply-To: <466af3c9e05d44cfa39a8b80ac834ff9@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8d4952b7-ac69-4969-2f6a-08d87ed48eb9 x-ms-traffictypediagnostic: BN7PR11MB2625: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: x1AY2fmlWKAz19wWSk8kicuOU3rvXqp3sWD2jvdTSsaxVp8wYjpE2SO5ERufSS85n236oo0DihNClazbB57Fk0SiizcETQaAcvWxvHgaSi/k6uTSVUfaBcKHHrhcG8thw0giz5rYWoI/nQPFqAm1q3JzaLkL7ySKvbyRxe/TC48Jm7sqduIP6JfiibQwtfe93zqM0CwppFYQTO4J5bpk6ZoregQBYX3aQF4hwdPdFowuWalW6Yxj05Q2txQwfdYYa7XDqEMLzhSc9JdHZADwGR8ptkBK01fgHV+NvKmB3v5lNzhhWK7mS/u+BCluHzRttdsaUlkYRCEUet2XCeUpwA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB4035.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(376002)(396003)(39860400002)(136003)(6636002)(64756008)(4326008)(186003)(66476007)(66946007)(66556008)(86362001)(66446008)(8676002)(33656002)(8936002)(2906002)(26005)(5660300002)(54906003)(76116006)(52536014)(478600001)(316002)(6862004)(55016002)(83380400001)(7696005)(9686003)(6506007)(53546011)(71200400001)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 98nscpSG3zigXw+b7Nv6WblzgMqUgSGHvkNtHYj7VwmyArSwuuAl1RjAVQauTVxI/rvnuqLehqVJblD46RMmIpMnBl4xGK9+eCXOfgYXVHJqYO60thoMnIXbH674DrMZVq9Aemrrvq0j0uj5vN7JPCePhqexpSaJKVQFonrEfOQXcNkNK5nVsOj7VLKxxR9xWgYMP6Y1hjYGKfcKTiit239zBX2rtV6qPSMPj2H+qG+yzrblpLQ0c7O2/4HETBV9Gn4TXko1kg5oZaqgzHi94z1lBGsLLUTZtbbvFTsfFFMluYFvLkYZebq0Ik8jDwin9116K70dXRiKFWE7lLWDzKlU8519E5LIqZ4yO83Dkw41XQnsZqkZoZ0zt/qc28EW+M40pqbWTgWzPwDUEEfKs2MYEx7cNwAkDfMPDPIsF1cLoqOu8nyABoSFLXZZvHzYGjzukKHpHUgf1i/iZAfNidEH5i8Kgw8w8J/P6/tdgP+Uymhfi5osPkgcJ+1AjTlE0psMK4FRt6hbfrS05RoasklfAhMj1F7Y2usZh7iMLqpHJX4lMsPBx14ayI2QOZZrYawBrpa1U3OIa6SqSwMNEvCGopS0Ch9ikXYmXAEVtcpNVd3K/jb+eMSuOAKmtGWR5C3H0JbFowD+BogY6ffIrg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB4035.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d4952b7-ac69-4969-2f6a-08d87ed48eb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2020 02:11:06.4243 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rW6OOgVqhewux7HsJ0K2taQtqW8nK5VIoHW25DMhLjyNYfDB7NQsCfyRLs7I00XY62PioKm4SulJcGaIkxJDHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2625 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix invalid RSS type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, October 30, 2020 5:41 PM > To: Su, Simei > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > > Subject: RE: [PATCH] net/iavf: fix invalid RSS type >=20 >=20 >=20 > > -----Original Message----- > > From: Su, Simei > > Sent: Friday, October 30, 2020 11:17 AM > > To: Zhang, Qi Z > > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > > ; Su, Simei > > Subject: [PATCH] net/iavf: fix invalid RSS type > > > > When a RSS rule with symmetric hash function, the RSS type shouldn't > > carry with SRC/DST_ONLY. This patch adds invalid RSS type check for the > case. > > > > Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") > > > > Signed-off-by: Simei Su > > --- > > drivers/net/iavf/iavf_hash.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/net/iavf/iavf_hash.c > > b/drivers/net/iavf/iavf_hash.c index be821b6..6d0360a 100644 > > --- a/drivers/net/iavf/iavf_hash.c > > +++ b/drivers/net/iavf/iavf_hash.c > > @@ -917,6 +917,22 @@ iavf_hash_parse_action(struct > > iavf_pattern_match_item *match_item, > > */ > > rss_type =3D rte_eth_rss_hf_refine(rss_type); > > > > +/** > > + * Check if SRC/DST_ONLY is set for SYMMETRIC_TOEPLITZ > > + * hash function. > > + */ > > +if (rss->func =3D=3D > > + RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) { if (rss_type & > > +((VALID_RSS_ATTR & > > + ~RTE_ETH_RSS_L3_PRE64) | > > + ~(VALID_RSS_IPV4 | VALID_RSS_IPV6))) return > > +rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, > > +action, "invalid rss types"); } >=20 > Better to move above check into the below "iavf_any_invalid_rss_type" Ok, will move it into " iavf_any_invalid_rss_type" in v2. >=20 > > + > > if (iavf_any_invalid_rss_type(rss_type, > > match_item->input_set_mask)) > > return rte_flow_error_set(error, ENOTSUP, > > -- > > 2.9.5 >=20