From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84C97A0C47; Tue, 12 Oct 2021 14:36:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17966410FC; Tue, 12 Oct 2021 14:36:16 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 01ED340E0F for ; Tue, 12 Oct 2021 14:36:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U8KXhUo8Q50i7vcVa6lKVLFMnHffgFAkzS6DkABbx4L/ZDVoD4/ND5xkqypTgmZxu81aZd2QtXMOveDjavGsinGglUB07kOuQziYsZg/Yirww35uWiFAiKdWChYmBdy+629jF0J/MltH+cspkiUV+1J0OkP3qCDhrLBUQ6jzrjNpi7qEXqPDLB7Zxv1d9qa+DJZRbbfuCXqnqZfPFkM5krNK03Q1olIKEjwLiQ/9YgwAqYWJAkEiGL6JcLzKJc1sTs23zEcr5harNr2EiDrZMI3iZxfQcchY7VzIlSg7FMNfxsFgOozdJPiqs9/YmUterYq1fIlRSUBfZ/w2V+RgsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PhK/Wfsw8hpa0lq1f6DecwWQ277BCXZX8GFRD4an99w=; b=CO7xycrzWl6HPyWOrRTh0ATDMK9BvdsEQdeTZcWX5KnBZpYxEkLHPj0sP91ZjCPH+aVm8GrbJjW1jRUiaNdpW+6JVh+i/tDVEw2fTcQBDzZ/cOjqsTnpyJEhSA8jVjWr6TnzCKEM+8VwmfUwbwttHcgP/YUvP4XpFP6f7IJHhGcMiN1z725BI26vP0SLzvPvVSjPMtIGijcQbMWv3gNWe9mGglqKzA/5vIIU4nR5KyJ6JhHnr6A3/lPcBfeQanoCSWHxIJG+jS+zZkQC0xk53zj4RB5msIQzr65eTilHRF3IhsVc1e6hMQo0hhUlQqFcbo7OKUAosPMPGhJoPtMG2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PhK/Wfsw8hpa0lq1f6DecwWQ277BCXZX8GFRD4an99w=; b=VvILUGp8Tjz6LwtibLkK/4QZF6ybIqUe61Q5fJE8LJ9mQJKXhXZf2DAsX5Lp9SeWgDChT0Kp+uX2/0gvE9/4750Ef8/5cqzlKx80XeIjKV/sHA6OlOWcUGmuuUm2OqbrSwW+EX1earbzUo4hhowlR6ptkKBujZ8Dws2+g7m92yxgUZkpRJr3t3yzMjvrrlIcSJKvPKpBpx3oyvJgJe7/s7Xo5UmSWh8DiFvOKkJkmapUZ9dGk0a+0FhDwBT3nSZsvBLtgfRfCPV228C3LXHL6aPl5mNP7HegnJq9+avvev+QvuLpJ7JbAgjFiZV03HJE5J2cFz54f5M5M7rZksI8KQ== Received: from BN6PR1201MB0227.namprd12.prod.outlook.com (2603:10b6:405:4e::7) by BN6PR12MB1922.namprd12.prod.outlook.com (2603:10b6:404:106::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Tue, 12 Oct 2021 12:36:13 +0000 Received: from BN6PR1201MB0227.namprd12.prod.outlook.com ([fe80::e98f:7bd:1d91:3e9c]) by BN6PR1201MB0227.namprd12.prod.outlook.com ([fe80::e98f:7bd:1d91:3e9c%5]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021 12:36:13 +0000 From: Gregory Etelson To: Olivier Matz , Stephen Hemminger CC: "dev@dpdk.org" , Matan Azrad , Raslan Darawsheh , NBU-Contact-Thomas Monjalon , Bernard Iremonger Thread-Topic: [dpdk-dev] [PATCH v4] net: introduce IPv4 ihl and version fields Thread-Index: AQHXuRlM5MFPyqgen0m5lKJ8G/m0aavC/3MAgAANlgCADEtqcA== Date: Tue, 12 Oct 2021 12:36:13 +0000 Message-ID: References: <20210527152858.13312-1-getelson@nvidia.com> <20211004121323.6677-1-getelson@nvidia.com> <20211004085934.7105af27@hermes.local> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 78506d61-a838-47b0-72a1-08d98d7ce0c6 x-ms-traffictypediagnostic: BN6PR12MB1922: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:556; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HE8ysk9QJFpdTmDlJZwL9ciQBCjeQ4A2siv2wEZnR6rL/A5hw8wSXE81EWJO2bc0+ilmsMd3PzvLcfKx8EBDDoY64/k7rND3k7EqGtB7fYmwnpIoURGB4eNw0qfLeq0D2flpGMf9ltFmhxarBdTJ0AihsjB/JfFDRNbQ4kEHFrz0JWAXKnMyAi8Bf5CHZ+F4z9fRFLDgrOXfw01zdZG5h3F0HiOXYM63io6WIMOb315RG/g8/liZCpczN+8cqOKnAp/6AES/C21RrWGh18HZoOb4z/H8mbzV3V8JxbjREKDMWNJMYmFQZ1ZVl05T8sfzExXQRq2Ld6p8BfcLsW9UtRq7zfVz1ZthQgIXghX7PUeIquGQFA3BTntpuFx0FZhqfHoU5t1dX0qbWjMXxlZZ9yTAfAoYKX+F+0/op2jrRx1mwAvIDskmQ86DBRa9L15oEDGtGYqXSAfPJCkgSsBU3UENsvpphyRJU+Gk3D1uLEJFJtcj0QdxZe0+H2JgNqPqWUEekyUc5MQiRBIX11Ol8wB/E+KMZm8GnZQVc8qFbsv60VLW0Y01h0jdL20n6x4vGxN2SjDlMmhcE3LNpb7NjT/+3JqgX6FARyXDJpd3ppBSI9L2teD06jxy5M38h/E7/4Zc9d4dIkmmU0IilippY107y03k8OQO9/3kDL+Gxo45o/XO6P+AuX9EBxZvOEVkolSrhKlGhtqHLunlMMUBzg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1201MB0227.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(122000001)(83380400001)(6506007)(186003)(38100700002)(5660300002)(33656002)(9686003)(316002)(71200400001)(86362001)(508600001)(110136005)(38070700005)(66446008)(66556008)(64756008)(66476007)(4744005)(52536014)(8676002)(4326008)(55016002)(66946007)(2906002)(76116006)(26005)(8936002)(54906003)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h4/ePRNoIuzsffoegtp/0KOgTLZiI+OWk9vuCFjIRluK2V9m6yzdvSrmxA55?= =?us-ascii?Q?FY/qz0WlwZQbn4iFmAZ3jUb7jvTNRb0u6nvIYTmSkscTiPuasakJc8NqVNX+?= =?us-ascii?Q?UWNm0MvOrclzLvv3afwiWCjqYLsA/orvoWxX7JnSLHBZEw6klsdBBE3sRzBK?= =?us-ascii?Q?qGBi3pyzHsewvQhYa2Twgv6GQbxVR01+3wMi+OEgt6OYb9w/AVU5EHMEZACU?= =?us-ascii?Q?gnSmh+xj3sqKyoyZyY6c3WYvoDkOU5Hh/7bWOolSbcKpzbQhRs1lgYsgnnjq?= =?us-ascii?Q?yF7dmhl1WtpY44GMNcvDlPFszIBqojS1uEQ2S0x7E/l5b1kxzo4hTkzJrtjq?= =?us-ascii?Q?9o+Cagwtp5Nngf6vk1v0igH25TmNDZBypE5MvJGKOPwIgxMYB5A3Et8gQ+Fu?= =?us-ascii?Q?m0LEi+XsWRbChUnm0iBriUk/MO3FMSkhE2iZjrIqu/KQHJYfttgEoqqHhkEU?= =?us-ascii?Q?NXSXcizdgVJSuZueU9u/F8cT5DykAVr5fCk/Rk94N52cr3tmuorJmP6Hy1QZ?= =?us-ascii?Q?SoE5C4rnODHJ498zJjq32MODXK2OsIcNgs5t4ECOYea9tc4stASKVlFsvBdK?= =?us-ascii?Q?lSWdBGUNx7Im1/QQOhEkjptMXTmTi96QSC94ZrvEkGcqPgHbpCHvw+In4QC5?= =?us-ascii?Q?pTIxH7rwDmotUDQm13ADB0meKHuG1bMJ4BjRULNPD2Zb7iaphLRpDWANI4NJ?= =?us-ascii?Q?PEwAQpCCOJvUPx2CPeLaqhaIbH3TkVOWhXwA2sqrQwXUYc8IrGgARF3UQFsy?= =?us-ascii?Q?iJ7wKZKgJRU7MWYurY+dVqRUAljVS+ptZCdZ6Jim5BjRT9PJWVfBB4gK/fKn?= =?us-ascii?Q?QApF+R4/l80sRc8dvxsClwxSYmcghG7w7bbWviqjcUQy2leu2MVOuiAHBrUF?= =?us-ascii?Q?62hF9n1m4Xhq5vFo/ZicxSPRQWzpc+cyiKbO5VdC7fDhU2XADt863xTtq/L7?= =?us-ascii?Q?vFFXH63DWhJu+93wU5JlzXDxvnrHTqNGHeF/P8OfZrCQ4lr9ZIdMOp2UT/dv?= =?us-ascii?Q?D5VJTM7rcZbms3xRnWCjwQffVQfbrfc+8n59OAuqH+490jmK/WcPjVCFoSYz?= =?us-ascii?Q?ctM74pFQgmrc91WmuFApYkNFPOhAfoj6ugWReCEvpp1abPsyp7kfDje/Lc+s?= =?us-ascii?Q?eMgb8sLGIwSGxbUHzP8iF5jU51UGppCSLurbNZoZAazJDEduSQY8SHbgVatN?= =?us-ascii?Q?uuU0qKBTg+CpD4c5IZFoU3JRDGcS/XVcP3f954BNg5fR7bTSWxEalENQYYUs?= =?us-ascii?Q?PK2KTWwnJKYENM2mUHjpkAdESN6H9WL4YvRR8041pSAbq6Dnt+ah2oz+aAap?= =?us-ascii?Q?Zirirmj5w8zOS/2vC9bpPaB/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR1201MB0227.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78506d61-a838-47b0-72a1-08d98d7ce0c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 12:36:13.5439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gKNuCc1Dvy2C3N8yYgDuGBrdo/By4wbweWCtbeX5uE6d8DM+LUZhMQrLqi/JBcJekmXSpAhT3IF1DZN4eUfuMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1922 Subject: Re: [dpdk-dev] [PATCH v4] net: introduce IPv4 ihl and version fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, ..snip.. > It was announced (commit f7383e7c7ec1). But > that's a good point: > - the removal of the deprecation is missing in the > patch I removed deprecation in v5 > - the message notice also talks about union for > fragment_offset A union for IPv4 fragmentation fields cannot be implemented. IPv4 header encodes fragment information into 16 bits field. 3 bits hold flags and remaining 13 bits are for fragment offset. 13 bits bit-field cannot be defined both for big and little endian systems.