From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25C39A0C4C; Mon, 4 Oct 2021 10:59:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A54A9412DA; Mon, 4 Oct 2021 10:59:37 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2071.outbound.protection.outlook.com [40.107.220.71]) by mails.dpdk.org (Postfix) with ESMTP id 1DD4E4068F for ; Mon, 4 Oct 2021 10:59:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ah2qp4G0I/ag5ZJdJftXPkkTulatI0obk97RMjPOyBVnAQKBYF+bV/0dphuIum6W7WA8giaYYMrhTmwSNRJ6N9/mHMjDlddhMTkLC2p2u7315+RX/1GkUxgj0SS9EBQss8TLwy45l86gMO4rpUqYV6kMZj5vulpLqFpPl15DP7sVjXn2v4sC2Bdv3Hw4Kqq8iB8k6WeWWmyrTeBbdZ2CWlJweTqsb0U3qTBJKKU/PYTYX1RRaBtWJXauYaWtV4g6GAdVWwY8nVKrh520qwyONdKbGGm8M35sYvl+/bQLULR4DK35HcytiryNXKd08EacfZqdsYRvUVv0BCze+8+Vkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l0io4pzmKpZE/9noRZNazbwzem2pyBRRZrAIFs3Gzng=; b=ViIWUFdj4XXGvp+NjlURyroLRTLVQelhw3+OEv6Bid0jL0hddUHBXYGMmb36d3oCg5zxDhKObjM3ZbCDHlYxQqYlbeL0yrg4ciR4d3nFpx4YHgVkfRvRTSo6Z/IdSSJOE7mdJ4AU4S8miVzGpNxLtl4x2qEUzTQ7+0SYF6MnBzcKb3y3yurL8B6SHTH9nKykkB/zc4fND6CSDyfaogVvSO6i1wp/5UrWqhmpO3NZeAKQS0IjTw107JYdkKgu9xB8Nm+Vr8giYvubAsAqXDSztK4GYTokrMH4iBdUAU4BdyPLtbIodbGrJ5Vldconh9b2JLI1etGGHfuJ0htA7FgiQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l0io4pzmKpZE/9noRZNazbwzem2pyBRRZrAIFs3Gzng=; b=hdLhUG8hUURtVa6nSD9cu4cLt2QKSZeepObepDYkrJcx4P00VlX6kj+VxwBFr1Ps5B0IpC2gEzYQi3L256eSsFrpdeV5BOWe2cg8k0WMiWwVGnHHyu58XwbD3RR9feQWdMi4fidLklqzB14Fu97c1GSNa2i6wvnJoltMO9ffSaydTnziEHxdRQsmzn+YsaJdBfgg64Ey38r4UdOqkNnnGnpBs7LMyDUtpo8PqqqQFZ2Y+ewav2BIIyipXTeGOJq2lnNUOHtaQnKXR2tny0uL5fdC7VOFS0mQWV63h1LOhUiNnUEBTh+EJmDYDMVEvTmdl2txcfNlCKYSHcVwwvAjfA== Received: from BN6PR1201MB0227.namprd12.prod.outlook.com (2603:10b6:405:4e::7) by BN6PR12MB1604.namprd12.prod.outlook.com (2603:10b6:405:c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Mon, 4 Oct 2021 08:59:34 +0000 Received: from BN6PR1201MB0227.namprd12.prod.outlook.com ([fe80::e98f:7bd:1d91:3e9c]) by BN6PR1201MB0227.namprd12.prod.outlook.com ([fe80::e98f:7bd:1d91:3e9c%5]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 08:59:34 +0000 From: Gregory Etelson To: Olivier Matz CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , "bernard.iremonger@intel.com" , Raslan Darawsheh , Matan Azrad Thread-Topic: [PATCH v2] net: introduce IPv4 ihl and version fields Thread-Index: AQHXoJWUzyuNyafyv0mcw+AOWT7mJqvCp6YAgAATAgA= Date: Mon, 4 Oct 2021 08:59:34 +0000 Message-ID: References: <20210527152858.13312-1-getelson@nvidia.com> <20210903073003.31400-1-getelson@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 531805dd-9ca5-4370-2007-08d98715496f x-ms-traffictypediagnostic: BN6PR12MB1604: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lKJXeDELM3Ce7623sd4x8fHj+Y3kGKE2QIC7bEwqIvCXP3k56ano5T1qMHXeqDU82AtEQnJwnZFR+aWlXsg06h/jtQYCHYu4hW//LRmEs5ZJzfTXS9ZVbyQuqLzNTuzm/l3QVH0tVcZzLi/DFQYvS4aGRIK/3tw39/XLbqzHkFfdfTG4pIGnenDRZOmY0KBa/grSpZrXsoz7+HeeJNg6eevcTyKAos2634kdZ1MBvnl374scBT7B/H9uDdFazbuhBJfdKJcDKfGFpKas810ZI2brm9H58Qo4z4WZI4f4GtRAaC1Uhyk3BOkHwIBl4O3Aol7m3AJnqBn4mpbiWE1tn7EqIJrIVaZbH9hx8a5Dbu6GosP1znR1ibsloB2F9U8GacvrzkehTr0//GHaPPSh6ulusGbp1bUSmMsgpSv4pQMCcyaaA+eLWPEwIiWpq/qNAOn9UQU32b5Da2G/Uvz51gIbNxyIRU6f0ZxHItwZsqS27UEPrBncje7JmqaoNQDvNhClY3+R4EwAHeMmXH+3acWF8rxifQSQi2Y0WP5Pm3Er7v5xhI8zYL4tfJuti51RoMdTYRjWQ/JUqjhBizHyQbKDgf8MjJQW0YnsZ01o6umGO9u6ZSekanJspxWohrNiB0r7p2/jqmIsKmn2fiInuGiArT7K+l8jHon7bqPH2RyhjDQC9zy1uLG65RBSMS+/BPn1MDORoP+wwGVHeX9cWA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1201MB0227.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(122000001)(316002)(8676002)(558084003)(5660300002)(33656002)(38100700002)(55016002)(6916009)(54906003)(38070700005)(4326008)(9686003)(8936002)(2906002)(52536014)(107886003)(66446008)(186003)(26005)(86362001)(7696005)(508600001)(71200400001)(66946007)(76116006)(66556008)(66476007)(64756008)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7Ujxx9TsVCBf3P2yCud9F3m9zXfKUpu8TclNBbOSgbrD72nfANP1hfm49vD0?= =?us-ascii?Q?8WmeGRHCbtHUoW7QZK0Si+SrXxQfHeLIBF6vf/eWo9KnqHr0ixTUayT0cWKh?= =?us-ascii?Q?PnjqlOpLfTz0A4O/YFwXjWn5ca3iho/jocHCgT5xGtiyIUFnl1lgWMsyHeS7?= =?us-ascii?Q?Th9uqTxNkJBd5dTQyZ6m95hxq1UtMuL0Drl0VqdJ9UWLB+dQtNy78am26nlv?= =?us-ascii?Q?JK9UKUtsLy/7CFpRp+cIPBFFwu6b+0PgITjv1ljHWOQ2h3xVDAYib6qoVnrc?= =?us-ascii?Q?pD0kF110LSbKXotQcg4jlqf9+Lb45TouDXvR2TJdV0Q5VZLafSe8KqpTRAkL?= =?us-ascii?Q?7mcpoY8WcEpDlObNdH1x+SB1zaRQoVNFXLOKuTG4F+wzvs1epNKg8ZQfnjYB?= =?us-ascii?Q?jPS1oGJ9NBhPvO/UHOcKD6QXK8Yk6T35RUMIKvVIxv7162j7HkfWu/cP0bX3?= =?us-ascii?Q?uh9oP8gvz0wI7Wl+NhkbMlblKXVacnrG+W8NvuKZxH9frRIOA7G7c6caC7bO?= =?us-ascii?Q?DrD1ZnWAbPr5Gy4N6A+zpRpeXs5/H7Un99g4uveeHzElNEbYspuqQpqNate9?= =?us-ascii?Q?437LGDic5vd82gFmgTxuCKBlAZ+dzQaqZ2HMud9nQ/XPoz/RtrF0mBtaQw4J?= =?us-ascii?Q?UH4zoOo5ElPKCVIBssDPnyPYZsOWBw12jNuMASwM1WlxrUDdlSLsQGsyI9kf?= =?us-ascii?Q?mzJL8VOQKodL9/Toen3i8FIYygVoUHHTwSY+SMRB22AYzma4u8rd57yBEXye?= =?us-ascii?Q?bS0EJRkGE12Qz3xfHnXczba2i65VRtAwPfjMrPJ1PTLEVQCyt925IK50jBZz?= =?us-ascii?Q?jnw9B/1ilvXqC6YH4Fl+Rt7Dt1m8L6bVv/jRxft1YMN+7oVz6SoCHwakpOXB?= =?us-ascii?Q?odTCsBUIFQoiHz8vzNmvC3Uq31CAHKPgxNhp3lKyP0w1+2HAPo87WhZNzhb3?= =?us-ascii?Q?Xq2TOWimO13Aw9eei6IH+XXOtdrYGQjCHNz3Vl3WeuU56qKNBMgb3yLplmHP?= =?us-ascii?Q?llS/IKYj4TGIx1WJP0jCYNanwBGk6LZV2oSwyqU374v5J7MWfdRU14URj7LM?= =?us-ascii?Q?e7+SNDxlpr/3Skr/o4RFP0fW4AABy2eUqAushFl4oba5BatPFRv7ej26PJae?= =?us-ascii?Q?Kl3k5q4rDxCQdvuVn4ZjsfQyYwEM6t/Q6fOeRaywDG0RP4ZYWX6qsvpfnALo?= =?us-ascii?Q?tRpxu6KoZeG4tsC3dz8nyv619odPfcwMqVJgOUwAihK1JhDANWZlDit0bMOr?= =?us-ascii?Q?CXdx+LLGwRfo/sVAPAzNHe2N9Z984LZu+dYr6MZ/nPvNvGMrRVhI9X1FCAAO?= =?us-ascii?Q?nnV8xyCQIiIryDJnZ6XGXuC5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR1201MB0227.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 531805dd-9ca5-4370-2007-08d98715496f X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2021 08:59:34.4548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +++cqLjVy6g588BJ8GjgnGdSGq+cdeXjnUgAEIA2LiRPp0ExtDOvcZSyoU0tiGUQlDSdcUAwQK07+HlJ7l5YwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1604 Subject: Re: [dpdk-dev] [PATCH v2] net: introduce IPv4 ihl and version fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Olivier, [:snip:] >=20 > nit: although it's obvious, we may want to add > /**< IP version */ and > /**< header length */ for these new fields, for > consistency with the > rest of the structure. I added comments to v3. Regards, Gregory