From: Shally Verma <shallyv@marvell.com>
To: Fiona Trahe <fiona.trahe@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"arturx.trybula@intel.com" <arturx.trybula@intel.com>,
"tjozwiakgm@gmail.com" <tjozwiakgm@gmail.com>,
Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v7 1/6] app/test-compress-perf: add weak functions for multi-cores test
Date: Sat, 6 Jul 2019 09:31:09 +0000 [thread overview]
Message-ID: <BN6PR1801MB20521A94120E4D696B8CFFDEADF40@BN6PR1801MB2052.namprd18.prod.outlook.com> (raw)
In-Reply-To: <1562325340-3891-2-git-send-email-fiona.trahe@intel.com>
> -----Original Message-----
> From: Fiona Trahe <fiona.trahe@intel.com>
> Sent: Friday, July 5, 2019 4:46 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Shally Verma <shallyv@marvell.com>;
> arturx.trybula@intel.com; tjozwiakgm@gmail.com; fiona.trahe@intel.com;
> Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> Subject: [EXT] [PATCH v7 1/6] app/test-compress-perf: add weak functions
> for multi-cores test
>
> External Email
>
> ----------------------------------------------------------------------
...
....
> +enum cperf_perf_test_type {
I think I had feedback here on enum name: it can be just cperf_test_type
> + CPERF_TEST_TYPE_BENCHMARK,
> + CPERF_TEST_TYPE_VERIFY
> +};
> +
...
> struct comp_test_data {
> char driver_name[64];
> char input_file[64];
Rather than using magic number better use MACRO NAME? also where is limitation mentioned on name sizes?
> - struct rte_mbuf **comp_bufs;
> - struct rte_mbuf **decomp_bufs;
> - uint32_t total_bufs;
> + enum cperf_perf_test_type test;
> +
> uint8_t *input_data;
> size_t input_data_sz;
> - uint8_t *compressed_data;
> - uint8_t *decompressed_data;
> - struct rte_mempool *comp_buf_pool;
> - struct rte_mempool *decomp_buf_pool;
> - struct rte_mempool *op_pool;
> - int8_t cdev_id;
> + uint16_t nb_qps;
> uint16_t seg_sz;
> uint16_t out_seg_sz;
> uint16_t burst_sz;
> uint32_t pool_sz;
> uint32_t num_iter;
> uint16_t max_sgl_segs;
> +
> enum rte_comp_huffman huffman_enc;
> enum comp_operation test_op;
> int window_sz;
> - struct range_list level;
> - /* Store TSC duration for all levels (including level 0) */
> - uint64_t comp_tsc_duration[RTE_COMP_LEVEL_MAX + 1];
> - uint64_t decomp_tsc_duration[RTE_COMP_LEVEL_MAX + 1];
> - size_t comp_data_sz;
> - size_t decomp_data_sz;
> + struct range_list level_lst;
> + uint8_t level;
> +
> double ratio;
> - double comp_gbps;
> - double decomp_gbps;
> - double comp_tsc_byte;
> - double decomp_tsc_byte;
> + enum cleanup_st cleanup;
> };
>
> int
> diff --git a/app/test-compress-perf/comp_perf_options_parse.c b/app/test-
> compress-perf/comp_perf_options_parse.c
> index a7a8c1f9e..74ea81d09 100644
> --- a/app/test-compress-perf/comp_perf_options_parse.c
> +++ b/app/test-compress-perf/comp_perf_options_parse.c
...
> @@ -500,7 +501,6 @@ struct long_opt_parser { };
>
> static struct option lgopts[] = {
> -
...
> - test_data->level.min = 1;
> - test_data->level.max = 9;
> - test_data->level.inc = 1;
> + test_data->level_lst.min = 1;
> + test_data->level_lst.max = 9;
> + test_data->level_lst.inc = 1;
Replace by Macro?
> + test_data->test = CPERF_TEST_TYPE_BENCHMARK;
> }
>
> int
> diff --git a/app/test-compress-perf/comp_perf_test_common.c b/app/test-
> compress-perf/comp_perf_test_common.c
> new file mode 100644
> index 000000000..dc9d0b0f4
> --- /dev/null
> +++ b/app/test-compress-perf/comp_perf_test_common.c
> @@ -0,0 +1,284 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2019 Intel Corporation
> + */
> +
> +#include <rte_malloc.h>
> +#include <rte_eal.h>
> +#include <rte_log.h>
> +#include <rte_compressdev.h>
> +
> +#include "comp_perf_options.h"
> +#include "comp_perf_test_verify.h"
> +#include "comp_perf_test_benchmark.h"
> +#include "comp_perf.h"
Should this is before comp_perf_xx files to maintain alphabetical order?
> +#include "comp_perf_test_common.h"
> +
...
> +
> +static uint32_t
> +find_buf_size(uint32_t input_size)
> +{
> + uint32_t i;
> +
> + /* From performance point of view the buffer size should be a
> + * power of 2 but also should be enough to store incompressible data
> + */
> +
> + /* We're looking for nearest power of 2 buffer size, which is greather
Typo: greater
> + * than input_size
> + */
> + uint32_t size =
> + !input_size ? MIN_COMPRESSED_BUF_SIZE : (input_size <<
> 1);
> +
> + for (i = UINT16_MAX + 1; !(i & size); i >>= 1)
> + ;
> +
> + return i > ((UINT16_MAX + 1) >> 1)
> + ? (uint32_t)((float)input_size * EXPANSE_RATIO)
> + : i;
> +}
> +
...
> --
> 2.13.6
next prev parent reply other threads:[~2019-07-06 9:31 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 8:06 [dpdk-dev] [PATCH v1 0/7] add multiple cores feature to test-compress-perf Tomasz Jozwiak
2019-05-30 8:06 ` [dpdk-dev] [PATCH v1 1/7] app/test-compress-perf: add weak functions for multi-cores test Tomasz Jozwiak
2019-05-30 8:06 ` [dpdk-dev] [PATCH v1 2/7] app/test-compress-perf: add ptest command line option Tomasz Jozwiak
2019-06-03 13:35 ` [dpdk-dev] [EXT] " Shally Verma
2019-05-30 8:06 ` [dpdk-dev] [PATCH v1 3/7] app/test-compress-perf: add verification test case Tomasz Jozwiak
2019-05-30 8:06 ` [dpdk-dev] [PATCH v1 4/7] app/test-compress-perf: add benchmark " Tomasz Jozwiak
2019-05-30 8:06 ` [dpdk-dev] [PATCH v1 5/7] doc: update dpdk-test-compress-perf description Tomasz Jozwiak
2019-05-30 8:06 ` [dpdk-dev] [PATCH v1 6/7] app/test-compress-perf: add force process termination Tomasz Jozwiak
2019-05-30 8:06 ` [dpdk-dev] [PATCH v1 7/7] doc: update release notes for 19.08 Tomasz Jozwiak
2019-06-08 22:22 ` [dpdk-dev] [PATCH v2 0/7] add multiple cores feature to test-compress-perf Tomasz Jozwiak
2019-06-08 22:22 ` [dpdk-dev] [PATCH v2 1/7] app/test-compress-perf: add weak functions for multi-cores test Tomasz Jozwiak
2019-06-08 22:22 ` [dpdk-dev] [PATCH v2 2/7] app/test-compress-perf: add ptest command line option Tomasz Jozwiak
2019-06-08 22:22 ` [dpdk-dev] [PATCH v2 3/7] app/test-compress-perf: add verification test case Tomasz Jozwiak
2019-06-08 22:22 ` [dpdk-dev] [PATCH v2 4/7] app/test-compress-perf: add benchmark " Tomasz Jozwiak
2019-06-08 22:22 ` [dpdk-dev] [PATCH v2 5/7] doc: update dpdk-test-compress-perf description Tomasz Jozwiak
2019-06-08 22:22 ` [dpdk-dev] [PATCH v2 6/7] app/test-compress-perf: add force process termination Tomasz Jozwiak
2019-06-08 22:22 ` [dpdk-dev] [PATCH v2 7/7] doc: update release notes for 19.08 Tomasz Jozwiak
2019-06-26 16:30 ` [dpdk-dev] [PATCH v3 0/7] add multiple cores feature to test-compress-perf Tomasz Jozwiak
2019-06-26 16:30 ` [dpdk-dev] [PATCH v3 1/7] app/test-compress-perf: add weak functions for multi-cores test Tomasz Jozwiak
2019-06-26 16:30 ` [dpdk-dev] [PATCH v3 2/7] app/test-compress-perf: add ptest command line option Tomasz Jozwiak
2019-06-26 17:13 ` [dpdk-dev] [EXT] " Shally Verma
2019-06-26 17:34 ` Tomasz Jozwiak
2019-06-27 4:41 ` Shally Verma
2019-06-27 21:27 ` Tomasz Jozwiak
2019-06-26 16:30 ` [dpdk-dev] [PATCH v3 3/7] app/test-compress-perf: add verification test case Tomasz Jozwiak
2019-06-26 16:30 ` [dpdk-dev] [PATCH v3 4/7] app/test-compress-perf: add benchmark " Tomasz Jozwiak
2019-06-26 16:30 ` [dpdk-dev] [PATCH v3 5/7] doc: update dpdk-test-compress-perf description Tomasz Jozwiak
2019-06-26 16:30 ` [dpdk-dev] [PATCH v3 6/7] app/test-compress-perf: add force process termination Tomasz Jozwiak
2019-06-26 16:30 ` [dpdk-dev] [PATCH v3 7/7] doc: update release notes for 19.08 Tomasz Jozwiak
2019-06-26 21:26 ` Thomas Monjalon
2019-06-27 21:25 ` Tomasz Jozwiak
2019-06-27 22:25 ` [dpdk-dev] [PATCH v4 0/6] add multiple cores feature to test-compress-perf Tomasz Jozwiak
2019-06-27 22:25 ` [dpdk-dev] [PATCH v4 1/6] app/test-compress-perf: add weak functions for multi-cores test Tomasz Jozwiak
2019-06-27 22:25 ` [dpdk-dev] [PATCH v4 2/6] app/test-compress-perf: add ptest command line option Tomasz Jozwiak
2019-06-30 14:41 ` [dpdk-dev] [EXT] " Shally Verma
2019-06-27 22:25 ` [dpdk-dev] [PATCH v4 3/6] app/test-compress-perf: add verification test case Tomasz Jozwiak
2019-06-30 14:55 ` [dpdk-dev] [EXT] " Shally Verma
2019-06-30 21:02 ` Tomasz Jozwiak
2019-07-01 4:29 ` Shally Verma
2019-06-27 22:25 ` [dpdk-dev] [PATCH v4 4/6] app/test-compress-perf: add benchmark " Tomasz Jozwiak
2019-06-27 22:25 ` [dpdk-dev] [PATCH v4 5/6] doc: update dpdk-test-compress-perf description Tomasz Jozwiak
2019-06-30 14:56 ` [dpdk-dev] [EXT] " Shally Verma
2019-06-27 22:25 ` [dpdk-dev] [PATCH v4 6/6] app/test-compress-perf: add force process termination Tomasz Jozwiak
2019-06-30 15:00 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-01 11:26 ` [dpdk-dev] [PATCH v5 0/6] add multiple cores feature to test-compress-perf Tomasz Jozwiak
2019-07-01 11:26 ` [dpdk-dev] [PATCH v5 1/6] app/test-compress-perf: add weak functions for multi-cores test Tomasz Jozwiak
2019-07-02 10:03 ` Trybula, ArturX
2019-07-03 15:24 ` [dpdk-dev] [PATCH v6 0/6] add multiple cores feature to test-compress-perf Artur Trybula
2019-07-03 15:24 ` [dpdk-dev] [PATCH v6 1/6] app/test-compress-perf: add weak functions for multi-cores test Artur Trybula
2019-07-03 15:24 ` [dpdk-dev] [PATCH v6 2/6] app/test-compress-perf: add ptest command line option Artur Trybula
2019-07-03 15:24 ` [dpdk-dev] [PATCH v6 3/6] app/test-compress-perf: add verification test case Artur Trybula
2019-07-03 15:24 ` [dpdk-dev] [PATCH v6 4/6] app/test-compress-perf: add benchmark " Artur Trybula
2019-07-03 15:24 ` [dpdk-dev] [PATCH v6 5/6] doc: update dpdk-test-compress-perf description Artur Trybula
2019-07-03 15:24 ` [dpdk-dev] [PATCH v6 6/6] app/test-compress-perf: add force process termination Artur Trybula
2019-07-05 9:50 ` [dpdk-dev] [PATCH v6 0/6] add multiple cores feature to test-compress-perf Shally Verma
2019-07-05 11:15 ` [dpdk-dev] [PATCH v7 " Fiona Trahe
2019-07-06 9:36 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-05 11:15 ` [dpdk-dev] [PATCH v7 1/6] app/test-compress-perf: add weak functions for multi-cores test Fiona Trahe
2019-07-06 9:31 ` Shally Verma [this message]
2019-07-08 18:16 ` [dpdk-dev] [PATCH v8 0/7] add multiple cores feature to test-compress-perf Artur Trybula
2019-07-08 18:16 ` [dpdk-dev] [PATCH v8 1/7] app/test-compress-perf: add weak functions for multi-cores test Artur Trybula
2019-07-08 18:16 ` [dpdk-dev] [PATCH v8 2/7] app/test-compress-perf: add ptest command line option Artur Trybula
2019-07-08 18:16 ` [dpdk-dev] [PATCH v8 3/7] app/test-compress-perf: add verification test case Artur Trybula
2019-07-08 18:16 ` [dpdk-dev] [PATCH v8 4/7] app/test-compress-perf: add benchmark " Artur Trybula
2019-07-08 18:16 ` [dpdk-dev] [PATCH v8 5/7] doc: update dpdk-test-compress-perf description Artur Trybula
2019-07-08 18:16 ` [dpdk-dev] [PATCH v8 6/7] app/test-compress-perf: add force process termination Artur Trybula
2019-07-08 18:16 ` [dpdk-dev] [PATCH v8 7/7] app/test-compress-perf: 'magic numbers' removed Artur Trybula
2019-07-15 10:03 ` Trahe, Fiona
2019-07-15 13:12 ` [dpdk-dev] [PATCH v8 0/7] add multiple cores feature to test-compress-perf Akhil Goyal
2019-07-05 11:15 ` [dpdk-dev] [PATCH v7 2/6] app/test-compress-perf: add ptest command line option Fiona Trahe
2019-07-05 11:15 ` [dpdk-dev] [PATCH v7 3/6] app/test-compress-perf: add verification test case Fiona Trahe
2019-07-05 11:15 ` [dpdk-dev] [PATCH v7 4/6] app/test-compress-perf: add benchmark " Fiona Trahe
2019-07-05 11:15 ` [dpdk-dev] [PATCH v7 5/6] doc: update dpdk-test-compress-perf description Fiona Trahe
2019-07-05 11:15 ` [dpdk-dev] [PATCH v7 6/6] app/test-compress-perf: add force process termination Fiona Trahe
2019-07-01 11:26 ` [dpdk-dev] [PATCH v5 2/6] app/test-compress-perf: add ptest command line option Tomasz Jozwiak
2019-07-02 10:05 ` Trybula, ArturX
2019-07-01 11:26 ` [dpdk-dev] [PATCH v5 3/6] app/test-compress-perf: add verification test case Tomasz Jozwiak
2019-07-02 10:02 ` Trybula, ArturX
2019-07-01 11:26 ` [dpdk-dev] [PATCH v5 4/6] app/test-compress-perf: add benchmark " Tomasz Jozwiak
2019-07-02 10:02 ` Trybula, ArturX
2019-07-01 11:26 ` [dpdk-dev] [PATCH v5 5/6] doc: update dpdk-test-compress-perf description Tomasz Jozwiak
2019-07-02 10:04 ` Trybula, ArturX
2019-07-01 11:26 ` [dpdk-dev] [PATCH v5 6/6] app/test-compress-perf: add force process termination Tomasz Jozwiak
2019-07-02 10:02 ` Trybula, ArturX
2019-07-03 10:21 ` [dpdk-dev] [PATCH v5 0/6] add multiple cores feature to test-compress-perf Akhil Goyal
2019-07-03 12:20 ` Tomasz Jóźwiak
[not found] ` <1560031175-13787-1-git-send-email-tjozwiakgm@gmail.com>
2019-06-09 4:53 ` [dpdk-dev] [EXT] [PATCH v2 0/7] " Shally Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR1801MB20521A94120E4D696B8CFFDEADF40@BN6PR1801MB2052.namprd18.prod.outlook.com \
--to=shallyv@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=arturx.trybula@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=tjozwiakgm@gmail.com \
--cc=tomaszx.jozwiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).