From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7417AA0471 for ; Thu, 18 Jul 2019 15:18:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E5E04152A; Thu, 18 Jul 2019 15:18:13 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 07949137C for ; Thu, 18 Jul 2019 15:18:11 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6IDHfSL031880; Thu, 18 Jul 2019 06:18:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=6pVpOjPRttKjAyf+ag2v1V75pVSoZSen2dkSx3Lxw10=; b=B9VoWlZogb979UTNM2cyLZzzXCO3z8DexIU7fFALOUnAxR2oTxANTm/vjJWZCNqc88ny IXieyzlPn0oT/Xu28o4Z4KyIpzdXCFclj2XIYRA6acrl+d/NAf1o74+FNBZavUJbOqgw WS9U7KNLS1KqfN7AI/BTXjbV2i/zC0K67xtdl7wc8poOcHO+WqO6QEyEGN7ypqJhG2Bz t8XYCxBL31krAAPsS2Ttlg0SWXzJ0dQsVoFcn/w3jDpCIXTOeyvsHVfloPwDdBbhAJks L3PcVT6B6V7WWza6/TPIooSzHSh3AojnHaW8prSBa+46eNYhY8fb1vQrWrqrELB9oF4V mw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2ts0a2c2t4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2019 06:18:11 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 18 Jul 2019 06:18:09 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.52) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 18 Jul 2019 06:18:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=at4L19w+klX/tHeNiOzjpOTL5fijCfqKXShnDYtb1ivdqBvWLomLz9rqMLKJSEsfbQpDQf+UgA4bxtDWB1Hhdw3VvefAI//N4UFOd4xCOGTBN/WToLRizzyOBTdHvzj8v5OnVVVfWoSgUKDHOBrJDLTK2/qhh3rphwMszY5uFwM76Wnd62u/RnvyvQdJ2P1/JeW4q7oZuo3Y/HxP2btchjattuphV5ANAjwYQk5DOX9Ov131rcyhRTAMIMeStCRkyTFVEQpbon6qqGSFezualUsJrLvstuW/r2ktt/hbJKl/jPyqkwlf4UbxyYcs8Ju6UZgDbqtwqZ94FqhEYxxrmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6pVpOjPRttKjAyf+ag2v1V75pVSoZSen2dkSx3Lxw10=; b=Efmo3LR4MHzWNo89b5y6NxtfuY6XKqdOem7R0r4s7miCtxIPzH9w0agwo/NrdRWCr0VXaaG10bwvhrTfcL6QbVjPv1JgK9z3m4uyU7L/pxqUtrnyIykvyqtVvudHsR1g/9nLD8mUEtkhtBGTKGFZIHzaiDfGFXXgv3PYSErOwmOIhvTbm6hmchHKIxnrvwzDMI6jfa1Zv5uAoE0EBpvjAww/0UyZ2Eyp+zE9mSlZNyy5Nane4o+yJiAjxWTseSanuwZzv/OiFiS7bRYAHdY+QDeXlJZVKnV47KNJyHjJuS8U9PsRDEqYl+XG5B9FCTJ7lBmgURv9hVLqhrR80UYk6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6pVpOjPRttKjAyf+ag2v1V75pVSoZSen2dkSx3Lxw10=; b=fIJqFaajXWBbLD2340jUrKlcJJ4OJSC8f/fWLz0mqyu3aA0U/P5Ftqzd2p2qjOvLH8laRVAdrKIYkNbXWkeUnoNPMypZ6ZY0p6t83mavazjgcJ3n3c14RqERGMDzbi8DeHjtnW2UJOqM/KiDE0JISQs/3mfzhVrEiyN9YW/HXpY= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB2049.namprd18.prod.outlook.com (10.161.152.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Thu, 18 Jul 2019 13:18:06 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72%6]) with mapi id 15.20.2073.012; Thu, 18 Jul 2019 13:18:06 +0000 From: Shally Verma To: "Kusztal, ArkadiuszX" , "Nowak, DamianX" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto Thread-Index: AQHVPUbadrKdxQ51eEG6ykcn6BOLRKbQMt6wgAAmn4CAAAGo4A== Date: Thu, 18 Jul 2019 13:18:06 +0000 Message-ID: References: <20190717125111.11288-1-arkadiuszx.kusztal@intel.com> <6976F642F4CB7B4C9D17DE41C99F326055D090CE@hasmsx107.ger.corp.intel.com> <06EE24DD0B19E248B53F6DC8657831551B281083@hasmsx109.ger.corp.intel.com> In-Reply-To: <06EE24DD0B19E248B53F6DC8657831551B281083@hasmsx109.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.169.231.225] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ddaf72ca-9e4f-448f-0b4b-08d70b825f08 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BN6PR1801MB2049; x-ms-traffictypediagnostic: BN6PR1801MB2049: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 01026E1310 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(366004)(39860400002)(396003)(136003)(13464003)(199004)(189003)(66476007)(66946007)(26005)(2501003)(76176011)(66556008)(64756008)(76116006)(476003)(446003)(486006)(53546011)(102836004)(7696005)(86362001)(11346002)(5660300002)(8936002)(81166006)(81156014)(6306002)(14444005)(55016002)(6436002)(9686003)(6506007)(52536014)(53936002)(68736007)(186003)(256004)(2906002)(66446008)(25786009)(110136005)(33656002)(71190400001)(99286004)(316002)(4326008)(8676002)(71200400001)(478600001)(14454004)(305945005)(6246003)(74316002)(229853002)(3846002)(6116002)(7736002)(54906003)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB2049; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kzC2Lt15eZikkzhJjTbZNFk5lNPhiwAxv4p66mGoIw8JxkznGh11R+TUAXq1oDeFR5aiPCz5Pa1+hUPIdGc7u4IF9iW12rQIs7WKgzOxh5XVbYQacQW30qj535UMlQ/3hsiNLTzAvHqOw2limNBYmx6BRALL4H8i7n4iQNXQkfCzJ0g+9LDCG3TnhimsLYdZN3lGAVHjUsrDfC0z0rgDthLin5lZQt+y4hf5pUJmscEGGH+ZsjCLHqpmm/mHIo7Elg2MkoGO8sPxy10rZECK+7eHUYyEZ6HKWWpGuaVvco7EefOaQEFbrakNmk6pBbwa1PZC+XeLC45M8MTMaRsuDdV7ACXi5NsDhCkqL1ahBztTxdgT+9dGzi9qiRYt/ovIJIuQ3qiCbwdIbAHu/gx0qo19+iqrqCcQc90qYmLQr0o= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ddaf72ca-9e4f-448f-0b4b-08d70b825f08 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2019 13:18:06.2552 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shallyv@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB2049 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-18_06:2019-07-18,2019-07-18 signatures=0 Subject: Re: [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Thursday, July 18, 2019 6:39 PM > To: Shally Verma ; Nowak, DamianX > ; dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona > Subject: [EXT] RE: [PATCH v4 00/11] Rework API for RSA algorithm in > asymmetric crypto >=20 > External Email >=20 > ---------------------------------------------------------------------- > > > > > > > > Split into smaller commits, in order from least disputable ones. > > > > Open things beside this: > > > > 1. Creating padding struct > > > > 2. Padding parameters (seedlen, optional label etc) 3. Leading > > > > zeroes questions. > > > > 4. Random number requirements. > > > > 5. Capabilities. > > > > 6. Verify signature field when none padding. > > > > > > > > v4: > > > > - change API comments from length -> array allocation to avoid > > > > ambiguity > > > > > > > > v3: > > > > - split into smaller patches > > > > - removed padding struct changes > > > > - rebased against patches from CRT patches from Ayuj Verma > > > > > > > > v2: > > > > - Field for singature verification when padding none selected was > > > > added > > > > - Removed details from RFC > > > > - Simplified padding struct > > > > - Added padding none test case > > > > > > > > This patchset depends on following patches: > > > > [1] > > > > test/crypto: move rsa enqueue/dequeue into separate functions > > > > (http://patchwork.dpdk.org/patch/56342/) > > > > [2] > > > > test/crypto: add tests for RSA key type CRT > > > > (http://patchwork.dpdk.org/patch/56343/) > > > > > > > > Arek Kusztal (11): > > > > cryptodev: change RSA API comments about primes > > > > cryptodev: add cipher field to RSA op > > > > crypto/openssl: add cipher field to openssl RSA implementation > > > > test: add cipher field to RSA test > > > > cryptodev: add information about message format when signing > > > > with > > RSA > > > > cryptodev: remove RSA PKCS1 BT0 padding > > > > openssl: remove RSA PKCS1_5 BT0 padding > > > > test: remove RSA PKCS1_5 BT0 padding from test cases > > > > cryptodev: add RSA padding none description > > > > test: add pkcs1_5 padding simulation > > > > test: add RSA PKCS1_5 padding case when no padding selected > > > > > > > > app/test/test_cryptodev_asym.c | 53 ++++++++++++++++++++= -- > ---- > > > > app/test/test_cryptodev_asym_util.h | 54 > > > > +++++++++++++++++++++++++++ > > > > drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++--- > > > > lib/librte_cryptodev/rte_crypto_asym.h | 64 > > > > ++++++++++++++++++++++++-------- > > > > 4 files changed, 149 insertions(+), 34 deletions(-) > > > > > > > > -- > > > > 2.1.0 > > > > > > Series-acked-by: Damian Nowak > > I had ack'd some. But others which are Nack'd , we need more time for > them. > > So, from my end, which are Ack'd good to go but other need to wait. >=20 > As I generally agree that we need far more time to get all things done, I > would like to know what is current situation: >=20 > We should apply > 1) Cipher field I assume I acked it with some improvement requirement on description. Let m= e know if I did not. > 2) Remove BT0 >=20 > We should still discuss (possibly 19.11) > 1) Signature input format > 2) None padding >=20 [Shally] Yes but sorry I don't recall if it covers all patches I Nack'd . I= , specifically, Acked some ,which are good to go. > Is this correct? >=20 >=20 >=20 > > > > Thanks > > Shally