From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBEBEA046B for ; Thu, 25 Jul 2019 11:17:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B30B91BFAC; Thu, 25 Jul 2019 11:17:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 4D4A31BE79 for ; Thu, 25 Jul 2019 11:17:31 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6P9FB0b012054; Thu, 25 Jul 2019 02:17:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=A+rDCs+ag3N81UBW4KqjjJBa4vZa4IEaRfZVNvOYbME=; b=fLhclFzFiwzmUVoKVpvsftvSCq6kKtegq3M9ZPNSmSer65h+fypeq+3/AVxNoMuMuUWM u/fvwEFEC3iGEASuXGcBZjEpS5JNwH4IZPokFBeu9LvPSDyEYFmQi2TOrD1cgSKql99h /jLmsOkixtCEfq9TLp9Kdsr0gio/kPnkyMUt7osxEf7QTnscHBVV0dzLwmM91We01yaC Q56sP0Unnp/t3lLe04fC/6z+nMe5JCLGRtOgPExsUM5gxMMhnqkGZp1GXdSDO2uM9NDc uGvwQdagnlfRlLErcUfcgp+V0UNECk/z7hDuKoirzCMX+CXMHSXZyUWTaM8yrtgZpEfW ew== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2tx61rgsxn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 25 Jul 2019 02:17:30 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 25 Jul 2019 02:17:29 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.50) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 25 Jul 2019 02:17:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NznNQACCqONTdSxm9P8o+7LwJ+pLoKFqcQqRnRn3aN73uNoFaYy8noVKUu8if6TRVGmc/esOMZjlFapUuds7PKBMDm11mbprjGyvNEvVRUV78vYAUKnoMH1IWAQtZCDFRYBevHZty2w43xSNZ1FIu4M7XEJubfeBrXVcMFsVZxOsaVNjH/zefzGLmwydEbJw3r1iFflsAGkmHuH9CgFF2GTh0FWW9gusdjIWzoHkqWncb08kHSCdxjx5WtaRiFnUZYzm/BeyyhKuDmWHxy0qnO+WKGs/jVpIvvXvKFAQ2ENq9OmzR+p64m9ZTn3wLeADYfokrtts15m7cqCG9iRA2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A+rDCs+ag3N81UBW4KqjjJBa4vZa4IEaRfZVNvOYbME=; b=liQ/bLLo8WcJMOt0WW2mO94fZ1igosWKX82cBHGL4g0CtudiXVqZbjT4n2cRgCEG9HgUZPtcZqwvmaUzrip/w2fNQjCBkgTOEeprQWCL2lOF9z1sqmg31nmk9agS7KYNwtV3Go5rBBEHHj/UnMyRxRi1hjv0dy8i1PQHSQedfbWIX10q37Csq9SF6uBa3Rgop4Pad89w23og62aW4eaR9Dpxohsa3zuKbsGmaZ0gDXaY96/Ywq/dAb7HvjLAtuguesZIjQnBCpBlAwa/VLjc3F1R9scfY22M1+ZJpDrr0HZ4qDBEs2vyUn6oRZI0MFJNDYZ5tVyR4p9ee23dvVdtpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A+rDCs+ag3N81UBW4KqjjJBa4vZa4IEaRfZVNvOYbME=; b=sa3fxjfQQ4I9GxbG3sMYiKXnJt3Dq6qOtbykL3MP6eJ5yPczkpErZl8sKnCPIMDtTmL/QFIEQFWkTcrp2LZyyn0bH3Mtu/UjC+fde/O3oeuKEDuzx9bwmwPfEJmcpRJWivDyQznwDusPTQWefhkSPyN463lDH7UjvRfC6Vy+bGg= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB1970.namprd18.prod.outlook.com (10.161.155.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Thu, 25 Jul 2019 09:17:27 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72%6]) with mapi id 15.20.2094.017; Thu, 25 Jul 2019 09:17:27 +0000 From: Shally Verma To: "Kusztal, ArkadiuszX" , "Nowak, DamianX" , "dev@dpdk.org" CC: "Trahe, Fiona" , Ayuj Verma , Sunila Sahu , Kanaka Durga Kotamarthy , Anoob Joseph , "Narayana Prasad Raju Athreya" Thread-Topic: [dpdk-dev] [PATCH v5 1/1] test: new test structure for asymmetric crypto Thread-Index: AQHU5IKFVp7P4HphXkK8vll685vq76bbkpHggAApGCCAAA1c8A== Date: Thu, 25 Jul 2019 09:17:27 +0000 Message-ID: References: <20190326141549.16125-1-damianx.nowak@intel.com> <20190327094521.16414-1-damianx.nowak@intel.com> <20190327094521.16414-2-damianx.nowak@intel.com> <06EE24DD0B19E248B53F6DC8657831551B282BC2@hasmsx109.ger.corp.intel.com> In-Reply-To: <06EE24DD0B19E248B53F6DC8657831551B282BC2@hasmsx109.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee592f50-5118-40ac-433b-08d710e0e998 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BN6PR1801MB1970; x-ms-traffictypediagnostic: BN6PR1801MB1970: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(39860400002)(366004)(346002)(136003)(189003)(199004)(13464003)(43544003)(486006)(11346002)(71190400001)(478600001)(476003)(68736007)(71200400001)(52536014)(33656002)(229853002)(5660300002)(76116006)(66476007)(256004)(2501003)(64756008)(25786009)(66066001)(6246003)(66946007)(66556008)(446003)(26005)(86362001)(99286004)(107886003)(7696005)(74316002)(81166006)(55236004)(66446008)(6506007)(53546011)(53936002)(102836004)(76176011)(6436002)(54906003)(2906002)(7736002)(9686003)(316002)(305945005)(3846002)(55016002)(6116002)(14454004)(4326008)(110136005)(8936002)(81156014)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB1970; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: QJqU9DYV6up5uXUm+n+1uXNCB/WQwtjzwODTB3UZapUpc/pYXQ9iatz0y4wa8twZN404Jcf5wFEmLF15cS+tLD4rYer0nX6nt5YBTXZPZBEdfkqmELHgHvz8AzWT1FgQIs0JRqVqLbZDFpnV90K5aToF/T2pKIAq6dQraE01WJfWugblXljpy7fcsYa8rK7KBMvhj6Ssp2YEiVAD/rYE/x2++pCcpUirynYANQ9OvStBSOKrBGdzfi1qay2opG00C6zKDM9Zj905pw2vCK06zdEVZea68/CknMMrTVJYrSlsHRUdoSKS3UGgp7V1NJTkE0VwUl3CyBl9G2dgHktoar3a39zsAAxBXjRX6KJp79MB/7/5dcvhwiHbnFSQBgUOMEZsLZK8i5ZcXNXje8fHN6veyfa0tdjuXCRyCAzH2CQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ee592f50-5118-40ac-433b-08d710e0e998 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2019 09:17:27.1954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shallyv@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB1970 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-25_04:2019-07-25,2019-07-25 signatures=0 Subject: Re: [dpdk-dev] [PATCH v5 1/1] test: new test structure for asymmetric crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Thursday, July 25, 2019 2:06 PM > To: Shally Verma ; Nowak, DamianX > ; dev@dpdk.org > Cc: Trahe, Fiona ; Ayuj Verma > ; Sunila Sahu ; Kanaka Durga > Kotamarthy ; Anoob Joseph > ; Narayana Prasad Raju Athreya > > Subject: RE: [dpdk-dev] [PATCH v5 1/1] test: new test structure for > asymmetric crypto >=20 >=20 >=20 > > -----Original Message----- > > From: Shally Verma [mailto:shallyv@marvell.com] > > Sent: Thursday, July 25, 2019 9:18 AM > > To: Nowak, DamianX ; dev@dpdk.org > > Cc: Trahe, Fiona ; Kusztal, ArkadiuszX > > ; Ayuj Verma ; > > Sunila Sahu ; Kanaka Durga Kotamarthy > > ; Anoob Joseph ; > Narayana > > Prasad Raju Athreya > > Subject: RE: [dpdk-dev] [PATCH v5 1/1] test: new test structure for > > asymmetric crypto > > > > Hi Damian, Fiona, Arek > > > > Though am bit late to come back to this. But I have question on > > mod_exp test vector. > > Please see below. > > > > > -----Original Message----- > > > From: dev On Behalf Of Damian Nowak > > > Sent: Wednesday, March 27, 2019 3:15 PM > > > To: dev@dpdk.org > > > Cc: fiona.trahe@intel.com; arkadiuszx.kusztal@intel.com; Damian > > > Nowak > > > Subject: [dpdk-dev] [PATCH v5 1/1] test: new test structure for > > > asymmetric crypto > > > > > > This patch adds new test structure for modexp and modinv for > > > asymmetric cryptography > > > > > > Signed-off-by: Damian Nowak ... > > > +static const struct > > > +modex_test_data modex_test_case[] =3D { { > > > + .description =3D "Modular Exponentiation " > > > + "(mod=3D128, base=3D20, exp=3D3, res=3D128)", > > > + .xform_type =3D RTE_CRYPTO_ASYM_XFORM_MODEX, > > ... > > > + .modulus =3D { > > > + .data =3D { > > > + 0xb3, 0xa1, 0xaf, 0xb7, 0x13, 0x08, 0x00, 0x0a, > > There's already a testvector mod_p[] in file with leading 0. Where as > > I see this one duplicate of that but without leading 0. > > Could you tell me if you ever tested with mod_p[] with leading 0 and > > if your qat PMD passed that? >=20 > [AK] - Hi Shally, > The problem with this vector is that it has 1024bit long number but > sizeof(mod_p) Is 129 bytes (1032 bit). > It is no problem for QAT to get correct result, but test will fail becaus= e QAT > PMD will return 129 bytes of date (with leading zero, number right-shifte= d) > so comparison will fail. This is the same question as padding NONE for RS= A. > Should we trim zeroes, or shouldn't we. [Shally] Ya. Now, I correlate changes that you proposed to another RSA xfor= m patch. Because Spec simply expect=20 Key input as positive integer and does not know if its DER formatted input. So, I have one question here: How QAT is handling leading 0? Do you pass da= ta as is to HW with 0 in it and it is still able to produce correct result for you? Or, you take care in PMD to remove it an= d then append it back later at o/p? In case, you pass to HW, then does all bytes after 0 store correct o/p? > > > > > + 0x35, 0xdc, 0x2b, 0x20, 0x8d, 0xa1, 0xb5, 0xce, > > > + 0x47, 0x8a, 0xc3, 0x80, 0xf4, 0x7d, 0x4a, 0xa2, > > > + 0x62, 0xfd, 0x61, 0x7f, 0xb5, 0xa8, 0xde, 0x0a, > > > + 0x17, 0x97, 0xa0, 0xbf, 0xdf, 0x56, 0x5a, 0x3d, > > > + 0x51, 0x56, 0x4f, 0x70, 0x70, 0x3f, 0x63, 0x6a, > > > + 0x44, 0x5b, 0xad, 0x84, 0x0d, 0x3f, 0x27, 0x6e, > > > + 0x3b, 0x34, 0x91, 0x60, 0x14, 0xb9, 0xaa, 0x72, > > > + 0xfd, 0xa3, 0x64, 0xd2, 0x03, 0xa7, 0x53, 0x87, > > > + 0x9e, 0x88, 0x0b, 0xc1, 0x14, 0x93, 0x1a, 0x62, > > > + 0xff, 0xb1, 0x5d, 0x74, 0xcd, 0x59, 0x63, 0x18, > > > + 0x11, 0x3d, 0x4f, 0xba, 0x75, 0xd4, 0x33, 0x4e, > > > + 0x23, 0x6b, 0x7b, 0x57, 0x44, 0xe1, 0xd3, 0x03, > > > + 0x13, 0xa6, 0xf0, 0x8b, 0x60, 0xb0, 0x9e, 0xee, > > > + 0x75, 0x08, 0x9d, 0x71, 0x63, 0x13, 0xcb, 0xa6, > > > + 0x81, 0x92, 0x14, 0x03, 0x22, 0x2d, 0xde, 0x55 > > > + }, > > > + .len =3D 128 > > > + }, > > > + .result_len =3D 128 > > > +}, > > .... > > > /* modular operation test data */ > > > uint8_t base[] =3D { > > > 0xF8, 0xBA, 0x1A, 0x55, 0xD0, 0x2F, 0x85, > > > -- > > > 2.7.4