From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B95B3A046B for ; Thu, 25 Jul 2019 13:46:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58AD41C30F; Thu, 25 Jul 2019 13:46:44 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 2D5191C30B for ; Thu, 25 Jul 2019 13:46:43 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6PBZPA9023966; Thu, 25 Jul 2019 04:46:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=aLUiqCKBXBdo5VwvLinWy+bwqfhJDZHYM4JhB+TIoHw=; b=bYkefKtqGTIX8aSrqXzQKF6Voke+iR5sw53DP9SBCREyItC3LdcL/3sHINAnKYp/oq9H a2l0JZC9nb/Bj9wg69IcxR/eBu9ECzDidyheFn1dwioR/eEpCaNOnNLhIaMHQMaPbaaL FX8BmK++yO7BTu1t1k5LMElO2Ofsq6sqtmU8AxZa6IhlDT9cqCNlH/fvN0UwTkadij2c l90JqY0LSBdPd/AFxQEzTNiApISFG1Iu+hIDCdpmWR8DXYoSH5/KSUNOgBpQT0dQ4a7N PwqzorZEmkw1m9w6edqDnGLS47tdP10XqVgLn2vwrQsUVyUx7xXZvcwXvZKBlFa1mhmW Zg== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2tx62512gx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 25 Jul 2019 04:46:42 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 25 Jul 2019 04:46:40 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.55) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 25 Jul 2019 04:46:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MeLWOOJRG42aRTzHLmNJhove9Kugysf+iHNQ0nrl3GcmbhPGitklJ4l6Iviik80/gzwpLSYsNb80FefEl7qbjosp7Kf5bmgM270kQnXRcn9vFjj/cHO+76i4Z/8dqowqtmy6E4i8Lgv8A5c/vGVPTEmM9aZjhoXiwG+m1wUKVMtqZJtsOVVlFSkbOTz/kNa3Il5TM3iJ0XBrfWg05C+YS5vTgOZ2jx2PVoFF7IH37CDFPZXwVcKR1ojQ7G+yUo48WrCSYwsUy9TdkYtPHIh2d07YjAESnHjG7RKjnoy4Zg8h4O3mwcP6b5PG2VA9rYC0S1wPQ730KmeTOVkUHyey+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aLUiqCKBXBdo5VwvLinWy+bwqfhJDZHYM4JhB+TIoHw=; b=PTFInVIRc7rVZDRWGbU5io4GxdZ+CLNT5Z5qQB5SATdBga4z5+k3GQTdeDxKWGDWVADYlOoFkevDBqZWe9QtvFjOhkaCQl9U8yjjUBoDdvM6VeiR2qQBOVSPX7WVrvcVOx8s1IlluuiyYFjGLLCQ4uJ4dIsskcOWhYa8zLAuXvAQCx6IgRKFx9aOcmeWKsJEcMxv8RtqzKIX5NBCJBhavrUBl/qoNg9vtQpURxD6xwyXX18kVdQcQpd8CUPDEZAsr2A3PiFPG0Hlmb/4p54PvoL4YXN4WOFOrKusghwY57HX/qKlt94K+OrACsLOYj4Xt7G8uFKxwrXgcOYLlSTvvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aLUiqCKBXBdo5VwvLinWy+bwqfhJDZHYM4JhB+TIoHw=; b=VzlV4ujVAskrtslrmud5Jlgmoz6BTKqLCijdKdvcT/eN/77Qh4GTuQlyVKOaOLW6zCZ7VPSR79cimecH+n9pXooN8vWJ8JZmar7K9+GFlgLHoi2s4oZWOCobZyWyqMU73kmvLJ7ED0sBxeEu4MMb8jqBixbP4+9Dcl6OdnJWOvk= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB1939.namprd18.prod.outlook.com (10.161.157.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Thu, 25 Jul 2019 11:46:37 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72%6]) with mapi id 15.20.2094.017; Thu, 25 Jul 2019 11:46:37 +0000 From: Shally Verma To: Akhil Goyal , Anoob Joseph , "Ayuj Verma" CC: "arkadiuszx.kusztal@intel.com" , Sunila Sahu , Kanaka Durga Kotamarthy , "dev@dpdk.org" , Fiona Trahe Thread-Topic: [PATCH v1 0/2] declare crypto asym xform immutable Thread-Index: AQHVQf0VE8fh0pVNEkyFNFVWwsyWkqbZdlWAgAFE6YCAAAg8YIAAH2YAgABRCoCAAAFPoIAAAuSAgAAA+vA= Date: Thu, 25 Jul 2019 11:46:37 +0000 Message-ID: References: <1563958317-480-1-git-send-email-ayverma@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 59e42b39-a937-4490-b063-08d710f5c087 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BN6PR1801MB1939; x-ms-traffictypediagnostic: BN6PR1801MB1939: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(39860400002)(376002)(366004)(396003)(13464003)(189003)(199004)(2906002)(305945005)(7736002)(74316002)(14444005)(256004)(8676002)(6306002)(9686003)(53936002)(476003)(6246003)(11346002)(25786009)(14454004)(52536014)(446003)(5660300002)(81156014)(6436002)(81166006)(4326008)(486006)(102836004)(8936002)(229853002)(55016002)(71190400001)(76116006)(66556008)(110136005)(64756008)(26005)(66476007)(66446008)(54906003)(66066001)(76176011)(7696005)(55236004)(53546011)(6116002)(6506007)(3846002)(99286004)(68736007)(86362001)(478600001)(186003)(966005)(66946007)(33656002)(316002)(6636002)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB1939; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: hSsHptONXaOeuP4mJfD4erVtvWy/XeHiyvF4EQgA/JwLpq+tMtzg7qq2ZbCzu7wT3/ggLWOwdnIrx7Q74hXNT6B1QAJMmwqFTTwADfVG5hdx/QwrPvgQ8U8hK9ccy2gKoQ6nysnHi3LXKc3JB76ppQKvn41+FBcfo/GpWBjCVL9qFJ+OYJLFWbF1xe3Ok6PB8xa54Re5H0FabztXSiIBBw/aS7Exbuk3FjxQRx/2QLeHKc9L+tnCzTrC4b85XBkWmLeOSr+NjPGWuylY2X9ssfe585rUI8955TbBcf+IZGAST+dMDkiAaCXHWPX/ttETMUMcEB00LWolamjcD2oVkm87TvKejkmG9ZwM+cJAcm30PxKNd4HSr8zp/OOqDuh7TCTV8/Ey/t+ABWjGsBzoL558ZIYduoZ6FeGKyDasBZU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 59e42b39-a937-4490-b063-08d710f5c087 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2019 11:46:37.8305 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shallyv@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB1939 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-25_04:2019-07-25,2019-07-25 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, July 25, 2019 5:13 PM > To: Shally Verma ; Anoob Joseph > ; Ayuj Verma > Cc: arkadiuszx.kusztal@intel.com; Sunila Sahu ; Kanaka > Durga Kotamarthy ; dev@dpdk.org; Fiona > Trahe > Subject: RE: [PATCH v1 0/2] declare crypto asym xform immutable >=20 >=20 >=20 > > > > Hi Akhil > > > > > > > > Hi Anoob/Shally > > > > > > > > > > > > > Hi Ayuj, > > > > > > > > > > I believe there are couple of issues with this patch. > > > > > > > > > > Are these experimental APIs? I believe they were made stable > > > > > this release and I'm not sure if it is a right practice to edit > > > > > an API without deprecation notice after it is made stable. > > > > > Especially now that RC2 is done. @Akhil, what is your take on thi= s? > > > > > [Shally] These are experimental still, hence no deprecation notic= e. > > > > > We checked about it with Fiona, Akhil before. > > > > > > > > [Anoob] In the patch, the edited APIs doesn't have experimental > > > > tag. I leave it to Akhil's judgement on this. > > > > > > > The API is experimental. Check the .map file. > > > > > > But these kind of patches cannot go in 1908 release, as we have > > > already tagged it for RC2. > > > We need to defer this change for 19.11 release. > > > > > [Shally] Well. Cant do anything if we have missed deadline here. Right > > now its up for feedback. > > Meanwhile if we get any agreement and window gets open for nearest > > release, then please consider it. >=20 > library changes cannot go beyond RC2 unless it is a fix for some issue. >=20 > > > > > One more issue that I see in this patch. QAT also uses these APIs, > > > so it shall also be modified along with openssl. > > > > > [Shally] We assume QAT changes will be done by QAT maintainer, once > > they review and approve this change. > > >=20 > Patch 1/2 will break the compilation for QAT and openssl. > All changes should be part of a single patch (both for QAT and openssl). > If somebody is modifying the common code, then it should not atleast brea= k > the compilation. >=20 > Check the following commit. > http://git.dpdk.org/next/dpdk-next- > crypto/commit/?id=3D186b14d6850654eb84a8ae9ea29b736f0ba5e093 >=20 [Shally] Okay. Agree. We will look into it. >=20 > -Akhil